*** tkajinam has joined #openstack-cinder | 00:03 | |
*** brinzhang_ has joined #openstack-cinder | 00:06 | |
*** brinzhang has quit IRC | 00:09 | |
*** baojg has quit IRC | 00:10 | |
*** tosky has quit IRC | 00:14 | |
*** brinzhang has joined #openstack-cinder | 00:19 | |
*** brinzhang_ has quit IRC | 00:22 | |
*** ociuhandu has joined #openstack-cinder | 00:38 | |
*** ociuhandu has quit IRC | 00:43 | |
*** brinzhang_ has joined #openstack-cinder | 00:58 | |
*** brinzhang has quit IRC | 01:02 | |
*** brinzhang_ has quit IRC | 01:04 | |
*** brinzhang_ has joined #openstack-cinder | 01:05 | |
*** Xuchu has quit IRC | 01:08 | |
*** ociuhandu has joined #openstack-cinder | 01:17 | |
openstackgerrit | Merged openstack/cinder-tempest-plugin master: Update README.md for running cinder tests in tempest https://review.opendev.org/688853 | 01:26 |
---|---|---|
*** ociuhandu has quit IRC | 01:26 | |
*** nanzha has joined #openstack-cinder | 01:29 | |
*** ociuhandu has joined #openstack-cinder | 01:31 | |
*** whfnst has joined #openstack-cinder | 01:35 | |
*** ociuhandu has quit IRC | 01:36 | |
*** nanzha has quit IRC | 02:03 | |
*** nanzha has joined #openstack-cinder | 02:04 | |
*** dasp has joined #openstack-cinder | 02:26 | |
*** dasp_ has quit IRC | 02:29 | |
*** ociuhandu has joined #openstack-cinder | 02:44 | |
*** ociuhandu has quit IRC | 02:51 | |
*** ociuhandu has joined #openstack-cinder | 03:04 | |
*** ociuhandu has quit IRC | 03:08 | |
*** ociuhandu has joined #openstack-cinder | 03:09 | |
*** ociuhandu has quit IRC | 03:14 | |
*** awalende has joined #openstack-cinder | 03:18 | |
openstackgerrit | Yong Huang proposed openstack/cinder master: [Unity] Cross-arrays storage-assisted migration support https://review.opendev.org/651450 | 03:20 |
*** awalende has quit IRC | 03:22 | |
*** ociuhandu has joined #openstack-cinder | 03:32 | |
*** ociuhandu has quit IRC | 03:46 | |
*** brinzhang_ has quit IRC | 03:51 | |
*** brinzhang_ has joined #openstack-cinder | 03:51 | |
*** brinzhang has joined #openstack-cinder | 04:19 | |
*** brinzhang_ has quit IRC | 04:23 | |
*** bhagyashris has joined #openstack-cinder | 04:23 | |
*** brinzhang_ has joined #openstack-cinder | 04:24 | |
*** brinzhang has quit IRC | 04:28 | |
*** udesale has joined #openstack-cinder | 04:54 | |
*** ociuhandu has joined #openstack-cinder | 05:30 | |
*** ociuhandu has quit IRC | 05:35 | |
*** brinzhang has joined #openstack-cinder | 05:37 | |
*** brinzhang_ has quit IRC | 05:40 | |
*** bhagyashris has quit IRC | 05:51 | |
*** n-saito has joined #openstack-cinder | 05:53 | |
*** yaawang has quit IRC | 06:04 | |
*** yaawang has joined #openstack-cinder | 06:04 | |
*** Luzi has joined #openstack-cinder | 06:04 | |
*** udesale has quit IRC | 06:07 | |
*** bhagyashris has joined #openstack-cinder | 06:09 | |
*** brinzhang_ has joined #openstack-cinder | 06:23 | |
*** brinzhang_ has quit IRC | 06:25 | |
*** brinzhang_ has joined #openstack-cinder | 06:26 | |
*** brinzhang has quit IRC | 06:26 | |
*** awalende has joined #openstack-cinder | 06:27 | |
*** brinzhang_ has quit IRC | 06:27 | |
*** brinzhang_ has joined #openstack-cinder | 06:27 | |
*** udesale has joined #openstack-cinder | 06:37 | |
*** udesale has quit IRC | 06:39 | |
*** udesale has joined #openstack-cinder | 06:39 | |
*** udesale has quit IRC | 06:42 | |
*** nanzha has quit IRC | 06:44 | |
*** nanzha has joined #openstack-cinder | 06:47 | |
*** udesale has joined #openstack-cinder | 06:52 | |
*** awalende has quit IRC | 06:56 | |
*** bhagyashris_ has joined #openstack-cinder | 06:57 | |
*** bhagyashris has quit IRC | 06:59 | |
*** udesale has quit IRC | 07:13 | |
*** udesale has joined #openstack-cinder | 07:13 | |
*** rcernin has quit IRC | 07:24 | |
*** lpetrut has joined #openstack-cinder | 07:28 | |
*** bhagyashris_ has quit IRC | 07:31 | |
*** bhagyashris has joined #openstack-cinder | 07:34 | |
*** brinzhang has joined #openstack-cinder | 07:49 | |
*** brinzhang_ has quit IRC | 07:53 | |
*** nanzha has quit IRC | 07:53 | |
*** nanzha has joined #openstack-cinder | 08:05 | |
*** ociuhandu has joined #openstack-cinder | 08:22 | |
*** ociuhandu has quit IRC | 08:22 | |
*** ociuhandu has joined #openstack-cinder | 08:23 | |
*** tesseract has joined #openstack-cinder | 08:24 | |
*** brinzhang_ has joined #openstack-cinder | 08:24 | |
*** brinzhang has quit IRC | 08:28 | |
*** udesale has quit IRC | 08:28 | |
*** ociuhandu has quit IRC | 08:28 | |
*** udesale has joined #openstack-cinder | 08:28 | |
*** udesale has quit IRC | 08:29 | |
*** udesale has joined #openstack-cinder | 08:30 | |
*** whoami-rajat has joined #openstack-cinder | 08:37 | |
*** udesale has quit IRC | 08:42 | |
*** udesale has joined #openstack-cinder | 08:43 | |
*** do3meli has joined #openstack-cinder | 08:43 | |
*** tkajinam has quit IRC | 08:43 | |
*** n-saito has quit IRC | 08:43 | |
*** tosky has joined #openstack-cinder | 08:46 | |
*** trident has quit IRC | 08:55 | |
*** trident has joined #openstack-cinder | 08:56 | |
*** brinzhang has joined #openstack-cinder | 08:58 | |
*** brinzhang_ has quit IRC | 09:02 | |
*** awalende has joined #openstack-cinder | 09:03 | |
*** martinkennelly has joined #openstack-cinder | 09:09 | |
*** Dinesh_Bhor has quit IRC | 09:11 | |
*** ociuhandu has joined #openstack-cinder | 09:22 | |
*** ociuhandu has quit IRC | 09:28 | |
*** ociuhandu has joined #openstack-cinder | 09:31 | |
*** udesale has quit IRC | 09:32 | |
*** udesale has joined #openstack-cinder | 09:33 | |
*** ociuhandu has quit IRC | 09:35 | |
*** ociuhandu has joined #openstack-cinder | 09:36 | |
*** ociuhandu has quit IRC | 09:37 | |
*** ociuhandu has joined #openstack-cinder | 09:38 | |
*** bhagyashris has quit IRC | 09:40 | |
*** ociuhandu has quit IRC | 09:40 | |
*** mvkr has quit IRC | 09:41 | |
*** mvkr has joined #openstack-cinder | 09:41 | |
*** ociuhandu has joined #openstack-cinder | 09:41 | |
*** mns96 has joined #openstack-cinder | 09:51 | |
openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: Fix: Purge volume record when attachment exists https://review.opendev.org/696676 | 09:51 |
*** ociuhandu has quit IRC | 09:55 | |
*** ociuhandu has joined #openstack-cinder | 09:56 | |
*** brinzhang_ has joined #openstack-cinder | 09:56 | |
*** brinzhang has quit IRC | 09:59 | |
*** Roamer` has joined #openstack-cinder | 10:01 | |
*** ociuhandu has quit IRC | 10:19 | |
*** ociuhandu has joined #openstack-cinder | 10:20 | |
*** ociuhandu has quit IRC | 10:21 | |
*** ociuhandu has joined #openstack-cinder | 10:22 | |
*** ociuhandu has quit IRC | 10:24 | |
*** ociuhandu has joined #openstack-cinder | 10:24 | |
*** ociuhandu has quit IRC | 10:26 | |
*** ociuhandu has joined #openstack-cinder | 10:27 | |
*** brinzhang_ has quit IRC | 10:28 | |
*** rcernin has joined #openstack-cinder | 10:31 | |
openstackgerrit | Peter Penchev proposed openstack/os-brick master: StorPool: parse the output of `blockdev` correctly. https://review.opendev.org/696680 | 10:33 |
Roamer` | ^^^ do I feel stupid now... | 10:34 |
*** ociuhandu has quit IRC | 10:34 | |
*** pcaruana has joined #openstack-cinder | 10:36 | |
*** davidsha has joined #openstack-cinder | 10:37 | |
*** e0ne has joined #openstack-cinder | 10:40 | |
*** rcernin has quit IRC | 10:49 | |
*** lennyb has joined #openstack-cinder | 10:52 | |
*** udesale has quit IRC | 10:52 | |
*** udesale has joined #openstack-cinder | 10:53 | |
*** psachin has joined #openstack-cinder | 11:26 | |
lyarwood | geguileo: https://review.opendev.org/#/c/695564/ - would you mind taking a look at this today if you have a second, trying to avoid issues in slow CI envs. | 11:28 |
*** awalende has quit IRC | 11:28 | |
geguileo | lyarwood: any chance we can just fix Nova? | 11:31 |
geguileo | to stop replacing the path provided by os-brick? | 11:31 |
geguileo | that way we wouldn't even need to return a symlink | 11:31 |
lyarwood | geguileo: nova isn't the issue, it's the original encryptors. | 11:34 |
lyarwood | geguileo: We should natively decrypt LUKS volumes now | 11:35 |
lyarwood | geguileo: dmcrypt plain volumes are the only thing we need to remove to remove this | 11:35 |
geguileo | how is the original encryptors the issue? | 11:35 |
geguileo | nova replaces the symlink that os-brick provides with the decrypted dm | 11:35 |
lyarwood | geguileo: that's os-brick isn't it | 11:35 |
lyarwood | geguileo: that code was in nova | 11:36 |
lyarwood | geguileo: but we moved it into os-brick a while ago | 11:36 |
geguileo | lyarwood: but it's because Nova doesn't do the right thing... | 11:36 |
geguileo | it stores the info and then doesn't update it after the encryption is done | 11:36 |
geguileo | it should be that os-brick returns a real device when attaching | 11:37 |
geguileo | and when we decrypt we return a new path | 11:37 |
geguileo | and that's the one that should be used by Nova | 11:37 |
lyarwood | hmm I see | 11:37 |
geguileo | but since Nova stores the path first, and will use that for the VM | 11:37 |
geguileo | we have to replace the first path | 11:37 |
lyarwood | I've always blamed the encryptors for this but I see your point | 11:37 |
geguileo | you can check upstream bug #1703954 | 11:38 |
openstack | bug 1703954 in OpenStack Compute (nova) "Attach/Detach encrypted volume problems with real paths" [Undecided,Incomplete] https://launchpad.net/bugs/1703954 | 11:38 |
geguileo | I broke encryption when I started returning real paths without knowing about this flow | 11:38 |
lyarwood | okay let me hackaround this afternoon, it shouldn't be that hard to update the path in the connection_info before we build the config | 11:39 |
lyarwood | or maybe it is and that's why we haven't yet | 11:39 |
geguileo | maybe | 11:39 |
geguileo | anyway, once you've had to suffer through my complains, let me review the patch XD | 11:39 |
lyarwood | \o/ will do man, thanks again | 11:40 |
*** ociuhandu has joined #openstack-cinder | 11:41 | |
*** ociuhandu has quit IRC | 11:42 | |
geguileo | lyarwood: reviewed | 11:53 |
geguileo | I downvoted because I believe we need to call the number of calls | 11:54 |
geguileo | to the mocks | 11:54 |
lyarwood | ack, I'll repsin shortly | 11:55 |
geguileo | lyarwood: thanks for the fix :-) | 11:56 |
*** ociuhandu has joined #openstack-cinder | 11:57 | |
*** dpawlik has quit IRC | 12:05 | |
*** lennyb has quit IRC | 12:07 | |
*** lennyb has joined #openstack-cinder | 12:12 | |
*** whoami-rajat has quit IRC | 12:17 | |
*** ociuhandu has quit IRC | 12:21 | |
*** lennyb has quit IRC | 12:25 | |
*** do3meli has quit IRC | 12:26 | |
*** dpawlik has joined #openstack-cinder | 12:28 | |
*** rcernin has joined #openstack-cinder | 12:29 | |
*** do3meli has joined #openstack-cinder | 12:30 | |
openstackgerrit | Lee Yarwood proposed openstack/os-brick master: WIP encryptors: Return the realpath to dm-crypt devices if requested https://review.opendev.org/696694 | 12:30 |
openstackgerrit | Lee Yarwood proposed openstack/os-brick master: WIP iscsi: Remove encryption workaround https://review.opendev.org/696695 | 12:30 |
*** lennyb has joined #openstack-cinder | 12:31 | |
*** awalende has joined #openstack-cinder | 12:33 | |
*** lennyb has quit IRC | 12:41 | |
openstackgerrit | Lee Yarwood proposed openstack/os-brick master: WIP Remove workaround for bug #1633518 https://review.opendev.org/696696 | 12:43 |
openstack | bug 1633518 in os-brick "The passphrase used to encrypt or decrypt volumes was mangled prior to Newton" [High,Fix released] https://launchpad.net/bugs/1633518 - Assigned to Lee Yarwood (lyarwood) | 12:43 |
*** ociuhandu has joined #openstack-cinder | 12:57 | |
*** dpawlik has quit IRC | 12:58 | |
openstackgerrit | Lee Yarwood proposed openstack/os-brick master: iscsi: Add _get_device_link retry when waiting for /dev/disk/by-id/ to populate https://review.opendev.org/695564 | 13:07 |
*** whoami-rajat has joined #openstack-cinder | 13:10 | |
*** nanzha has quit IRC | 13:22 | |
*** nanzha has joined #openstack-cinder | 13:25 | |
*** dpawlik has joined #openstack-cinder | 13:25 | |
*** enriquetaso has joined #openstack-cinder | 13:30 | |
*** spsurya has joined #openstack-cinder | 13:57 | |
openstackgerrit | Sofia Enriquez proposed openstack/cinder master: NFS encrypted volume support https://review.opendev.org/597148 | 13:58 |
*** awalende has quit IRC | 14:01 | |
*** ociuhandu has quit IRC | 14:07 | |
*** ociuhandu has joined #openstack-cinder | 14:08 | |
*** dave-mccowan has joined #openstack-cinder | 14:10 | |
*** ociuhandu has quit IRC | 14:13 | |
*** Luzi has quit IRC | 14:23 | |
*** awalende has joined #openstack-cinder | 14:24 | |
*** ociuhandu has joined #openstack-cinder | 14:29 | |
*** nanzha has quit IRC | 14:38 | |
*** awalende has quit IRC | 14:39 | |
*** nanzha has joined #openstack-cinder | 14:49 | |
Roamer` | hm, has anybody seen os-brick's remove_scsi_device() fail because blockdev --flushbufs says "no such device"? Case in point: we're about to add an option to export StorPool volumes via iSCSI, I tested it on an unrelated review, and see first the several lines following | 15:07 |
Roamer` | https://spfactory.storpool.com/logs/38/696438/1/silent/cinder-storpool-tempest-exp/0fa49af/controller/logs/screen-n-cpu.txt.gz#_Nov_28_18_46_53_967021 and then, the very next log message for this request, suddenly https://spfactory.storpool.com/logs/38/696438/1/silent/cinder-storpool-tempest-exp/0fa49af/controller/logs/screen-n-cpu.txt.gz#_Nov_28_18_49_50_503889 | 15:07 |
*** dpawlik has quit IRC | 15:08 | |
*** ociuhandu has quit IRC | 15:13 | |
*** ociuhandu has joined #openstack-cinder | 15:14 | |
*** ociuhandu has quit IRC | 15:19 | |
geguileo | lyarwood: I'm reviewing your updated patch, but I don't see any comment/change regarding the counting of calls, which was the reason for my downvote | 15:20 |
geguileo | lyarwood: also, I'm thinking that we could just decide to create/delete our own symlink instead of waiting for one from the system | 15:20 |
lyarwood | geguileo: looking at the wrong PS? https://review.opendev.org/#/c/695564/2..3/os_brick/tests/initiator/connectors/test_iscsi.py | 15:24 |
geguileo | lyarwood: nop, that's the one | 15:24 |
geguileo | lyarwood: if you have more calls that assert will still say it's ok | 15:24 |
geguileo | afaik | 15:24 |
geguileo | iirc: if listdir_mock.assert_has_calls(3 * [mock.call('/dev/disk/by-id/')]) succeeds | 15:25 |
lyarwood | geguileo: ah sorry I missed that | 15:25 |
geguileo | it means that listdir_mock.assert_has_calls(2 * [mock.call('/dev/disk/by-id/')]) | 15:25 |
geguileo | will also | 15:25 |
lyarwood | geguileo: I'll add that now, apologies. | 15:25 |
geguileo | lyarwood: oh, no worries :-) | 15:25 |
geguileo | lyarwood: should we explore the faster solution? | 15:25 |
geguileo | create our own symlink? | 15:26 |
geguileo | instead of reusing one? | 15:26 |
geguileo | we create it when we create the decrypted dm | 15:26 |
geguileo | and we remove it after we remove the dm | 15:26 |
geguileo | that way we wouldn't have to wait for udev rules to execute | 15:26 |
lyarwood | geguileo: I'm trying to remove the workaround entirely with encrypted volumes by returning the normal decrypted dm path | 15:27 |
geguileo | lyarwood: thanks!! you are my hero!!! :-) | 15:27 |
lyarwood | geguileo: np, the issue with this is it isn't going to be backportable obviously | 15:28 |
lyarwood | geguileo: https://review.opendev.org/#/q/topic:remove-iscsi-encryption-workaround+(status:open+OR+status:merged) | 15:28 |
lyarwood | geguileo: I'll get that passing later once I've finished up with another bug | 15:29 |
geguileo | lyarwood: awesome!! | 15:29 |
*** martinkennelly has quit IRC | 15:29 | |
geguileo | lyarwood: feel free to ping me once the os-brick code is ready, as I'll be happy to review it | 15:30 |
*** martinkennelly has joined #openstack-cinder | 15:31 | |
*** e0ne has quit IRC | 15:34 | |
*** enriquetaso has quit IRC | 15:40 | |
*** jcosmao has joined #openstack-cinder | 15:42 | |
*** martinkennelly has quit IRC | 15:49 | |
*** udesale has quit IRC | 15:49 | |
*** lpetrut has quit IRC | 15:52 | |
*** martinkennelly has joined #openstack-cinder | 15:53 | |
openstackgerrit | Helen Walsh proposed openstack/cinder stable/train: PowerMax Driver - QoS calculation failure https://review.opendev.org/696725 | 15:59 |
*** dave-mccowan has quit IRC | 16:01 | |
*** ociuhandu has joined #openstack-cinder | 16:02 | |
*** ociuhandu has quit IRC | 16:08 | |
*** sapd1 has joined #openstack-cinder | 16:11 | |
*** sfernand has quit IRC | 16:11 | |
*** lpetrut has joined #openstack-cinder | 16:17 | |
openstackgerrit | Lee Yarwood proposed openstack/os-brick master: iscsi: Add _get_device_link retry when waiting for /dev/disk/by-id/ to populate https://review.opendev.org/695564 | 16:23 |
*** whoami-rajat has quit IRC | 16:28 | |
*** nanzha has quit IRC | 16:33 | |
openstackgerrit | Helen Walsh proposed openstack/cinder stable/stein: PowerMax Driver - PowerMax Formatted Vols Fix https://review.opendev.org/696734 | 16:36 |
*** do3meli has quit IRC | 17:01 | |
*** spsurya has quit IRC | 17:05 | |
*** mns96 has quit IRC | 17:13 | |
*** lpetrut has quit IRC | 17:16 | |
*** davidsha has quit IRC | 17:26 | |
*** lpetrut has joined #openstack-cinder | 17:33 | |
*** ociuhandu has joined #openstack-cinder | 17:33 | |
*** psachin has quit IRC | 17:34 | |
*** ociuhandu has quit IRC | 17:38 | |
*** benfelin has joined #openstack-cinder | 17:39 | |
*** ociuhandu has joined #openstack-cinder | 17:43 | |
*** tosky has quit IRC | 17:50 | |
*** baojg has joined #openstack-cinder | 17:54 | |
*** enriquetaso has joined #openstack-cinder | 18:17 | |
*** ociuhandu has quit IRC | 18:31 | |
*** ociuhandu has joined #openstack-cinder | 19:09 | |
*** ociuhandu has quit IRC | 19:15 | |
openstackgerrit | Erlon R. Cruz proposed openstack/cinder master: Fix DriverFilter string evaluations https://review.opendev.org/696756 | 19:16 |
*** tosky has joined #openstack-cinder | 19:36 | |
*** martinkennelly has quit IRC | 19:52 | |
*** jmlowe has quit IRC | 19:56 | |
*** tesseract has quit IRC | 20:00 | |
*** jmlowe has joined #openstack-cinder | 20:12 | |
*** dklyle has quit IRC | 20:12 | |
*** whfnst has quit IRC | 20:15 | |
*** e0ne has joined #openstack-cinder | 20:17 | |
*** e0ne has quit IRC | 20:40 | |
*** dklyle has joined #openstack-cinder | 20:42 | |
*** ociuhandu has joined #openstack-cinder | 20:50 | |
*** jmlowe has quit IRC | 20:53 | |
*** ociuhandu has quit IRC | 20:55 | |
*** enriquetaso has quit IRC | 21:10 | |
*** enriquetaso has joined #openstack-cinder | 21:13 | |
openstackgerrit | Sofia Enriquez proposed openstack/cinder master: Fix service-get-log to respect server filters https://review.opendev.org/686000 | 21:20 |
*** jmlowe has joined #openstack-cinder | 21:50 | |
*** martinkennelly has joined #openstack-cinder | 21:53 | |
*** e0ne has joined #openstack-cinder | 21:58 | |
*** pcaruana has quit IRC | 22:03 | |
*** e0ne has quit IRC | 22:10 | |
*** enriquetaso has quit IRC | 22:52 | |
*** ociuhandu has joined #openstack-cinder | 23:09 | |
*** ociuhandu has quit IRC | 23:14 | |
*** rcernin has quit IRC | 23:18 | |
*** martinkennelly has quit IRC | 23:19 | |
*** jcosmao has left #openstack-cinder | 23:26 | |
*** baojg has quit IRC | 23:50 | |
*** baojg has joined #openstack-cinder | 23:50 | |
*** sapd1 has quit IRC | 23:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!