Wednesday, 2020-01-08

« Tuesday, 2020-01-07 Index Thursday, 2020-01-09 »
*** pvradu has quit IRC00:18
*** hoonetorg has quit IRC00:45
*** hoonetorg has joined #openstack-cinder00:57
*** lvbin02 has joined #openstack-cinder01:14
*** lvbin01 has quit IRC01:18
*** lvbin02 is now known as lvbin0101:18
*** whfnst has joined #openstack-cinder01:56
*** pvradu has joined #openstack-cinder02:16
*** Xuchu has joined #openstack-cinder02:18
*** Lucas_Gray has quit IRC02:21
*** mmethot has quit IRC02:43
*** pvradu has quit IRC02:47
openstackgerritQian Mingyue proposed openstack/cinder master: Fujitsu Driver: Change the calculation of TPP's capacity  https://review.opendev.org/69295403:19
*** psachin has joined #openstack-cinder03:33
*** mmethot has joined #openstack-cinder03:34
*** bhagyashris has joined #openstack-cinder04:18
*** pvradu has joined #openstack-cinder04:44
*** whoami-rajat__ has joined #openstack-cinder04:52
*** udesale has joined #openstack-cinder05:03
*** spsurya has joined #openstack-cinder05:05
*** pvradu has quit IRC05:17
*** bhagyashris has quit IRC05:28
*** bhagyashris has joined #openstack-cinder05:30
*** dave-mccowan has quit IRC05:36
*** Xuchu_ has joined #openstack-cinder05:58
*** Xuchu has quit IRC06:00
*** Xuchu_ is now known as Xuchu06:00
*** yaawang has quit IRC06:12
*** yaawang has joined #openstack-cinder06:12
*** Xuchu has quit IRC06:30
*** Xuchu has joined #openstack-cinder06:35
*** jawad_axd has joined #openstack-cinder06:49
*** bhagyashris has quit IRC06:51
*** bhagyashris has joined #openstack-cinder06:52
*** dpawlik has joined #openstack-cinder06:52
*** jawad_ax_ has joined #openstack-cinder06:52
*** jawad_axd has quit IRC06:54
openstackgerritOpenStack Proposal Bot proposed openstack/cinder master: Imported Translations from Zanata  https://review.opendev.org/70029606:57
*** pvradu has joined #openstack-cinder07:00
*** pcaruana has joined #openstack-cinder07:38
*** ociuhandu has joined #openstack-cinder07:46
*** bhagyashris has quit IRC07:48
*** zhanglong has joined #openstack-cinder07:54
*** ociuhandu has quit IRC07:58
*** e0ne has joined #openstack-cinder07:59
*** pvradu has quit IRC08:02
*** pvradu has joined #openstack-cinder08:03
*** tosky has joined #openstack-cinder08:05
*** tesseract has joined #openstack-cinder08:06
*** bhagyashris has joined #openstack-cinder08:06
*** zhanglong has quit IRC08:06
*** zhanglong has joined #openstack-cinder08:08
*** e0ne has quit IRC08:08
*** e0ne has joined #openstack-cinder08:09
*** e0ne has quit IRC08:23
*** tkajinam has quit IRC08:29
*** bhagyashris has quit IRC08:32
*** tosky_ has joined #openstack-cinder08:33
*** e0ne has joined #openstack-cinder08:33
*** tosky has quit IRC08:34
*** bhagyashris has joined #openstack-cinder08:37
*** tosky_ is now known as tosky08:39
*** pvradu has quit IRC08:41
*** e0ne has quit IRC08:46
*** brinzhang_ has quit IRC08:46
*** brinzhang has joined #openstack-cinder09:12
*** brinzhang_ has joined #openstack-cinder09:14
*** brinzhang_ has quit IRC09:16
*** brinzhang_ has joined #openstack-cinder09:16
*** brinzhang has quit IRC09:18
*** zhanglong has quit IRC09:29
*** brinzhang has joined #openstack-cinder09:31
*** brinzhang_ has quit IRC09:34
*** brinzhang has quit IRC09:36
*** jc_ has joined #openstack-cinder09:36
*** martinkennelly has joined #openstack-cinder09:39
*** bhagyashris has quit IRC09:43
*** e0ne has joined #openstack-cinder09:50
*** ociuhandu has joined #openstack-cinder10:02
*** dpawlik has quit IRC10:07
*** dpawlik has joined #openstack-cinder10:14
*** ociuhandu has quit IRC10:19
*** geguileo has joined #openstack-cinder10:28
*** e0ne has quit IRC10:29
*** Xuchu has quit IRC10:45
*** e0ne has joined #openstack-cinder10:57
*** ociuhandu has joined #openstack-cinder10:59
*** sapd1_x has joined #openstack-cinder11:02
*** ociuhandu has quit IRC11:18
*** ociuhandu has joined #openstack-cinder11:29
*** ociuhandu has quit IRC11:34
*** vishakha has quit IRC11:35
*** sapd1_x has quit IRC11:47
openstackgerritDamion Parry proposed openstack/cinder master: Remove surplus calls to modifyVolume  https://review.opendev.org/70101411:52
*** dviroel has joined #openstack-cinder12:07
*** rosmaita has joined #openstack-cinder12:34
*** jawad_ax_ has quit IRC12:38
*** whoami-rajat__ has quit IRC12:45
*** udesale has quit IRC12:52
*** enriquetaso has joined #openstack-cinder12:54
*** jawad_axd has joined #openstack-cinder12:55
*** anastzhyr has joined #openstack-cinder12:56
*** jawad_ax_ has joined #openstack-cinder12:59
*** jawad_axd has quit IRC12:59
*** jawad_ax_ has quit IRC13:03
*** jawad_axd has joined #openstack-cinder13:04
*** jawad_axd has quit IRC13:09
*** ociuhandu has joined #openstack-cinder13:09
*** jawad_axd has joined #openstack-cinder13:09
*** jawad_ax_ has joined #openstack-cinder13:12
*** jawad_axd has quit IRC13:14
*** jawad_axd has joined #openstack-cinder13:16
*** jawad_ax_ has quit IRC13:16
*** ociuhandu has quit IRC13:17
*** jawad_axd has quit IRC13:21
*** sapd1 has joined #openstack-cinder13:24
*** whoami-rajat__ has joined #openstack-cinder13:27
*** dpawlik has quit IRC13:37
*** dpawlik has joined #openstack-cinder13:37
*** ociuhandu has joined #openstack-cinder13:38
*** ociuhandu has quit IRC13:42
*** jawad_axd has joined #openstack-cinder13:45
*** jawad_axd has quit IRC13:49
*** Liang__ has joined #openstack-cinder13:53
*** jawad_axd has joined #openstack-cinder13:56
*** Liang__ is now known as LiangFang13:58
rosmaitaCourtesy reminder: Cinder meeting in #openstack-meeting-4 at 1400 UTC13:59
rosmaitajungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard13:59
smcginnisThanks rosmaita13:59
openstackgerritMerged openstack/cinder-specs master: update review site link  https://review.opendev.org/70066513:59
openstackgerritMerged openstack/cinder-specs master: Update review site link  https://review.opendev.org/70066613:59
rosmaitai need a reminder about the reminder13:59
geguileorosmaita: thanks  :-)13:59
*** jawad_axd has quit IRC14:00
*** thgcorrea has joined #openstack-cinder14:02
*** andrebeltrami has joined #openstack-cinder14:02
*** sfernand has joined #openstack-cinder14:02
openstackgerritWalter A. Boring IV (hemna) proposed openstack/cinder master: FCZM - Remove six due to Py2 support dropped  https://review.opendev.org/70154214:05
openstackgerritEric Harney proposed openstack/cinder master: RBD: catch argument exceptions when configuring multiattach  https://review.opendev.org/69437914:17
*** lvbin01 has quit IRC14:19
*** lvbin01 has joined #openstack-cinder14:20
*** jawad_axd has joined #openstack-cinder14:21
openstackgerritMaciej Szwed proposed openstack/cinder master: SPDK drivers: Update RPC calls to match latest SPDK changes  https://review.opendev.org/69385614:24
m5z^^ I will apprieciate review :)14:25
*** jawad_axd has quit IRC14:26
*** ociuhandu has joined #openstack-cinder14:38
*** bhagyashris has joined #openstack-cinder14:39
*** eharney has quit IRC14:42
hemnado we have a common topic for removing six ?14:42
hemnafor reviews14:43
*** ociuhandu has quit IRC14:43
smcginnisThere's the general goal topic of drop-py27-support, but actually removing compat code is a little beyond the goal.14:44
smcginnisMaybe we just decide to use drop-py27?14:44
*** ociuhandu has joined #openstack-cinder14:44
hemnayah I think that'd be good14:44
hemnaok I updated the topic on my FCZM review14:45
*** ociuhandu has quit IRC14:47
*** enriquetaso has quit IRC14:49
*** whoami-rajat__ has quit IRC14:49
smcginnisI think I saw another patch from someone else earlier yesterday for that. I'll have to watch out for it.14:52
*** whoami-rajat has joined #openstack-cinder14:55
*** LiangFang has quit IRC15:00
*** rcernin has quit IRC15:01
*** bhagyashris has quit IRC15:06
*** dave-mccowan has joined #openstack-cinder15:06
*** bhagyashris has joined #openstack-cinder15:12
*** jmlowe has quit IRC15:17
*** ociuhandu has joined #openstack-cinder15:18
openstackgerritMerged openstack/cinder master: Imported Translations from Zanata  https://review.opendev.org/70029615:19
*** ociuhandu has quit IRC15:23
*** whoami-rajat has quit IRC15:24
openstackgerritAnastasiya Zhyrkevich proposed openstack/cinder master: Add test coverage for manage_existing API revert  https://review.opendev.org/69152715:26
*** eharney has joined #openstack-cinder15:28
*** jmlowe has joined #openstack-cinder15:38
*** udesale has joined #openstack-cinder15:39
*** ociuhandu has joined #openstack-cinder15:42
*** ociuhandu has quit IRC15:50
*** ociuhandu has joined #openstack-cinder15:51
toskygeguileo: hi! Have anything change recently in the cinderlib functional tests? https://zuul.opendev.org/t/openstack/build/8ffebd7b74dd45ae96f85d92feb620ad/log/job-output.txt#3725315:57
smcginnisLooks like that must be running under py2?15:58
*** ociuhandu has quit IRC15:58
smcginnisAh, yep - "python2.7 (/usr/bin/python2.7) is {'executable': '/usr/bin/python2.7',"15:58
toskybut it has been executed under py215:59
toskyit's just running tox -e functional15:59
smcginnisI think we need to drop that.15:59
toskyshouldn't "functional" be the proper main target?15:59
toskyI mean, always pointing to the right version of python?15:59
smcginnisCinder itself has dropped py2 compatibility, so there are parts where we had code to handle the relocation of collections.abc that now assume the py3 location only.15:59
toskybut then, shouldn't the cinderlib functional tox target be updated?16:00
geguileotosky: yeah, I think that would be the right approach16:00
smcginnisYeah, it looks like that's what we need to do.16:00
tosky3.6 or 3.7?16:01
geguileotosky: make functional run with python316:01
toskyjust python316:01
smcginnisWe could either be explicit with each version, or just pick up whichever version the test node has present.16:01
smcginnisPersonally, I think python3 is good enough.16:02
geguileoMe too16:02
*** whoami-rajat has joined #openstack-cinder16:03
openstackgerritAnastasiya Zhyrkevich proposed openstack/cinder master: Add test coverage for manage_existing API revert  https://review.opendev.org/69152716:03
*** hoonetorg has quit IRC16:07
*** whoami-rajat has quit IRC16:09
*** rishabhhpe has joined #openstack-cinder16:11
openstackgerritAnastasiya Zhyrkevich proposed openstack/cinder master: Add test coverage for manage_snapshot_flow  https://review.opendev.org/69157416:17
*** hoonetorg has joined #openstack-cinder16:21
*** N3l1x has joined #openstack-cinder16:23
*** N3l1x_ has joined #openstack-cinder16:24
*** N3l1x_ has quit IRC16:24
*** rishabhhpe has quit IRC16:27
*** rishabhhpe has joined #openstack-cinder16:27
*** enriquetaso has joined #openstack-cinder16:28
*** N3l1x has quit IRC16:29
*** openstackgerrit has quit IRC16:30
*** openstackgerrit has joined #openstack-cinder16:31
openstackgerritLuigi Toscano proposed openstack/cinderlib master: tox: use Python 3 by default basepython  https://review.opendev.org/70157216:31
hemnaeharney so I'm not sure about the original reason for the hacking check re: str(Exception)16:32
toskygeguileo, smcginnis: ^^ hopefully that should work16:32
hemnajungleboyj oringally created that hacking check patch16:32
hemnafwiw16:32
hemna4 years ago16:32
* jungleboyj looks at the scroll back.16:32
toskygeguileo: btw, there is required train patch that should be merged: https://review.opendev.org/#/c/698670/16:33
jungleboyjhemna:  I am missing the context of your comment.  :-)16:34
jungleboyjOh, for your fczm py2 support change?16:34
hemnayah16:35
hemnaeharney had a question on the review16:35
geguileotosky: thanks16:35
hemnalooks like we have/had a hacking check in place to prevent str(e)16:35
*** bhagyashris has quit IRC16:35
jungleboyjOh ...16:35
jungleboyj*Thinking*16:35
hemnaand your patch said to remove it or use six.text_type()16:36
geguileoit made sense16:36
geguileowe no longer need it16:36
geguileosince we don't support python2 anymore16:36
hemnawell I removed six.text_type(e), and replaced it with str(e)16:36
*** N3l1x has joined #openstack-cinder16:37
jungleboyjI know there was a reason for it ...16:42
smcginnisjungleboyj, hemna, eharney, geguileo: We added that because we were getting unicode errors with str() conversion.16:42
smcginnisI agree, I don't believe that is an issue anymore.16:42
jungleboyjOh, that is right.  It was because str didn't handle unicode coming in exceptions.16:43
geguileosmcginnis: yup, I know, that's why it made sense back then16:43
jungleboyjsmcginnis:  Ok.16:44
jungleboyjIs there a patch to remove the check?16:44
*** bhagyashris has joined #openstack-cinder16:45
smcginnisWe should remove it.16:47
hemnais that still a vaild test?16:47
hemnameaning str(e) will puke on unicode? for py3 ?16:47
smcginnishemna: Added some comments on there that might be good to address. Would make this whole question irrelevant.16:47
smcginnisI don't believe it's still valid now that we are py3 only.16:48
jungleboyjsmcginnis:  ++16:48
smcginnisIt was an issue with py2 converting unicdoe strings to byte-strings, IIRC.16:48
hemnaah ok16:48
*** jmlowe has quit IRC16:50
jungleboyjI can remove the check if people want.16:50
*** jmlowe has joined #openstack-cinder16:50
smcginnisI'll let you remove the code this time. :D16:50
eharneydoes the check even work?  at a glance i thought it would have failed on hemna's patch...16:51
jungleboyjsmcginnis:  I don't want to reduce your gratification.  ;-)16:51
eharneybut yes, remove it16:51
jungleboyjeharney:  Yeah, I would have thought it would fail.16:51
jungleboyjeharney:  Ok.  I will push up a patch today to remove.16:51
openstackgerritLuigi Toscano proposed openstack/cinderlib master: tox: use Python 3 by default basepython  https://review.opendev.org/70157216:52
*** rishabhhpe has quit IRC16:54
*** rishabhhpe has joined #openstack-cinder16:55
*** thgcorrea has quit IRC17:02
toskysmcginnis: should I also remove the sphinx definition for python 2.7, or that should happen later?17:02
openstackgerritSean McGinnis proposed openstack/cinder master: Mark IET target driver deprecated  https://review.opendev.org/70157617:03
smcginnistosky: Either way. Might be good to just remove it now.17:03
smcginnistosky: Thanks for taking care of all that.17:03
*** ociuhandu has joined #openstack-cinder17:03
*** udesale has quit IRC17:05
*** bhagyashris has quit IRC17:06
*** ociuhandu has quit IRC17:08
*** psachin has quit IRC17:12
jungleboyjsmcginnis: eharney hemna  Str now handles Unicode in Pyton3.  So we are fine to remove that check.  https://docs.python.org/3/howto/unicode.html17:12
*** rishabhhpe has quit IRC17:18
*** rishabhhpe has joined #openstack-cinder17:19
rishabhhpeHi All , Can anyone help me out for setting up third party CI setup for zuul v3 along with latest version of devstack ?17:19
*** ociuhandu has joined #openstack-cinder17:26
*** ociuhandu has quit IRC17:27
*** abishop_ has joined #openstack-cinder17:27
*** ociuhandu has joined #openstack-cinder17:27
lsekiIHAC running RHOSP13 (based on queens release), and he needs multiattach support for NetApp's Cinder driver.17:27
lsekiQueens release dropped multiattach support for all drivers [0], and NetApp driver re-enabled it again [1] in the Rocky release.17:27
lsekiSo, is it possible to have it re-enabled on stable/queens (even being on EM)?17:27
lseki[0] https://review.opendev.org/#/c/428365/17:27
lseki[1] https://review.opendev.org/#/c/57811417:27
openstackgerritLuigi Toscano proposed openstack/cinderlib master: Use Python 3 by default and drop Python 2.  https://review.opendev.org/70157217:28
*** abishop has quit IRC17:29
*** tbarron_ is now known as tbarron17:30
*** vnayar has joined #openstack-cinder17:30
*** ociuhandu has quit IRC17:31
jgriffithlseki: in Queens you need to move to the "new" multi-attach feature.  You can get some info here:  https://docs.openstack.org/cinder/latest/admin/blockstorage-volume-multiattach.html17:33
*** asbishop has joined #openstack-cinder17:33
*** ociuhandu has joined #openstack-cinder17:34
*** abishop_ has quit IRC17:35
lsekijgriffith: hmm, so we would just need to backport this [1] to stable/queens, right?17:37
lseki[1] https://review.opendev.org/#/c/57811417:37
lsekiI was just wondering if I still can backport it to stable/queens, since it is in EM17:37
jgriffithNot sure, better commit message would've helped :)17:38
lsekijgriffith: oh, that's really a bad commit message17:38
*** jawad_axd has joined #openstack-cinder17:40
lsekiwell, the patch just makes the driver report that it does support multiattaching17:41
*** ociuhandu has quit IRC17:41
openstackgerritLuigi Toscano proposed openstack/cinderlib master: Use Python 3 by default and drop Python 2  https://review.opendev.org/70157217:42
*** jawad_axd has quit IRC17:44
*** ociuhandu has joined #openstack-cinder17:44
*** ociuhandu has quit IRC17:49
toskysmcginnis, geguileo : I fear the change will take more time, and I'm heading out now, sorry17:50
lsekijgriffith: so I'll backport it (with improved commit message)  to stable/queens and wait for reviews 🙂17:51
*** tosky has quit IRC17:54
*** asbishop is now known as abishop17:56
*** dpawlik has quit IRC17:58
*** jawad_axd has joined #openstack-cinder18:00
*** andrebeltrami has quit IRC18:02
hemnajungleboyj cool thanks man, so leaving those in the patch should be ok then18:04
jungleboyjhemna:  Yeah, should be.18:04
*** jawad_axd has quit IRC18:05
smcginnisBut they really should just be removed, since we shouldn't be doing string conversions on something that is getting formatted into a string.18:06
hemnaI guess if that's the policy then I can update the review18:06
hemnaI don't care either way18:06
smcginnisYeah, it's not critical, but if we're changing things there I think it would make sense to clean it up right.18:07
*** e0ne has quit IRC18:07
hemnayah, I'd rather comply to whatever we decide on18:08
*** ociuhandu has joined #openstack-cinder18:13
openstackgerritSean McGinnis proposed openstack/cinderlib master: Use Python 3 by default and drop Python 2  https://review.opendev.org/70157218:14
*** tesseract has quit IRC18:15
*** ociuhandu has quit IRC18:17
*** anastzhyr has quit IRC18:25
*** pcaruana has quit IRC18:27
*** martinkennelly has quit IRC18:38
*** jmlowe has quit IRC18:39
*** rishabhhpe has quit IRC18:44
*** enriquetaso has quit IRC18:56
*** jmlowe has joined #openstack-cinder19:01
*** jawad_axd has joined #openstack-cinder19:02
*** jawad_axd has quit IRC19:07
openstackgerritSean McGinnis proposed openstack/cinder master: Clean up test requirements  https://review.opendev.org/66285019:33
*** vnayar has quit IRC19:37
*** eharney has quit IRC20:01
*** e0ne has joined #openstack-cinder20:14
*** eharney has joined #openstack-cinder20:15
*** whfnst has quit IRC20:15
*** e0ne_ has joined #openstack-cinder20:28
*** e0ne has quit IRC20:28
*** openstackgerrit has quit IRC20:31
*** eharney has quit IRC20:38
*** openstackgerrit has joined #openstack-cinder20:52
openstackgerritAnastasiya Zhyrkevich proposed openstack/cinder master: Add test coverage for manage_existing API revert  https://review.opendev.org/69152720:52
openstackgerritAnastasiya Zhyrkevich proposed openstack/cinder master: Add test coverage for manage_snapshot_flow  https://review.opendev.org/69157420:52
*** ociuhandu has joined #openstack-cinder21:10
*** sfernand has quit IRC21:22
*** vnayar has joined #openstack-cinder21:26
*** spsurya has quit IRC21:32
*** ociuhandu has quit IRC21:39
*** vnayar has quit IRC21:59
*** hedvig_01 has joined #openstack-cinder22:03
*** jawad_axd has joined #openstack-cinder22:06
*** eharney has joined #openstack-cinder22:08
*** jawad_axd has quit IRC22:10
*** rchurch has joined #openstack-cinder22:27
*** N3l1x has quit IRC22:30
*** e0ne_ has quit IRC22:31
*** rchurch has quit IRC22:33
*** rchurch has joined #openstack-cinder22:33
*** tkajinam has joined #openstack-cinder22:56
*** tkajinam has quit IRC22:58
*** tkajinam has joined #openstack-cinder23:00
*** jawad_axd has joined #openstack-cinder23:08
openstackgerritMerged openstack/os-brick master: Add linuxscsi get_device_info unit test  https://review.opendev.org/68765423:10
*** jawad_axd has quit IRC23:12
*** dviroel has quit IRC23:12
*** rcernin has joined #openstack-cinder23:12
*** eharney has quit IRC23:19
*** jawad_axd has joined #openstack-cinder23:29
*** jawad_axd has quit IRC23:33
« Tuesday, 2020-01-07 Index Thursday, 2020-01-09 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!