Tuesday, 2020-02-18

« Monday, 2020-02-17 Index Wednesday, 2020-02-19 »
*** lennyb has quit IRC00:02
*** lennyb has joined #openstack-cinder00:04
openstackgerritMerged openstack/cinder stable/train: Install all requirements in docs builds  https://review.opendev.org/70820500:07
*** dviroel has quit IRC00:11
*** n-saito has joined #openstack-cinder00:16
*** vishalmanchanda has joined #openstack-cinder00:50
*** enriquetaso has quit IRC00:54
*** zhanglong has joined #openstack-cinder01:04
openstackgerritChris Krelle proposed openstack/cinder master: Tegile Driver  https://review.opendev.org/70727501:06
*** xuanyd has joined #openstack-cinder01:12
xuanydrosmaita: hello01:14
*** dave-mccowan has quit IRC01:32
*** dave-mccowan has joined #openstack-cinder01:35
*** dave-mccowan has quit IRC01:40
*** xiaolin has quit IRC01:49
*** Lucas_Gray has joined #openstack-cinder01:59
*** ociuhandu has joined #openstack-cinder02:12
*** ociuhandu has quit IRC02:16
*** Lucas_Gray has quit IRC02:25
*** enriquetaso has joined #openstack-cinder02:49
*** adrianc has quit IRC02:58
*** adrianc has joined #openstack-cinder03:01
*** enriquetaso has quit IRC03:17
*** psachin has joined #openstack-cinder03:41
*** zhanglong has quit IRC03:43
*** zhanglong has joined #openstack-cinder03:51
*** zhanglong has quit IRC03:56
*** udesale has joined #openstack-cinder04:10
*** dave-mccowan has joined #openstack-cinder04:15
*** dave-mccowan has quit IRC04:19
*** imacdonn has quit IRC04:43
*** imacdonn has joined #openstack-cinder04:44
*** brinzhang_ has joined #openstack-cinder05:03
*** brinzhang has quit IRC05:05
*** ykarel|away is now known as ykarel05:16
*** dave-mccowan has joined #openstack-cinder05:19
*** brinzhang__ has joined #openstack-cinder05:33
*** brinzhang_ has quit IRC05:36
*** ykarel is now known as ykarel|mtg05:47
*** udesale_ has joined #openstack-cinder05:51
*** udesale has quit IRC05:52
*** zhanglong has joined #openstack-cinder06:29
*** e0ne has joined #openstack-cinder06:43
*** e0ne has quit IRC06:49
*** zhanglong has quit IRC06:50
*** zhanglong has joined #openstack-cinder06:51
*** ykarel|mtg is now known as ykarel07:10
*** lpetrut has joined #openstack-cinder07:20
n-saitosmcginnis: thanks for your review. we updated the patch two weeks ago. could you check it again? https://review.opendev.org/#/c/689383/307:29
openstackgerritXuchu Jiang proposed openstack/cinder master: Add new license scheme for Flashsystem9000 series  https://review.opendev.org/70831007:30
*** dpawlik has joined #openstack-cinder07:38
*** Lucas_Gray has joined #openstack-cinder07:40
*** zhanglong has quit IRC07:52
*** zhanglong has joined #openstack-cinder07:55
*** xuanyd has quit IRC07:59
*** tesseract has joined #openstack-cinder08:02
*** mvkr has joined #openstack-cinder08:26
*** johanssone has quit IRC08:28
*** pcaruana has joined #openstack-cinder08:29
*** tkajinam has quit IRC08:31
*** johanssone has joined #openstack-cinder08:32
*** tosky has joined #openstack-cinder08:32
openstackgerritMerged openstack/cinder master: Hacking: Remove C304 check for LOG.audit  https://review.opendev.org/70126608:48
*** rcernin has quit IRC09:12
*** e0ne has joined #openstack-cinder09:17
*** zhanglong has quit IRC09:22
*** zhanglong has joined #openstack-cinder09:22
*** zhanglong has quit IRC09:27
*** zhanglong has joined #openstack-cinder09:29
*** pcaruana has quit IRC09:30
*** martinkennelly has joined #openstack-cinder09:31
*** Lucas_Gray has quit IRC09:35
*** Lucas_Gray has joined #openstack-cinder09:41
*** n-saito has quit IRC09:51
*** brinzhang_ has joined #openstack-cinder09:59
*** zhanglong has quit IRC10:00
*** Wryhder has joined #openstack-cinder10:01
*** Lucas_Gray has quit IRC10:01
*** Wryhder is now known as Lucas_Gray10:01
*** brinzhang__ has quit IRC10:02
*** zhanglong has joined #openstack-cinder10:03
*** migawa is now known as migawa|AFK10:04
*** dviroel has joined #openstack-cinder10:27
*** pcaruana has joined #openstack-cinder10:28
*** pcaruana has quit IRC10:45
*** Lucas_Gray has quit IRC10:51
*** pcaruana has joined #openstack-cinder10:55
*** Lucas_Gray has joined #openstack-cinder10:56
*** udesale_ has quit IRC10:57
*** Lucas_Gray has quit IRC10:58
*** zhanglong has quit IRC11:02
*** zhanglong has joined #openstack-cinder11:03
*** ykarel is now known as ykarel|afk11:09
openstackgerritLucian Petrut proposed openstack/os-brick stable/stein: Split connector list by platform  https://review.opendev.org/70619111:10
openstackgerritfutaotao proposed openstack/cinder master: Revert "Remove Huawei FusionStorage Driver"  https://review.opendev.org/70172511:12
*** Lucas_Gray has joined #openstack-cinder11:20
*** Lucas_Gray has quit IRC11:20
*** Lucas_Gray has joined #openstack-cinder11:24
*** ykarel|afk is now known as ykarel11:26
openstackgerritHelen Walsh proposed openstack/cinder stable/train: PowerMax Docs -  corrections and improvements  https://review.opendev.org/70794911:31
*** Lucas_Gray has quit IRC11:33
*** Lucas_Gray has joined #openstack-cinder11:34
*** Lucas_Gray has quit IRC11:41
*** Lucas_Gray has joined #openstack-cinder11:51
*** jvisser_ has quit IRC11:54
*** migawa|AFK is now known as migawa11:54
*** mvkr has quit IRC12:02
*** mvkr has joined #openstack-cinder12:03
*** ykarel is now known as ykarel|afk12:09
*** Luzi has joined #openstack-cinder12:14
*** tkajinam has joined #openstack-cinder12:23
*** zhanglong has quit IRC12:32
*** jvisser_ has joined #openstack-cinder12:34
*** Wryhder has joined #openstack-cinder12:39
*** Lucas_Gray has quit IRC12:41
*** Wryhder is now known as Lucas_Gray12:41
*** ykarel|afk is now known as ykarel12:46
smcginnisWe should get this in before the next os-brick release: https://review.opendev.org/#/c/699987/13:08
smcginnis(thanks e0ne!)13:08
e0nesmcginnis: you're welcome :)13:14
*** enriquetaso has joined #openstack-cinder13:16
*** jvisser__ has joined #openstack-cinder13:17
*** jvisser_ has quit IRC13:21
*** jvisser__ has quit IRC13:24
*** jvisser__ has joined #openstack-cinder13:39
*** ykarel is now known as ykarel|afk13:44
*** brinzhang_ has quit IRC13:48
*** brinzhang_ has joined #openstack-cinder13:48
*** brinzhang_ has quit IRC13:49
*** brinzhang has joined #openstack-cinder13:51
jungleboyjsmcginnis:  Done.  :-)  Thanks for cleaning that up.13:51
smcginnisThanks!13:51
jungleboyjNo problem.  Know how happy it makes you to remove code.  :-)13:51
smcginnis;)13:54
openstackgerritMerged openstack/os-brick stable/train: Split connector list by platform  https://review.opendev.org/70619013:59
*** udesale has joined #openstack-cinder14:02
*** enriquetaso has quit IRC14:02
*** enriquetaso has joined #openstack-cinder14:05
*** brinzhang has quit IRC14:07
*** brinzhang has joined #openstack-cinder14:08
*** brinzhang has quit IRC14:09
*** pcaruana has quit IRC14:14
*** Luzi has quit IRC14:14
*** enriquetaso has quit IRC14:14
*** enriquetaso has joined #openstack-cinder14:16
*** CeeMac has joined #openstack-cinder14:17
*** jmlowe has joined #openstack-cinder14:33
*** jmlowe has quit IRC14:37
openstackgerritPawel Kaminski proposed openstack/os-brick master: connectors/nvme: Wait until nvme device shows up in kernel  https://review.opendev.org/67203114:38
*** udesale has quit IRC14:41
*** zigo has quit IRC14:42
openstackgerritMerged openstack/os-brick stable/queens: iscsi: Add _get_device_link retry when waiting for /dev/disk/by-id/ to populate  https://review.opendev.org/69711814:45
*** Lucas_Gray has quit IRC14:51
*** Lucas_Gray has joined #openstack-cinder14:55
openstackgerritSandStone Storage CI proposed openstack/cinder master: Add sandstone iscsi driver.  https://review.opendev.org/68527114:57
*** johanssone has quit IRC15:02
*** pcaruana has joined #openstack-cinder15:03
openstackgerritMerged openstack/os-brick stable/queens: linuxscsi: Stop waiting for multipath devices during extend_volume  https://review.opendev.org/69854915:06
*** johanssone has joined #openstack-cinder15:08
*** lpetrut has quit IRC15:11
openstackgerritPawel Kaminski proposed openstack/os-brick master: connectors/nvme: Wait until nvme device shows up in kernel  https://review.opendev.org/67203115:12
*** jmlowe has joined #openstack-cinder15:12
openstackgerritMerged openstack/python-cinderclient stable/stein: Add missed 'Server ID' output in attachment-list  https://review.opendev.org/70352515:26
openstackgerritMerged openstack/os-brick master: Remove Sheepdog connector  https://review.opendev.org/69998715:29
*** jmlowe has quit IRC15:34
*** eharney has quit IRC15:38
hemnamorning15:40
hemnasmcginnis hey man, I have a question about https://review.opendev.org/#/c/679138/15:41
*** Lucas_Gray has quit IRC15:41
*** takamatsu has joined #openstack-cinder15:41
hemnais it just me or is there an assumption that _check_snapshot_support() doesn't work and yet that is what should be fixed?15:41
hemnaI'm not sure how that doesn't work looking at the code15:41
*** Lucas_Gray has joined #openstack-cinder15:43
smcginnishemna: My interpretation was that _check_snapshot_support() will fail for NFS if it is disabled, but that's the cause of the bug for this.15:43
smcginnisThat the NFS driver still needs to delete these failed snapshots, even if snapshotting is not supported.15:44
smcginnis"The root of the problem comes from the NFS driver. The driver allow you15:44
smcginnisto create snapshots even if snapshot support is disable.15:44
smcginnisBecause of that, I have snapshots in error state that I'm not able to delete."15:44
smcginnisSeems like the root bug is that the snapshot entries are created in the first place, but the user should still be able to delete them if they exist.15:45
smcginnisSo I wonder if that should just be a Partial-bug and not Closes-bug...15:45
*** udesale has joined #openstack-cinder15:51
hemnayah that was my point really15:51
hemnathe _check_snapshot_Support should be fixed15:51
*** pcaruana has quit IRC15:53
smcginnisI don't know if it's that call specifically, but at least how it's used in the flow for creating a snapshot.15:54
smcginnisSounds like maybe it isn't be called soon enough or something, so we start the process for creating a snapshot before realizing it can't be done.15:54
hemnaI'm not sure how that doesn't work15:54
hemnahttps://github.com/openstack/cinder/blame/master/cinder/volume/drivers/nfs.py#L552-L55515:54
hemnathat's the call15:54
hemnait's called inside of create_snapshot()15:55
*** tesseract has quit IRC15:55
hemnahttps://github.com/openstack/cinder/blame/master/cinder/volume/drivers/nfs.py#L567-L57115:55
smcginnisSo it might be a case that we do some things prior to calling into the driver and finding out it can't be done.15:55
*** pcaruana has joined #openstack-cinder15:55
hemnathe only way you get a snapshot if it's disabled is that call somehow fails to fail15:55
hemnaand self._create_snapshot() is called15:56
hemnamaybe it's a derivitive driver of nfs that does this?15:56
* hemna is confused how this allows a snap to be created15:57
smcginnisBug isn't clear on that point, but it is using the NFS driver and not a dirivitive - https://bugs.launchpad.net/cinder/+bug/184208815:57
openstackLaunchpad bug 1842088 in Cinder "NFS doesn't remove snapshots in error status" [Undecided,In progress] - Assigned to Sofia Enriquez (lsofia-enriquez)15:57
*** pcaruana has quit IRC15:58
hemnayah I was just looking at her bug15:58
hemnathe creation of the snapshot is the real bug in this IMHO15:59
hemnanot delete15:59
smcginnisYeah, pretty convinced this should just be a partial-bug, not closes-bug.15:59
hemnayah15:59
smcginnisWe should allow deleting something like that, regardless of how it got there.15:59
smcginnisBut we also need to make sure it doesn't happen in the first place.15:59
hemnayah I'm going through the excersize to see if there is a reason we shouldn't allow deleting15:59
hemnamaybe snaps were enabled at one point and they got disabled in the mean time16:00
*** pcaruana has joined #openstack-cinder16:00
smcginnisSeems like another case where we should still allow this then.16:00
hemnayah16:00
*** jmlowe has joined #openstack-cinder16:01
hemnamost of the time deletes we just allow anyway16:01
hemnaok thanks.   I put a -1 on the review to get her to change it to partial bug16:03
smcginnisThanks, good call.16:05
whoami-rajathemna, smcginnis i've had a few suggestions on the patch, i think cleaning up the created snapshot (error state) before raising the exception should be done rather than handling it in delete snapshot code16:06
*** udesale_ has joined #openstack-cinder16:06
hemnayah ok16:07
hemnashe found the delete problem by testing anyway, so the real bug is in create if it exists16:07
*** zigo has joined #openstack-cinder16:07
hemnaI really don't know how that allows a create if it's disabled16:07
*** udesale has quit IRC16:07
*** rosmaita has quit IRC16:09
*** N3l1x has quit IRC16:09
smcginnisI think the issue is the manager creates the entry prior to knowing whether the driver can do it or not.16:10
smcginnishttps://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L115116:10
*** brinzhang has joined #openstack-cinder16:10
*** brinzhang has quit IRC16:11
*** brinzhang has joined #openstack-cinder16:12
*** rosmaita has joined #openstack-cinder16:14
*** brinzhang has quit IRC16:14
*** brinzhang has joined #openstack-cinder16:14
*** brinzhang has quit IRC16:15
*** brinzhang has joined #openstack-cinder16:16
*** udesale_ has quit IRC16:17
*** brinzhang has quit IRC16:17
*** brinzhang has joined #openstack-cinder16:17
*** brinzhang has quit IRC16:18
openstackgerritMerged openstack/cinder stable/train: Tell reno to ignore the kilo branch  https://review.opendev.org/70749616:19
openstackgerritMerged openstack/cinder stable/train: Skip cryptsetup password quality checking  https://review.opendev.org/70764316:19
openstackgerritMerged openstack/cinder master: Remove Dell EMC PS Series Driver  https://review.opendev.org/70383916:19
openstackgerritMerged openstack/cinder master: Add cryptsetup to bindep.txt  https://review.opendev.org/70467416:19
openstackgerritMerged openstack/cinder master: Pure Storage - remove six due to Py2 support dropped  https://review.opendev.org/70144516:19
*** brinzhang has joined #openstack-cinder16:20
*** brinzhang has quit IRC16:21
whoami-rajatthe current patch also allows a case which i mentioned here[1] that shouldn't be allowed16:21
whoami-rajat[1]https://review.opendev.org/#/c/679138/4/cinder/volume/drivers/nfs.py@a57716:21
*** brinzhang has joined #openstack-cinder16:22
*** brinzhang has quit IRC16:22
*** brinzhang has joined #openstack-cinder16:23
*** udesale has joined #openstack-cinder16:23
openstackgerritMerged openstack/cinder stable/queens: Increase cpu limit for image conversion  https://review.opendev.org/70514116:24
*** brinzhang has quit IRC16:25
*** brinzhang has joined #openstack-cinder16:25
whoami-rajatsmcginnis, hemna maybe we can define a new exception and set the snapshot state to deleting in that case16:26
*** brinzhang has quit IRC16:26
hemnaso most likely this is happening for anyone that fail to create a snap for whatever reason16:27
hemnanfs just happens to fail 100% of the time because it's disabled16:27
*** psachin has quit IRC16:27
hemnaand the disable works and raises, and leaves the snap in error state.16:28
*** brinzhang has joined #openstack-cinder16:28
hemnawhoami-rajat so if we set the snap to deleting during create?16:28
hemnathe snap creation should fail at this point, and the caller should get notified that it failed16:29
hemnawhich I'm sure it does now16:29
*** brinzhang has quit IRC16:29
*** Lucas_Gray has quit IRC16:29
*** brinzhang has joined #openstack-cinder16:29
hemnamaybe the review should still call _check_snapshot_support() and expect the exception when it's disabled16:30
hemnaand then just call self._delete_snapshot()16:30
*** vishalmanchanda has quit IRC16:30
*** brinzhang has quit IRC16:30
*** brinzhang has joined #openstack-cinder16:31
whoami-rajathemna, if we set the state to deleting in nfs driver, it will be reset to error after the exception occurs16:31
hemnathe advantage of catching the exception in delete is that the driver can log the error16:32
*** brinzhang has quit IRC16:32
hemnaand then just continue on and delete the snap anyway16:32
whoami-rajathemna, if we catch the exception and delete the snapshot inside the driver's create, the rest of the manager code will fail to execute16:32
*** rishabhhpe has joined #openstack-cinder16:32
hemnaeither way it looks like allowing the delete is probably the way to go16:33
hemnawhy will it fail to execute the manager code during delete?   as far as the manager is concerned the delete worked16:34
*** brinzhang has joined #openstack-cinder16:34
hemnaI don't think we should set the snap to deleteing on failure of create16:35
hemnathat will affect all other drivers too16:35
hemnaif it fails to create, it should be in error state16:35
whoami-rajatyep, i'm not suggesting that16:35
*** brinzhang has quit IRC16:35
whoami-rajatso if we handle the exception in delete and delete the snap anyway, then we allow the available snapshots to be deleted as well ?16:36
*** pcaruana has quit IRC16:36
*** brinzhang has joined #openstack-cinder16:37
*** brinzhang has quit IRC16:39
*** brinzhang has joined #openstack-cinder16:39
*** brinzhang has quit IRC16:40
hemnayah, if it's disabled, then just catch the exception in the driver, log the error message (for admins), and then allow the delete anyway16:40
hemnathat way the log shows that we caught that snaps was disabled and deleted the snap anyway16:41
*** brinzhang has joined #openstack-cinder16:41
*** brinzhang has quit IRC16:42
*** brinzhang has joined #openstack-cinder16:42
hemnaI updated my -1 on the review with that.16:44
*** jmlowe has quit IRC16:44
*** jmlowe has joined #openstack-cinder16:50
*** brinzhang has quit IRC16:50
*** brinzhang has joined #openstack-cinder16:50
*** brinzhang has quit IRC16:51
*** brinzhang has joined #openstack-cinder16:52
*** brinzhang has quit IRC16:53
*** brinzhang has joined #openstack-cinder16:53
*** brinzhang has quit IRC16:55
*** brinzhang has joined #openstack-cinder16:55
*** brinzhang has quit IRC16:57
*** spatel has joined #openstack-cinder16:57
*** udesale_ has joined #openstack-cinder16:58
*** jmlowe has quit IRC16:59
*** udesale has quit IRC16:59
*** enriquetaso has quit IRC17:00
*** e0ne has quit IRC17:05
openstackgerritHelen Walsh proposed openstack/cinder master: PowerMax Driver - Allowing for default volume type in group  https://review.opendev.org/70845917:11
openstackgerritMerged openstack/cinder master: NEC driver: fix migrate/retype an in-use volume  https://review.opendev.org/68938317:12
*** udesale_ has quit IRC17:12
*** udesale has joined #openstack-cinder17:14
*** jmlowe has joined #openstack-cinder17:16
*** spatel has quit IRC17:18
*** spatel has joined #openstack-cinder17:18
*** enriquetaso has joined #openstack-cinder17:26
*** udesale has quit IRC17:27
*** spatel has quit IRC17:34
openstackgerritMerged openstack/os-brick stable/train: Skip cryptsetup password quality checking  https://review.opendev.org/70764417:43
openstackgerritMerged openstack/os-brick master: StorPool: parse the output of `blockdev` correctly.  https://review.opendev.org/69668017:43
*** spatel has joined #openstack-cinder17:49
*** rishabhhpe has quit IRC17:54
*** rishabhhpe has joined #openstack-cinder17:54
openstackgerritMerged openstack/cinder master: Fix stestr command error in doc  https://review.opendev.org/70668517:59
*** martinkennelly has quit IRC18:03
*** rishabhhpe has quit IRC18:21
*** rishabhhpe has joined #openstack-cinder18:21
*** rishabhhpe has quit IRC18:25
*** e0ne has joined #openstack-cinder18:26
*** efried has quit IRC18:33
*** tosky has quit IRC18:35
*** jmlowe has quit IRC18:40
*** jmlowe has joined #openstack-cinder18:45
openstackgerritMerged openstack/python-cinderclient stable/rocky: Add missed 'Server ID' output in attachment-list  https://review.opendev.org/70352618:52
*** brinzhang has joined #openstack-cinder19:01
*** jmlowe has quit IRC19:09
rosmaitasmcginnis: jungleboyj: when you have a few minutes, could you look over https://etherpad.openstack.org/p/bug-1852106 for clarity/accuracy ?19:11
rosmaitaanyone else: feel free ^^19:12
*** jmlowe has joined #openstack-cinder19:17
*** jmlowe has quit IRC19:31
*** e0ne has quit IRC19:32
*** mvkr has quit IRC19:34
*** enriquetaso has quit IRC19:35
smcginnisLooks good to me rosmaita19:38
rosmaitasmcginnis: thanks19:59
*** jmlowe has joined #openstack-cinder20:05
*** e0ne has joined #openstack-cinder20:08
*** e0ne has quit IRC20:08
*** jmlowe has quit IRC20:11
jungleboyjrosmaita:  Makes sense to me.20:12
rosmaitajungleboyj: ty20:12
*** jmlowe has joined #openstack-cinder20:12
jungleboyjNP.20:13
*** enriquetaso has joined #openstack-cinder20:33
*** jvisser__ has quit IRC20:47
*** asbishop is now known as abishop20:53
*** mvkr has joined #openstack-cinder21:12
openstackgerritMerged openstack/cinder master: Handle retries in PowerMax unit tests  https://review.opendev.org/69406121:16
*** jvisser has joined #openstack-cinder21:19
*** takamatsu has quit IRC21:32
*** jmlowe has quit IRC21:34
hemnamep21:45
hemnaso it looks like we have a small inconsistency in notification messages for os-reset_status actions on volumes, backups, snaps21:46
hemnamost volume actions are in the format of 'volume.create.start'21:46
hemnabut the os-reset_status is 'volumes.reset.start'21:46
hemnaso any filtering on volume.* is missed21:46
smcginnisThat fits I think.21:46
smcginnisAh, I see now.21:47
smcginnisSorry, you're right.21:47
hemnaany actions on a volume are volume.*21:47
smcginnisShould not be plural.21:47
hemnayah21:47
smcginnisBug?21:47
hemnaI guess I can file a bug and push up a review21:47
hemnawe slurp ALL notifications for all actions on cinder and we noticed we were missing os-reset_status21:48
smcginnisI doubt it's used much, but we could call out the plural version of the notification is deprecated in the release notes and send both the existing and a correct notifiction in U, then drop the plural form in V.21:48
smcginnisNot sure how important that would be.21:48
hemnayah I was a bit concerned about that too21:50
hemnaI can send both21:50
hemnaI'm filing the bug now21:51
*** e0ne has joined #openstack-cinder21:52
hemnasmcginnis another issue/difference21:58
*** jmlowe has joined #openstack-cinder21:58
hemnathe queue name is 'VolumeStatusUpdate' not 'volume'21:58
hemnawhich could also lead to not finding the notifications21:59
hemnahttps://github.com/openstack/cinder/blob/master/cinder/volume/volume_utils.py#L159-L16021:59
hemnathat's the normal usage pattern for volume notifications21:59
hemnabut the admin action for reset_status is:21:59
hemnahttps://github.com/openstack/cinder/blob/master/cinder/api/contrib/admin_actions.py#L101-L10322:00
hemnaI kinda think that should get switched to use 'volume'22:00
hemnasame with backup and snaps22:00
*** enriquetaso has quit IRC22:02
rosmaitais it possible that the difference is so that admin actions can be put in a different queue so regular users can't see them?22:02
hemnaI don't think end users can see notifications about events22:03
hemnathese all just end up in the notifications queue in rabbitmq22:04
smcginnisYeah, I'm not aware of user versus admin events.22:04
hemnaI kinda think it should be deprecated what they are doing now, and migrated to use the same volume queue22:04
smcginnisIt does seem like that should be consistent.22:04
hemnaok, so I'll keep whats there now and mark it as deprecated22:05
hemnaand then also add a call to the volume_utils.py notify methods to be consistent moving forward22:05
smcginnis++22:08
*** jmlowe has quit IRC22:10
hemnaanyone run tox -epy37 on macos ?22:10
hemna"ld: library not found for -lssl"22:11
hemnaboo :(22:11
hemnahad to install postgresql just to run tox -epep8 :(22:11
rosmaitathat seems counterintuitive22:11
hemnayah, same with -epy3722:12
hemnareally?  I need postgres just to run unit tests?22:12
hemnasux0rs22:12
*** rcernin has joined #openstack-cinder22:15
hemnahrmm22:16
hemnacan't install psycopg2 on macos due to missing -lssl :(22:16
smcginnisI went through the exercise once. It took a bit to get all the packages installed that are needed for basic tests.22:16
hemnamight be easier to fire up an ubuntu docker image and use that22:18
hemnableh22:18
smcginnisI think I got everything between installing the Apple developer tools and brew. Too long ago now to remember details though.22:19
smcginnisWe may just need some SkipTest checks on things like https://github.com/openstack/cinder/blob/e8f03523e8d244fb9c1ecceb091784cc37d63b0d/cinder/tests/unit/db/test_migrations.py#L21122:21
*** jvisser has quit IRC22:21
smcginnisSomething like https://review.opendev.org/#/c/575539/1/cinder/tests/unit/test_cmd.py22:23
hemnaah yah that'd be nice22:33
*** migawa is now known as migawa|AFK|AFK22:39
*** rcernin has quit IRC22:49
*** rcernin has joined #openstack-cinder22:50
*** dave-mccowan has quit IRC22:55
*** migawa|AFK|AFK is now known as migawa22:59
*** dave-mccowan has joined #openstack-cinder22:59
*** jmlowe has joined #openstack-cinder23:01
*** spatel has quit IRC23:27
*** jmlowe has quit IRC23:46
*** mvkr has quit IRC23:47
*** jmlowe has joined #openstack-cinder23:51
*** e0ne has quit IRC23:53
« Monday, 2020-02-17 Index Wednesday, 2020-02-19 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!