*** sfernand has quit IRC | 00:10 | |
*** n-saito has joined #openstack-cinder | 00:15 | |
*** martinkennelly has quit IRC | 00:48 | |
*** tosky has quit IRC | 00:50 | |
*** brinzhang has joined #openstack-cinder | 00:52 | |
*** brinzhang has quit IRC | 00:57 | |
*** brinzhang has joined #openstack-cinder | 00:57 | |
*** Liang__ has joined #openstack-cinder | 01:15 | |
*** brinzhang_ has joined #openstack-cinder | 01:20 | |
*** brinzhang has quit IRC | 01:23 | |
openstackgerrit | zhaoleilc proposed openstack/cinder master: Fix error of checking lun id for infortrend driver https://review.opendev.org/713769 | 01:29 |
---|---|---|
*** vishalmanchanda has joined #openstack-cinder | 01:33 | |
*** ianychoi_ has joined #openstack-cinder | 01:38 | |
*** ianychoi has quit IRC | 01:40 | |
*** sapd1 has joined #openstack-cinder | 01:50 | |
openstackgerrit | zhaoleilc proposed openstack/cinder master: Add configuration item for infortrend document https://review.opendev.org/713771 | 02:01 |
*** ociuhandu has joined #openstack-cinder | 02:04 | |
*** ociuhandu has quit IRC | 02:09 | |
*** zhanglong has joined #openstack-cinder | 02:28 | |
*** psachin has joined #openstack-cinder | 02:30 | |
openstackgerrit | renminmin proposed openstack/cinder master: RBD: Fix volume delete error for missed parent https://review.opendev.org/709342 | 02:56 |
*** raunak12 has quit IRC | 03:07 | |
openstackgerrit | Liang Fang proposed openstack/devstack-plugin-open-cas master: [WIP] Add tempest tests to zuul https://review.opendev.org/713772 | 03:12 |
*** raunak12 has joined #openstack-cinder | 03:55 | |
*** udesale has joined #openstack-cinder | 04:32 | |
*** baojg has quit IRC | 04:42 | |
*** dave-mccowan has quit IRC | 05:10 | |
*** raunak12 has quit IRC | 05:11 | |
*** raunak12 has joined #openstack-cinder | 05:14 | |
*** zhanglong has quit IRC | 05:57 | |
*** zhanglong has joined #openstack-cinder | 05:57 | |
openstackgerrit | Liang Fang proposed openstack/devstack-plugin-open-cas master: [WIP] Add tempest tests to zuul https://review.opendev.org/713772 | 06:11 |
*** yedongcan has joined #openstack-cinder | 06:47 | |
*** dpawlik has joined #openstack-cinder | 06:53 | |
*** raunak12 has quit IRC | 06:58 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder master: Imported Translations from Zanata https://review.opendev.org/713791 | 07:17 |
*** ociuhandu has joined #openstack-cinder | 07:28 | |
*** ociuhandu has quit IRC | 07:33 | |
*** tesseract has joined #openstack-cinder | 07:51 | |
*** jawad_axd has joined #openstack-cinder | 07:51 | |
*** threestrands has quit IRC | 08:01 | |
*** xyang has quit IRC | 08:08 | |
*** lxkong has quit IRC | 08:08 | |
*** carloss has quit IRC | 08:08 | |
*** guilhermesp has quit IRC | 08:09 | |
*** carloss has joined #openstack-cinder | 08:09 | |
*** lxkong has joined #openstack-cinder | 08:10 | |
*** mnaser has quit IRC | 08:10 | |
*** xyang has joined #openstack-cinder | 08:10 | |
*** mnaser has joined #openstack-cinder | 08:11 | |
*** guilhermesp has joined #openstack-cinder | 08:11 | |
*** tkajinam has quit IRC | 08:12 | |
openstackgerrit | Liang Fang proposed openstack/devstack-plugin-open-cas master: [WIP] Add tempest tests to zuul https://review.opendev.org/713772 | 08:12 |
*** e0ne has joined #openstack-cinder | 08:16 | |
e0ne | geguileo: hi. could you please review https://review.opendev.org/#/c/713649/? | 08:16 |
*** lpetrut has joined #openstack-cinder | 08:18 | |
*** tosky has joined #openstack-cinder | 08:21 | |
*** zhanglong has quit IRC | 08:22 | |
*** zhanglong has joined #openstack-cinder | 08:27 | |
openstackgerrit | Liang Fang proposed openstack/devstack-plugin-open-cas master: [WIP] Add tempest tests to zuul https://review.opendev.org/713772 | 08:44 |
*** psachin has quit IRC | 09:01 | |
*** psachin has joined #openstack-cinder | 09:02 | |
*** yoctozepto has quit IRC | 09:07 | |
*** ociuhandu has joined #openstack-cinder | 09:10 | |
*** yoctozepto0 has joined #openstack-cinder | 09:16 | |
openstackgerrit | Raghavendra Tilay proposed openstack/cinder master: HPE 3PAR: Support duplicated FQDN in network https://review.opendev.org/713803 | 09:19 |
*** ociuhandu has quit IRC | 09:22 | |
*** yoctozepto9 has joined #openstack-cinder | 09:27 | |
*** yoctozepto0 has quit IRC | 09:27 | |
*** e0ne has quit IRC | 09:36 | |
*** e0ne has joined #openstack-cinder | 09:36 | |
openstackgerrit | Liang Fang proposed openstack/devstack-plugin-open-cas master: [WIP] Add tempest tests to zuul https://review.opendev.org/713772 | 09:38 |
*** zhanglong has quit IRC | 09:42 | |
*** Liang__ has quit IRC | 09:45 | |
*** ociuhandu has joined #openstack-cinder | 09:54 | |
*** Xuchu has quit IRC | 09:55 | |
*** vishalmanchanda has quit IRC | 10:03 | |
*** kaisers_ has joined #openstack-cinder | 10:16 | |
*** vishalmanchanda has joined #openstack-cinder | 10:22 | |
*** Xuchu has joined #openstack-cinder | 10:23 | |
*** tesseract has quit IRC | 10:36 | |
*** yoctozepto9 is now known as yoctozepto | 10:37 | |
*** tesseract has joined #openstack-cinder | 10:42 | |
*** tesseract has quit IRC | 10:46 | |
*** enriquetaso has joined #openstack-cinder | 10:47 | |
*** tesseract has joined #openstack-cinder | 10:48 | |
*** n-saito has quit IRC | 10:48 | |
e0ne | geguileo: thanks for the review! | 10:54 |
geguileo | e0ne: np, thank you for working on the bug :-) | 10:54 |
e0ne | geguileo: you're en expert in A/A, so I'll be bothering you on this area | 10:55 |
geguileo | e0ne: sure, feel free to ping me | 10:56 |
*** ociuhandu has quit IRC | 10:58 | |
*** tesseract-RH has joined #openstack-cinder | 11:00 | |
*** tesseract-RH has left #openstack-cinder | 11:01 | |
e0ne | geguile: could you please poing me on code where we set host to the volume group? | 11:02 |
e0ne | _create_group_from_group_snapshot and _create_group_from_source_group are called after scheduler verifies a host, so it's not so easy for me to find the right place | 11:03 |
*** tesseract has quit IRC | 11:03 | |
*** ociuhandu has joined #openstack-cinder | 11:03 | |
geguileo | e0ne: I thought I had added the links to the code in the comments... r:-?? | 11:04 |
e0ne | geguileo: it's not the right place https://opendev.org/openstack/cinder/src/branch/master/cinder/group/api.py#L250-L263 | 11:04 |
*** ociuhandu has quit IRC | 11:04 | |
* geguileo facepalms... | 11:05 | |
*** ociuhandu has joined #openstack-cinder | 11:05 | |
e0ne | geguileo: you dropped a link where volume.host is being set | 11:05 |
geguileo | e0ne: https://opendev.org/openstack/cinder/src/branch/master/cinder/group/api.py#L342 | 11:05 |
e0ne | but we need to set a group.host | 11:05 |
geguileo | e0ne: https://opendev.org/openstack/cinder/src/branch/master/cinder/group/api.py#L425 | 11:05 |
*** sapd1 has quit IRC | 11:05 | |
e0ne | geguileo: it's not I'm talking about | 11:06 |
geguileo | e0ne: the group should already have the host and the cluster_name, if it doesn't, then we have a bug somewhere else | 11:06 |
e0ne | *not what I'm talking about | 11:06 |
e0ne | geguileo: "the group should already have the host and the cluster_name" it does, but I can't find where we do it | 11:06 |
*** dviroel has joined #openstack-cinder | 11:11 | |
*** Lucas_Gray has joined #openstack-cinder | 11:13 | |
*** pck has joined #openstack-cinder | 11:16 | |
*** pck is now known as pckizer | 11:16 | |
geguileo | e0ne: https://opendev.org/openstack/cinder/src/branch/master/cinder/scheduler/driver.py#L62 | 11:17 |
geguileo | e0ne: that's where we set the values | 11:17 |
geguileo | e0ne: and we call that from https://opendev.org/openstack/cinder/src/branch/master/cinder/scheduler/filter_scheduler.py#L83 | 11:18 |
e0ne | geguileo: thanks! | 11:18 |
geguileo | np | 11:18 |
*** andrebeltrami has joined #openstack-cinder | 11:21 | |
openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder master: WIP. FilterScheduler uses backend.host instead backend.id now https://review.opendev.org/713649 | 11:32 |
*** pcaruana has quit IRC | 11:35 | |
*** pcaruana has joined #openstack-cinder | 11:48 | |
*** ociuhandu has quit IRC | 11:50 | |
*** dave-mccowan has joined #openstack-cinder | 11:52 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder master: Vmware: Revert the volume stats revert. https://review.opendev.org/702730 | 12:07 |
openstackgerrit | Sean McGinnis proposed openstack/cinder master: Skip common tests on translation files https://review.opendev.org/713858 | 12:12 |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder master: Adds support for min/max volume size on vol_type https://review.opendev.org/713710 | 12:13 |
*** udesale_ has joined #openstack-cinder | 12:19 | |
*** udesale has quit IRC | 12:20 | |
*** e0ne_ has joined #openstack-cinder | 12:20 | |
*** e0ne has quit IRC | 12:21 | |
*** ociuhandu has joined #openstack-cinder | 12:22 | |
*** ociuhandu has quit IRC | 12:28 | |
openstackgerrit | Merged openstack/python-brick-cinderclient-ext master: Correct typo in title https://review.opendev.org/711083 | 12:35 |
hemna | mornin | 12:43 |
*** Wryhder has joined #openstack-cinder | 12:51 | |
openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: Backup: Limit number of concurent operations https://review.opendev.org/710297 | 12:52 |
*** Lucas_Gray has quit IRC | 12:53 | |
*** Wryhder is now known as Lucas_Gray | 12:53 | |
openstackgerrit | Merged openstack/cinder master: Imported Translations from Zanata https://review.opendev.org/713791 | 12:53 |
openstackgerrit | Merged openstack/cinder master: [Unity] Fix TypeError for test case test_delete_host_wo_lock https://review.opendev.org/713217 | 12:53 |
*** psachin has quit IRC | 13:21 | |
e0ne_ | hemna: mornint | 13:21 |
e0ne_ | hemna: morning | 13:21 |
e0ne_ | geguileo: in which cases we should use backend_id instead of host? | 13:24 |
geguileo | e0ne_: in general always | 13:26 |
geguileo | e0ne_: it's how we determine the ID of a backend | 13:26 |
geguileo | if it's an A/P deployment it will return the host, if it's A/A it will return the cluster_name | 13:26 |
geguileo | that's important for sending RPCs | 13:27 |
geguileo | for filtering | 13:27 |
e0ne_ | I understand how it works wirh RPC | 13:27 |
geguileo | with filtering is similar | 13:27 |
geguileo | the dict with the stats is using that as a key | 13:28 |
e0ne_ | here is what I've got in my devstack http://paste.openstack.org/show/790894/ | 13:28 |
e0ne_ | I've got a regular devstack + ceph setup with 'cluster=ceph-cluster' in my cinder.conf | 13:29 |
geguileo | e0ne_: the problem is that I forgot to report the cluster name in the volumes :-( | 13:29 |
geguileo | so you cannot see it with the API | 13:29 |
geguileo | if you select the volume with mysql you should see the cluster_name field | 13:29 |
e0ne_ | ok, I see it | 13:31 |
geguileo | e0ne_: that's something we should probably fix with a new microversion... Reporting the cluster_name on the volumes | 13:32 |
geguileo | because it's painful not seeing it | 13:32 |
* e0ne_ hates microversions | 13:32 | |
*** Lucas_Gray has quit IRC | 13:56 | |
*** udesale_ has quit IRC | 14:00 | |
*** Lucas_Gray has joined #openstack-cinder | 14:00 | |
openstackgerrit | Merged openstack/cinder master: QNAP: Fix login on Python3 https://review.opendev.org/672265 | 14:03 |
openstackgerrit | Merged openstack/cinder master: Extend remove_version_from_href support https://review.opendev.org/635995 | 14:03 |
openstackgerrit | Merged openstack/cinder master: Enable mutate for cinder scheduler https://review.opendev.org/677053 | 14:03 |
openstackgerrit | Brian Rosmaita proposed openstack/cinder master: Update weekly meeting location https://review.opendev.org/713895 | 14:51 |
*** jvisser has quit IRC | 15:09 | |
*** lpetrut has quit IRC | 15:23 | |
*** jv has joined #openstack-cinder | 15:28 | |
openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder master: Set cluster name for volume groups https://review.opendev.org/713649 | 15:30 |
*** jawad_axd has quit IRC | 15:31 | |
*** jawad_axd has joined #openstack-cinder | 15:42 | |
*** vishalmanchanda has quit IRC | 15:43 | |
*** jgriffith has quit IRC | 15:44 | |
*** jgriffith has joined #openstack-cinder | 15:46 | |
*** spatel has joined #openstack-cinder | 15:48 | |
*** spatel has quit IRC | 15:51 | |
*** Lucas_Gray has quit IRC | 15:59 | |
*** ociuhandu has joined #openstack-cinder | 16:04 | |
*** ociuhandu has quit IRC | 16:06 | |
*** ociuhandu_ has joined #openstack-cinder | 16:06 | |
*** Lucas_Gray has joined #openstack-cinder | 16:08 | |
*** raunak12 has joined #openstack-cinder | 16:08 | |
*** yedongcan has left #openstack-cinder | 16:15 | |
*** sebnet has joined #openstack-cinder | 16:18 | |
*** sebnet has left #openstack-cinder | 16:18 | |
*** Lucas_Gray has quit IRC | 16:21 | |
*** Lucas_Gray has joined #openstack-cinder | 16:24 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinderlib master: Fix test_set_snapshot https://review.opendev.org/713931 | 16:43 |
geguileo | whoami-rajat: ^ could you review that one? is a trivial fix that blocks the cinderli gate and it was and after effect of your patch that forbids snapshot's volume_type_id to be null | 16:44 |
*** adrianc_ has quit IRC | 17:06 | |
*** adrianc has joined #openstack-cinder | 17:06 | |
whoami-rajat | geguileo, sure, let me take a look | 17:11 |
geguileo | whoami-rajat: it's a one-liner XD | 17:12 |
geguileo | whoami-rajat: thanks! | 17:12 |
whoami-rajat | geguileo, sorry got distracted | 17:16 |
geguileo | lol | 17:16 |
whoami-rajat | geguileo, since it's so small should we just merge it? | 17:17 |
whoami-rajat | the commit msg is lot longer than the fix :D | 17:17 |
geguileo | whoami-rajat: Yeah, I think it's OK to just merge it | 17:17 |
geguileo | whoami-rajat: it's a really silly thing fixing a test | 17:17 |
whoami-rajat | geguileo, done | 17:19 |
geguileo | whoami-rajat: thanks! | 17:19 |
whoami-rajat | geguileo, i was remembering i added the default vol type support in cinderlib and what did i miss | 17:20 |
whoami-rajat | geguileo, and then i saw this was the migration patch which merged this cycle | 17:20 |
geguileo | whoami-rajat: you didn't miss anything | 17:20 |
geguileo | whoami-rajat: yeah, that merged like 3 weeks ago XD | 17:20 |
geguileo | whoami-rajat: and the problem is in the unit tests, because real usage won't have that issue | 17:20 |
geguileo | cinderlib functional tests passed on your patch just fine :-) | 17:21 |
whoami-rajat | geguileo, great. so there we've persistence plugin which uses ram and dbms plugin which uses db. forgive me if i'm forgetting the concepts | 17:24 |
whoami-rajat | geguileo, i'm getting a little confused with the point of persistence plugin but i will better read the docs | 17:24 |
geguileo | whoami-rajat: yeah, and the dbms also can store things in memory using sqlite | 17:24 |
geguileo | whoami-rajat: persistence plugin is basically the mechanism to be able to store the things we store in the Cinder DB anywhere we want | 17:25 |
geguileo | whoami-rajat: for example Ember-CSI stores it in kuberntes etcd using CRDs | 17:25 |
whoami-rajat | geguileo, oh ok. got it. thanks for the short and very good explanation. :) | 17:29 |
geguileo | np | 17:30 |
*** ociuhandu_ has quit IRC | 17:42 | |
*** ociuhandu has joined #openstack-cinder | 17:42 | |
*** ociuhandu has quit IRC | 17:48 | |
*** ociuhandu has joined #openstack-cinder | 18:01 | |
jungleboyj | I now appreicate just how much more productive I have been working from home. Now that I have other people here interrupting me the day is going super fast and I am not getting nearly as much done. | 18:12 |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder master: Vmware: Revert the volume stats revert. https://review.opendev.org/702730 | 18:12 |
geguileo | jungleboyj: lol | 18:13 |
smcginnis | hemna: What's going on with ignoring comments on that? I'm getting confused. | 18:13 |
hemna | not doing it on purpose, just didn't see them | 18:13 |
hemna | getting senile I guess | 18:14 |
jungleboyj | https://gph.is/g/ajWp6mj | 18:14 |
smcginnis | hemna: Another patch coming for the release note? | 18:14 |
smcginnis | Hah! | 18:14 |
hemna | yah | 18:15 |
smcginnis | hemna: Cool, thanks. Just wasn't sure if it meant you didn't agree and were just going to ignore it, or if it was just missed. ;) | 18:16 |
hemna | so we don't use a features section for release notes at all? | 18:16 |
hemna | no, I just missed them | 18:16 |
smcginnis | We do, but it's really when we add some new functionality that someone would want to use with Cinder. | 18:16 |
hemna | ok I guess it's debateable then for adding a new feature to a driver then. | 18:17 |
smcginnis | I think this makes sense as upgrade so they know what to expect and that something has changed before they decide to upgrade the code, and Fixes so they are aware some issue they may have run into has been addressed. | 18:17 |
smcginnis | It's really an internal detail of the driver, not new functionality. | 18:17 |
hemna | cool | 18:17 |
hemna | I'll update the scheduler comment | 18:17 |
smcginnis | Thanks! | 18:18 |
hemna | as it does effectively break scheduling properly | 18:18 |
hemna | especially when other drivers for different backends are enabled | 18:18 |
*** Lucas_Gray has quit IRC | 18:25 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder master: Vmware: Revert the volume stats revert. https://review.opendev.org/702730 | 18:26 |
hemna | ok | 18:27 |
hemna | I hope I addressed everything | 18:27 |
hemna | you know me, if I don't agree I'll speak up about it (for better or for worse) | 18:27 |
*** ociuhandu has quit IRC | 18:27 | |
hemna | w i t f | 18:28 |
*** ociuhandu has joined #openstack-cinder | 18:28 | |
hemna | arg | 18:28 |
hemna | jungleboyj nice gif | 18:29 |
jungleboyj | I had been looking for that one. Finally saw it. | 18:30 |
*** ociuhandu has quit IRC | 18:33 | |
openstackgerrit | Gorka Eguileor proposed openstack/cinderlib master: NotLocal exception after refresh https://review.opendev.org/713964 | 18:58 |
openstackgerrit | Gorka Eguileor proposed openstack/cinderlib master: DBMS: Fix volume deletion with MySQL https://review.opendev.org/713965 | 18:59 |
openstackgerrit | Gorka Eguileor proposed openstack/cinderlib master: DBMS: Fix db_sync between N and N+1 releases https://review.opendev.org/713966 | 18:59 |
*** jawad_axd has quit IRC | 19:04 | |
*** andrebeltrami has quit IRC | 19:10 | |
whoami-rajat | geguileo, there seems to be some problem with SQLAlchemy and centos8, you patch is failing lvm functional tests job :( | 19:25 |
whoami-rajat | http://paste.openstack.org/show/790909/ | 19:25 |
openstackgerrit | Simon O'Donovan proposed openstack/cinder master: PowerMax Driver - Support of Multiple Replication https://review.opendev.org/709669 | 19:53 |
*** Lucas_Gray has joined #openstack-cinder | 20:20 | |
*** e0ne_ has quit IRC | 21:04 | |
*** e0ne has joined #openstack-cinder | 21:08 | |
*** e0ne has quit IRC | 21:22 | |
*** ociuhandu has joined #openstack-cinder | 21:33 | |
*** enriquetaso has quit IRC | 21:58 | |
*** ociuhandu has quit IRC | 22:09 | |
*** ociuhandu has joined #openstack-cinder | 22:10 | |
*** ociuhandu has quit IRC | 22:15 | |
*** zigo has quit IRC | 22:22 | |
*** zigo has joined #openstack-cinder | 22:30 | |
*** Lucas_Gray has quit IRC | 22:31 | |
*** dpawlik has quit IRC | 22:38 | |
*** CeeMac has quit IRC | 22:50 | |
*** raunak12 has quit IRC | 23:14 | |
*** raunak12 has joined #openstack-cinder | 23:31 | |
*** spatel has joined #openstack-cinder | 23:42 | |
*** rosmaita has quit IRC | 23:43 | |
*** spatel has quit IRC | 23:46 | |
*** CeeMac has joined #openstack-cinder | 23:49 | |
*** rosmaita has joined #openstack-cinder | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!