*** enriquetaso has joined #openstack-cinder | 00:25 | |
*** ociuhandu has joined #openstack-cinder | 00:34 | |
*** ociuhandu has quit IRC | 00:38 | |
*** Xuchu has joined #openstack-cinder | 00:58 | |
*** Liang__ has joined #openstack-cinder | 01:08 | |
*** Xuchu has quit IRC | 01:39 | |
*** zhanglong has joined #openstack-cinder | 01:40 | |
*** ruffian_sheep has joined #openstack-cinder | 01:40 | |
*** Xuchu has joined #openstack-cinder | 01:43 | |
*** ruffian_sheep has quit IRC | 01:48 | |
*** raunak12 has quit IRC | 02:49 | |
*** xuanyd has joined #openstack-cinder | 03:03 | |
xuanyd | whoami-rajat: hello, the path has update, please review again, thanks! https://review.opendev.org/#/c/705876/ | 03:05 |
---|---|---|
*** sapd1_x has joined #openstack-cinder | 03:10 | |
*** Liang__ is now known as LiangFang | 03:22 | |
*** enriquetaso has quit IRC | 03:24 | |
*** ykarel|away is now known as ykarel | 04:33 | |
*** rishabhhpe has joined #openstack-cinder | 04:42 | |
*** udesale has joined #openstack-cinder | 04:56 | |
*** sapd1_x has quit IRC | 05:02 | |
*** yaawang has quit IRC | 05:05 | |
*** yaawang has joined #openstack-cinder | 05:05 | |
*** threestrands has joined #openstack-cinder | 05:06 | |
*** fnordahl has joined #openstack-cinder | 05:10 | |
*** sapd1_x has joined #openstack-cinder | 05:14 | |
*** ociuhandu has joined #openstack-cinder | 05:58 | |
*** ociuhandu has quit IRC | 06:02 | |
*** spatel has joined #openstack-cinder | 06:20 | |
openstackgerrit | Xuchu Jiang proposed openstack/cinder master: Delete volume with additional removehostmappings parameter https://review.opendev.org/715766 | 06:21 |
*** mnasiadka has quit IRC | 06:21 | |
*** mnasiadka has joined #openstack-cinder | 06:22 | |
*** ociuhandu has joined #openstack-cinder | 06:23 | |
*** spatel has quit IRC | 06:25 | |
*** sapd1_x has quit IRC | 06:29 | |
*** vishalmanchanda has joined #openstack-cinder | 06:30 | |
*** jv has quit IRC | 06:39 | |
*** zhanglong has quit IRC | 06:39 | |
*** zhanglong has joined #openstack-cinder | 06:40 | |
*** sapd1_x has joined #openstack-cinder | 06:41 | |
*** gary_perkins has quit IRC | 06:55 | |
*** gary_perkins has joined #openstack-cinder | 06:58 | |
*** ociuhandu has quit IRC | 07:03 | |
*** Xuchu has quit IRC | 07:03 | |
*** ociuhandu has joined #openstack-cinder | 07:04 | |
*** Xuchu has joined #openstack-cinder | 07:05 | |
*** ociuhandu has quit IRC | 07:09 | |
*** yaawang has quit IRC | 07:34 | |
*** yaawang has joined #openstack-cinder | 07:34 | |
*** ociuhandu has joined #openstack-cinder | 07:37 | |
*** sapd1_x has quit IRC | 07:39 | |
*** threestrands has quit IRC | 08:01 | |
*** tosky has joined #openstack-cinder | 08:02 | |
*** yaawang has quit IRC | 08:03 | |
*** yaawang has joined #openstack-cinder | 08:04 | |
*** ykarel is now known as ykarel|lunch | 08:08 | |
*** e0ne has joined #openstack-cinder | 08:15 | |
*** yaawang has quit IRC | 08:32 | |
*** yaawang has joined #openstack-cinder | 08:34 | |
*** ociuhandu has quit IRC | 08:36 | |
*** ociuhandu has joined #openstack-cinder | 08:38 | |
*** martinkennelly has joined #openstack-cinder | 08:39 | |
*** ociuhandu has quit IRC | 08:43 | |
*** ociuhandu has joined #openstack-cinder | 09:10 | |
*** LiangFang has quit IRC | 09:22 | |
*** xuanyd has quit IRC | 09:30 | |
*** Xuchu has quit IRC | 09:30 | |
*** Xuchu has joined #openstack-cinder | 09:35 | |
*** ykarel|lunch is now known as ykarel | 09:42 | |
*** tkajinam has quit IRC | 09:47 | |
openstackgerrit | Xuchu Jiang proposed openstack/cinder master: Delete volume with additional removehostmappings parameter https://review.opendev.org/715766 | 09:55 |
*** zhanglong has quit IRC | 10:08 | |
*** spatel has joined #openstack-cinder | 10:09 | |
*** spatel has quit IRC | 10:14 | |
*** Xuchu has quit IRC | 10:21 | |
openstackgerrit | Luigi Toscano proposed openstack/cinder master: DNM Check that revert tests fail on RBD https://review.opendev.org/716919 | 10:26 |
openstackgerrit | Seema S B proposed openstack/cinder master: Add different RBAC rule for different HTTP REST API https://review.opendev.org/678799 | 10:33 |
*** n-saito has quit IRC | 10:35 | |
*** Xuchu has joined #openstack-cinder | 10:49 | |
openstackgerrit | OpenStack Release Bot proposed openstack/os-brick stable/ussuri: Update .gitreview for stable/ussuri https://review.opendev.org/716940 | 10:54 |
openstackgerrit | OpenStack Release Bot proposed openstack/os-brick stable/ussuri: Update TOX/UPPER_CONSTRAINTS_FILE for stable/ussuri https://review.opendev.org/716941 | 10:54 |
openstackgerrit | OpenStack Release Bot proposed openstack/os-brick master: Update master for stable/ussuri https://review.opendev.org/716942 | 10:54 |
openstackgerrit | Merged openstack/devstack-plugin-open-cas master: Add tempest tests to zuul https://review.opendev.org/713772 | 11:04 |
*** tkajinam has joined #openstack-cinder | 11:12 | |
hemna | iœ6pö333fhjfd | 11:27 |
hemna | my cat says good morning | 11:27 |
rosmaita | good morning | 11:27 |
*** vishakha has quit IRC | 11:36 | |
*** udesale_ has joined #openstack-cinder | 11:40 | |
*** udesale has quit IRC | 11:43 | |
*** rcernin has quit IRC | 11:54 | |
*** ykarel is now known as ykarel|afk | 12:03 | |
walshh_ | is anyone available to look at https://review.opendev.org/#/c/711217/ It has +2 and clean CI. Thank you | 12:05 |
*** jv__ has joined #openstack-cinder | 12:13 | |
*** ykarel|afk is now known as ykarel | 12:13 | |
*** jv__ has quit IRC | 12:20 | |
hemna | walshh_ added my feedback | 12:21 |
hemna | I think we have many drivers that don't use driver.do_setup() and driver.check_for_setup_errors() like this, but we should encourage driver maintainers to use those instead of doing validation checks at driver.__init__ time. | 12:22 |
hemna | FWIW, this is where the driver is created in the volume manager: https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L260-L267 | 12:27 |
hemna | the volume manager calls driver.do_setup() in it's init_host() call, which gives the volume manager a chance to create profiling and output the driver name and version info to the logs. | 12:28 |
hemna | it's probably a little late at this stage to encourage this, but drivers really should use do_setup() and check_for_setup_errors() | 12:29 |
walshh_ | thanks hemna | 12:31 |
hemna | I suppose you can do a follow up to refactor that a bit if you want. | 12:31 |
*** ykarel is now known as ykarel|afk | 12:33 | |
walshh_ | We will look into it, we have 4 other methods in the init that are candidate to the moved to do_setup so perhaps we could do it in a separate review | 12:33 |
walshh_ | candidates* | 12:34 |
hemna | yah, I figured it would take a bit of work to refactor that | 12:34 |
hemna | if you file a bug on it, then I'll +A this one | 12:34 |
walshh_ | great feedback, thank you | 12:34 |
*** jv__ has joined #openstack-cinder | 12:34 | |
*** enriquetaso has joined #openstack-cinder | 12:35 | |
hemna | smcginnis ping | 12:42 |
hemna | what's the best way to skip certain tempest tests? like if I have a policy that will always cause a test to fail | 12:44 |
hemna | I have lots of those | 12:44 |
*** ajitha has joined #openstack-cinder | 12:45 | |
rosmaita | whoami-rajat: around? question about https://review.opendev.org/#/c/705876/ | 12:52 |
rosmaita | your comment on PS 23 | 12:52 |
whoami-rajat | rosmaita, yep | 12:53 |
*** jv__ has quit IRC | 12:53 | |
hemna | walshh_ have that bug url for me? | 12:54 |
*** Xuchu has quit IRC | 12:54 | |
smcginnis | hemna: I believe you just pass a regex to match (or in your case not match) a pattern. | 12:54 |
hemna | and if I have like....20+ of them? | 12:55 |
rosmaita | whoami-rajat: sorry, am trying to formulate my question | 12:55 |
*** ykarel|afk is now known as ykarel | 12:55 | |
whoami-rajat | rosmaita, np, i'm here | 12:55 |
rosmaita | whoami-rajat: so what you were able to make happen is that you can create a volume with the incorrect src_backup_id | 12:56 |
rosmaita | and that seems to be because the src_backup_id is only written to new volumes, not to restores? | 12:57 |
whoami-rajat | rosmaita, yes and my concern was it's a static field once set doesn't change again | 12:57 |
smcginnis | hemna: There might be some tempest.conf settings you can use, but I'm not finding anything. | 12:58 |
smcginnis | hemna: Looking around in https://docs.openstack.org/tempest/latest/run.html | 12:58 |
hemna | hrmm ok | 12:58 |
hemna | we have a policy.json that restricts a lot of stuff, which will cause tempest.api.volume test failures | 12:58 |
whoami-rajat | rosmaita, yes | 12:58 |
smcginnis | Maybe easier using the --blacklist-file or --whitelist-file? | 12:58 |
rosmaita | whoami-rajat: it's static in the sense that it doesn't get modified by current workflow, but there's no reason why it could not be modified, is that right? | 12:58 |
hemna | trying to find the 'right' way to just skip those with a blacklist or something | 12:58 |
hemna | ok I suppose I could create a blacklist file and add each of the desired tests to be skipped there | 12:59 |
hemna | thanks, I'll try that | 12:59 |
rosmaita | whoami-rajat: because it's just volume metadata, so could be changed/removed by volume owner/admin | 13:00 |
smcginnis | hemna: I have noticed some CI's passing a pretty long regex string, so it's certainly possible to do it all in one command line. But of course, complicated regex == hard to read. ;) | 13:01 |
whoami-rajat | rosmaita, from a code perspective, i think a volume should have the backup id of the latest backup it's restored from | 13:01 |
whoami-rajat | rosmaita, i can't say regarding the owner/admin changing it manually :/ | 13:01 |
smcginnis | hemna: Just as an example, search for "tox -eall" in here: http://s3.eu-geo.objectstorage.softlayer.net/ibm-storage-ci-log/storwize-tempest-dsvm-full-iscsi/751/console.txt | 13:01 |
*** ociuhandu has quit IRC | 13:02 | |
hemna | yah that's a little nasty | 13:02 |
rosmaita | whoami-rajat: right, i wasn't clear in my question ... i just meant that there's no reason why the code could not handle the case of changing a src_backup_id | 13:03 |
*** jv__ has joined #openstack-cinder | 13:04 | |
whoami-rajat | rosmaita, yep, we can handle the case in the code | 13:04 |
whoami-rajat | rosmaita, from the recent change, i see they've considered the src_backup_id during the update but i think it still lacks some verification as to if the src_backup_id is a valid UUID and a valid backup | 13:06 |
rosmaita | ok, i will update that review, thanks | 13:06 |
whoami-rajat | rosmaita, np, but i'm still unsure what the query was :P | 13:09 |
*** laurent\ has quit IRC | 13:16 | |
*** ianychoi_ has joined #openstack-cinder | 13:17 | |
openstackgerrit | Andreas Jaeger proposed openstack/cinderlib master: Update hacking for Python3 https://review.opendev.org/716997 | 13:19 |
openstackgerrit | Andreas Jaeger proposed openstack/cinderlib master: Update hacking for Python3 https://review.opendev.org/716997 | 13:19 |
*** ianychoi has quit IRC | 13:20 | |
*** ianychoi_ is now known as ianychoi | 13:23 | |
*** rishabhhpe has quit IRC | 13:25 | |
*** ykarel is now known as ykarel|afk | 13:29 | |
rosmaita | whoami-rajat: when you have a few minutes, see if my comment on PS31 of https://review.opendev.org/#/c/705876/ makes sense | 13:32 |
*** xakaitetoia has joined #openstack-cinder | 13:34 | |
*** Xuchu has joined #openstack-cinder | 13:45 | |
*** xuanyd has joined #openstack-cinder | 13:53 | |
*** sfernand has joined #openstack-cinder | 13:55 | |
whoami-rajat | rosmaita, that conditional statement was very confusing, the only case they are avoiding is when a volume is restored several times with the same backup, they won't update the db and performance wise i think that makes sense | 13:57 |
*** Xuchu has quit IRC | 13:57 | |
*** vishalmanchanda has quit IRC | 13:58 | |
xuanyd | rosmatia: hello, thanks for review and thanks for suggestions. i think that, the src_backup_id is mark the volume's init data, So we just need to ensure that src_backup_id is up to date | 14:03 |
openstackgerrit | Andreas Jaeger proposed openstack/cinderlib master: Update hacking for Python3 https://review.opendev.org/716997 | 14:05 |
xuanyd | rosmaita: hello, thanks for review and thanks for suggestions. i think that, the src_backup_id is mark the volume's init data, So we just need to ensure that src_backup_id is up to date | 14:11 |
sfernand | Hi everyone | 14:15 |
sfernand | could anyone take a look at this patch? https://review.opendev.org/#/c/712799/1 | 14:15 |
sfernand | This adds Active/Active replication to the SolidFire driver, also enables the SUPPORTS_ACTIVE_ACTIVE flag | 14:15 |
*** ociuhandu has joined #openstack-cinder | 14:17 | |
xuanyd | rosmaita: about the last comment, When recovering to the original volume, if src_backup_id is empty, we do not write src_backup_id | 14:18 |
rosmaita | xuanyd: right, but if src_backup_id is not empty, you do | 14:21 |
rosmaita | so you get a situation were sometimes you do, sometimes you don't | 14:21 |
*** Xuchu has joined #openstack-cinder | 14:23 | |
*** N3l1x has joined #openstack-cinder | 14:25 | |
*** ykarel|afk is now known as ykarel | 14:28 | |
*** ociuhandu has quit IRC | 14:34 | |
xuanyd | rosmatia: got it, I will split the conditions to make it clearer, thanks | 14:34 |
rosmaita | xuanyd: ok, i'll take a look after you update | 14:35 |
xuanyd | rosmatia: how about change to :if backup.volume_id == volume.id and old_src_backup_id != backup.id: | 14:38 |
xuanyd | rosmaita: Can you tell me which scenarios will go wrong about path 31 | 14:46 |
rosmaita | xuanyd: i am in a meeting now, will look in 15 min or so | 14:47 |
openstackgerrit | Merged openstack/os-brick master: Update master for stable/ussuri https://review.opendev.org/716942 | 14:49 |
openstackgerrit | Merged openstack/os-brick stable/ussuri: Update .gitreview for stable/ussuri https://review.opendev.org/716940 | 14:50 |
openstackgerrit | Merged openstack/os-brick stable/ussuri: Update TOX/UPPER_CONSTRAINTS_FILE for stable/ussuri https://review.opendev.org/716941 | 14:50 |
*** throne82 has joined #openstack-cinder | 14:59 | |
throne82 | Hi! I have an bug - https://bugs.launchpad.net/cinder/+bug/1870367 | 15:01 |
openstack | Launchpad bug 1870367 in Cinder "Fail to extend attached volume using generic NFS driver" [Undecided,New] | 15:01 |
throne82 | How can we proceed with this ? | 15:01 |
xuanyd | rosmaita: Hello, are you free now | 15:08 |
rosmaita | xuanyd: in 5 minutes | 15:08 |
rosmaita | xuanyd: free now | 15:15 |
*** ociuhandu has joined #openstack-cinder | 15:18 | |
xuanyd | rosmaita: Can you tell me which scenarios will go wrong about path 31 | 15:19 |
rosmaita | looking | 15:20 |
hemna | mep | 15:21 |
xuanyd | rosmaita: I think the current conditions can be met to restore the new volume and restore the original volume with src_backup_id | 15:22 |
*** ociuhandu has quit IRC | 15:23 | |
rosmaita | ok, i will try to talk through this and we can see if it is a problem or not | 15:25 |
xuanyd | thanks | 15:28 |
rosmaita | sorry for the delay ... i am confusing myself! | 15:29 |
xuanyd | Never mind, there are more conditions | 15:32 |
*** ociuhandu has joined #openstack-cinder | 15:34 | |
rosmaita | xuanyd: so the good thing is that lines 616-622 make sure that if a volume has src_backup_id metadata, then it is correct | 15:38 |
rosmaita | so that is goo | 15:38 |
rosmaita | *good | 15:38 |
rosmaita | so actually i think your code is fine | 15:39 |
xuanyd | Yes, thanks for review, i will rename the src_backup_id to old_src_backup_id in line 614 | 15:41 |
rosmaita | ok, cool | 15:41 |
rosmaita | xuanyd: thanks for your patience! | 15:42 |
xuanyd | Glad to discuss the problem with you too. | 15:44 |
*** ykarel is now known as ykarel|away | 15:47 | |
openstackgerrit | Xuan Yandong proposed openstack/cinder master: Add features for add backup id to volume metadata https://review.opendev.org/705876 | 15:48 |
xuanyd | rosmaita: I submitted the update, please review it again latter, thanks very much | 15:51 |
rosmaita | xuanyd: i will keep an eye on it | 15:51 |
*** xuanyd has quit IRC | 15:55 | |
openstackgerrit | Merged openstack/cinder master: PowerMax Driver - Replication array serial check https://review.opendev.org/711217 | 16:19 |
*** KeithMnemonic has joined #openstack-cinder | 16:25 | |
*** udesale_ has quit IRC | 16:26 | |
*** ajitha has quit IRC | 16:43 | |
*** ociuhandu has quit IRC | 16:52 | |
openstackgerrit | Helen Walsh proposed openstack/cinder master: PowerMax Driver - Refreshing stale metadata https://review.opendev.org/712977 | 17:02 |
*** martinkennelly has quit IRC | 17:08 | |
*** martinkennelly has joined #openstack-cinder | 17:09 | |
*** KeithMnemonic has quit IRC | 17:12 | |
*** martinkennelly has quit IRC | 17:24 | |
*** martinkennelly has joined #openstack-cinder | 17:25 | |
*** martinkennelly has quit IRC | 17:27 | |
*** KeithMnemonic has joined #openstack-cinder | 17:28 | |
*** martinkennelly has joined #openstack-cinder | 17:28 | |
*** ociuhandu has joined #openstack-cinder | 17:32 | |
*** ociuhandu has quit IRC | 17:36 | |
*** rishabhhpe has joined #openstack-cinder | 17:37 | |
*** xakaitetoia has quit IRC | 17:38 | |
*** rishabhhpe has quit IRC | 17:46 | |
*** rishabhhpe has joined #openstack-cinder | 17:47 | |
*** xakaitetoia has joined #openstack-cinder | 17:48 | |
*** xakaitetoia has quit IRC | 17:56 | |
*** andrebeltrami has quit IRC | 18:06 | |
*** rishabhhpe has quit IRC | 18:08 | |
*** xakaitetoia has joined #openstack-cinder | 18:24 | |
*** xakaitetoia has quit IRC | 18:29 | |
*** xakaitetoia has joined #openstack-cinder | 19:01 | |
*** xakaitetoia has quit IRC | 19:07 | |
*** xakaitetoia has joined #openstack-cinder | 19:34 | |
*** xakaitetoia has quit IRC | 19:39 | |
*** ociuhandu has joined #openstack-cinder | 19:52 | |
*** ociuhandu has quit IRC | 20:02 | |
*** ociuhandu has joined #openstack-cinder | 20:02 | |
*** ociuhandu has quit IRC | 20:07 | |
*** xakaitetoia has joined #openstack-cinder | 20:09 | |
*** xakaitetoia has quit IRC | 20:17 | |
enriquetaso | Hello ganso o/ : I'm not able to reproduce step 3 in https://bugs.launchpad.net/cinder/+bug/1869746 | 20:18 |
openstack | Launchpad bug 1869746 in Cinder "Cinder throws error creating incremental backup from parent in another project" [Undecided,New] | 20:18 |
enriquetaso | I'm able to see volumes by other tenants from the admin user. The documentation says: "--all-tenants [<all_tenants>] Shows details for all tenants. Admin only." | 20:18 |
enriquetaso | Because of that, I can't see the backup created by the admin with the demo user, I guess it's not possible unless the demo user has admin role. Does the demo has admin roles? | 20:18 |
ganso | enriquetaso: no it doesn't have admin roles. I am confused, are you sure it is step 3? Don't you mean step 2? | 20:19 |
enriquetaso | ganso, i'm able to create the full backup as user admin :) but I can't see the backup with the demo user, because of that I can't create an incremental from it, but I can create a full backup instead. | 20:21 |
ganso | enriquetaso: in step 1, you create the volume as the user: "openstack volume create --size 1 v1". In step 2, you change your credentials to admin, and run "openstack volume backup create <v1_id>". Step 3 you go back to demo credentials and run "openstack volume backup create <v1_id or just v1> --incremental". | 20:21 |
ganso | enriquetaso: you don't need to see the backup to issue another incremental one | 20:21 |
enriquetaso | oh true, confirmed then :P | 20:24 |
enriquetaso | thanks ganso, i'll try to propose a fix this week | 20:26 |
ganso | enriquetaso: if you are the user you don't need to know about other backups that have been taken by the admin. Those steps are the simplest to reproduce the issue. On a more realistic scenario, the user would have a full backup, then the admin has another one, and then the user, oblivious to the fact the admin has taken another one, tries an incremental and gets the error. Regardless of that, the docs state that even if the user has no backups and | 20:26 |
ganso | specifies --incremental, it will ignore the parameter and create a full one automatically, which creates the use case of the user always using --incremental with no full backups and hitting the error as well | 20:26 |
ganso | enriquetaso: I created this etherpad for us to discuss https://etherpad.openstack.org/p/cinder-backup-bug | 20:26 |
ganso | enriquetaso: we need to choose the proper solution. I like (c) best, but it has a few concerns, and I am not sure we will be able to backport it :( | 20:30 |
enriquetaso | Thanks for creating the etherpad ganso! I'll check the solutions an write my opinion then | 20:39 |
ganso | enriquetaso: great! thanks! let's work together on this and discuss the solution with the team if there are any other concerns we missed | 20:40 |
enriquetaso | sounds good to me | 20:41 |
*** Xuchu has quit IRC | 20:52 | |
*** ociuhandu has joined #openstack-cinder | 21:02 | |
*** e0ne has quit IRC | 21:06 | |
*** ociuhandu has quit IRC | 21:06 | |
*** dpawlik has quit IRC | 21:12 | |
*** Xuchu has joined #openstack-cinder | 21:29 | |
*** Lucas_Gray has joined #openstack-cinder | 21:34 | |
*** Lucas_Gray has quit IRC | 21:40 | |
openstackgerrit | Helen Walsh proposed openstack/cinder master: PowerMax Driver - Version comparison correction https://review.opendev.org/713329 | 21:52 |
*** rcernin has joined #openstack-cinder | 22:22 | |
*** openstackstatus has quit IRC | 22:56 | |
*** openstack has joined #openstack-cinder | 23:01 | |
*** ChanServ sets mode: +o openstack | 23:01 | |
*** martinkennelly has quit IRC | 23:21 | |
*** Xuchu has quit IRC | 23:24 | |
*** Xuchu has joined #openstack-cinder | 23:27 | |
*** enriquetaso has quit IRC | 23:34 | |
*** rosmaita has quit IRC | 23:46 | |
*** Xuchu has quit IRC | 23:56 | |
*** Xuchu has joined #openstack-cinder | 23:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!