| *** n-saito has joined #openstack-cinder | 00:19 | |
| *** rchurch has quit IRC | 00:34 | |
| rosmaita | smcginnis: thanks for rechecking that patch for stein -- i saw it had failed and gave up! | 00:35 |
|---|---|---|
| *** zhanglong has joined #openstack-cinder | 00:38 | |
| *** andrebeltrami has quit IRC | 00:38 | |
| *** Liang__ has joined #openstack-cinder | 01:17 | |
| *** markvoelker has joined #openstack-cinder | 01:20 | |
| *** markvoelker has quit IRC | 01:24 | |
| *** lvbin01 has quit IRC | 01:36 | |
| *** yaawang has quit IRC | 01:42 | |
| *** yaawang has joined #openstack-cinder | 01:43 | |
| *** Liang__ has quit IRC | 01:46 | |
| *** yaawang has quit IRC | 02:45 | |
| *** yaawang has joined #openstack-cinder | 02:46 | |
| openstackgerrit | Xuan Yandong proposed openstack/cinder-specs master: Support revert any snapshot to the volume https://review.opendev.org/736111 | 02:57 |
| *** psachin has joined #openstack-cinder | 03:33 | |
| *** zhanglong has quit IRC | 03:42 | |
| *** Liang__ has joined #openstack-cinder | 03:58 | |
| *** markvoelker has joined #openstack-cinder | 04:03 | |
| *** m75abrams has joined #openstack-cinder | 04:06 | |
| *** markvoelker has quit IRC | 04:08 | |
| *** ykarel|away is now known as ykarel | 04:24 | |
| *** Lucas_Gray has quit IRC | 04:30 | |
| *** udesale has joined #openstack-cinder | 04:33 | |
| *** abdysn has joined #openstack-cinder | 04:59 | |
| *** markvoelker has joined #openstack-cinder | 05:03 | |
| *** strigazi has quit IRC | 05:04 | |
| *** strigazi has joined #openstack-cinder | 05:06 | |
| *** markvoelker has quit IRC | 05:07 | |
| *** vishalmanchanda has joined #openstack-cinder | 05:23 | |
| *** yaawang has quit IRC | 05:45 | |
| *** yaawang has joined #openstack-cinder | 05:45 | |
| *** strigazi has quit IRC | 05:46 | |
| openstackgerrit | Xuan Yandong proposed openstack/cinder-specs master: Support revert any snapshot to the volume https://review.opendev.org/736111 | 06:07 |
| *** zhanglong has joined #openstack-cinder | 06:09 | |
| openstackgerrit | wanghao proposed openstack/cinder master: time comparison filter didn't support time zone offset https://review.opendev.org/734415 | 06:15 |
| *** zhanglong has quit IRC | 06:18 | |
| *** zhanglong has joined #openstack-cinder | 06:20 | |
| *** zhanglong has quit IRC | 06:42 | |
| *** zhanglong has joined #openstack-cinder | 06:43 | |
| *** yaawang has quit IRC | 06:43 | |
| openstackgerrit | Merged openstack/cinder master: Default volume_type set too early https://review.opendev.org/730183 | 06:45 |
| *** yaawang has joined #openstack-cinder | 06:51 | |
| *** yaawang has quit IRC | 06:55 | |
| *** yaawang has joined #openstack-cinder | 06:56 | |
| *** bhagyashris is now known as bhagyashris|brb | 06:59 | |
| *** rcernin has quit IRC | 07:02 | |
| *** rcernin has joined #openstack-cinder | 07:04 | |
| *** markvoelker has joined #openstack-cinder | 07:04 | |
| *** markvoelker has quit IRC | 07:09 | |
| *** bhagyashris|brb is now known as bhagyashris | 07:15 | |
| *** markvoelker has joined #openstack-cinder | 07:18 | |
| *** markvoelker has quit IRC | 07:23 | |
| *** m75abrams has quit IRC | 07:30 | |
| *** rcernin has quit IRC | 07:30 | |
| *** Liang__ has quit IRC | 07:30 | |
| *** Liang__ has joined #openstack-cinder | 07:31 | |
| *** m75abrams has joined #openstack-cinder | 07:32 | |
| *** zhanglong has quit IRC | 07:34 | |
| *** zhanglong has joined #openstack-cinder | 07:36 | |
| *** m75abrams has quit IRC | 07:37 | |
| *** tosky has joined #openstack-cinder | 07:40 | |
| *** ociuhandu has quit IRC | 07:41 | |
| *** rcernin has joined #openstack-cinder | 07:49 | |
| *** e0ne has joined #openstack-cinder | 07:58 | |
| *** rcernin has quit IRC | 08:06 | |
| *** zhanglong has quit IRC | 08:11 | |
| *** zhanglong has joined #openstack-cinder | 08:15 | |
| *** ociuhandu has joined #openstack-cinder | 08:20 | |
| *** martinkennelly has joined #openstack-cinder | 08:24 | |
| *** m75abrams has joined #openstack-cinder | 08:31 | |
| *** yaawang has quit IRC | 08:46 | |
| *** yaawang has joined #openstack-cinder | 08:47 | |
| *** yaawang has quit IRC | 09:30 | |
| *** yaawang has joined #openstack-cinder | 09:31 | |
| *** Lucas_Gray has joined #openstack-cinder | 09:33 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder master: Move get_volume_stats impl to the base volume driver https://review.opendev.org/656888 | 09:41 |
| *** n-saito has quit IRC | 09:42 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder-specs master: Backup Backends Configuration https://review.opendev.org/712301 | 09:56 |
| *** tkajinam has quit IRC | 09:59 | |
| *** Liang__ has quit IRC | 10:40 | |
| openstackgerrit | Andrei Perepiolkin proposed openstack/cinder master: [WIP] Add Cinder driver for Open-E JovianDSS data storage https://review.opendev.org/726906 | 10:44 |
| rosmaita | looks like stable/stein is finally unblocked -- need some reviews on https://review.opendev.org/#/c/736805/ so we can kill off OSSN-0086 | 10:51 |
| rosmaita | e0ne eharney geguileo jungleboyj smcginnis ^^ | 10:51 |
| e0ne | rosmaita: great! | 10:52 |
| smcginnis | rosmaita: Perfect timing, I was literally just going to search for that patch to check the status. | 10:52 |
| rosmaita | \o/ | 10:52 |
| *** priteau has joined #openstack-cinder | 11:02 | |
| openstackgerrit | Brian Rosmaita proposed openstack/cinder stable/ussuri: Default volume_type set too early https://review.opendev.org/738791 | 11:06 |
| *** kevinz has quit IRC | 11:11 | |
| *** markvoelker has joined #openstack-cinder | 11:15 | |
| *** markvoelker has quit IRC | 11:19 | |
| *** udesale_ has joined #openstack-cinder | 11:28 | |
| *** udesale has quit IRC | 11:31 | |
| *** zhanglong has quit IRC | 11:32 | |
| *** Lucas_Gray has quit IRC | 11:58 | |
| *** Lucas_Gray has joined #openstack-cinder | 12:00 | |
| *** andrebeltrami has joined #openstack-cinder | 12:06 | |
| *** breizhkoala has joined #openstack-cinder | 12:15 | |
| *** irclogbot_2 has quit IRC | 12:16 | |
| *** irclogbot_2 has joined #openstack-cinder | 12:17 | |
| *** xinliang has joined #openstack-cinder | 12:23 | |
| *** swegener has quit IRC | 12:26 | |
| openstackgerrit | Brian Rosmaita proposed openstack/cinder-tempest-plugin master: Add test for cinder_img_volume_type image metadata https://review.opendev.org/737380 | 12:26 |
| *** xinliang has quit IRC | 12:27 | |
| *** martinkennelly has quit IRC | 12:40 | |
| *** trident has quit IRC | 12:46 | |
| *** zhanglong has joined #openstack-cinder | 12:48 | |
| *** trident has joined #openstack-cinder | 12:49 | |
| *** abhishekk has quit IRC | 13:22 | |
| *** abhishekk has joined #openstack-cinder | 13:23 | |
| *** Lucas_Gray has quit IRC | 13:27 | |
| *** Lucas_Gray has joined #openstack-cinder | 13:30 | |
| *** psachin has quit IRC | 13:31 | |
| *** zhanglong has quit IRC | 13:34 | |
| *** bhagyashris is now known as bhagyashris|afk | 13:42 | |
| rosmaita | Courtesy reminder: Cinder meeting in #openstack-meeting-alt at 1400 UTC | 13:57 |
| rosmaita | jungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard lseki sfernand rajinir enriquetaso ^^ | 13:57 |
| whoami-rajat | thanks rosmaita | 13:57 |
| geguileo | rosmaita: thanks | 13:59 |
| *** abdysn has quit IRC | 14:00 | |
| *** sfernand has joined #openstack-cinder | 14:02 | |
| *** Liang__ has joined #openstack-cinder | 14:02 | |
| *** Liang__ is now known as LiangFang | 14:02 | |
| *** TusharTgite has joined #openstack-cinder | 14:07 | |
| TusharTgite | #link https://etherpad.openstack.org/p/cinder-victoria-meetings | 14:09 |
| openstackgerrit | Merged openstack/cinder stable/stein: Update os-brick library to 2.8.6 https://review.opendev.org/736805 | 14:10 |
| TusharTgite | #startmeeting cinder | 14:15 |
| openstack | Meeting started Wed Jul 1 14:15:18 2020 UTC and is due to finish in 60 minutes. The chair is TusharTgite. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:15 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:15 |
| *** openstack changes topic to " (Meeting topic: cinder)" | 14:15 | |
| openstack | The meeting name has been set to 'cinder' | 14:15 |
| TusharTgite | #link https://etherpad.openstack.org/p/cinder-victoria-meetings | 14:16 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder-specs master: Default volume type overrides https://review.opendev.org/733555 | 14:18 |
| geguileo | whoami-rajat: jungleboyj I fixed the typos and answered the UUID questions from the reviews | 14:19 |
| whoami-rajat | thanks geguileo for the quick update, the delete part makes sense, i will implement it similarly | 14:23 |
| geguileo | whoami-rajat: I initially wanted to add it to the URL, because it looked better, but I had to reconsider it :-( | 14:23 |
| whoami-rajat | geguileo, yeah, the client's delete method also accepts URL only, i will define a new method or update the existing one to accept a body, but i also got this thought now, should we support deletion w.r.t. uuid ? i think we should | 14:25 |
| *** dave-mccowan has joined #openstack-cinder | 14:25 | |
| geguileo | whoami-rajat: what does w.r.t. mean? | 14:26 |
| whoami-rajat | geguileo, with respect to, currently we planned to unset the default with project_id, should we support it with uuid as well? | 14:27 |
| tosky | TusharTgite: can you please close this? The meeting is on another channel | 14:27 |
| geguileo | whoami-rajat: project id is the project's UUID, isn't it? | 14:27 |
| geguileo | if your project is using UUIDs | 14:28 |
| smcginnis | Someone's learning how the meetbot works. :D | 14:28 |
| whoami-rajat | geguileo, yes, so we've a DB entry consisting of volume_type_id, project_id and id | 14:28 |
| smcginnis | TusharTgite: Enter "#endmeeting" to end this. | 14:29 |
| whoami-rajat | geguileo, http://paste.openstack.org/show/795447/ | 14:30 |
| geguileo | whoami-rajat: the ID is wrong | 14:30 |
| geguileo | whoami-rajat: look at the spec, it's a primary integer key | 14:31 |
| geguileo | not a UUID | 14:31 |
| geguileo | and it's mostly to facilitate the quick access to a given resource for update | 14:31 |
| geguileo | and it's something the user should never see | 14:32 |
| whoami-rajat | geguileo, ah my bad, i initially set it integer during table create then forgot and changed the table, i will update it | 14:32 |
| geguileo | whoami-rajat: you can see in the spec that it's never returned on the GET method | 14:32 |
| whoami-rajat | geguileo, yes, yes, i do it right once then change it some other day because of something else, keep forgetting stuff :/ | 14:33 |
| *** m75abrams has quit IRC | 14:34 | |
| geguileo | whoami-rajat: ooooooh, welcome to the fish brain club!!! };-) | 14:36 |
| smcginnis | :) | 14:37 |
| *** xinliang has joined #openstack-cinder | 14:39 | |
| whoami-rajat | geguileo, :D , should we also update the GET response from 'type_name' to 'volume_type' or keep that as it is? | 14:46 |
| openstackgerrit | Raghavendra Tilay proposed openstack/cinder stable/train: HPE 3PAR: Support duplicated FQDN in network https://review.opendev.org/724271 | 14:47 |
| geguileo | whoami-rajat: if we are returning type names, then it's ok as it is, but maybe we should return type_id instead, since that's what we have in the DB table | 14:47 |
| *** LiangFang has quit IRC | 14:48 | |
| whoami-rajat | geguileo, either one is fine with me :) | 14:48 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder-specs master: Default volume type overrides https://review.opendev.org/733555 | 14:50 |
| geguileo | whoami-rajat: ^ updated | 14:50 |
| *** Liang__ has joined #openstack-cinder | 14:51 | |
| whoami-rajat | geguileo, great, thanks. sorry for all the updates on minor corrections | 14:53 |
| geguileo | whoami-rajat: don't be, it's important to have a proper spec :-) | 14:53 |
| whoami-rajat | :) | 14:54 |
| smcginnis | rosmaita, jungleboyj: Took me way too long to find it - http://lists.openstack.org/pipermail/openstack-discuss/2020-March/013006.html | 15:01 |
| smcginnis | I'm going to update the governance docs to include the results. Right now they only refer to the polling process with no conclusions. | 15:01 |
| rosmaita | smcginnis: i thought i had seen that somewhere! | 15:03 |
| TusharTgite | #endmeeting | 15:04 |
| *** openstack changes topic to "The Block Storage Project | https://wiki.openstack.org/wiki/Cinder | https://tiny.cc/CinderPriorities" | 15:04 | |
| openstack | Meeting ended Wed Jul 1 15:04:41 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:04 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/cinder/2020/cinder.2020-07-01-14.15.html | 15:04 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/cinder/2020/cinder.2020-07-01-14.15.txt | 15:04 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/cinder/2020/cinder.2020-07-01-14.15.log.html | 15:04 |
| rosmaita | TusharTgite: i think you are in the wrong channel! | 15:05 |
| smcginnis | I've requested that infra delete the logs for that one. | 15:05 |
| TusharTgite | yeah sorry i didn't understand what to do | 15:06 |
| openstackgerrit | Raghavendra Tilay proposed openstack/cinder stable/train: HPE 3PAR: Support duplicated FQDN in network https://review.opendev.org/724271 | 15:06 |
| rosmaita | smcginnis: thanks, i completely missed this entire interaction | 15:07 |
| rosmaita | TusharTgite: were you trying to attend the cinder meeting? | 15:07 |
| *** dave-mccowan has quit IRC | 15:08 | |
| TusharTgite | yes | 15:09 |
| *** dave-mccowan has joined #openstack-cinder | 15:12 | |
| rosmaita | ok, we have it in a different channel, #openstack-meeting-alt | 15:12 |
| rosmaita | here's the meeting log, if you want to see what happened: http://eavesdrop.openstack.org/meetings/cinder/2020/cinder.2020-07-01-14.00.log.html | 15:12 |
| TusharTgite | ok i'll take care from next time. | 15:13 |
| rosmaita | sounds good, see you next week! | 15:13 |
| tosky | TusharTgite: you can check the schedule and the right channel to join for all OpenStack projects from http://eavesdrop.openstack.org/ | 15:13 |
| tosky | for example, here are the details of the cinder meetings: http://eavesdrop.openstack.org/#Cinder_Team_Meeting | 15:14 |
| jungleboyj | https://giphy.com/gifs/kangaroo-UcNFNtz1d1BLy | 15:14 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinderlib master: Improve cinder supported drivers output https://review.opendev.org/738473 | 15:15 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinderlib master: Support references in driver configuration https://review.opendev.org/738866 | 15:15 |
| TusharTgite | ok i'll check all those links | 15:17 |
| *** TusharTgite has quit IRC | 15:21 | |
| xinliang | hemna_: Any new update on ceph iscsi volume driver patch? | 15:28 |
| xinliang | hemna_: I've try it today, but it doesn't work. | 15:28 |
| hemna_ | I can't get ceph-iscsi to work properly | 15:29 |
| hemna_ | creating the gateway, etc | 15:29 |
| xinliang | Hemna_: Have try my patch? https://review.opendev.org/#/c/736508 | 15:29 |
| hemna_ | my local modifications to the plugin look similar | 15:30 |
| xinliang | hemna_: Creating volume seems works. But attaching the volume to vm when lauching a vm fails. | 15:30 |
| hemna_ | I am doing 'work' items currently and haven't had time to work on this today | 15:31 |
| xinliang | hemna_: I can create ceph iscsi gateway now. What problem do you encounter? | 15:31 |
| xinliang | hemna_: Fine, if you have any update on ceph iscsi volume driver patch https://review.opendev.org/662829. Please update and I can help to test it. Thanks | 15:33 |
| *** Liang__ has quit IRC | 15:33 | |
| hemna_ | ok I'll see if I can get it back up this afternoon | 15:37 |
| hemna_ | I think at this point the problem lies with ceph-iscsi itself | 15:38 |
| hemna_ | xinliang https://github.com/ceph/ceph-iscsi/issues/195 | 15:38 |
| xinliang | hemna_: Not sure, I see dillaman comment, Not fully understand what he says :( | 15:41 |
| xinliang | Any way, we will figure out it. | 15:41 |
| rosmaita | geguileo: left a comment on your spec https://review.opendev.org/#/c/733555/8 | 15:54 |
| *** hamalq has joined #openstack-cinder | 15:57 | |
| *** hamalq_ has joined #openstack-cinder | 15:58 | |
| *** xinliang has quit IRC | 16:00 | |
| *** hamalq has quit IRC | 16:02 | |
| openstackgerrit | Merged openstack/cinder-specs master: Backup Backends Configuration https://review.opendev.org/712301 | 16:07 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder-specs master: Default volume type overrides https://review.opendev.org/733555 | 16:07 |
| geguileo | rosmaita: replied to your comment and updated the patch ^ | 16:07 |
| rosmaita | just saw that, thanks | 16:07 |
| geguileo | whoami-rajat: I have changed how the DELETE method is called | 16:07 |
| *** udesale_ has quit IRC | 16:12 | |
| rosmaita | geguileo: what do you think of no DELETE verb, but instead use PUT with {"project_id": 123456, "volume_type": null} in the body? | 16:12 |
| geguileo | rosmaita: then would we make that so in the DB? | 16:13 |
| geguileo | rosmaita: I mean, would we keep the DB entry setting the value to NULL? Or would we be deleting it? | 16:13 |
| rosmaita | i think we would delete it, which would effectively set it to null in the DB | 16:13 |
| geguileo | leaving it could mean that we leave projects there that no longer exist | 16:13 |
| rosmaita | yes, we don't want to leave it | 16:14 |
| geguileo | To me the delete makes more sense... | 16:14 |
| geguileo | as in delete the default type | 16:14 |
| rosmaita | i have to admit, i have not looked at your revision of delete yet | 16:14 |
| geguileo | rosmaita: basically is doing the same as the GET, getting the project_id as a parameter instead of in the body | 16:15 |
| rosmaita | i have to go back and read through your discussion with rajat on the patch ... i'm not clear on your objection to having the project_id in the URL | 16:17 |
| *** gnufied has joined #openstack-cinder | 16:18 | |
| rosmaita | geguileo: don't worry about this now ... i will give a spec-freeze exception -- everyone is on board with the idea, it will be good to get the API right | 16:19 |
| whoami-rajat | geguileo, ah, now i'm not sure anymore, why don't we just make the project_id primary key and everything makes sense then ? | 16:21 |
| *** ykarel is now known as ykarel|away | 16:34 | |
| *** breizhkoala has quit IRC | 16:41 | |
| *** ociuhandu_ has joined #openstack-cinder | 16:45 | |
| *** ociuhandu has quit IRC | 16:49 | |
| *** ociuhandu_ has quit IRC | 16:52 | |
| *** Lucas_Gray has quit IRC | 16:53 | |
| *** Lucas_Gray has joined #openstack-cinder | 16:58 | |
| *** ociuhandu has joined #openstack-cinder | 16:59 | |
| *** sfernand has quit IRC | 17:02 | |
| *** ociuhandu has quit IRC | 17:07 | |
| *** jdillaman has quit IRC | 17:15 | |
| *** mvkr has quit IRC | 17:15 | |
| *** jmccrory has quit IRC | 17:15 | |
| *** ganso has quit IRC | 17:15 | |
| *** ericyoung has quit IRC | 17:15 | |
| *** ganso has joined #openstack-cinder | 17:18 | |
| *** ericyoung has joined #openstack-cinder | 17:18 | |
| *** jmccrory has joined #openstack-cinder | 17:18 | |
| *** jdillaman has joined #openstack-cinder | 17:18 | |
| *** mvkr has joined #openstack-cinder | 17:19 | |
| *** johanssone has quit IRC | 17:26 | |
| *** kmarc has quit IRC | 17:26 | |
| *** zzzeek has quit IRC | 17:26 | |
| *** irclogbot_2 has quit IRC | 17:28 | |
| *** johanssone has joined #openstack-cinder | 17:29 | |
| *** kmarc has joined #openstack-cinder | 17:29 | |
| *** zzzeek has joined #openstack-cinder | 17:29 | |
| *** irclogbot_0 has joined #openstack-cinder | 17:29 | |
| *** Lucas_Gray has quit IRC | 17:30 | |
| *** hoonetorg has quit IRC | 17:40 | |
| *** hoonetorg has joined #openstack-cinder | 17:52 | |
| *** e0ne has quit IRC | 17:59 | |
| *** eharney has quit IRC | 18:16 | |
| *** dasp_ has quit IRC | 18:39 | |
| *** dasp has joined #openstack-cinder | 18:41 | |
| rosmaita | smcginnis: feel free to approve e0ne's patch when you have a few minutes: https://review.opendev.org/#/c/656888/ | 18:51 |
| smcginnis | Done! | 18:57 |
| rosmaita | ty | 18:59 |
| smcginnis | Glad we're getting that one through. | 19:01 |
| rosmaita | let's hope it doesn't get a merge conflict at the last minute | 19:02 |
| rosmaita | we're going to have another big patch or set of patches in a week or two for eric's type-checking stuff | 19:03 |
| openstackgerrit | Merged openstack/cinder master: Fix cross-project incremental backups https://review.opendev.org/720833 | 19:05 |
| rosmaita | ganso: ^^ | 19:05 |
| *** ociuhandu has joined #openstack-cinder | 19:06 | |
| ganso | YAY! | 19:06 |
| ganso | rosmaita: thanks! | 19:06 |
| rosmaita | thanks for your patience | 19:06 |
| ganso | rosmaita: now, one important question | 19:06 |
| ganso | rosmaita: to which stable branches do you think it could be backported to? My customer is running queens | 19:06 |
| smcginnis | Looks safe to me. I would say, backported it as far back as it goes. | 19:08 |
| rosmaita | i was going to say, this is a good question for smcginnis | 19:08 |
| rosmaita | :) | 19:08 |
| smcginnis | I don't think that code has changed much, so it should be easy enough to go all the way back to queens. | 19:08 |
| smcginnis | rosmaita: ;) | 19:08 |
| ganso | smcginnis, rosmaita: thanks! I am rechecking the test case patch (cinder-tempest-plugin) now, as soon as it is merged, I will propose the backport. Another quick question though, should the test case patch be backported as well? | 19:09 |
| rosmaita | yes, that's the usual practice | 19:09 |
| smcginnis | Tempest plugins are not branched though. | 19:09 |
| smcginnis | So merged to master should be good enough. | 19:09 |
| rosmaita | sorry, i thought you meant the tests on this patch | 19:10 |
| ganso | thanks! so I will just backport the main patch then | 19:10 |
| rosmaita | ganso: do the cherry pick to ussuri locally and run the tests | 19:10 |
| rosmaita | i just ran into a problem today where we moved the base test class; the change merged fine but the tests broke | 19:11 |
| ganso | rosmaita: you mean functional? | 19:11 |
| rosmaita | maybe, let me look | 19:11 |
| rosmaita | i was thinking unit, though | 19:11 |
| smcginnis | Yeah, this - https://opendev.org/openstack/cinder/commit/d4eb4a9ba18743a86813008d31b58c0f7acbaa95 | 19:12 |
| rosmaita | that's the one | 19:13 |
| rosmaita | my functional tests seem to be ok, it's the unit tests | 19:13 |
| ganso | oh ok, cherry pick locally and run unit tests. Will do that for each branch. Thanks! | 19:13 |
| rosmaita | https://review.opendev.org/#/c/738791/ | 19:13 |
| rosmaita | ganso: don't forget to cherry-pick -x to get the info into the commit message | 19:13 |
| ganso | rosmaita: I used to do that manually, thanks for the "-x" reminder! =) | 19:14 |
| rosmaita | :) | 19:14 |
| *** vishalmanchanda has quit IRC | 19:47 | |
| *** spatel has joined #openstack-cinder | 19:55 | |
| *** eharney has joined #openstack-cinder | 19:59 | |
| *** e0ne has joined #openstack-cinder | 20:20 | |
| openstackgerrit | Merged openstack/cinder master: Move get_volume_stats impl to the base volume driver https://review.opendev.org/656888 | 20:21 |
| openstackgerrit | Eric Harney proposed openstack/cinder master: Remove unneeded arg from _clean_db (vol manager) https://review.opendev.org/738933 | 20:26 |
| *** spatel has quit IRC | 20:29 | |
| *** spatel has joined #openstack-cinder | 20:30 | |
| *** spatel has quit IRC | 20:30 | |
| *** jgriffith has quit IRC | 20:54 | |
| *** ircuser-1 has quit IRC | 21:03 | |
| *** e0ne has quit IRC | 21:07 | |
| ganso | rosmaita, smcginnis: ok, it seems now I have to make the test case patch backwards compatible: https://review.opendev.org/#/c/728289 is that ok if I just skip the test and then add other patches in the future to unskip? how is this being handled? | 21:15 |
| smcginnis | ganso: Basically how you plan to get around it. If it's new functionality, then there is a conditional skip in the code. | 21:17 |
| rosmaita | but if you are backporting the fix, then the tempest tests should pass after all the fixes have merged | 21:17 |
| smcginnis | ganso: Since in this case there isn't a way to tell if it should be skipped or not, I think it may make sense to hold on the tempest test, get the fix backported to the stable branches, then recheck the tempest plugin patch. | 21:17 |
| rosmaita | what smcginnis said | 21:18 |
| smcginnis | We at least see that it passes in master, so that's good. | 21:18 |
| ganso | ok, works for me =) | 21:18 |
| smcginnis | Presumably then, as soon as the backport merges, that branch should go green too. | 21:18 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/cinder stable/ussuri: Fix cross-project incremental backups https://review.opendev.org/738943 | 21:18 |
| ganso | there goes one | 21:18 |
| smcginnis | ganso: Looks like you picked up an extra file. | 21:19 |
| ganso | smcginnis: oh crap, yes, fixing that, thanks! | 21:19 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/cinder stable/ussuri: Fix cross-project incremental backups https://review.opendev.org/738943 | 21:20 |
| *** priteau has quit IRC | 21:21 | |
| *** gregwork has joined #openstack-cinder | 22:09 | |
| *** zhanglong has joined #openstack-cinder | 22:22 | |
| *** rcernin has joined #openstack-cinder | 22:35 | |
| *** tkajinam has joined #openstack-cinder | 22:46 | |
| *** rcernin has quit IRC | 22:47 | |
| *** rcernin has joined #openstack-cinder | 22:47 | |
| *** zhanglong has quit IRC | 22:50 | |
| *** zhanglong has joined #openstack-cinder | 22:52 | |
| *** spatel has joined #openstack-cinder | 22:58 | |
| *** jmlowe has quit IRC | 23:06 | |
| *** spatel has quit IRC | 23:07 | |
| *** hoonetorg has quit IRC | 23:08 | |
| *** hoonetorg has joined #openstack-cinder | 23:12 | |
| *** tosky has quit IRC | 23:16 | |
| *** zhanglong has quit IRC | 23:17 | |
| *** Lucas_Gray has joined #openstack-cinder | 23:21 | |
| *** jmlowe has joined #openstack-cinder | 23:29 | |
| *** hamalq_ has quit IRC | 23:41 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!