| *** andrebeltrami has quit IRC | 00:01 | |
| *** hoonetorg has quit IRC | 00:04 | |
| *** hoonetorg has joined #openstack-cinder | 00:18 | |
| *** hoonetorg has quit IRC | 00:36 | |
| *** brinzhang has joined #openstack-cinder | 00:57 | |
| *** hoonetorg has joined #openstack-cinder | 00:59 | |
| openstackgerrit | Kazufumi Noto proposed openstack/cinder-specs master: Support modern compression algorithms in cinder backup https://review.opendev.org/726307 | 00:59 |
|---|---|---|
| *** enriquetaso has quit IRC | 01:11 | |
| *** knomura has joined #openstack-cinder | 01:13 | |
| *** knomura has quit IRC | 01:17 | |
| *** knomura has joined #openstack-cinder | 01:21 | |
| *** m3m0__ has joined #openstack-cinder | 01:23 | |
| *** knomura has quit IRC | 01:25 | |
| *** knomura has joined #openstack-cinder | 01:27 | |
| *** knomura has quit IRC | 01:32 | |
| *** brinzhang_ has joined #openstack-cinder | 01:33 | |
| *** brinzhang has quit IRC | 01:36 | |
| *** knomura has joined #openstack-cinder | 01:39 | |
| *** knomura has quit IRC | 01:44 | |
| *** spatel has joined #openstack-cinder | 01:55 | |
| *** brinzhang0 has joined #openstack-cinder | 01:56 | |
| *** brinzhang has joined #openstack-cinder | 01:57 | |
| brinzhang | smcginnis, all team: Hi, we upgrade openstack from R-->U by kolla, but the cinder serverice cannot start up, because of the etcd version incorrect(Ussuri seems required the version is 3.2.21, but the kolla intalled 3.3 by default) | 01:58 |
| *** brinzhang_ has quit IRC | 01:59 | |
| brinzhang | do we have some required etcd version for Ussuri release? In the requirements.rst I was not found some useful info about etcd | 01:59 |
| *** brinzhang0 has quit IRC | 02:00 | |
| *** knomura has joined #openstack-cinder | 02:09 | |
| *** knomura has quit IRC | 02:13 | |
| *** knomura has joined #openstack-cinder | 02:14 | |
| *** brinzhang_ has joined #openstack-cinder | 02:17 | |
| *** knomura has quit IRC | 02:18 | |
| *** brinzhang has quit IRC | 02:20 | |
| *** knomura has joined #openstack-cinder | 02:24 | |
| *** knomura has quit IRC | 02:28 | |
| *** spatel has quit IRC | 02:34 | |
| *** knomura has joined #openstack-cinder | 02:38 | |
| *** knomura has quit IRC | 02:43 | |
| *** Lucas_Gray has quit IRC | 02:44 | |
| openstackgerrit | Xinliang Liu proposed openstack/cinder master: Add ceph-iscsci CI job https://review.opendev.org/667108 | 02:51 |
| *** spatel has joined #openstack-cinder | 02:51 | |
| *** psachin has joined #openstack-cinder | 02:59 | |
| openstackgerrit | Xinliang Liu proposed openstack/cinder master: Add ceph-iscsci CI job https://review.opendev.org/667108 | 03:36 |
| *** knomura has joined #openstack-cinder | 03:49 | |
| *** m5z has quit IRC | 03:54 | |
| *** TheJulia has quit IRC | 03:54 | |
| *** knomura has quit IRC | 03:54 | |
| *** knomura has joined #openstack-cinder | 03:54 | |
| *** TheJulia has joined #openstack-cinder | 03:55 | |
| *** sapd__x has joined #openstack-cinder | 03:57 | |
| *** knomura has quit IRC | 03:58 | |
| *** m3m0__ has quit IRC | 04:04 | |
| *** psachin has quit IRC | 04:07 | |
| *** psachin has joined #openstack-cinder | 04:45 | |
| *** abdysn has joined #openstack-cinder | 04:54 | |
| *** ociuhandu has joined #openstack-cinder | 05:01 | |
| *** ociuhandu has quit IRC | 05:05 | |
| *** spatel has quit IRC | 05:09 | |
| *** m75abrams has quit IRC | 05:24 | |
| *** udesale has joined #openstack-cinder | 05:29 | |
| *** psachin has quit IRC | 05:29 | |
| *** psachin has joined #openstack-cinder | 05:39 | |
| *** vishalmanchanda has joined #openstack-cinder | 05:41 | |
| *** whoami-rajat__ has joined #openstack-cinder | 05:44 | |
| *** sapd__x has quit IRC | 05:59 | |
| *** knomura has joined #openstack-cinder | 06:07 | |
| *** knomura has quit IRC | 06:09 | |
| *** knomura_ has joined #openstack-cinder | 06:09 | |
| *** whoami-rajat__ has quit IRC | 06:12 | |
| *** knomura_ has quit IRC | 06:13 | |
| *** elod is now known as elod_off | 06:15 | |
| *** knomura has joined #openstack-cinder | 06:23 | |
| *** knomura has quit IRC | 06:28 | |
| *** knomura has joined #openstack-cinder | 06:31 | |
| *** whoami-rajat__ has joined #openstack-cinder | 06:33 | |
| *** knomura has quit IRC | 06:36 | |
| *** m75abrams has joined #openstack-cinder | 06:51 | |
| *** rcernin has quit IRC | 07:05 | |
| *** kevinz has joined #openstack-cinder | 07:26 | |
| *** raghavendrat has joined #openstack-cinder | 07:36 | |
| raghavendrat | hi whoami-rajat__: are you online? | 07:37 |
| whoami-rajat__ | raghavendrat, hey | 07:37 |
| *** tosky has joined #openstack-cinder | 07:37 | |
| raghavendrat | this is regarding https://review.opendev.org/#/c/739033/ | 07:38 |
| raghavendrat | Zuul and CI have passed. | 07:38 |
| raghavendrat | whenever you get time, it would be great if you can have a look. Thanks | 07:38 |
| *** m5z has joined #openstack-cinder | 07:40 | |
| whoami-rajat__ | ok, i will take a look | 07:41 |
| raghavendrat | ok | 07:42 |
| *** bhagyashris|afk is now known as bhagyashris | 07:44 | |
| *** whoami-rajat__ is now known as whoami-rajat | 07:51 | |
| *** sapd__x has joined #openstack-cinder | 07:55 | |
| *** e0ne has joined #openstack-cinder | 08:01 | |
| *** raghavendrat has quit IRC | 08:04 | |
| *** rcernin has joined #openstack-cinder | 08:09 | |
| *** Lucas_Gray has joined #openstack-cinder | 08:10 | |
| *** rcernin has quit IRC | 08:14 | |
| *** rcernin has joined #openstack-cinder | 08:15 | |
| *** martinkennelly has joined #openstack-cinder | 08:29 | |
| *** brinzhang_ has quit IRC | 08:31 | |
| *** brinzhang0 has joined #openstack-cinder | 08:31 | |
| *** martinkennelly has quit IRC | 08:41 | |
| *** rcernin has quit IRC | 08:42 | |
| *** martinkennelly has joined #openstack-cinder | 08:42 | |
| *** ociuhandu has joined #openstack-cinder | 08:50 | |
| *** donnyd has quit IRC | 08:53 | |
| *** donnyd has joined #openstack-cinder | 08:53 | |
| *** whoami-rajat has quit IRC | 09:03 | |
| *** brinzhang_ has joined #openstack-cinder | 09:05 | |
| *** brinzhang0 has quit IRC | 09:08 | |
| openstackgerrit | Gorka Eguileor proposed openstack/cinderlib master: RBD: Fix containerized detection https://review.opendev.org/738230 | 09:19 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinderlib master: RBD: Fix missing root_helper https://review.opendev.org/738213 | 09:21 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinderlib master: RBD: Ensure rbd_keyring_conf is available https://review.opendev.org/738472 | 09:29 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinderlib master: Improve cinder supported drivers output https://review.opendev.org/738473 | 09:29 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinderlib master: Support references in driver configuration https://review.opendev.org/738866 | 09:29 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinderlib master: Prevent duplicated backend names https://review.opendev.org/739190 | 09:29 |
| *** raghavendrat has joined #openstack-cinder | 09:37 | |
| raghavendrat | hi e0ne: are you online ? | 09:38 |
| e0ne | raghavendrat: hi, yes | 09:39 |
| raghavendrat | this is regarding https://review.opendev.org/#/c/739033/ | 09:39 |
| raghavendrat | Zuul and CI have passed. | 09:40 |
| raghavendrat | whenever you get time, it would be great if you can have a look. Thanks | 09:40 |
| *** frickler is now known as frickler_pto | 09:44 | |
| *** frickler_pto is now known as frickler | 09:47 | |
| *** whoami-rajat has joined #openstack-cinder | 09:49 | |
| *** devfaz has quit IRC | 09:51 | |
| *** devfaz has joined #openstack-cinder | 09:52 | |
| openstackgerrit | wanwencong proposed openstack/cinder master: Avoid rbd import operation to reduce encryption volume creation time https://review.opendev.org/740931 | 10:08 |
| *** tkajinam has quit IRC | 10:12 | |
| *** gouthamr has quit IRC | 10:22 | |
| *** gouthamr has joined #openstack-cinder | 10:23 | |
| *** martinkennelly has quit IRC | 10:53 | |
| *** raghavendrat has quit IRC | 11:02 | |
| *** rcernin has joined #openstack-cinder | 11:13 | |
| *** m75abrams has quit IRC | 11:23 | |
| openstackgerrit | Merged openstack/cinder stable/stein: 3PAR: Fix live migration https://review.opendev.org/739468 | 11:24 |
| *** m75abrams has joined #openstack-cinder | 11:24 | |
| *** Lucas_Gray has quit IRC | 11:28 | |
| *** Lucas_Gray has joined #openstack-cinder | 11:33 | |
| *** sapd__x has quit IRC | 11:50 | |
| openstackgerrit | renminmin proposed openstack/cinder master: Correct new_type type in VolumeManager retype method https://review.opendev.org/657985 | 11:57 |
| *** spatel has joined #openstack-cinder | 11:58 | |
| *** spatel has quit IRC | 12:03 | |
| *** udesale_ has joined #openstack-cinder | 12:22 | |
| *** udesale has quit IRC | 12:25 | |
| *** vishakha has joined #openstack-cinder | 12:29 | |
| *** rcernin has quit IRC | 12:48 | |
| *** baojg has joined #openstack-cinder | 12:54 | |
| *** Luzi has joined #openstack-cinder | 12:55 | |
| *** spatel has joined #openstack-cinder | 12:58 | |
| whoami-rajat | geguileo, hey, i've a doubt regarding your patch https://review.opendev.org/#/c/739033/ | 13:06 |
| whoami-rajat | geguileo, if we have 2 backends, hpe3par and kaminario and both have this option set, it will work fine in that case right? | 13:07 |
| geguileo | whoami-rajat: that's the idea | 13:09 |
| geguileo | whoami-rajat: instead of going directly to get it from the backends default section we now go to the self.configuration | 13:10 |
| geguileo | which means it will use the one defined in the driver section, and if it's not defined it will use the onde from the backends default | 13:10 |
| *** eharney has joined #openstack-cinder | 13:11 | |
| whoami-rajat | geguileo, yep, i thought so but i didn't have much idea regarding how self.configuration works | 13:12 |
| *** baojg has quit IRC | 13:15 | |
| *** baojg has joined #openstack-cinder | 13:16 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder master: Add ceph iscsi volume driver https://review.opendev.org/662829 | 13:17 |
| geguileo | whoami-rajat: you can have a look at cinder/volume/configuration.py to find out more about self.config | 13:18 |
| *** enriquetaso has joined #openstack-cinder | 13:22 | |
| whoami-rajat | geguileo, yep, thanks | 13:24 |
| *** Luzi has quit IRC | 13:29 | |
| *** pcaruana has quit IRC | 13:31 | |
| *** benj_ has quit IRC | 13:39 | |
| *** benj_ has joined #openstack-cinder | 13:41 | |
| *** pcaruana has joined #openstack-cinder | 13:43 | |
| *** psachin has quit IRC | 13:44 | |
| *** Luzi has joined #openstack-cinder | 13:45 | |
| *** frickler is now known as frickler_pto | 13:50 | |
| *** sapd__x has joined #openstack-cinder | 14:00 | |
| *** dave-mccowan has joined #openstack-cinder | 14:01 | |
| *** raghavendrat has joined #openstack-cinder | 14:05 | |
| *** Luzi has quit IRC | 14:18 | |
| *** knikolla has joined #openstack-cinder | 14:21 | |
| *** abdysn has quit IRC | 14:29 | |
| *** dave-mccowan has quit IRC | 14:33 | |
| *** dave-mccowan has joined #openstack-cinder | 14:38 | |
| *** raghavendrat has quit IRC | 14:50 | |
| *** hamalq has joined #openstack-cinder | 15:23 | |
| *** hamalq has quit IRC | 15:29 | |
| openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: WIP: default type overrides https://review.opendev.org/737707 | 15:30 |
| whoami-rajat | geguileo, ^^ I've added the keystone multitenancy authorization logic and it works as i think it should, would be great if you could take a look | 15:31 |
| geguileo | whoami-rajat: but the spec hasn't been aproved yet, right? | 15:32 |
| whoami-rajat | geguileo, yeah right | 15:32 |
| whoami-rajat | but i saw no conflicts on this part | 15:33 |
| *** hamalq has joined #openstack-cinder | 15:35 | |
| *** udesale_ has quit IRC | 15:35 | |
| *** baojg has quit IRC | 15:37 | |
| *** baojg has joined #openstack-cinder | 15:38 | |
| openstackgerrit | Eric Harney proposed openstack/cinder master: Add mypy tox env https://review.opendev.org/733620 | 15:45 |
| openstackgerrit | Eric Harney proposed openstack/cinder master: mypy: annotate volume manager https://review.opendev.org/733621 | 15:45 |
| openstackgerrit | Eric Harney proposed openstack/cinder master: mypy: annotate api.py https://review.opendev.org/733622 | 15:45 |
| *** spatel has quit IRC | 15:54 | |
| *** m75abrams has quit IRC | 16:00 | |
| *** whoami-rajat has quit IRC | 16:01 | |
| *** Lucas_Gray has quit IRC | 16:01 | |
| *** whoami-rajat has joined #openstack-cinder | 16:02 | |
| openstackgerrit | Rajini Karthik proposed openstack/cinder master: Rebranding of VxFlex OS driver to PowerFlex https://review.opendev.org/740522 | 16:15 |
| openstackgerrit | Merged openstack/cinderlib master: Fix rbd attach on python3 https://review.opendev.org/720553 | 16:17 |
| openstackgerrit | Merged openstack/cinderlib master: RBD: Fix containerized detection https://review.opendev.org/738230 | 16:17 |
| openstackgerrit | Merged openstack/cinderlib master: RBD: Ensure rbd_keyring_conf is available https://review.opendev.org/738472 | 16:17 |
| openstackgerrit | Merged openstack/cinderlib master: Improve cinder supported drivers output https://review.opendev.org/738473 | 16:17 |
| openstackgerrit | Merged openstack/cinderlib master: RBD: Fix missing root_helper https://review.opendev.org/738213 | 16:17 |
| openstackgerrit | Merged openstack/cinderlib master: Support references in driver configuration https://review.opendev.org/738866 | 16:17 |
| openstackgerrit | Merged openstack/cinderlib master: Prevent duplicated backend names https://review.opendev.org/739190 | 16:17 |
| *** whoami-rajat has quit IRC | 16:19 | |
| openstackgerrit | Merged openstack/cinder stable/train: Default volume_type set too early https://review.opendev.org/740598 | 16:29 |
| *** knomura has joined #openstack-cinder | 16:38 | |
| *** e0ne has quit IRC | 16:38 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder master: PowerMax Driver - Volume Migrate Exception Handling https://review.opendev.org/731479 | 16:41 |
| *** Reepicheep has joined #openstack-cinder | 16:44 | |
| *** whoami-rajat has joined #openstack-cinder | 16:48 | |
| *** whoami-rajat has quit IRC | 16:51 | |
| *** Reepicheep has quit IRC | 16:51 | |
| *** Reepicheep has joined #openstack-cinder | 16:55 | |
| *** ociuhandu_ has joined #openstack-cinder | 16:58 | |
| *** knomura has quit IRC | 16:59 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder master: Add ceph iscsi volume driver https://review.opendev.org/662829 | 17:00 |
| *** ociuhandu has quit IRC | 17:01 | |
| hemna | is there a quick way to build the docs for only the changes that you've made to the tree? | 17:01 |
| hemna | instead of building the docs for the entire tree? | 17:01 |
| hemna | tox -edocs takes a while | 17:01 |
| *** ociuhandu_ has quit IRC | 17:02 | |
| *** whoami-rajat has joined #openstack-cinder | 17:27 | |
| *** whoami-rajat has quit IRC | 17:33 | |
| smcginnis | hemna: You can remove the "rm -fr" lines from the docs commands. | 17:40 |
| smcginnis | Or activate the docs venv and run "sphinx-build -W -b html -d doc/build/doctrees doc/source doc/build/html" manually. | 17:40 |
| hemna | ok I'll try removing the rm -rf line | 17:41 |
| hemna | I'm working on the docs for the ceph-iscsi driver | 17:41 |
| rosmaita | \o/ | 17:43 |
| smcginnis | Should speed things up quite a bit. | 17:44 |
| *** whoami-rajat has joined #openstack-cinder | 18:05 | |
| *** spatel has joined #openstack-cinder | 18:14 | |
| *** sapd__x has quit IRC | 18:18 | |
| *** whoami-rajat has quit IRC | 18:19 | |
| *** whoami-rajat has joined #openstack-cinder | 18:28 | |
| *** rmcall has joined #openstack-cinder | 18:30 | |
| *** whoami-rajat has quit IRC | 18:37 | |
| *** whoami-rajat has joined #openstack-cinder | 18:37 | |
| openstackgerrit | Sean McGinnis proposed openstack/cinder master: Make docs build parallel https://review.opendev.org/741027 | 18:44 |
| hemna | ah cool, I was just hacking around with -N | 18:45 |
| hemna | err -j | 18:45 |
| smcginnis | You reminded me that I had started that effort months ago. I was waiting for a few of the sphinx extensions we use to get updated. Looks like we're down to just sphinx-feature-classification-matrix. | 18:45 |
| smcginnis | Once that gets updated, we should be able to speed things up a bit. | 18:46 |
| smcginnis | Probably not a lot in the gate with constrained test nodes, but at least on my 16-core workstation it's definitely faster. ;) | 18:46 |
| hemna | I'll give that a shot | 18:47 |
| hemna | it still takes quite a while to edit/test/build cycle | 18:47 |
| *** enriquetaso has quit IRC | 18:55 | |
| openstackgerrit | Rajini Karthik proposed openstack/cinder master: Rebranding of VxFlex OS driver to PowerFlex https://review.opendev.org/740522 | 18:58 |
| *** knomura has joined #openstack-cinder | 19:11 | |
| *** ociuhandu has joined #openstack-cinder | 19:14 | |
| *** knomura has quit IRC | 19:15 | |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder master: Add ceph iscsi volume driver https://review.opendev.org/662829 | 19:19 |
| openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/cinder master: Add ceph iscsi volume driver https://review.opendev.org/662829 | 19:20 |
| *** ociuhandu has quit IRC | 19:23 | |
| openstackgerrit | Eric Harney proposed openstack/cinder-tempest-plugin master: WIP: Test workaround for lio-barbican failures https://review.opendev.org/741042 | 20:06 |
| openstackgerrit | Eric Harney proposed openstack/cinder master: DNM: lio-barbican test run https://review.opendev.org/741044 | 20:08 |
| *** vishakha has quit IRC | 20:09 | |
| *** whoami-rajat has quit IRC | 20:15 | |
| openstackgerrit | Eric Harney proposed openstack/cinderlib master: Tests: Fix format arg mismatch https://review.opendev.org/741046 | 20:28 |
| smcginnis | eharney: Isn't that the same? Just with the string moved on to one line? | 20:29 |
| eharney | smcginnis: nah, it had 4 %s before :) | 20:30 |
| smcginnis | Ah, now I see. Going blind. | 20:31 |
| eharney | but it's tricky enough that you really had me staring at it for a second... | 20:31 |
| smcginnis | It definitely not obvious. | 20:31 |
| *** e0ne has joined #openstack-cinder | 20:57 | |
| *** enriquetaso has joined #openstack-cinder | 21:05 | |
| openstackgerrit | Eric Harney proposed openstack/cinder master: Bump hacking version to 3.1.0 https://review.opendev.org/741052 | 21:06 |
| *** whoami-rajat has joined #openstack-cinder | 21:11 | |
| openstackgerrit | Rajini Karthik proposed openstack/cinder master: Rebranding of VxFlex OS driver to PowerFlex https://review.opendev.org/740522 | 21:17 |
| *** markvoelker has joined #openstack-cinder | 21:23 | |
| *** markvoelker has quit IRC | 21:27 | |
| *** e0ne has quit IRC | 21:37 | |
| *** e0ne has joined #openstack-cinder | 21:38 | |
| eharney | hmm, cinderlib functional tests failed on cinder-tempest-plugin-lvm-lio-barbican for https://review.opendev.org/#/c/741042/ due not having ddt installed | 21:39 |
| eharney | not sure where exactly the missing link is that causes that, since ddt is in cinderlib's test-requirements | 21:39 |
| smcginnis | Is that job just doing a local install of the package, not a pip install like we define in the tox environments? | 21:42 |
| smcginnis | A normal pip install ./ won't pick up test-requirements.txt | 21:42 |
| rosmaita | i'm not sure what's going on, it only happens sometimes | 21:43 |
| *** spatel has quit IRC | 21:44 | |
| tosky | uhm, the cinderlib functional tests are executed in the lvm-lio-barbican job in their own venv and ddt is installed when that venv is created | 21:44 |
| *** spatel has joined #openstack-cinder | 21:45 | |
| eharney | https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_be1/741042/1/check/cinder-tempest-plugin-lvm-lio-barbican/be11fe5/job-output.txt is the actual log since it hasn't posted yet | 21:45 |
| smcginnis | Hmm... | 21:45 |
| smcginnis | Successfully installed coverage-5.2 ddt-1.4.1 ... | 21:45 |
| smcginnis | eharney: Something is wrong with how that test is defined. | 21:47 |
| smcginnis | It installs ddt and other requirements under .tox/functional. | 21:47 |
| smcginnis | But then that backtrace shows it isn't using a virtual environment. | 21:47 |
| smcginnis | File "/usr/lib/python3.6/unittest/loader.py" | 21:47 |
| smcginnis | It's loading from default python path. | 21:47 |
| eharney | i'm thinking it's something to do with bash manipulating the environment for the call from tox out to run stestr | 21:47 |
| tosky | something in that review specifically? Otherwise it would fail in the other jobs | 21:48 |
| rosmaita | it's failing a lot: https://zuul.opendev.org/t/openstack/builds?job_name=cinder-tempest-plugin-lvm-lio-barbican# | 21:48 |
| rosmaita | but not all the failures are the ddt missing thing | 21:48 |
| tosky | no, that's the first time I see the ddt issue | 21:49 |
| tosky | most of the other failures are 2 or 3 tests | 21:49 |
| tosky | it started failing this afternoon | 21:49 |
| tosky | what did it change in cinderlib? | 21:50 |
| tosky | started failing due to the missing ddt, I mean | 21:51 |
| smcginnis | Looks like several merge commits from today. | 21:51 |
| tosky | https://review.opendev.org/#/c/738473/4/cinderlib/tests/functional/test_basic.py - but ddt was already there | 21:53 |
| smcginnis | Yeah, I'm not seeing anything recent in cinderlib. | 21:57 |
| smcginnis | * anything recent that looks like it would have an effect on that. | 21:57 |
| smcginnis | Maybe worth checking with opendev or zuul team to see if anything changed with jobs that could have changed that behavior. | 21:58 |
| clarkb | looking at it it looks like your stestr may be running outside of the venv | 21:59 |
| clarkb | I don't think we've changed anything on our side that would affect that | 21:59 |
| smcginnis | Thanks clarkb | 21:59 |
| clarkb | (I'm inferring that through the unittests path being in /usr/lib and not /someting/.tox/functional/lib | 21:59 |
| smcginnis | That was my take. | 22:00 |
| smcginnis | It sets up the venv, but then it looks like it runs from the default path. | 22:00 |
| tosky | so maybe it was a latent issue which was exposed by https://review.opendev.org/#/c/738473/ ? | 22:00 |
| smcginnis | Yeah, I'm not seeing any other changes that would have changed that behavior. | 22:01 |
| smcginnis | Should be able to look at logs from past test runs and see if we can tell where the jobs are actually running from. | 22:01 |
| clarkb | looks like the change tosky links didn't run the failing job | 22:01 |
| clarkb | so ya I'm guessing that may be the case, basically land code thatworks in job foo but is broken in bar but isnce bar didn't run it fails later | 22:02 |
| clarkb | if you ensured your python is run out of the venv there it should work | 22:02 |
| tosky | clarkb: yes, I know, my fault: I said a few weeks ago I should have added the lvm-lio-barbican job to cinderlib gates | 22:02 |
| tosky | and then I forgot | 22:02 |
| tosky | and guess what obviously happened -_-' | 22:02 |
| *** spatel has quit IRC | 22:04 | |
| clarkb | I think the bash -i -c may be te problem? | 22:04 |
| clarkb | you're setting the PATH on the stestr command which will set it for stestr but not necessarily for the bash that starts stestr | 22:04 |
| clarkb | this means that the bash started there could be using a different path depending on how stuff is exported then it finds stestr in the dfeault path which doens't include the vnev | 22:05 |
| clarkb | (thats a hunch based on reading the logs) | 22:05 |
| openstackgerrit | Luigi Toscano proposed openstack/cinderlib master: zuul: add cinder-tempest-plugin-lvm-lio-barbican https://review.opendev.org/741060 | 22:07 |
| tosky | there is a comment in the code which explains that bash -i -c is used to workaround a tox bug which ignores PATH set in setenv | 22:09 |
| tosky | here: https://opendev.org/openstack/cinderlib/src/branch/master/tox.ini#L51 | 22:09 |
| tosky | maybe an old issue now solved? | 22:10 |
| clarkb | or you need to do bash -i -c 'export PATH=something ; stestr ...' | 22:11 |
| clarkb | that way when stestr runs bash is using the new path | 22:11 |
| smcginnis | I had never seen that issue before. Maybe worth trying a patch that just drops that? | 22:11 |
| *** knomura has joined #openstack-cinder | 22:11 | |
| clarkb | the way the bas hcommand is written now stestr is found in whatever path bash starts with | 22:12 |
| clarkb | which may not include the venv path | 22:12 |
| smcginnis | According to https://tox.readthedocs.io/en/latest/example/basic.html#passing-down-environment-variables PATH should be passed along. So maybe that bash -i -c workaround isn't needed. | 22:14 |
| smcginnis | Would have been good to include a link in that comment to the issue it was addressing. | 22:15 |
| *** knomura has quit IRC | 22:16 | |
| tosky | let's see | 22:16 |
| openstackgerrit | Luigi Toscano proposed openstack/cinderlib master: functional tests: directly set PATH https://review.opendev.org/741061 | 22:17 |
| tosky | if it works, let's swap the two jobs | 22:17 |
| tosky | s/jobs/reviews/ | 22:17 |
| smcginnis | geguileo added that in https://review.opendev.org/#/c/638442/28/tox.ini | 22:17 |
| smcginnis | Maybe tomorrow he will remember some more context about it. | 22:18 |
| tosky | there is no much in that commit, a lot of restructuring | 22:18 |
| tosky | I will ping him tomorrow (well, in a few hours :) | 22:18 |
| smcginnis | :) | 22:18 |
| rosmaita | tosky: thanks | 22:18 |
| * smcginnis goes to check on supper preparations | 22:19 | |
| *** e0ne has quit IRC | 22:21 | |
| *** spatel has joined #openstack-cinder | 22:23 | |
| *** spatel has quit IRC | 22:23 | |
| *** vishalmanchanda has quit IRC | 22:39 | |
| *** rcernin has joined #openstack-cinder | 22:44 | |
| *** tosky has quit IRC | 22:50 | |
| *** rcernin has quit IRC | 22:51 | |
| *** rcernin has joined #openstack-cinder | 22:51 | |
| *** tkajinam has joined #openstack-cinder | 22:58 | |
| *** hamalq has quit IRC | 22:58 | |
| *** e0ne has joined #openstack-cinder | 23:11 | |
| *** e0ne has quit IRC | 23:13 | |
| openstackgerrit | Merged openstack/cinderlib master: Tests: Fix format arg mismatch https://review.opendev.org/741046 | 23:20 |
| openstackgerrit | Kazufumi Noto proposed openstack/cinder master: Support modern compression algorithms in cinder backup https://review.opendev.org/726765 | 23:20 |
| openstackgerrit | Merged openstack/os-brick stable/train: rbd: Correct local_attach disconnect test and showmapped arguments https://review.opendev.org/734091 | 23:23 |
| *** enriquetaso has quit IRC | 23:51 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!