| *** tosky has quit IRC | 00:00 | |
| *** tkajinam has quit IRC | 00:16 | |
| *** tkajinam has joined #openstack-cinder | 00:16 | |
| *** Reepicheep has quit IRC | 00:52 | |
| *** Reepicheep has joined #openstack-cinder | 00:53 | |
| *** benj_ has quit IRC | 00:54 | |
| *** zigo has quit IRC | 00:54 | |
| *** benj_ has joined #openstack-cinder | 00:54 | |
| -openstackstatus- NOTICE: The Gerrit service on review.opendev.org is being restarted quickly to make heap memory and jgit config adjustments, downtime should be less than 5 minutes | 01:08 | |
| *** user_19173783170 has joined #openstack-cinder | 01:40 | |
| user_19173783170 | I'm have built my third party ci system to test. Should the third party ci system must get voting right? | 01:43 |
|---|---|---|
| *** zzzeek has quit IRC | 01:52 | |
| *** zzzeek has joined #openstack-cinder | 01:53 | |
| *** amotoki has quit IRC | 02:01 | |
| *** amotoki has joined #openstack-cinder | 02:02 | |
| *** zzzeek has quit IRC | 02:05 | |
| *** zzzeek has joined #openstack-cinder | 02:06 | |
| *** hamalq has quit IRC | 02:12 | |
| *** lifeless has quit IRC | 02:25 | |
| *** lifeless has joined #openstack-cinder | 02:27 | |
| *** amar7ibm has joined #openstack-cinder | 02:29 | |
| *** psachin has joined #openstack-cinder | 03:20 | |
| *** user_19173783170 has quit IRC | 04:00 | |
| *** gksk has joined #openstack-cinder | 04:14 | |
| gksk | To the Core reviewers please review the below feature related to revert to snapshot | 04:14 |
| gksk | https://review.opendev.org/c/openstack/cinder/+/751837 | 04:14 |
| *** GirishChilukuri has joined #openstack-cinder | 04:16 | |
| *** zzzeek has quit IRC | 04:19 | |
| *** zzzeek has joined #openstack-cinder | 04:21 | |
| *** zzzeek has quit IRC | 04:26 | |
| *** zzzeek has joined #openstack-cinder | 04:27 | |
| *** sharathkacham has joined #openstack-cinder | 04:32 | |
| openstackgerrit | Brian Rosmaita proposed openstack/cinder master: Add cinder permissions matrix https://review.opendev.org/c/openstack/cinder/+/763306 | 04:40 |
| *** venkatakrishnath has joined #openstack-cinder | 04:43 | |
| venkatakrishnath | Hi Rajat, In your free time, can you please review https://review.opendev.org/c/openstack/cinder/+/757082 which is one step way from merge. I am posting in community regarding this patch since last 15 days but getting no response. | 04:47 |
| *** vishalmanchanda has joined #openstack-cinder | 04:55 | |
| openstackgerrit | Merged openstack/cinder master: Update requirements and lower-constraints https://review.opendev.org/c/openstack/cinder/+/766085 | 04:58 |
| *** m75abrams has joined #openstack-cinder | 05:03 | |
| *** GirishChilukuri has quit IRC | 05:06 | |
| *** gksk has quit IRC | 05:08 | |
| *** GirishChilukuri has joined #openstack-cinder | 05:12 | |
| *** zzzeek has quit IRC | 05:26 | |
| *** jopdorp has quit IRC | 05:27 | |
| *** arne_wiebalck has quit IRC | 05:27 | |
| *** simondodsley has quit IRC | 05:27 | |
| *** jopdorp has joined #openstack-cinder | 05:28 | |
| *** simondodsley has joined #openstack-cinder | 05:29 | |
| *** arne_wiebalck has joined #openstack-cinder | 05:29 | |
| *** zzzeek has joined #openstack-cinder | 05:29 | |
| GirishChilukuri | hi all, | 05:30 |
| GirishChilukuri | can you please review the code changes https://review.opendev.org/c/openstack/cinder/+/765060, https://review.opendev.org/c/openstack/cinder/+/744664 | 05:31 |
| openstackgerrit | Amar proposed openstack/cinder-specs master: Migration support for a volume with replication status enabled https://review.opendev.org/c/openstack/cinder-specs/+/766130 | 05:33 |
| *** udesale has joined #openstack-cinder | 05:33 | |
| openstackgerrit | Suman proposed openstack/os-brick master: Failed to discover the volumes on ppc64le https://review.opendev.org/c/openstack/os-brick/+/737446 | 05:53 |
| openstackgerrit | Suman proposed openstack/os-brick master: Failed to discover the volumes on ppc64le https://review.opendev.org/c/openstack/os-brick/+/737446 | 05:56 |
| *** GirishChilukuri has quit IRC | 05:57 | |
| *** manoj_kumar_kata has quit IRC | 05:59 | |
| *** zenkuro has joined #openstack-cinder | 06:08 | |
| *** zzzeek has quit IRC | 06:15 | |
| *** zzzeek has joined #openstack-cinder | 06:17 | |
| *** user_19173783170 has joined #openstack-cinder | 06:40 | |
| *** user_19173783170 has quit IRC | 06:46 | |
| *** zzzeek has quit IRC | 06:49 | |
| *** zzzeek has joined #openstack-cinder | 06:51 | |
| *** user_19173783170 has joined #openstack-cinder | 06:55 | |
| *** lpetrut has joined #openstack-cinder | 07:12 | |
| *** GirishChilukuri has joined #openstack-cinder | 07:16 | |
| *** psachin has quit IRC | 07:17 | |
| *** zzzeek has quit IRC | 07:21 | |
| *** zzzeek has joined #openstack-cinder | 07:23 | |
| *** venkatakrishnath has quit IRC | 07:34 | |
| *** lifeless has quit IRC | 07:54 | |
| *** lifeless has joined #openstack-cinder | 07:56 | |
| *** tosky has joined #openstack-cinder | 08:02 | |
| *** elod_pto is now known as elod | 08:05 | |
| *** rpittau|afk is now known as rpittau | 08:14 | |
| *** zenkuro has quit IRC | 08:28 | |
| *** ociuhandu has joined #openstack-cinder | 08:42 | |
| *** GirishChilukuri has quit IRC | 08:46 | |
| *** udesale has quit IRC | 08:48 | |
| *** zzzeek has quit IRC | 08:50 | |
| *** udesale has joined #openstack-cinder | 08:50 | |
| *** zzzeek has joined #openstack-cinder | 08:50 | |
| *** geguileo has joined #openstack-cinder | 08:51 | |
| *** ociuhandu has quit IRC | 08:52 | |
| *** rcernin has quit IRC | 08:56 | |
| *** rcernin has joined #openstack-cinder | 08:56 | |
| *** ociuhandu has joined #openstack-cinder | 08:59 | |
| *** CeeMac has quit IRC | 09:07 | |
| *** zzzeek has quit IRC | 09:16 | |
| *** zzzeek has joined #openstack-cinder | 09:17 | |
| *** rcernin has quit IRC | 09:23 | |
| *** martinkennelly has joined #openstack-cinder | 09:25 | |
| *** rcernin has joined #openstack-cinder | 09:32 | |
| *** zzzeek has quit IRC | 09:40 | |
| *** zzzeek has joined #openstack-cinder | 09:41 | |
| openstackgerrit | Suman proposed openstack/os-brick master: Failed to discover the volumes on ppc64le https://review.opendev.org/c/openstack/os-brick/+/737446 | 09:42 |
| *** zzzeek has quit IRC | 09:46 | |
| *** rcernin has quit IRC | 09:48 | |
| *** zzzeek has joined #openstack-cinder | 09:49 | |
| *** rcernin has joined #openstack-cinder | 09:49 | |
| openstackgerrit | Amar proposed openstack/cinder-specs master: Migration support for a volume with replication status enabled https://review.opendev.org/c/openstack/cinder-specs/+/766130 | 09:52 |
| *** zzzeek has quit IRC | 10:01 | |
| *** user_19173783170 has quit IRC | 10:02 | |
| *** zzzeek has joined #openstack-cinder | 10:03 | |
| *** udesale has quit IRC | 10:06 | |
| *** rcernin has quit IRC | 10:31 | |
| *** brinzhang_ has quit IRC | 10:34 | |
| *** brinzhang has joined #openstack-cinder | 10:42 | |
| *** ociuhandu has quit IRC | 10:47 | |
| *** ociuhandu has joined #openstack-cinder | 10:51 | |
| *** rcernin has joined #openstack-cinder | 10:53 | |
| *** zzzeek has quit IRC | 11:17 | |
| *** zzzeek has joined #openstack-cinder | 11:18 | |
| *** ociuhandu has quit IRC | 11:35 | |
| *** e0ne has joined #openstack-cinder | 11:37 | |
| *** ociuhandu has joined #openstack-cinder | 11:49 | |
| *** ociuhandu_ has joined #openstack-cinder | 11:58 | |
| *** ociuhandu has quit IRC | 12:02 | |
| *** rcernin has quit IRC | 12:04 | |
| *** zenkuro has joined #openstack-cinder | 12:08 | |
| *** udesale has joined #openstack-cinder | 12:49 | |
| *** ociuhandu_ has quit IRC | 12:51 | |
| *** ociuhandu has joined #openstack-cinder | 12:51 | |
| *** ociuhandu has quit IRC | 13:06 | |
| *** ociuhandu has joined #openstack-cinder | 13:08 | |
| *** ociuhandu has quit IRC | 13:16 | |
| openstackgerrit | Corey Bryant proposed openstack/cinder master: RBD: Retry delete if VolumeIsBusy in _copy_image_to_volume https://review.opendev.org/c/openstack/cinder/+/759315 | 13:20 |
| *** martinkennelly has quit IRC | 13:22 | |
| *** ociuhandu has joined #openstack-cinder | 13:24 | |
| *** ociuhandu has quit IRC | 13:24 | |
| *** martinkennelly has joined #openstack-cinder | 13:24 | |
| *** martinkennelly has quit IRC | 13:27 | |
| *** martinkennelly has joined #openstack-cinder | 13:28 | |
| *** amar7ibm_ has joined #openstack-cinder | 13:39 | |
| *** martinkennelly has quit IRC | 13:42 | |
| *** m75abrams has quit IRC | 13:46 | |
| rosmaita | Reminder: today's cinder meeting is actually the midcycle | 13:55 |
| rosmaita | connection info: https://bluejeans.com/3228528973 | 13:55 |
| rosmaita | etherpad: https://etherpad.opendev.org/p/cinder-wallaby-mid-cycles | 13:55 |
| rosmaita | jungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard lseki sfernand rajinir enriquetaso hemna michael-mcaleer ^^ | 13:55 |
| *** enriquetaso has joined #openstack-cinder | 13:56 | |
| jungleboyj | Thanks. I will join in 30 minutes. | 13:56 |
| rosmaita | ack | 13:56 |
| *** ociuhandu has joined #openstack-cinder | 14:00 | |
| *** zenkuro has quit IRC | 14:05 | |
| *** ociuhandu has quit IRC | 14:07 | |
| lbragstad | rosmaita i can join during the secure rbac portion if you'd like | 14:09 |
| *** rosmaita has quit IRC | 14:09 | |
| lbragstad | i'm not sure what time you expect to hit that topic though | 14:09 |
| *** ociuhandu has joined #openstack-cinder | 14:11 | |
| *** rosmaita has joined #openstack-cinder | 14:12 | |
| *** m75abrams has joined #openstack-cinder | 14:23 | |
| *** johanssone has quit IRC | 14:23 | |
| *** zoharm has joined #openstack-cinder | 14:24 | |
| *** johanssone has joined #openstack-cinder | 14:26 | |
| *** jv has quit IRC | 14:26 | |
| zoharm | Hi all, with the spec freeze date looming, I would like to double check what is the official place specs should be kept and reviewed at? Our blueprints have a reference to specs (on the wiki) - is there any other official spec submission needed? | 14:26 |
| *** jv has joined #openstack-cinder | 14:30 | |
| *** noonedeadpunk has quit IRC | 14:30 | |
| *** noonedeadpunk_ has joined #openstack-cinder | 14:33 | |
| whoami-rajat__ | lbragstad: it's the next topic if you would like to join | 14:33 |
| lbragstad | whoami-rajat__ oh - cool | 14:33 |
| lbragstad | i'm on my way | 14:33 |
| whoami-rajat__ | great | 14:33 |
| geguileo | zoharm: we are in the mid-cycle meeting right now: https://bluejeans.com/3228528973 | 14:34 |
| geguileo | zoharm: https://etherpad.opendev.org/p/cinder-wallaby-mid-cycles | 14:34 |
| geguileo | that's why nobody's around to answer right now | 14:34 |
| *** amar7ibm has quit IRC | 14:35 | |
| *** amar7ibm_ is now known as amar7ibm | 14:35 | |
| *** ociuhandu has quit IRC | 14:36 | |
| *** rajeev has joined #openstack-cinder | 14:41 | |
| *** ociuhandu has joined #openstack-cinder | 14:43 | |
| *** TusharTgite has joined #openstack-cinder | 14:54 | |
| zoharm | thank you geguileo, once you or anyone has a chance, please point me to the proper process to submit spec to review? do i simply make a pull request to https://github.com/openstack/cinder-specs/tree/master/specs/wallaby ? | 14:54 |
| jungleboyj | zoharm: We don't use pull requests. | 14:54 |
| jungleboyj | We have documentation that explains how to submit something for review. Let me find that. | 14:55 |
| jungleboyj | But to propose a new design, yes you would put it there in the specs repo. | 14:55 |
| zoharm | jungleboyj, thank you! got it, so without pull request, what is the process to put it into the specs repo? | 14:56 |
| zoharm | i could not find documentation with actual details, just a reference to that cinder-spec repo | 14:56 |
| jungleboyj | zoharm: Here is how you push a change to gerrit: https://docs.openstack.org/contributors/code-and-documentation/using-gerrit.html | 14:57 |
| jungleboyj | That is the review tool we use. | 14:57 |
| zoharm | oh ok, so same git review process but for the cinder-spec repo, i think i got it. thank you! | 14:58 |
| jungleboyj | If you don't have gerrit set up you can get info on that here: https://docs.openstack.org/contributors/common/setup-gerrit.html | 14:58 |
| jungleboyj | zoharm: Ahhhh, yes! It is just the same git review process. | 14:58 |
| TusharTgite | jungleboyj:hi | 15:00 |
| jungleboyj | zoharm: The one additional step is to make sure there is a blueprint also submitted to associate the spec with: https://blueprints.launchpad.net/cinder | 15:00 |
| jungleboyj | TusharTgite: Hi. | 15:00 |
| *** rosmaita has quit IRC | 15:01 | |
| TusharTgite | jungleboyj, what about if someone already push a spec and i want to re submit it like this one https://review.opendev.org/c/openstack/cinder-specs/+/682456/2 | 15:01 |
| TusharTgite | i'm thinking about push this one and have a discussion on my own patch. | 15:02 |
| jungleboyj | TusharTgite: Good question. Since it didn't make it to Victoria you will want to move it to the wallaby directory and include your updates to the spec. | 15:03 |
| TusharTgite | jungleboyj, yes | 15:03 |
| *** ociuhandu has quit IRC | 15:11 | |
| whoami-rajat__ | lbragstad: hey, i had this question regarding RBAC in tempest, did the base framework merge or are there still few patches remaining ? | 15:11 |
| lbragstad | i can check | 15:12 |
| lbragstad | whoami-rajat__ it looks like some of the tempest plumbing is still in flight | 15:13 |
| lbragstad | https://review.opendev.org/c/openstack/tempest/+/686306/ | 15:13 |
| *** sapd1 has joined #openstack-cinder | 15:13 | |
| whoami-rajat__ | lbragstad: oh, last comment was on 17th Nov :/ | 15:14 |
| *** hoonetorg has quit IRC | 15:14 | |
| *** ociuhandu has joined #openstack-cinder | 15:15 | |
| whoami-rajat__ | lbragstad: is any PS update required or just need to ping gmann to review again? | 15:15 |
| lbragstad | gmann might know more about where that work is at | 15:15 |
| whoami-rajat__ | ok | 15:15 |
| lbragstad | i want to say the patches in the series for 686306 is all that's required | 15:16 |
| *** ociuhandu has quit IRC | 15:20 | |
| *** ociuhandu has joined #openstack-cinder | 15:25 | |
| *** venkatakrishnath has joined #openstack-cinder | 15:28 | |
| *** ociuhandu has quit IRC | 15:30 | |
| openstackgerrit | Lucian Petrut proposed openstack/os-brick master: rbd Windows support https://review.opendev.org/c/openstack/os-brick/+/718403 | 15:32 |
| *** ociuhandu has joined #openstack-cinder | 15:35 | |
| *** lxkong has quit IRC | 15:39 | |
| *** ociuhandu has quit IRC | 15:39 | |
| *** sharathkacham has quit IRC | 15:42 | |
| *** ociuhandu has joined #openstack-cinder | 15:43 | |
| *** ociuhandu has quit IRC | 15:47 | |
| *** dsariel has joined #openstack-cinder | 15:49 | |
| *** m75abrams has quit IRC | 15:54 | |
| *** sapd1 has quit IRC | 15:56 | |
| *** rajeev has quit IRC | 16:00 | |
| *** sapd1 has joined #openstack-cinder | 16:09 | |
| *** rosmaita has joined #openstack-cinder | 16:17 | |
| *** udesale has quit IRC | 16:18 | |
| openstackgerrit | Merged openstack/cinder-specs master: Fix redirects https://review.opendev.org/c/openstack/cinder-specs/+/764116 | 16:20 |
| rosmaita | redirects work! try this out: https://specs.openstack.org/openstack/cinder-specs/specs/victoria/image-encryption.html | 16:22 |
| eharney | nice | 16:24 |
| *** zenkuro has joined #openstack-cinder | 16:25 | |
| openstackgerrit | Rajat Dhasmana proposed openstack/cinder-specs master: Support storing volume format info https://review.opendev.org/c/openstack/cinder-specs/+/760999 | 16:27 |
| *** brinzhang has quit IRC | 16:27 | |
| whoami-rajat__ | rosmaita: eharney ^^ updated the spec with format response in attachement get API | 16:27 |
| rosmaita | thanks | 16:27 |
| venkatakrishnath | @Core reviewers, | 16:28 |
| *** ociuhandu has joined #openstack-cinder | 16:29 | |
| *** abishop_ is now known as abishop | 16:29 | |
| openstackgerrit | Merged openstack/cinder-specs master: Add clarification about re-proposing specs https://review.opendev.org/c/openstack/cinder-specs/+/762032 | 16:40 |
| *** lpetrut has quit IRC | 16:46 | |
| *** zoharm has quit IRC | 16:50 | |
| *** hamalq has joined #openstack-cinder | 16:53 | |
| *** hamalq_ has joined #openstack-cinder | 16:55 | |
| *** hamalq has quit IRC | 16:59 | |
| *** benfelin has joined #openstack-cinder | 17:00 | |
| *** zenkuro has quit IRC | 17:08 | |
| *** rpittau is now known as rpittau|afk | 17:12 | |
| *** e0ne has quit IRC | 17:12 | |
| *** zenkuro has joined #openstack-cinder | 17:14 | |
| *** TusharTgite has quit IRC | 17:21 | |
| geguileo | lseki: do you have a minute to talk about https://bugs.launchpad.net/cinder/+bug/1906291 ? | 17:21 |
| openstack | Launchpad bug 1906291 in Cinder "NetApp ONTAP: QoS policy group is deleted after migration" [Medium,Triaged] | 17:21 |
| *** ociuhandu_ has joined #openstack-cinder | 17:24 | |
| *** ociuhandu has quit IRC | 17:27 | |
| *** ociuhandu_ has quit IRC | 17:28 | |
| *** ociuhandu has joined #openstack-cinder | 17:34 | |
| *** e0ne has joined #openstack-cinder | 17:34 | |
| *** venkatakrishnath has quit IRC | 17:36 | |
| *** ociuhandu has quit IRC | 17:39 | |
| *** hoonetorg has joined #openstack-cinder | 17:41 | |
| lseki | hi geguileo, sure | 17:45 |
| geguileo | lseki: the issue is that when an NFS volume that has QoS is migrated it loses the QoS | 17:46 |
| lseki | that's correct | 17:47 |
| *** GirishChilukuri has joined #openstack-cinder | 17:47 | |
| lseki | I didn't test it with iSCSI | 17:47 |
| geguileo | lseki: I digged into the NetApp driver, and I believe the issue is when the manager calls update_migrated_volume | 17:47 |
| geguileo | lseki: because the NetApp driver doesn't implement it | 17:47 |
| geguileo | lseki: so the one from the NFSDriver is used, which uses os.rename to change the qcow2 name | 17:48 |
| geguileo | lseki: so now the qcow2 name and the qos don't match | 17:48 |
| geguileo | lseki: does that make sense? | 17:48 |
| geguileo | or am I talking nonsense? | 17:49 |
| lseki | I quickly tested implementing update_migrate_volume that just raises NotImplementedError, but it still deletes the qos policy | 17:51 |
| geguileo | lseki: and did you see that method getting called? (adding logs) | 17:52 |
| geguileo | lseki: ooooh, I think I may know what's going on... | 17:53 |
| lseki | geguileo: oh, forgot checking the log, let me try it again | 17:54 |
| geguileo | lseki: FOUND THE SECOND PART OF THE BUG!! XDXD | 18:00 |
| geguileo | looking at unfamiliar code is so hard... | 18:00 |
| *** noonedeadpunk_ is now known as noonedeadpunk | 18:01 | |
| lseki | oh no | 18:02 |
| GirishChilukuri | @core reviewers: please review this code changes https://review.opendev.org/c/openstack/cinder/+/744664, https://review.opendev.org/c/openstack/cinder/+/765060 | 18:03 |
| geguileo | lseki: https://github.com/openstack/cinder/blob/d3ffa90baa959530eaa1cd1d4e3800fbe9148806/cinder/volume/drivers/netapp/utils.py#L269 | 18:07 |
| geguileo | lseki: it's using the id and not the name... | 18:07 |
| geguileo | lseki: I believe changing that line to something like return OPENSTACK_PREFIX + (volume.get('name') or volume['id']) | 18:08 |
| geguileo | should do the trick | 18:08 |
| lseki | hmm makes sense | 18:13 |
| -openstackstatus- NOTICE: The Gerrit service on review.opendev.org is currently responding slowly or timing out due to resource starvation, investigation is underway | 18:15 | |
| *** GirishChilukuri has quit IRC | 18:18 | |
| *** baojg has quit IRC | 18:37 | |
| *** enriquetaso has quit IRC | 18:42 | |
| geguileo | lseki: any chance you could test/confirm? | 18:43 |
| openstackgerrit | Eric Harney proposed openstack/cinder master: mypy: annotate volume manager https://review.opendev.org/c/openstack/cinder/+/733621 | 18:46 |
| lseki | geguileo: just checked the 1st part, it does calls the driver's update_migrated_volume (which just raises a NotImplementedError) | 18:47 |
| lseki | just waiting to confirm that the qos policies are deleted | 18:47 |
| openstackgerrit | Eric Harney proposed openstack/cinder master: mypy: annotate volume_utils / utils / exc https://review.opendev.org/c/openstack/cinder/+/736855 | 18:47 |
| geguileo | lseki: thanks :-) | 18:48 |
| lseki | change in utils.py just waiting for c-vol restart | 18:48 |
| *** enriquetaso has joined #openstack-cinder | 18:49 | |
| lseki | oh thanks, you updated LP | 18:50 |
| *** e0ne has quit IRC | 18:51 | |
| geguileo | lseki: yeah, updating bugs helps me remember things in the future XD | 19:02 |
| lseki | geguileo: it's fixed! 🎉 | 19:08 |
| geguileo | lseki: AWESOME!!! :-) | 19:08 |
| lseki | I'll reply the LP with the logs and outputs | 19:08 |
| lseki | thanks a lot! | 19:08 |
| geguileo | lseki: it will probably get fixed if we remove the raise of the NotImplemented as well | 19:08 |
| geguileo | but I'm not really sure about that XD | 19:09 |
| lseki | yeah I'll try that | 19:09 |
| geguileo | lseki: no problem, thanks for testing this :-) | 19:09 |
| geguileo | lseki: will you take care of the patch and I do the review, or do you want the other way around? | 19:09 |
| lseki | geguileo: I think it would be quicker if you submit the patch | 19:12 |
| geguileo | lseki: ok | 19:12 |
| lseki | because I'm supposed to submit patches upstream only after our 3rd party CI says ok | 19:12 |
| geguileo | lseki: ok :-) | 19:14 |
| *** martinkennelly has joined #openstack-cinder | 19:16 | |
| lseki | thanks! | 19:17 |
| *** martinkennelly has quit IRC | 19:37 | |
| *** lxkong has joined #openstack-cinder | 19:40 | |
| *** rosmaita has quit IRC | 19:45 | |
| lseki | geguileo: yep, the NotImplemented was unnecessary | 19:46 |
| *** rosmaita has joined #openstack-cinder | 19:49 | |
| *** benfelin has quit IRC | 20:03 | |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder master: NetApp ONTAP: Fix QoS lost after moving volume https://review.opendev.org/c/openstack/cinder/+/766296 | 20:05 |
| geguileo | lseki: ^ that's the patch. Should I remove the NotImplemented then? | 20:06 |
| lseki | yes plz | 20:06 |
| geguileo | lseki: I'm a bit on the defense because I know that the NetApp driver doesn't immediately delete the QoS policies | 20:06 |
| geguileo | it does the cleanup at a later time... | 20:07 |
| lseki | yes, here it took 10 min or so | 20:07 |
| geguileo | and it deleted the right one? | 20:07 |
| *** hoonetorg has quit IRC | 20:08 | |
| lseki | yes | 20:08 |
| geguileo | does the backend track the renaming of the files and change the qos policy automatically? | 20:08 |
| geguileo | because first we create a volume with name X.qcow2 and set a qos policy for that file | 20:09 |
| geguileo | then we use os.rename to change it to Y.qcow2 | 20:09 |
| geguileo | as I understand it the policy would have to be automatically changed by the backend when the rename happens | 20:10 |
| geguileo | or we would have to add code to the driver to do it | 20:10 |
| lseki | hmm let me check what happened here | 20:11 |
| lseki | fwiw the commands/outputs are here http://paste.openstack.org/show/800913/ | 20:11 |
| geguileo | lseki: mmmm, is it me or are we leaving the wrong policy? | 20:12 |
| geguileo | lseki: if the os.rename is happening the policy seems to have the wrong name | 20:12 |
| lseki | weird | 20:12 |
| lseki | the original vol was X.qcow2 (59063c5259063c52-... here) | 20:13 |
| geguileo | lseki: if that's the result with raising the exception, then the output makes sense | 20:13 |
| geguileo | lseki: and it's actually correct | 20:13 |
| lseki | then it created Y.qcow2 at the target (cbb1f348-...) | 20:13 |
| geguileo | but if it's for the case where we don't raise the exception, then it's likely incorrect | 20:13 |
| geguileo | oooooh wait | 20:14 |
| geguileo | lseki: are you using the same pool? | 20:14 |
| geguileo | I mean, two backends with the same nfs pool? | 20:14 |
| geguileo | because if you are, then it's behaving like not imlpemented | 20:15 |
| lseki | oh shoot I am | 20:15 |
| geguileo | because os.rename will fail | 20:15 |
| lseki | sorry, I enabled the wrong back end | 20:15 |
| geguileo | if the pools are different then the rename will happen | 20:15 |
| lseki | trying again with proper pools | 20:19 |
| geguileo | lseki: thanks | 20:20 |
| lbragstad | rosmaita ping - i was curious if you had a chance to take a peak at the protection testing question i put in the cinder midcycle etherpad | 20:25 |
| rosmaita | lbragstad: yes, i saw it but am don't have a definite opinion yet | 20:25 |
| * lbragstad nods | 20:25 | |
| rosmaita | i'm aiming to have an answer for you early next week | 20:26 |
| lbragstad | ok - that sounds good | 20:26 |
| rosmaita | thanks | 20:26 |
| *** dave-mccowan has joined #openstack-cinder | 20:29 | |
| *** benfelin has joined #openstack-cinder | 20:31 | |
| *** gksk has joined #openstack-cinder | 20:33 | |
| gksk | To the core reviewers Please review the below feature | 20:34 |
| gksk | https://review.opendev.org/c/openstack/cinder/+/751837 | 20:34 |
| lseki | geguileo: gotta leave for a few hours | 20:37 |
| lseki | I'll let you know the results here if you're online | 20:37 |
| lseki | update the patch and/or the LP otherwise | 20:37 |
| geguileo | lseki: ok, I won't be here in a couple of hours, but the chat will be open ;-) | 20:38 |
| *** ociuhandu has joined #openstack-cinder | 20:42 | |
| *** ociuhandu has quit IRC | 20:46 | |
| *** ociuhandu has joined #openstack-cinder | 20:48 | |
| *** ociuhandu has quit IRC | 20:52 | |
| *** vishalmanchanda has quit IRC | 20:54 | |
| openstackgerrit | Lance Bragstad proposed openstack/cinder master: Introduce basic context objects in policy tests https://review.opendev.org/c/openstack/cinder/+/766302 | 20:57 |
| *** ociuhandu has joined #openstack-cinder | 20:59 | |
| openstackgerrit | Lance Bragstad proposed openstack/cinder master: Introduce basic context objects in policy tests https://review.opendev.org/c/openstack/cinder/+/766302 | 21:00 |
| *** ociuhandu has quit IRC | 21:04 | |
| *** sapd1 has quit IRC | 21:04 | |
| *** ociuhandu has joined #openstack-cinder | 21:10 | |
| *** hack-char has quit IRC | 21:17 | |
| *** hack-char has joined #openstack-cinder | 21:17 | |
| *** zenkuro has quit IRC | 21:37 | |
| *** e0ne has joined #openstack-cinder | 21:38 | |
| *** rcernin has joined #openstack-cinder | 22:02 | |
| *** rcernin has quit IRC | 22:04 | |
| *** rcernin has joined #openstack-cinder | 22:05 | |
| *** ociuhandu has quit IRC | 22:09 | |
| *** e0ne has quit IRC | 22:14 | |
| *** ociuhandu has joined #openstack-cinder | 22:15 | |
| *** ociuhandu has quit IRC | 22:19 | |
| *** ociuhandu has joined #openstack-cinder | 22:20 | |
| *** gksk has quit IRC | 22:28 | |
| *** ociuhandu has quit IRC | 22:34 | |
| *** ociuhandu has joined #openstack-cinder | 22:41 | |
| *** ociuhandu has quit IRC | 22:41 | |
| *** baojg has joined #openstack-cinder | 22:43 | |
| *** dsariel has quit IRC | 22:51 | |
| *** benfelin has quit IRC | 22:53 | |
| *** baojg has quit IRC | 23:09 | |
| *** baojg has joined #openstack-cinder | 23:09 | |
| *** lemko3 has joined #openstack-cinder | 23:28 | |
| *** lemko has quit IRC | 23:31 | |
| *** lemko3 is now known as lemko | 23:31 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!