*** hoonetorg has joined #openstack-cinder | 00:01 | |
*** sfernand has quit IRC | 00:10 | |
*** sapd1 has joined #openstack-cinder | 00:26 | |
*** benfelin has quit IRC | 00:36 | |
*** caiqilong has joined #openstack-cinder | 00:55 | |
*** benfelin has joined #openstack-cinder | 01:02 | |
*** sapd1 has quit IRC | 01:11 | |
*** knomura has joined #openstack-cinder | 01:17 | |
*** knomura has quit IRC | 01:22 | |
*** dave-mccowan has quit IRC | 01:24 | |
caiqilong | rosmaita: Hi, I have added newly patchset fixed the issues smcginnis proposed. If you have time, please review at: "https://review.opendev.org/c/openstack/cinder/+/767290" | 01:30 |
---|---|---|
*** baojg has joined #openstack-cinder | 01:36 | |
*** hamalq has quit IRC | 01:40 | |
*** enriquetaso has quit IRC | 01:56 | |
*** martinkennelly has quit IRC | 02:08 | |
*** benfelin has quit IRC | 02:11 | |
*** lbragstad_ is now known as lbragstad | 02:15 | |
*** GirishChilukuri has joined #openstack-cinder | 02:25 | |
caiqilong | When I run this test: "cinder_tempest_plugin.scenario.test_volume_encrypted.TestEncryptedCinderVolumes.test_boot_cloned_encrypted_volume". | 02:59 |
caiqilong | There is an error when running cmd: "cryptsetup isLuks --verbose /dev/sdd". | 02:59 |
caiqilong | The error message was: "'Command failed with code -1 (wrong or missing parameters).\n'" | 02:59 |
caiqilong | Is there any idea? | 02:59 |
*** jmlowe has joined #openstack-cinder | 03:36 | |
*** zenkuro has quit IRC | 04:01 | |
*** ajitha has joined #openstack-cinder | 04:24 | |
*** manoj_kumar_kata has quit IRC | 04:58 | |
*** m75abrams has joined #openstack-cinder | 05:10 | |
*** udesale has joined #openstack-cinder | 05:22 | |
openstackgerrit | haobing1 proposed openstack/cinder master: Delete quotas when deleting volume type https://review.opendev.org/c/openstack/cinder/+/768592 | 05:28 |
*** zzzeek has quit IRC | 05:41 | |
*** zzzeek has joined #openstack-cinder | 05:42 | |
*** whoami-rajat__ has joined #openstack-cinder | 05:56 | |
*** vishalmanchanda has joined #openstack-cinder | 05:58 | |
openstackgerrit | haobing1 proposed openstack/cinder master: Delete quotas when deleting volume type https://review.opendev.org/c/openstack/cinder/+/768592 | 06:07 |
*** rcernin has quit IRC | 06:07 | |
*** GirishChilukuri has quit IRC | 06:28 | |
openstackgerrit | Rajat Dhasmana proposed openstack/cinder-tempest-plugin master: Add Snapshot data integrity test https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/702495 | 06:55 |
openstackgerrit | Rajat Dhasmana proposed openstack/cinder-tempest-plugin master: Add Snapshot data integrity test https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/702495 | 07:02 |
openstackgerrit | Rajat Dhasmana proposed openstack/cinder-tempest-plugin master: Add Snapshot data integrity test https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/702495 | 07:04 |
*** lpetrut has joined #openstack-cinder | 07:10 | |
*** tkajinam_ has joined #openstack-cinder | 07:19 | |
*** tkajinam has quit IRC | 07:20 | |
*** GirishChilukuri has joined #openstack-cinder | 07:55 | |
*** e0ne has joined #openstack-cinder | 07:58 | |
*** ociuhandu has joined #openstack-cinder | 08:00 | |
*** GirishChilukuri has quit IRC | 08:00 | |
*** ociuhandu has quit IRC | 08:05 | |
*** rpittau|afk is now known as rpittau | 08:11 | |
*** tosky has joined #openstack-cinder | 08:16 | |
*** GirishChilukuri has joined #openstack-cinder | 08:28 | |
openstackgerrit | Masahiro Okuri proposed openstack/cinder master: created s3 cinder backup driver https://review.opendev.org/c/openstack/cinder/+/746561 | 08:34 |
*** mokuri has joined #openstack-cinder | 08:41 | |
*** mokuri has quit IRC | 08:48 | |
*** brinzhang has quit IRC | 08:55 | |
*** brinzhang has joined #openstack-cinder | 08:55 | |
*** brinzhang has quit IRC | 08:57 | |
*** brinzhang has joined #openstack-cinder | 08:57 | |
*** ociuhandu has joined #openstack-cinder | 08:58 | |
*** ociuhandu has quit IRC | 09:04 | |
*** ociuhandu has joined #openstack-cinder | 09:10 | |
*** ociuhandu has quit IRC | 09:14 | |
openstackgerrit | Venkata krishna Thumu proposed openstack/cinder master: [SVF] Update volume replication properties https://review.opendev.org/c/openstack/cinder/+/771563 | 09:26 |
*** martinkennelly has joined #openstack-cinder | 09:29 | |
*** lpetrut_ has joined #openstack-cinder | 09:34 | |
*** udesale_ has joined #openstack-cinder | 09:35 | |
*** tosky has quit IRC | 09:36 | |
*** tosky_ has joined #openstack-cinder | 09:36 | |
*** lpetrut has quit IRC | 09:37 | |
*** udesale has quit IRC | 09:37 | |
*** tosky_ is now known as tosky | 09:43 | |
*** GirishChilukuri has quit IRC | 09:54 | |
*** zoharm has joined #openstack-cinder | 09:58 | |
openstackgerrit | Zohar Mamedov proposed openstack/cinder master: Add KIOXIA KumoScale NVMeOF driver https://review.opendev.org/c/openstack/cinder/+/768574 | 10:04 |
*** raghavendrat has joined #openstack-cinder | 10:09 | |
*** ociuhandu has joined #openstack-cinder | 10:18 | |
openstackgerrit | Girish Chilukuri proposed openstack/cinder master: [SVF]:Storwize hyperswap volume is not deleting. https://review.opendev.org/c/openstack/cinder/+/771783 | 10:25 |
*** GirishChilukuri has joined #openstack-cinder | 10:48 | |
*** benfelin has joined #openstack-cinder | 10:49 | |
*** dsariel has joined #openstack-cinder | 10:56 | |
*** raghavendrat has quit IRC | 11:06 | |
*** udesale__ has joined #openstack-cinder | 11:12 | |
*** udesale_ has quit IRC | 11:15 | |
*** rosmaita has quit IRC | 11:19 | |
*** rcernin has joined #openstack-cinder | 11:23 | |
*** e0ne has quit IRC | 11:28 | |
*** rosmaita has joined #openstack-cinder | 11:32 | |
*** baojg has quit IRC | 11:41 | |
*** rcernin has quit IRC | 11:57 | |
caiqilong | rosmaita: Hi, I have added newly patchset fixed the issues smcginnis proposed. If you have time, please review at: "https://review.opendev.org/c/openstack/cinder/+/767290" | 12:10 |
*** ociuhandu has quit IRC | 12:49 | |
*** raghavendrat has joined #openstack-cinder | 13:05 | |
*** raghavendrat has left #openstack-cinder | 13:06 | |
*** tosky has quit IRC | 13:06 | |
*** tosky has joined #openstack-cinder | 13:06 | |
*** benfelin has quit IRC | 13:11 | |
*** GirishChilukuri has quit IRC | 13:22 | |
*** ociuhandu has joined #openstack-cinder | 13:23 | |
*** enriquetaso has joined #openstack-cinder | 13:37 | |
*** knomura has joined #openstack-cinder | 13:44 | |
*** sapd1 has joined #openstack-cinder | 13:47 | |
*** zenkuro has joined #openstack-cinder | 14:03 | |
*** raghavendrat has joined #openstack-cinder | 14:18 | |
raghavendrat | hi core reviewers, this is regarding https://review.opendev.org/#/c/752934/ | 14:20 |
raghavendrat | CI have passed. It has one +2. Request if someone can have look & share feedback. Thanks | 14:22 |
*** m75abrams has quit IRC | 14:24 | |
caiqilong | rosmaita: Hi, I have added newly patchset fixed the issues smcginnis proposed. If you have time, please review at: "https://review.opendev.org/c/openstack/cinder/+/767290" | 14:26 |
rosmaita | caiqilong: ack | 14:26 |
*** vishalmanchanda has quit IRC | 14:38 | |
*** dave-mccowan has joined #openstack-cinder | 14:40 | |
*** brinzhang has quit IRC | 15:01 | |
*** brinzhang has joined #openstack-cinder | 15:01 | |
*** rosmaita has left #openstack-cinder | 15:02 | |
*** raghavendrat has left #openstack-cinder | 15:03 | |
*** brinzhang has quit IRC | 15:04 | |
*** brinzhang has joined #openstack-cinder | 15:04 | |
*** rosmaita has joined #openstack-cinder | 15:06 | |
*** masterpe has quit IRC | 15:19 | |
*** irclogbot_2 has quit IRC | 15:21 | |
*** irclogbot_0 has joined #openstack-cinder | 15:22 | |
*** masterpe has joined #openstack-cinder | 15:28 | |
*** knomura has quit IRC | 15:39 | |
*** lpetrut_ has quit IRC | 15:42 | |
openstackgerrit | Lee Yarwood proposed openstack/cinder-tempest-plugin master: test_volume_encrypted: Stop creating an image for each instance https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/771835 | 15:43 |
openstackgerrit | Lee Yarwood proposed openstack/cinder-tempest-plugin master: zuul: Add nova-ceph-multistore to gate https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/771836 | 15:43 |
*** rosmaita has quit IRC | 15:52 | |
*** rosmaita has joined #openstack-cinder | 15:54 | |
*** GirishChilukuri has joined #openstack-cinder | 15:54 | |
hemna | rosmaita: CI is passing - https://review.opendev.org/c/openstack/cinder/+/667108 | 16:04 |
rosmaita | hemna: excellent! | 16:04 |
jungleboyj | Woohoo! | 16:06 |
hemna | :) | 16:16 |
caiqilong | congratulations, :) | 16:18 |
*** udesale__ has quit IRC | 16:24 | |
*** GirishChilukuri has quit IRC | 16:25 | |
*** e0ne has joined #openstack-cinder | 16:29 | |
*** lpetrut has joined #openstack-cinder | 16:42 | |
*** ociuhandu_ has joined #openstack-cinder | 16:49 | |
*** lpetrut has quit IRC | 16:50 | |
*** ociuhandu has quit IRC | 16:53 | |
*** ociuhandu_ has quit IRC | 16:54 | |
*** dave-mccowan has quit IRC | 17:31 | |
*** manoj_kumar_kata has joined #openstack-cinder | 17:31 | |
openstackgerrit | Helen Walsh proposed openstack/cinder master: PowerMax Driver - Offline r1 promotion fixes https://review.opendev.org/c/openstack/cinder/+/752295 | 17:32 |
*** hamalq has joined #openstack-cinder | 17:33 | |
*** lpetrut has joined #openstack-cinder | 17:40 | |
*** rpittau is now known as rpittau|afk | 17:42 | |
lpetrut | rosmaita: hi, good news: we've started the os-brick Windows Ceph job: https://review.opendev.org/c/openstack/os-brick/+/718403 | 17:42 |
lpetrut | os-brick-ceph http://cloudbase-ci.com/os-brick/718403/17/ceph/ : SUCCESS in 1h 02m 03s | 17:42 |
*** knomura has joined #openstack-cinder | 17:51 | |
lpetrut | it would be great if we could have another round of reviews | 17:51 |
*** rcernin has joined #openstack-cinder | 17:54 | |
*** lpetrut has quit IRC | 17:55 | |
*** knomura has quit IRC | 17:56 | |
*** rcernin has quit IRC | 17:59 | |
*** e0ne has quit IRC | 18:33 | |
openstackgerrit | Simon Dodsley proposed openstack/cinder master: Pure Storage: Add volume prefix option and check lengths https://review.opendev.org/c/openstack/cinder/+/769405 | 18:39 |
openstackgerrit | Simon Dodsley proposed openstack/cinder master: Pure Storage: Add volume prefix option and check lengths https://review.opendev.org/c/openstack/cinder/+/769405 | 18:39 |
openstackgerrit | Helen Walsh proposed openstack/cinder master: PowerMax Driver - RDF checks https://review.opendev.org/c/openstack/cinder/+/768105 | 18:46 |
openstackgerrit | Sofia Enriquez proposed openstack/cinder master: Log information about the Ceph v2 clone API https://review.opendev.org/c/openstack/cinder/+/754849 | 18:52 |
hemna | lpetrut nice | 19:00 |
*** sapd1 has quit IRC | 19:02 | |
openstackgerrit | Lance Bragstad proposed openstack/cinder master: Introduce basic plumbing for protection tests with ddt https://review.opendev.org/c/openstack/cinder/+/771875 | 19:05 |
openstackgerrit | Walt proposed openstack/cinder master: [vmware] validate storage profile at startup https://review.opendev.org/c/openstack/cinder/+/726180 | 19:05 |
openstackgerrit | Walt proposed openstack/cinder stable/train: API: os-reset_status notification fix https://review.opendev.org/c/openstack/cinder/+/715421 | 19:06 |
*** sapd1 has joined #openstack-cinder | 19:06 | |
openstackgerrit | Lance Bragstad proposed openstack/cinder master: Introduce basic plumbing for protection tests with ddt https://review.opendev.org/c/openstack/cinder/+/771875 | 19:06 |
openstackgerrit | Lance Bragstad proposed openstack/cinder master: Introduce basic plumbing for protection tests with ddt https://review.opendev.org/c/openstack/cinder/+/771875 | 19:07 |
*** MrClayPole has quit IRC | 19:27 | |
*** MrClayPole has joined #openstack-cinder | 19:28 | |
*** martinkennelly has quit IRC | 19:38 | |
openstackgerrit | Fernando Ferraz Silva proposed openstack/cinder stable/queens: NetApp SolidFire: Fix duplicate volume when API response is lost https://review.opendev.org/c/openstack/cinder/+/764278 | 19:43 |
*** dave-mccowan has joined #openstack-cinder | 19:51 | |
*** zoharm has quit IRC | 20:00 | |
*** manoj_kumar_kata has quit IRC | 20:12 | |
*** enriquetaso has quit IRC | 20:14 | |
*** irclogbot_0 has quit IRC | 20:14 | |
*** enriquetaso has joined #openstack-cinder | 20:14 | |
*** tosky has quit IRC | 20:14 | |
*** tosky has joined #openstack-cinder | 20:15 | |
*** irclogbot_1 has joined #openstack-cinder | 20:16 | |
*** caiqilong has quit IRC | 20:52 | |
*** ajitha has quit IRC | 20:56 | |
*** whoami-rajat__ has quit IRC | 21:04 | |
lbragstad | o/ hey folks - curious if anyone is around to discuss some potential changes necessary for testing the RBAC changes proposed to cinder | 21:12 |
lbragstad | i'm attempting to write protection tests that should make it easier to review the policy changes, but i noticed the NoAuthMiddleware is used by default in the tests (which seems completely fine) | 21:24 |
lbragstad | NoAuthMiddleware also appears to have an opinion about what a context object should look like | 21:25 |
lbragstad | so 1.) i think using NoAuthMiddleware is going to have an impact on how we write protection tests for cinder (if we choose to use it) | 21:25 |
lbragstad | 2.) if anyone is using cinder standalone - is it safe to assume the new policies are going to make NoAuthMiddleware's representation of the context object obsolete | 21:26 |
tosky | I can't help too much on this as I don't know that part, but are you suggesting to drop the usage of NoAuthMiddleware? | 21:27 |
tosky | and use the real middleware directly? | 21:28 |
lbragstad | i don't think so - because it sounds like people use cinder in standalone, which would require some sort of middleware that doesn't care about validating tokens against keystone | 21:30 |
lbragstad | i think my real question is - do we evolve NoAuthMiddleware to work with the new policies and for the new protection tests? | 21:31 |
lbragstad | (which could have implications on clients using cinder deployed with NoAuthMiddleware) | 21:32 |
rosmaita | i think we need to research this a bit | 21:35 |
rosmaita | i think smcginnis and jungleboyj may know the most about how people use cinder in standalone mode | 21:35 |
lbragstad | yeah - that makes sense | 21:42 |
*** rcernin has joined #openstack-cinder | 21:54 | |
*** rcernin has quit IRC | 21:59 | |
*** rcernin has joined #openstack-cinder | 22:38 | |
jungleboyj | I wouldn't say that I know the most. :-) | 22:40 |
jungleboyj | lbragstad: I think you are right that standalone requires some middleware that doesn't require keystone. | 22:42 |
jungleboyj | So, we still need something that will work in that way. Not sure what changes you are referring to as far as policies are concerned. | 22:43 |
lbragstad | jungleboyj https://review.opendev.org/q/project:openstack/cinder+topic:secure-rbac | 22:43 |
lbragstad | those are the proposed policy changes | 22:43 |
jungleboyj | hemna: ^^ I think you worked on setting this up originally. Do you have input? | 22:45 |
lbragstad | granted - these changes are deprecating the old policies and replacing them with new policies | 22:45 |
lbragstad | so - i imagine the obsolete context objects from NoAuthMiddleware will continue to work for some period of time | 22:46 |
lbragstad | and i'm saying that because i'm assuming people who are using noauth strategies aren't overriding their policies with custom overrides | 22:47 |
jungleboyj | I don't think that people who are doing standalone are doing much with policies. Probably just mostly trying to get things to work without more trouble than necessary. | 22:53 |
lbragstad | sure | 22:53 |
lbragstad | http://paste.openstack.org/show/801850/ is another option (it's a similar technique that ironic uses) | 22:53 |
lbragstad | only call enforcement with the proper inputs if keystone is actually the auth_strategy | 22:54 |
lbragstad | otherwise just return True | 22:54 |
lbragstad | in which case, it might not really matter what NoAuthMiddleware does or how it builds a context object (unless other parts of cinder use it in ways i'm not aware of) | 22:54 |
*** rcernin has quit IRC | 22:56 | |
*** rcernin has joined #openstack-cinder | 22:57 | |
openstackgerrit | Simon Dodsley proposed openstack/cinder master: Pure Storage: Add volume prefix option and check lengths https://review.opendev.org/c/openstack/cinder/+/769405 | 22:57 |
*** brinzhang has quit IRC | 23:00 | |
jungleboyj | lbragstad: Ok. Would you be able to bring this up in our next meeting? I would like to get input from geguileo hemna e0ne as they might have stronger opinions on the way forward. | 23:01 |
lbragstad | sounds good - next wednesday at 8 CST? | 23:02 |
*** knomura has joined #openstack-cinder | 23:04 | |
*** knomura has quit IRC | 23:08 | |
jungleboyj | lbragstad: Yes! | 23:12 |
lbragstad | sounds good | 23:13 |
openstackgerrit | Lance Bragstad proposed openstack/cinder master: Introduce basic plumbing for protection tests with ddt https://review.opendev.org/c/openstack/cinder/+/771875 | 23:19 |
openstackgerrit | Lance Bragstad proposed openstack/cinder master: Introduce basic plumbing for protection tests with ddt https://review.opendev.org/c/openstack/cinder/+/771875 | 23:20 |
lbragstad | rosmaita ^ that works for me locally - it takes a different approach to middleware for now | 23:21 |
*** ociuhandu has joined #openstack-cinder | 23:24 | |
*** ociuhandu has quit IRC | 23:29 | |
*** brinzhang has joined #openstack-cinder | 23:34 | |
*** lemko has quit IRC | 23:51 | |
*** lemko6 has joined #openstack-cinder | 23:51 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!