*** enriquetaso has quit IRC | 00:07 | |
*** whoami-rajat has quit IRC | 00:15 | |
*** enriquetaso has joined #openstack-cinder | 00:16 | |
*** johanssone has quit IRC | 00:16 | |
*** tosky has quit IRC | 00:17 | |
*** johanssone has joined #openstack-cinder | 00:19 | |
*** martinkennelly has quit IRC | 00:50 | |
*** Underknowledge has quit IRC | 01:08 | |
*** Underknowledge has joined #openstack-cinder | 01:08 | |
*** Underknowledge2 has joined #openstack-cinder | 01:51 | |
*** Underknowledge has quit IRC | 01:54 | |
*** Underknowledge2 is now known as Underknowledge | 01:54 | |
*** rcernin has quit IRC | 02:00 | |
*** enriquetaso has quit IRC | 02:05 | |
*** rratnaka has joined #openstack-cinder | 02:11 | |
*** rratnaka14 has joined #openstack-cinder | 02:16 | |
*** rratnaka has quit IRC | 02:20 | |
*** hamalq has quit IRC | 02:25 | |
*** rcernin has joined #openstack-cinder | 02:29 | |
*** rcernin has quit IRC | 02:29 | |
*** enriquetaso has joined #openstack-cinder | 02:30 | |
*** rcernin has joined #openstack-cinder | 02:30 | |
*** rratnaka14 has quit IRC | 02:33 | |
*** Underknowledge has quit IRC | 02:38 | |
*** Xuchu_ has joined #openstack-cinder | 02:43 | |
*** rcernin has quit IRC | 02:44 | |
*** Xuchu has quit IRC | 02:46 | |
*** rcernin has joined #openstack-cinder | 03:16 | |
*** dasp has quit IRC | 03:34 | |
*** rratnaka has joined #openstack-cinder | 03:35 | |
*** enriquetaso has quit IRC | 03:37 | |
*** dasp has joined #openstack-cinder | 03:45 | |
*** psachin has joined #openstack-cinder | 03:50 | |
*** caiqilong has quit IRC | 03:53 | |
*** GirishChilukuri has joined #openstack-cinder | 04:04 | |
*** venkatakrishnath has joined #openstack-cinder | 04:13 | |
*** zzzeek has quit IRC | 04:17 | |
*** zzzeek has joined #openstack-cinder | 04:17 | |
*** GirishChilukuri has quit IRC | 04:18 | |
*** zzzeek has quit IRC | 04:22 | |
*** GirishChilukuri has joined #openstack-cinder | 04:23 | |
*** zzzeek has joined #openstack-cinder | 04:23 | |
*** rratnaka14 has joined #openstack-cinder | 04:35 | |
*** udesale has joined #openstack-cinder | 04:35 | |
*** rratnaka has quit IRC | 04:38 | |
*** dviroel has quit IRC | 04:55 | |
openstackgerrit | Merged openstack/os-brick stable/ussuri: FC: Fix not flushing on detach https://review.opendev.org/c/openstack/os-brick/+/777408 | 04:56 |
---|---|---|
*** whoami-rajat has joined #openstack-cinder | 04:58 | |
*** vishalmanchanda has joined #openstack-cinder | 05:27 | |
*** m75abrams has joined #openstack-cinder | 05:35 | |
openstackgerrit | Girish Chilukuri proposed openstack/cinder stable/ussuri: [SVF]:Fix clone fcmap not being deleted in cleanup https://review.opendev.org/c/openstack/cinder/+/767334 | 05:36 |
*** brinzhang has joined #openstack-cinder | 05:41 | |
openstackgerrit | Lance Bragstad proposed openstack/cinder-tempest-plugin master: Implement basic protection testing jobs https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/772915 | 05:43 |
openstackgerrit | Lance Bragstad proposed openstack/cinder-tempest-plugin master: Implement protection testing for capabilities API https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/775894 | 05:43 |
openstackgerrit | Lance Bragstad proposed openstack/cinder-tempest-plugin master: Add basic volume protection tests https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/778357 | 05:43 |
lbragstad | rosmaita ^ those are some example protection tests using the volumes API | 05:44 |
lbragstad | it doesn't use the new default policies for project-member and project-reader, but you'll see that when the project-reader tests fail (since they're creating things) | 05:44 |
lbragstad | if you pull that down and run in against https://review.opendev.org/c/openstack/cinder/+/760199 it should work | 05:45 |
lbragstad | but - i guess the test bits would follow that general pattern is that's what cinder wants to do | 05:46 |
lbragstad | it's all using the tempest clients, so it should be relatively straight forward for folks to hop in and start writing some more tests | 05:47 |
lbragstad | which would really help | 05:47 |
*** ajitha has joined #openstack-cinder | 05:48 | |
*** zzzeek has quit IRC | 06:06 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder master: Imported Translations from Zanata https://review.opendev.org/c/openstack/cinder/+/776822 | 06:14 |
*** Xuchu_ has quit IRC | 06:22 | |
*** Xuchu has joined #openstack-cinder | 06:22 | |
*** rratnaka has joined #openstack-cinder | 06:35 | |
*** rratnaka14 has quit IRC | 06:38 | |
openstackgerrit | Xuan Yandong proposed openstack/os-brick master: Remove six https://review.opendev.org/c/openstack/os-brick/+/754598 | 06:41 |
*** zzzeek has joined #openstack-cinder | 06:41 | |
openstackgerrit | Rajat Dhasmana proposed openstack/cinder master: Fix: show volume by name for non-admins https://review.opendev.org/c/openstack/cinder/+/778373 | 07:13 |
whoami-rajat | frickler: ^^ , i thought it was being removed for all APIs at a later stage but those are some custom cases who do not support resource filtering | 07:15 |
*** rratnaka14 has joined #openstack-cinder | 07:34 | |
*** rratnaka has quit IRC | 07:38 | |
*** rratnaka has joined #openstack-cinder | 07:39 | |
*** rratnaka14 has quit IRC | 07:39 | |
*** rcernin has quit IRC | 07:44 | |
*** rpittau|afk is now known as rpittau | 07:52 | |
*** ociuhandu has joined #openstack-cinder | 08:13 | |
frickler | whoami-rajat: great, thx | 08:27 |
*** ociuhandu has quit IRC | 08:30 | |
*** tosky has joined #openstack-cinder | 08:34 | |
*** ociuhandu has joined #openstack-cinder | 08:35 | |
*** jdillaman has quit IRC | 08:44 | |
*** jdillaman has joined #openstack-cinder | 08:45 | |
*** Underknowledge has joined #openstack-cinder | 09:11 | |
*** venkatakrishnath has quit IRC | 09:11 | |
openstackgerrit | Helen Walsh proposed openstack/cinder master: PowerMax Driver - Extend replicated volume https://review.opendev.org/c/openstack/cinder/+/767172 | 09:17 |
*** ociuhandu has quit IRC | 09:39 | |
*** Xuchu has quit IRC | 09:43 | |
*** ociuhandu has joined #openstack-cinder | 10:04 | |
*** lpetrut has joined #openstack-cinder | 10:22 | |
*** ociuhandu has quit IRC | 10:28 | |
*** ociuhandu has joined #openstack-cinder | 10:37 | |
*** carloss has joined #openstack-cinder | 10:49 | |
*** dviroel has joined #openstack-cinder | 11:05 | |
*** venkatakrishnath has joined #openstack-cinder | 11:09 | |
*** whoami-rajat__ has joined #openstack-cinder | 11:11 | |
*** zoharm has joined #openstack-cinder | 11:11 | |
*** bhagyashris is now known as bhagyashris|rove | 11:30 | |
*** bhagyashris|rove is now known as bhagyashri|rover | 11:30 | |
*** ociuhandu has quit IRC | 11:41 | |
openstackgerrit | Xuan Yandong proposed openstack/cinder-specs master: Add xena directory for specs https://review.opendev.org/c/openstack/cinder-specs/+/778436 | 11:41 |
openstackgerrit | Xuan Yandong proposed openstack/cinder-specs master: WIP Update original volume az https://review.opendev.org/c/openstack/cinder-specs/+/778437 | 11:43 |
*** dsariel has joined #openstack-cinder | 11:51 | |
*** udesale_ has joined #openstack-cinder | 11:57 | |
*** udesale has quit IRC | 12:00 | |
*** legochen has quit IRC | 12:00 | |
openstackgerrit | Takashi Kajinami proposed openstack/os-brick master: Avoid unhandled exceptions during connecting to iSCSI portals https://review.opendev.org/c/openstack/os-brick/+/775545 | 12:11 |
*** ociuhandu has joined #openstack-cinder | 12:12 | |
openstackgerrit | Merged openstack/os-brick stable/train: Improve error handling on target query https://review.opendev.org/c/openstack/os-brick/+/777406 | 12:15 |
*** ociuhandu has quit IRC | 12:17 | |
*** martinkennelly has joined #openstack-cinder | 12:18 | |
openstackgerrit | Luigi Toscano proposed openstack/cinder-tempest-plugin master: WIP no cinderlib before train https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/778448 | 12:32 |
*** ociuhandu has joined #openstack-cinder | 12:37 | |
*** legochen has joined #openstack-cinder | 12:38 | |
*** legochen_ has joined #openstack-cinder | 12:42 | |
*** legochen has quit IRC | 12:43 | |
*** legochen_ is now known as legochen | 12:43 | |
*** rratnaka has quit IRC | 12:48 | |
*** psachin has quit IRC | 13:01 | |
*** rratnaka has joined #openstack-cinder | 13:26 | |
*** rratnaka14 has joined #openstack-cinder | 13:27 | |
*** rratnaka has quit IRC | 13:31 | |
*** e0ne has joined #openstack-cinder | 13:45 | |
*** enriquetaso has joined #openstack-cinder | 13:50 | |
*** amar7ibm_ has joined #openstack-cinder | 13:51 | |
*** almir-okato has joined #openstack-cinder | 13:52 | |
*** jv_ has quit IRC | 13:55 | |
rosmaita | Courtesy reminder: Cinder meeting in #openstack-meeting-alt at 1400 UTC | 13:56 |
rosmaita | jungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard lseki sfernand rajinir enriquetaso hemna atmark ^^ | 13:56 |
geguileo | rosmaita: thanks :-) | 13:56 |
whoami-rajat | thanks rosmaita | 13:57 |
jungleboyj | Morning. | 13:57 |
*** ociuhandu has quit IRC | 13:58 | |
*** ociuhandu has joined #openstack-cinder | 13:59 | |
*** jv_ has joined #openstack-cinder | 14:00 | |
openstackgerrit | Zohar Mamedov proposed openstack/os-brick master: Add NVMeOF monitoring and healing agent https://review.opendev.org/c/openstack/os-brick/+/768576 | 14:00 |
*** thgcorrea has joined #openstack-cinder | 14:02 | |
*** sfernand has joined #openstack-cinder | 14:04 | |
*** ociuhandu has quit IRC | 14:04 | |
*** ociuhandu has joined #openstack-cinder | 14:07 | |
*** felipe_rodrigues has joined #openstack-cinder | 14:13 | |
*** takamatsu has joined #openstack-cinder | 14:17 | |
*** jdillaman has quit IRC | 14:18 | |
*** jdillaman has joined #openstack-cinder | 14:18 | |
openstackgerrit | Eric Harney proposed openstack/os-brick master: Fix import order in exception.py https://review.opendev.org/c/openstack/os-brick/+/778470 | 14:25 |
*** ociuhandu has quit IRC | 14:27 | |
*** ociuhandu has joined #openstack-cinder | 14:28 | |
*** ociuhandu has quit IRC | 14:33 | |
*** jv_ has quit IRC | 14:33 | |
*** jv_ has joined #openstack-cinder | 14:34 | |
*** ociuhandu has joined #openstack-cinder | 14:40 | |
openstackgerrit | Eric Harney proposed openstack/os-brick master: Fix import order of libraries https://review.opendev.org/c/openstack/os-brick/+/778470 | 14:40 |
openstackgerrit | Luigi Toscano proposed openstack/cinder stable/stein: WIP [stable-only] Set IPv6 params to fix tempest-slow-py3 https://review.opendev.org/c/openstack/cinder/+/778476 | 14:44 |
*** zoharm has quit IRC | 14:47 | |
whoami-rajat | geguileo: isn't that an bug with using multiple schedulers? should we have that data centralized or sync before requests, although I don't have much experience with cinder scheduler | 14:55 |
geguileo | whoami-rajat: in an ideal world we would, but reality is that makes us have a dependency on an external service we don't have | 14:56 |
geguileo | whoami-rajat: so each scheduler has different data and they sync when they receive reports from the backend | 14:57 |
*** zoharm has joined #openstack-cinder | 14:57 | |
*** jv_ has quit IRC | 14:59 | |
*** jdillaman has quit IRC | 15:00 | |
whoami-rajat | geguileo: ah, makes sense | 15:01 |
* enriquetaso thinking | 15:01 | |
geguileo | whoami-rajat: it's not perfect, but it protects the system in a way ;-) | 15:01 |
eharney | keep in mind that bugs about "i scheduled 3 volumes and they didn't go where i'd like" are kind of tricky -- it's a lot more useful to think about what happens when scheduling 1000 of them instead | 15:02 |
tosky | regarding that cinder-tempest-plugin item on the agenda, I just wanted to ask if there are any objections about tagging a new cinder-tempest-release (the change I've mentioned is on the way of being merged), | 15:05 |
tosky | so please comment on the etherpad if you are for/against it and/or if you want to have specific changes included (but please note another tag won't be far away) | 15:06 |
rosmaita | tosky: i think let's just propose the release and we can release again later | 15:06 |
rosmaita | because if we don't the release team will anyway | 15:07 |
tosky | I can do that as soon as that patch lands (which may take a while, there is a long queue in the gate job) | 15:07 |
*** jv_ has joined #openstack-cinder | 15:07 | |
rosmaita | tosky: ty, i'm not sure if cinder-tempest-plugin is in deliverables/wallaby or deliverables/independent, you may have to sort that out | 15:09 |
tosky | I know that part :) | 15:09 |
*** lpetrut has quit IRC | 15:09 | |
GirishChilukuri | regarding: Run cinder tempest plugin in third party CI, This "https://review.opendev.org/c/openstack/cinder/+/773937" patch adds functionality for revert to snapshot for IBM driver but isn't running any revert to snapshot tests as they reside in cinder_tempest_plugin | 15:10 |
tosky | then it should be nice to run them :) | 15:11 |
whoami-rajat | tosky: i left a question on the etherpad | 15:11 |
*** happyhemant has joined #openstack-cinder | 15:13 | |
rosmaita | whoami-rajat: btw, i left some questions for the release team on your victoria releases patch, just not sure about some of the version numbers | 15:13 |
tosky | whoami-rajat: answered there, but basically we can re-release anytime | 15:13 |
rosmaita | but everything else looked fine, thanks for proposing the patch | 15:13 |
whoami-rajat | rosmaita: smcginnis replied and I've updated the patch | 15:13 |
whoami-rajat | unless you left few more comments just now | 15:14 |
rosmaita | tosky: you pay the most attention out of all of us to tempest events (i.e., you have > 0 awareness), so i think we should do whatever you suggest | 15:14 |
rosmaita | whoami-rajat: thanks, i will look and +1 | 15:14 |
whoami-rajat | tosky: thanks | 15:14 |
enriquetaso | tosky++ | 15:15 |
whoami-rajat | no new comments after my update so it's good | 15:15 |
whoami-rajat | rosmaita: thanks for adding the reply on my topic, i wasn't sure cinder-tempest-plugin is a hard requirement to run in CI but that patch for revert to snapshot feature should surely run it (since revert to snapshot tests exist in cinder-tempest-plugin) | 15:16 |
rosmaita | yeah, i was looking for the statement about that for GirishChilukuri it's either in the all about driver page in cinder docs or the 3rd party ci stuff on the wiki | 15:17 |
rosmaita | we could probably use a doc update, the idea is that you should always run cinder-tempest-plugin, but you turn off the features you don't support as part of the tempest config | 15:17 |
whoami-rajat | seems like the best approach, GirishChilukuri ^ | 15:18 |
*** rratnaka has joined #openstack-cinder | 15:21 | |
*** rratnaka14 has quit IRC | 15:23 | |
tosky | you need to explicitly enable revert to snapshot tests by setting a key in tempest.conf (volume-feature-enabled.volume-revert=True) | 15:24 |
rosmaita | tosky: thanks, so i have it backwards: you have to turn ON the features that you DO support | 15:25 |
whoami-rajat | oh yeah the defaults are false, although i mentioned on the review to turn it on so they should do it the right way | 15:26 |
GirishChilukuri | yeah I got it now, Thanks rosmaita whoami-rajat tosky | 15:29 |
rosmaita | np | 15:29 |
*** hemna has quit IRC | 15:39 | |
*** hemna has joined #openstack-cinder | 15:40 | |
*** GirishChilukuri_ has joined #openstack-cinder | 15:43 | |
*** GirishChilukuri has quit IRC | 15:46 | |
*** zoharm has quit IRC | 15:55 | |
*** rratnaka14 has joined #openstack-cinder | 16:04 | |
*** rratnaka has quit IRC | 16:08 | |
*** takamatsu has quit IRC | 16:11 | |
*** ociuhandu has quit IRC | 16:15 | |
*** smcginnis has quit IRC | 16:25 | |
*** ociuhandu has joined #openstack-cinder | 16:31 | |
*** smcginnis has joined #openstack-cinder | 16:34 | |
*** ChanServ sets mode: +o smcginnis | 16:34 | |
*** e0ne has quit IRC | 16:37 | |
*** m75abrams has quit IRC | 16:48 | |
*** udesale_ has quit IRC | 16:52 | |
*** hemna has quit IRC | 17:01 | |
*** jv_ has quit IRC | 17:01 | |
*** hoonetorg has quit IRC | 17:01 | |
*** n-saito has quit IRC | 17:01 | |
*** stand has quit IRC | 17:01 | |
*** lifeless_ has quit IRC | 17:01 | |
*** JohnnyRa1 has quit IRC | 17:01 | |
*** hack-char has quit IRC | 17:01 | |
*** openstackgerrit has quit IRC | 17:02 | |
*** stand has joined #openstack-cinder | 17:05 | |
*** hemna has joined #openstack-cinder | 17:07 | |
*** jv_ has joined #openstack-cinder | 17:07 | |
*** hoonetorg has joined #openstack-cinder | 17:07 | |
*** n-saito has joined #openstack-cinder | 17:07 | |
*** lifeless_ has joined #openstack-cinder | 17:07 | |
*** JohnnyRa1 has joined #openstack-cinder | 17:07 | |
*** hack-char has joined #openstack-cinder | 17:07 | |
*** e0ne has joined #openstack-cinder | 17:13 | |
*** venkatakrishnath has quit IRC | 17:14 | |
GirishChilukuri_ | tosky: Do we need to install cinder-tempest-plugin module, since this module is installed while devstack is installed and revert to snapshot test cases are part of this module. | 17:21 |
*** ociuhandu_ has joined #openstack-cinder | 17:21 | |
tosky | GirishChilukuri_: that's the idea, yes | 17:23 |
tosky | GirishChilukuri_: that module is not installed by devstack automatically; you need to install it and tell devstack to configure it by listing the local checkout in the TEMPEST_PLUGINS variable | 17:24 |
*** ociuhandu has quit IRC | 17:25 | |
tosky | GirishChilukuri_: if your CI uses Zuul v3 the process is easier (you can copy one of the jobs we use in cinder-tempest-plugin) | 17:25 |
*** ociuhandu_ has quit IRC | 17:26 | |
*** e0ne has quit IRC | 17:26 | |
GirishChilukuri_ | tosky: Zuul version is 2.5.1 | 17:28 |
*** whoami-rajat__ has quit IRC | 17:29 | |
tosky | erm, then you don't have all the shiny feature of the newest zuul | 17:30 |
tosky | but anyway, what I've written still applies: you need to make sure your job clones cinder-tempest-plugin as well, and devstack is provided the path of that local checkout through TEMPEST_PLUGINS | 17:31 |
*** ociuhandu has joined #openstack-cinder | 17:32 | |
*** manoj_katari has joined #openstack-cinder | 17:35 | |
GirishChilukuri_ | tosky: after installing cinder tempest plugin module, we need to export the "TEMPEST_PLUGINS" variable with the path where the module is installed. Is my understanding is correct. | 17:36 |
*** ociuhandu has quit IRC | 17:37 | |
tosky | GirishChilukuri_: it's been a while since I've done that without zuul v3, but yes, that should be it | 17:37 |
tosky | GirishChilukuri_: you can check how the zuul v3 jobs on opendev.org generates the local.conf configuration file for devstack | 17:38 |
tosky | GirishChilukuri_: for example (just one of the builds) https://191b3b2e56a0631260e6-9a2bdf79ebc3dafe7919d3415a023c8b.ssl.cf5.rackcdn.com/777074/1/check/cinder-tempest-plugin-lvm-lio-barbican/27eb541/controller/logs/local_conf.txt | 17:39 |
GirishChilukuri_ | tosky: TEMPEST_PLUGINS="/opt/stack/cinder-tempest-plugin" this is how we need to set | 17:41 |
tosky | of course the path depends on how you clone the repository in your job | 17:43 |
*** e0ne has joined #openstack-cinder | 17:43 | |
tosky | but yeah | 17:43 |
tosky | hopefully that should work | 17:43 |
GirishChilukuri_ | tosky: LIBS_FROM_GIT=barbican,cinder,cinder-tempest-plugin,cinderlib,devstack,glance,keystone,neutron,nova,placement,requirements,swift,tempest, do we need to update this variable also | 17:43 |
*** e0ne has quit IRC | 17:43 | |
tosky | GirishChilukuri_: if you set it, I'd say yet: that way, the latest commit of cinder-tempest-plugin will be installed; otherwise it will be installed from pip | 17:45 |
tosky | but you want to use the last commit | 17:45 |
tosky | so yes, please add cinder-tempest-plugin to that list | 17:45 |
*** e0ne has joined #openstack-cinder | 17:59 | |
*** rpittau is now known as rpittau|afk | 18:11 | |
GirishChilukuri_ | Thanks tosky we will try and get back to you If any clarification is needed | 18:14 |
tosky | sure | 18:16 |
geguileo | enriquetaso: apparently wu.chunyang had already proposed a fix for the wrong notification on detach https://review.opendev.org/c/openstack/cinder/+/723179 | 18:25 |
geguileo | enriquetaso: though in my opinion it is the wrong approach, I didn't know about it, so I proposed my own: https://review.opendev.org/c/openstack/cinder/+/778534 | 18:26 |
*** GirishChilukuri_ has quit IRC | 18:26 | |
geguileo | (while fixing some stuff around that part of the code) | 18:26 |
*** lpetrut has joined #openstack-cinder | 18:38 | |
*** zenkuro has joined #openstack-cinder | 18:43 | |
*** rratnaka14 has quit IRC | 18:44 | |
*** manoj_katari has quit IRC | 18:44 | |
*** lpetrut has quit IRC | 18:49 | |
*** whoami-rajat has quit IRC | 19:50 | |
enriquetaso | thanks geguileo, let me add both tho the bug report i guess | 19:52 |
*** lifeless_ is now known as lifeless | 19:56 | |
*** openstackgerrit has joined #openstack-cinder | 20:00 | |
openstackgerrit | Merged openstack/cinder-tempest-plugin master: Use the embedded scenario manager instead of tempest one https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/777074 | 20:00 |
*** happyhemant has quit IRC | 20:13 | |
*** rcernin has joined #openstack-cinder | 20:46 | |
openstackgerrit | Luigi Toscano proposed openstack/cinder-tempest-plugin master: Refactor the *lvm-lio* job(s) with a no cinderlib variant https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/778448 | 20:49 |
openstackgerrit | Luigi Toscano proposed openstack/cinder stable/stein: [stable-only] Set IPv6 params to fix tempest-slow-py3 https://review.opendev.org/c/openstack/cinder/+/778476 | 20:59 |
openstackgerrit | Luigi Toscano proposed openstack/cinder stable/stein: Port several legacy tempest jobs to Zuul v3 https://review.opendev.org/c/openstack/cinder/+/751211 | 20:59 |
openstackgerrit | Fernando Ferraz Silva proposed openstack/cinder stable/ussuri: NetApp SolidFire: Fix duplicate volume when API response is lost https://review.opendev.org/c/openstack/cinder/+/764274 | 21:04 |
*** rcernin has quit IRC | 21:17 | |
*** e0ne has quit IRC | 21:23 | |
*** gary_perkins has joined #openstack-cinder | 21:27 | |
openstackgerrit | Eric Harney proposed openstack/os-brick master: Fix import order of libraries https://review.opendev.org/c/openstack/os-brick/+/778470 | 21:30 |
openstackgerrit | Eric Harney proposed openstack/os-brick master: Enforce import order with flake8-import-order https://review.opendev.org/c/openstack/os-brick/+/778583 | 21:31 |
*** irclogbot_0 has quit IRC | 21:33 | |
*** ianw has quit IRC | 21:33 | |
*** abishop has quit IRC | 21:33 | |
*** Reepicheep has quit IRC | 21:33 | |
*** amotoki has quit IRC | 21:33 | |
*** atmark has quit IRC | 21:33 | |
*** Mr_Freezeex has quit IRC | 21:33 | |
*** atmark has joined #openstack-cinder | 21:34 | |
*** irclogbot_0 has joined #openstack-cinder | 21:34 | |
*** ianw has joined #openstack-cinder | 21:34 | |
*** abishop has joined #openstack-cinder | 21:34 | |
*** Reepicheep has joined #openstack-cinder | 21:34 | |
*** amotoki has joined #openstack-cinder | 21:34 | |
*** Mr_Freezeex has joined #openstack-cinder | 21:34 | |
eharney | rosmaita: it would be good to get 778583 ^ on the radar before req freeze | 21:37 |
rosmaita | ok, thanks | 21:38 |
*** e0ne has joined #openstack-cinder | 21:38 | |
*** zzzeek has quit IRC | 21:44 | |
openstackgerrit | Eric Harney proposed openstack/cinder master: Move require_driver_initialized / log_unsupp to volume_utils https://review.opendev.org/c/openstack/cinder/+/775250 | 21:44 |
*** zzzeek has joined #openstack-cinder | 21:45 | |
*** rcernin has joined #openstack-cinder | 22:05 | |
*** rcernin has quit IRC | 22:11 | |
*** rcernin has joined #openstack-cinder | 22:11 | |
openstackgerrit | Merged openstack/os-brick master: Changed minversion in tox to 3.18.0 https://review.opendev.org/c/openstack/os-brick/+/771568 | 22:14 |
*** ajitha has quit IRC | 22:23 | |
*** smekala has joined #openstack-cinder | 22:27 | |
smekala | Hello, Can I get some help with https://review.opendev.org/c/openstack/python-cinderclient/+/776311 | 22:31 |
smekala | This proposed changes will address the bug | 22:32 |
smekala | https://bugs.launchpad.net/python-cinderclient/+bug/1915996 | 22:32 |
openstack | Launchpad bug 1915996 in python-cinderclient "Fetching server version fails to support passing client certificates" [Medium,New] - Assigned to Sri Harsha mekala (harshayahoo) | 22:32 |
*** e0ne has quit IRC | 22:42 | |
*** smekala has quit IRC | 22:55 | |
*** rcernin has quit IRC | 22:56 | |
*** rcernin has joined #openstack-cinder | 23:01 | |
*** thgcorrea has quit IRC | 23:01 | |
openstackgerrit | Merged openstack/os-brick stable/train: FC: Fix not flushing on detach https://review.opendev.org/c/openstack/os-brick/+/777409 | 23:16 |
*** rcernin has quit IRC | 23:26 | |
openstackgerrit | Merged openstack/python-cinderclient master: Bump pylint to 2.6.0 https://review.opendev.org/c/openstack/python-cinderclient/+/746705 | 23:39 |
*** zzzeek has quit IRC | 23:40 | |
*** zzzeek has joined #openstack-cinder | 23:42 | |
lbragstad | rosmaita did you happen to get my ping from last night on the cinder tests? | 23:42 |
rosmaita | lbragstad: i did, will be looking at them a bit later | 23:43 |
lbragstad | ok - that's the basic template | 23:43 |
rosmaita | meant to ack but got sidetracked | 23:43 |
lbragstad | and it's still using the cinderlib bits - which i don't think i'm supposed to be using according to tosky and geguileo | 23:43 |
rosmaita | ok, i'll ignore the cinderlib parts | 23:44 |
*** vishalmanchanda has quit IRC | 23:44 | |
lbragstad | well - i think it just means we have a missing piece | 23:44 |
lbragstad | we need to have something setup config for cinder and tempest to do things properly for 1.) cinder to enforce the new defaults 2.) have tempest execute the right tests | 23:45 |
lbragstad | and i'm not sure where that something should live (in .zuul.conf)? | 23:45 |
lbragstad | or in devstack directly? | 23:45 |
tosky | lbragstad: how did you solve the problem for nova? I though the only devstack configuration for nova happens in devstack itself | 23:45 |
tosky | same for neutron and glance | 23:45 |
lbragstad | i didn't solve the problem for nova | 23:45 |
tosky | ... so devstack :) | 23:45 |
rosmaita | tosky never sleeps | 23:45 |
lbragstad | gmann did - but i'll let him weight in | 23:46 |
lbragstad | for glance i used the glance-tempest-plugin | 23:46 |
lbragstad | for keystone i used the keystone-tempest-plugin | 23:46 |
rosmaita | there is a cinder-tempest-plugin | 23:46 |
tosky | that's for tempest | 23:46 |
tosky | I guess the question is the glance part | 23:46 |
tosky | I mean, that's the problem with the former "core" projects: while newer projects have their own devstack plugin, the core ones generally rely on devstack | 23:47 |
rosmaita | we live a privileged life as part of the "dirty six" | 23:47 |
lbragstad | so - these tests are for tempest? | 23:48 |
tosky | no | 23:48 |
tosky | the tests are for cinder-tempest-plugin | 23:48 |
lbragstad | they are technically protection tests implemented using tempest | 23:48 |
lbragstad | but yea - they live in cinder-tempest-plugin | 23:48 |
tosky | ok | 23:49 |
tosky | so the problem is: how to configure cinder to enforce the new defaults? The only place is devstack | 23:49 |
tosky | the problem is not point 2.) from your list above, just point 1.) | 23:49 |
lbragstad | ok - so just configuring cinder to enforce scope | 23:50 |
lbragstad | if i can do that in .zuul.conf with test-config in devstack hooks, is that fine? | 23:50 |
tosky | if you add code to devstack, you don't need any changes to the jobs | 23:50 |
lbragstad | and that would live in openstack/cinder's .zuul.yaml file? | 23:50 |
lbragstad | i'm not convinced i need to add anything to devstack, yet | 23:51 |
tosky | so why did you try to change cinderlib? | 23:51 |
lbragstad | because i was investigating things :) | 23:51 |
tosky | this is the change: https://review.opendev.org/c/openstack/cinderlib/+/772770/3/devstack/plugin.sh | 23:52 |
lbragstad | i've started looking at things more closely after your comments, but i want to make sure the approach i take is agreed upon | 23:52 |
tosky | I guess gmann and masayukig need to chime in | 23:53 |
tosky | if it was up to me, I would add some central configuration to devstack to enable the "policy enforcement mode" (part of configure_protection_tests is really common for most of the services) | 23:55 |
lbragstad | tosky to be clear - it doesn't really matter to me where it lives, i'd just like to get some testing in place is all (i certainly don't want to me mistaken for saying it must live in cinderlib because that's where I proposed the first patch) | 23:55 |
tosky | and configure_enforce_scope may be a function defined for each service, whose implementation should live in devstack for the 6 and on each devstack plugin for the others | 23:55 |
rosmaita | i think tosky is right, that kind of stuff you have in the cinderlib patch is usually seen in lib/cinder in devstach | 23:56 |
lbragstad | ok | 23:56 |
rosmaita | but he's also right that gmann and masayukig are probably the best references here | 23:57 |
lbragstad | ok - i'll see if i can hack something in to place and get something working, but i imagine it'll change | 23:57 |
lbragstad | i just don't really want to wait anymore to get some tests written | 23:57 |
lbragstad | especially this late in the cycle | 23:57 |
rosmaita | agreed | 23:57 |
rosmaita | i have to grab dinner and do an errand, will look over your patches in cinder later | 23:58 |
tosky | sure; but then just through that cinderlib patch directly into devstack, even if it's a WIP and it's going to change | 23:58 |
lbragstad | yep - makes sense | 23:58 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!