| *** brinzhang has joined #openstack-cinder | 00:17 | |
| opendevreview | Keigo Noha proposed openstack/cinder master: Add libcgroup related packages in bindep.txt https://review.opendev.org/c/openstack/cinder/+/795009 | 00:45 |
|---|---|---|
| opendevreview | Keigo Noha proposed openstack/cinder master: Add libcgroup related packages in bindep.txt https://review.opendev.org/c/openstack/cinder/+/795009 | 00:45 |
| *** bhagyashris_ has joined #openstack-cinder | 01:01 | |
| *** bhagyashris has quit IRC | 01:09 | |
| *** felipe_rodrigues has quit IRC | 01:11 | |
| *** zenkuro has quit IRC | 02:03 | |
| *** brinzhang_ has joined #openstack-cinder | 02:51 | |
| *** brinzhang has quit IRC | 02:52 | |
| opendevreview | Rajat Dhasmana proposed openstack/cinder master: Add user messages for backup operations https://review.opendev.org/c/openstack/cinder/+/786627 | 03:22 |
| *** carloss has quit IRC | 03:29 | |
| *** opendevreview has quit IRC | 04:26 | |
| *** vishalmanchanda has joined #openstack-cinder | 04:39 | |
| *** abhishekk has joined #openstack-cinder | 04:55 | |
| *** brinzhang0 has joined #openstack-cinder | 05:05 | |
| *** brinzhang_ has quit IRC | 05:12 | |
| *** opendevreview has joined #openstack-cinder | 05:59 | |
| opendevreview | Rajat Dhasmana proposed openstack/cinder master: Implement project personas for volume API https://review.opendev.org/c/openstack/cinder/+/760199 | 05:59 |
| *** bhagyashris_ is now known as bhagyashris | 06:08 | |
| *** elodilles is now known as elodilles_pto | 07:55 | |
| *** Luzi has joined #openstack-cinder | 07:55 | |
| *** martinkennelly has joined #openstack-cinder | 07:59 | |
| *** martinkennelly_ has joined #openstack-cinder | 07:59 | |
| *** sfernand has quit IRC | 08:06 | |
| *** luksky has joined #openstack-cinder | 08:14 | |
| *** tosky has joined #openstack-cinder | 08:39 | |
| *** brinzhang_ has joined #openstack-cinder | 09:11 | |
| *** brinzhang0 has quit IRC | 09:17 | |
| *** abhishekk has quit IRC | 09:27 | |
| *** carloss has joined #openstack-cinder | 10:36 | |
| *** manoj_katari has joined #openstack-cinder | 10:42 | |
| *** amar7ibm has joined #openstack-cinder | 10:47 | |
| geguileo | whoami-rajat: I added comments to your backup user messages patch, but didn't vote, as we may have to discuss things in the IRC meeting | 11:06 |
| geguileo | whoami-rajat: sorry for driving you crazy with the patch, but I think we may need to make it more clear in our docs/code the level of detail we want to provide in the user messages | 11:07 |
| *** zenkuro has joined #openstack-cinder | 11:08 | |
| *** agarwchh has joined #openstack-cinder | 11:11 | |
| agarwchh | eharney: request the review for the initial draft of this proposed feature https://review.opendev.org/c/openstack/cinder-specs/+/792722 | 11:12 |
| yoctozepto | hello cinder team, may I bring your attention to this simple patch related to QA ~> https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/795159 (centos-8-stream migration) | 11:13 |
| opendevreview | Tobias Urdin proposed openstack/cinder master: Add backup_swift_create_storage_policy config opt https://review.opendev.org/c/openstack/cinder/+/761113 | 11:13 |
| *** gksk has joined #openstack-cinder | 11:15 | |
| *** gksk has left #openstack-cinder | 11:16 | |
| opendevreview | Tobias Urdin proposed openstack/cinder master: Add backup_swift_create_storage_policy config opt https://review.opendev.org/c/openstack/cinder/+/761113 | 11:16 |
| whoami-rajat | geguileo: thanks. i saw your comments and i was also looking into similar lines of something that could allow us to pass less parameters to create messages (since there are many now) | 11:18 |
| tobias-urdin | geguileo: abishop thanks for feedback, all changes fixed in ^ | 11:18 |
| whoami-rajat | geguileo: i like your idea if the implementation doesn't turn out to be very complicated | 11:18 |
| *** hemna3 has joined #openstack-cinder | 11:19 | |
| *** hemna has quit IRC | 11:25 | |
| *** hemna3 is now known as hemna | 11:25 | |
| geguileo | whoami-rajat: glad you liked it, now we just have to decide what's the level of detail we want to provide users | 11:42 |
| opendevreview | Walt proposed openstack/cinder master: Rework backup process to make it async https://review.opendev.org/c/openstack/cinder/+/784477 | 12:05 |
| hemna | should be working unit tests now ^^ | 12:06 |
| whoami-rajat | geguileo: i think the idea is to keep it simple so an end user can understand it without providing detail of internal parameters used? that's why i tried to write simple messages but i can modify for better suggestions | 12:06 |
| hemna | *should* | 12:06 |
| geguileo | hemna: awesome! | 12:06 |
| hemna | I'd love to get this in | 12:07 |
| geguileo | whoami-rajat: yeah, simple messages are good, but in your patch we have a good example of deciding what granurality we want to keep | 12:07 |
| geguileo | whoami-rajat: should we differentiate between failing on attach/detach and when on the upload itself? | 12:08 |
| whoami-rajat | geguileo: i like the idea of more user messages (except that it makes the code hard to read) since we can easily differentiate which part has the issue. ex: for the upload we know backup driver has issue and for attach/detach we know it's somewhere in cinder driver or os-brick. I think apart from end users it might benefit the operators (so they know what specifically to search in logs) and developers (atleast | 12:12 |
| whoami-rajat | myself :D) | 12:12 |
| geguileo | yes, I think it's very useful | 12:13 |
| geguileo | and if we do the context thingy I mention we can make the code cleaner, since managers use common code to attach/detach | 12:13 |
| geguileo | and we can look at other patters such as having a context manager instead of a try ... except clause in cojunction with the context thingy to make the code more readable | 12:14 |
| whoami-rajat | yep, i wanted to make it simpler but had no idea how to, i will try to implement your idea | 12:14 |
| whoami-rajat | yeah, try except for every user message is the saddest thing to implement :/ | 12:15 |
| whoami-rajat | geguileo: also i remember we cancelled the weekly meeting tomorrow | 12:15 |
| whoami-rajat | geguileo: since Brian isn't around | 12:15 |
| geguileo | oh, right, forgot :-( | 12:16 |
| geguileo | maybe we can just ping people tomorrow here and see what they think | 12:16 |
| geguileo | probably a context manager can really help with that pattern | 12:16 |
| geguileo | the easier we make it to add messages, the more messages we'll end up having | 12:17 |
| whoami-rajat | yep, i will try to work on a demo implementation, it will also make it easier for others to decide if it's the right way or not? | 12:19 |
| *** GirishChilukuri has joined #openstack-cinder | 12:35 | |
| *** enriquetaso has joined #openstack-cinder | 12:46 | |
| *** sfernand has joined #openstack-cinder | 12:49 | |
| *** admin1 has joined #openstack-cinder | 13:04 | |
| admin1 | hi all .. if i have cinder backed by ceph, is it possible to extend an existing volume ? | 13:04 |
| admin1 | its the resize option i think .. just checking if there is anything to note on it | 13:05 |
| yoctozepto | admin1: yeah, it works fine | 13:15 |
| yoctozepto | cinder extend <id> <new-size-in-gb> | 13:15 |
| yoctozepto | not sure about how it's called in the openstack client | 13:15 |
| *** nahimsouza has joined #openstack-cinder | 13:23 | |
| *** abhishekk has joined #openstack-cinder | 13:34 | |
| *** elodilles_pto has quit IRC | 13:41 | |
| *** elodilles has joined #openstack-cinder | 13:43 | |
| *** amar7ibm has quit IRC | 13:52 | |
| *** amar7ibm has joined #openstack-cinder | 13:52 | |
| *** Luzi has quit IRC | 13:58 | |
| *** vishalmanchanda has quit IRC | 14:18 | |
| *** brinzhang0 has joined #openstack-cinder | 14:30 | |
| *** brinzhang_ has quit IRC | 14:36 | |
| tosky | if any other core is around, please urgently vote/approve this cinder-tempest-plugin patch which switches the centos-8 job to centos-8-stream, as it's blocking the global removal of centos-8 (non-stream) jobs | 14:40 |
| tosky | https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/795159/ | 14:40 |
| yoctozepto | thanks, tosky | 14:41 |
| *** amar7ibm has quit IRC | 14:54 | |
| *** amar7ibm has joined #openstack-cinder | 14:59 | |
| *** amar_ has joined #openstack-cinder | 15:21 | |
| *** amar_ has quit IRC | 15:23 | |
| *** amar_ has joined #openstack-cinder | 15:25 | |
| *** amar7ibm has quit IRC | 15:27 | |
| *** whoami-rajat has quit IRC | 15:46 | |
| *** GirishChilukuri has quit IRC | 15:56 | |
| *** amar_ has quit IRC | 16:03 | |
| *** amar_ has joined #openstack-cinder | 16:10 | |
| *** GirishChilukuri has joined #openstack-cinder | 16:16 | |
| *** GirishChilukuri has quit IRC | 16:26 | |
| *** akekane_ has joined #openstack-cinder | 16:34 | |
| *** akekane_ has quit IRC | 16:35 | |
| *** amar_ is now known as amar7ibm | 16:37 | |
| *** abhishekk has quit IRC | 16:41 | |
| *** fabiooliveira has joined #openstack-cinder | 16:50 | |
| opendevreview | Eric Harney proposed openstack/cinder master: Snapshot in-use volumes without force flag https://review.opendev.org/c/openstack/cinder/+/789564 | 17:34 |
| opendevreview | Eric Harney proposed openstack/cinder master: mypy: annotate volume/api.py https://review.opendev.org/c/openstack/cinder/+/733622 | 17:39 |
| opendevreview | Eric Harney proposed openstack/cinder master: mypy: image_utils https://review.opendev.org/c/openstack/cinder/+/774286 | 17:47 |
| *** manoj_katari has quit IRC | 18:15 | |
| *** manoj_katari has joined #openstack-cinder | 18:35 | |
| *** amar7ibm has quit IRC | 18:39 | |
| *** amar7ibm has joined #openstack-cinder | 18:40 | |
| *** amar7ibm has quit IRC | 18:42 | |
| *** manoj_katari has quit IRC | 18:43 | |
| *** agarwchh has quit IRC | 20:06 | |
| *** brinzhang_ has joined #openstack-cinder | 20:41 | |
| *** brinzhang0 has quit IRC | 20:47 | |
| *** luksky has quit IRC | 22:10 | |
| *** nahimsouza has quit IRC | 22:15 | |
| *** fabiooliveira has quit IRC | 22:20 | |
| *** enriquetaso has quit IRC | 22:55 | |
| *** enriquetaso has joined #openstack-cinder | 22:58 | |
| *** tosky has quit IRC | 23:03 | |
| *** enriquetaso has quit IRC | 23:51 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!