Monday, 2021-07-19

opendevreviewKeigo Noha proposed openstack/cinder stable/wallaby: Add libcgroup related packages in bindep.txt
-opendevstatus- NOTICE: The maintenance of the Gerrit service is now complete and service has been restored. Please alert us in #opendev if you have any issues. Thank you03:26
opendevreviewGirish Chilukuri proposed openstack/cinder master: [SVF]:Fix multiple lshost calls during attach.
*** akekane_ is now known as abhishekk07:07
opendevreviewTushar Trambak Gite proposed openstack/cinder master: Doc: api-ref doc update
zoharmHi geguileo and all!10:02
zoharmI would like to double check if it is ok to move nvmeof connector "replicated+" methods into os_brick/privileged/ - replacing self._execute() with rootwrap.custom_execute() - as part of upcoming "addition of nvmeof agent" review that I will submit?10:02
geguileozoharm: sorry, I'm a bit out of touch with that.  Why is there a need to move the methods?10:04
zoharmgeguileo: for the nvmeof agent (a console script) to be able to import and use them10:05
geguileozoharm: but is that new code or existing code?  why can't the script import the code if it's not there?10:06
zoharmgeguileo: those methods do "self._execute()" which requires a "self" object first param with a "_execute" method which i could not figure out how to do from the console script in an "openstack way"10:08
zoharmother users of os-brick are openstack services which pass the correct object10:09
zoharmthe methods i want to move are the "new" nvmeof code from the last cycle10:10
zoharmthe code i added back then with all your help :)10:11
geguileois all that code privileged?10:11
zoharmi will only move the priviliged code10:11
zoharmall the nvmeof stuff that needs to be accessed by the connector or agent is priviliged10:12
geguileozoharm: moving it sounds reasonable to me10:14
geguileothanks for the clarification10:14
zoharmgeguileo: thank you! all those methods only do "self._execute()" (only priviliged) which just ends up doing the rootwrap thing anyway. additionally, i would like to treat those "sub" methods as a library, and leave only the "top level API" of the connector (ie. connect/disconnect/extend)10:18
zoharmso it cleans up a lot for me too, i got the inspiration from your /etc/nvme/hostnqn fix :)10:18
walshh_Hi all, could someone take a look at when they get a chance.   Its a small change with clean CI.  Thank you15:14
opendevreviewHelen Walsh proposed openstack/cinder master: PowerMax Driver - Fix for renaming GVG
opendevreviewStephen Finucane proposed openstack/cinder master: db: Remove 'db_driver' option
opendevreviewStephen Finucane proposed openstack/cinder master: db: Remove 'db' argument from various managers
opendevreviewStephen Finucane proposed openstack/cinder master: WIP: db: Remove 'self.db' from most code paths
simondodsleyCan I get a +2 and +W for
simondodsleyI'm also looking for some +2s on
opendevreviewMerged openstack/cinder master: [Pure Storage] Fix CG cloning crash when very long volume names
opendevreviewSimon Dodsley proposed openstack/cinder stable/wallaby: [Pure Storage] Fix CG cloning crash when very long volume names
rosmaitasimondodsley: left a question for you on 21:22

Generated by 2.17.2 by Marius Gedminas - find it at!