*** bhagyashris_ is now known as bhagyashris | 05:39 | |
opendevreview | Girish Chilukuri proposed openstack/cinder-specs master: Replication disable reason for replication backend https://review.opendev.org/c/openstack/cinder-specs/+/804204 | 06:26 |
---|---|---|
opendevreview | 江治林 proposed openstack/cinder master: when backend is not support consistency group, creating generic group is successful https://review.opendev.org/c/openstack/cinder/+/802669 | 07:09 |
opendevreview | 江治林 proposed openstack/cinder master: when backend is not support consistency group, creating generic group is successful https://review.opendev.org/c/openstack/cinder/+/802669 | 07:15 |
opendevreview | yangheng proposed openstack/cinder master: Support Cinder FC driver for TOYOU NetStor https://review.opendev.org/c/openstack/cinder/+/803000 | 07:24 |
opendevreview | yangheng proposed openstack/cinder master: Support Cinder FC driver for TOYOU NetStor https://review.opendev.org/c/openstack/cinder/+/803000 | 10:02 |
opendevreview | 江治林 proposed openstack/cinder master: when backend is not support consistency group, creating generic group is successful https://review.opendev.org/c/openstack/cinder/+/802669 | 10:05 |
opendevreview | katari manoj kumar proposed openstack/cinder master: [SVF]:Fix create volume on drp https://review.opendev.org/c/openstack/cinder/+/787115 | 10:44 |
admin1 | hi all.. I have 2 ceph pools .. and 2 cinder backends . but when i create volumes, it only goes to 1 backend .. Here is my ceph.conf config and the ceph pools .. https://pastebin.com/imQ8LawX | 11:31 |
*** dviroel|out is now known as dviroel | 11:32 | |
opendevreview | Eric Harney proposed openstack/cinder master: mypy: continued manager, scheduler, rpcapi https://review.opendev.org/c/openstack/cinder/+/784453 | 12:41 |
opendevreview | katari manoj kumar proposed openstack/cinder master: [SVF]:Fix create volume on drp https://review.opendev.org/c/openstack/cinder/+/787115 | 13:28 |
manoj_katari | @core team: could you please review https://review.opendev.org/c/openstack/cinder/+/784092 which is in review for a long time. Thanks in advance! | 13:36 |
rosmaita | @manoj_katari: would be helpful if you could review some non-ibm/svf patches yourself, will show good community spirit and motivate people to review your work: https://review.opendev.org/q/reviewedby:katkumar%2540in.ibm.com | 13:40 |
*** abhishekk is now known as akekane|home | 13:44 | |
*** akekane|home is now known as abhishekk | 13:44 | |
rosmaita | Courtesy reminder: Cinder meeting in #openstack-meeting-alt at 1400 UTC | 13:58 |
rosmaita | jungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard lseki sfernand rajinir enriquetaso hemna ^^ | 13:58 |
opendevreview | Vladislav Belogrudov proposed openstack/os-brick master: Add support for multiple volumes within subsystem to NVMe-OF connector https://review.opendev.org/c/openstack/os-brick/+/800014 | 15:01 |
enriquetaso | #startmeeting cinder_bs | 15:04 |
opendevmeet | Meeting started Wed Aug 11 15:04:01 2021 UTC and is due to finish in 60 minutes. The chair is enriquetaso. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:04 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:04 |
opendevmeet | The meeting name has been set to 'cinder_bs' | 15:04 |
enriquetaso | Welcome to the cinder bug meeting. | 15:04 |
enriquetaso | We have 3 new bugs reported this last week. Lucky two of them are low-hanging-fruit and are related to the cinder-tempest-plugin README. | 15:04 |
enriquetaso | #topic search and tag the nas_secure bugs | 15:04 |
enriquetaso | But first, regarding the cinder meeting earlier today, I need to drop this action item here to don't forget about it: | 15:04 |
enriquetaso | #action(enriquetaso) search and tag the nas_secure bugs, prepare this for next week's cinder meeting. | 15:04 |
enriquetaso | Example: | 15:04 |
enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1938196 | 15:04 |
enriquetaso | Full discussion: | 15:05 |
enriquetaso | #link https://meetings.opendev.org/meetings/cinder/2021/cinder.2021-08-11-14.01.log.html | 15:05 |
rosmaita | thanks, that will be really helpful in seeing how bad the situation is | 15:06 |
rosmaita | and hopefully find corner cases that should be addressed | 15:06 |
eharney | https://bugs.launchpad.net/cinder?field.searchtext=nas_secure shows 5 to start | 15:07 |
enriquetaso | cool | 15:07 |
enriquetaso | ha | 15:07 |
enriquetaso | OK, moving on | 15:07 |
enriquetaso | #topic bug_1 "[victoria] max_over_subscription_ratio set auto mode rbd backend will have a negative value" | 15:07 |
enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1938869 | 15:08 |
enriquetaso | Summary: If max_over_subscription_ratio is set to auto, c-sch doesn't allow the user to create volumes. | 15:08 |
enriquetaso | max_over_subscription_ratio = Representation of the over subscription ratio when thin provisioning is enabled. Default ratio is 20.0, meaning provisioned capacity can be 20 times of the total physical capacity. If the ratio is auto, Cinder will automatically calculate the ratio based on the provisioned capacity and the used space. If not set to auto, the ratio has to be a minimum of 1.0. | 15:08 |
enriquetaso | As the reporter is using the Victoria release I thought that It would be nice to reproduce this in master. I couldn't reproduce this.. so maybe this is a victoria only bug or I'm missing something. I left some comments in the bug report asking for more detailed steps information. | 15:08 |
eharney | we could put code in the manager/scheduler to detect when this situation happens (due to a driver bug or whatever) and at least push it back to a sensible value | 15:09 |
rosmaita | nice work, sofia, trying to reproduce | 15:09 |
rosmaita | more detailed info request sounds correct | 15:09 |
rosmaita | eharney: that strategy has a precedent in cinder, so probably not a bad idea | 15:10 |
enriquetaso | so, this is a possible scenario then | 15:10 |
enriquetaso | I'll add a note regarding this to the bug report | 15:11 |
eharney | well max_over_subscription_ratio being negative doesn't make sense | 15:11 |
rosmaita | well, always good to get more info | 15:11 |
eharney | but i'm a little unsure on the whole concept of why we have "auto" for it, too | 15:11 |
rosmaita | but eric is right, if we auto calculate, we should make sure we don't go negative | 15:11 |
rosmaita | i guess that would give you extra-thick volumes | 15:11 |
eharney | does "auto" give a behavior that someone actually wants? | 15:12 |
rosmaita | i dont' know ... sounds like cinder will compute whatever's necessary to jam the volume into the space that's there? | 15:12 |
eharney | i'm not sure about that | 15:13 |
rosmaita | yeah, me neither, but in general, it's probably not a good idea to let cinder figure this out for you | 15:13 |
rosmaita | i am afraid to look at what exactly is being computed | 15:14 |
Roamer` | hm, looking at the code (cinder/utils.py, calculate_max_over_subscription_ratio), it looks like there is a debug-level log message that would show how the negative value is derived from provisioned_capacity_gb, total_capacity_gb, and free_capacity_gb... maybe the reporter could retry this with verbose logging enabled and that would show them that Cinder cannot really do anything about it | 15:14 |
Roamer` | it seems, at least to me, that the calculation is, well, reasonable | 15:14 |
enriquetaso | #link https://opendev.org/openstack/cinder/src/branch/master/cinder/utils.py#L745 | 15:16 |
Roamer` | yeah, sorry about that, I should have posted the link, looking at the files locally here :( | 15:16 |
Roamer` | and thanks | 15:16 |
enriquetaso | #action(enriquetaso) ask the reporter the reason of using 'auto'?? and ask for more verbose logs and steps | 15:17 |
eharney | you'd be surprised how much confusion there has been about the math/logic involved in these calculations in the past, i'm hesitant to say any of it is reasonable without close examination :) | 15:17 |
enriquetaso | Roamer`++ | 15:17 |
Roamer` | ...it's more like https://opendev.org/openstack/cinder/src/branch/master/cinder/utils.py#L785 | 15:17 |
eharney | at any rate, it's probably unreasonable to compute something < 1.0 | 15:17 |
Roamer` | eharney, yeah, I get your point, ask me someday about figuring out which disks on which servers a new volume should be placed at :) or rather don't :) ...and yeah, maybe an explicit check for < 1 and returning a "nope, don't even think about going there" answer would be better | 15:18 |
Roamer` | although the end result is the same | 15:18 |
enriquetaso | OK.. moving on | 15:20 |
enriquetaso | #topic bug_2 "Add/remove things to cinder-tempest-plugin README" | 15:20 |
enriquetaso | #link https://bugs.launchpad.net/cinder-tempest-plugin/+bug/1939325 | 15:20 |
enriquetaso | #link https://bugs.launchpad.net/cinder-tempest-plugin/+bug/1939322 | 15:20 |
enriquetaso | The first bug report is to add placement service to README and the second: glance registry was deprecated in Queens and should be removed from README. | 15:21 |
eharney | why do we need to add placement-api to local conf for the tempest plugin? | 15:21 |
eharney | that doesn't sound right | 15:21 |
rosmaita | i think maybe nova won't work without it? | 15:22 |
eharney | then devstack should be installing it for nova anyway? | 15:22 |
eharney | i mean we don't have to write a config enabling the nova service, right? | 15:23 |
rosmaita | you'd think, unless it's only needed for some configurations, i guess | 15:23 |
Roamer` | devstack does include it in the default set of services (unless that is overridden) | 15:23 |
enriquetaso | good question, all our current jobs enable it https://zuul.opendev.org/t/openstack/build/ef71a0bc0d6046e88b1404f4050bf4ac/log/controller/logs/_.localrc_auto.txt#26 | 15:23 |
eharney | this sounds like it isn't cinder-tempest-plugin's business | 15:23 |
enriquetaso | yes.. makes sense, the bug is invalid | 15:24 |
eharney | unless our tests actually require placement-api? | 15:24 |
eharney | i don't know | 15:25 |
rosmaita | i guess it depends on what exactly we are trying to say in the README | 15:25 |
enriquetaso | as far as I can see they don't but as I saw the placement-api in all the jobs I thought we need it | 15:25 |
rosmaita | https://opendev.org/openstack/cinder-tempest-plugin/src/branch/master/README.rst | 15:25 |
eharney | well then we need nova and glance and all kinds of other stuff too... | 15:25 |
eharney | oh, it's because we aren't just asking to enable some services, we are setting ENABLED_SERVICES to a specific list | 15:26 |
Roamer` | BTW it is actually also enabled in devstack's .zuul.yaml | 15:27 |
eharney | i would consider dropping that and just using enable_service for what we actually need | 15:27 |
rosmaita | hmm ... i dont' think there's a 'cinder' service | 15:27 |
Roamer` | at least the StorPool CI did not need to enable it explicitly, it was inherited from the "devstack" job | 15:28 |
Roamer` | #link https://opendev.org/openstack/devstack/src/branch/master/.zuul.yaml#L507 | 15:28 |
eharney | what we have listed in the sample config overrides anything that would be inherited | 15:29 |
enriquetaso | drop it and enable the necessary makes more sense | 15:29 |
rosmaita | here's the default set: https://opendev.org/openstack/devstack/src/branch/master/stackrc#L56-L83 | 15:30 |
Roamer` | hm... okay... so it's true that I've never actually tried overriding ENABLED_SERVICES explicitly, yeah, so eharney is right..... maybe what is in the Zuul config will also be ignored, not just what's in stackrc | 15:31 |
enriquetaso | #link https://opendev.org/openstack/devstack/src/branch/master/stackrc#L56-L83 | 15:32 |
rosmaita | well, i think for the README you can just remove the ENABLED_SERVICES lines | 15:32 |
Roamer` | so yeah, I may have been spoiled by SoftwareFactory's nice configuration :) | 15:33 |
rosmaita | looks like the only thing you really don't need is horizon | 15:33 |
enriquetaso | #action(enriquetaso) the bugs are not necessary, remove the ENABLED_SERVICES lines and disable horizon | 15:34 |
eharney | i don't know why we are specifying VIRT_DRIVER, or CINDER_VOLUME_CLEAR either... | 15:34 |
eharney | or LIBVIRT_FIREWALL_DRIVER? weird | 15:35 |
rosmaita | this was probably somebody's localrc that got copied in | 15:35 |
eharney | or SYSLOG, or... yeah | 15:35 |
rosmaita | we only say that it "should" work | 15:36 |
opendevreview | Luigi Toscano proposed openstack/cinder stable/wallaby: RBD: use correct stripe unit in clone operation https://review.opendev.org/c/openstack/cinder/+/804265 | 15:36 |
rosmaita | i guess maybe make this bug more general, something like "cleanup deployment suggestion in README" | 15:38 |
enriquetaso | that works for me... OK, we exceed the half an hour meeting | 15:38 |
enriquetaso | let me mention the last bug | 15:39 |
enriquetaso | #topic bug_3 "[IBM Storwize SVC]: use system_id in mkrelationship" | 15:39 |
enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1939145 | 15:39 |
enriquetaso | Finally, as far as I can see there's a couple IBM Storwize bugs and patches related to. Nothing else to add in this case. I left some comments asking for more information because as i see it, the bug it's incomplete, | 15:39 |
enriquetaso | that's all I have for today's meeting | 15:39 |
Roamer` | BTW, yeah, sorry, I'm not quite sure what the etiquette is... I reported a couple of trivial bugs on Monday, but I suppose those will be discussed next week? if so, then sorry, and anyway, thanks for all your work on the bugs! | 15:41 |
rosmaita | the storwize team has a bad habit of filing bugs saying what change they want to make, instead of explaining what error is being produced | 15:41 |
enriquetaso | Roamer`, could you send the links here? | 15:42 |
enriquetaso | rosmaita++ | 15:42 |
Roamer` | #link https://bugs.launchpad.net/cinder/+bug/1939242 | 15:42 |
Roamer` | ^^ I'm not really sure how Glance with multistore enabled could ever actually work without this fix | 15:42 |
enriquetaso | oh sorry, I forgot about them :/ | 15:43 |
Roamer` | #link https://bugs.launchpad.net/cinder/+bug/1939241 | 15:43 |
rosmaita | i think there's already a bug for the glance multistore | 15:43 |
eharney | hmm, 1939242 sounds familiar, was someone else fixing this a while ago? | 15:43 |
rosmaita | i think me, but got stalled | 15:43 |
Roamer` | ^^ this one is totally on me, I should have reported it as a bug back in April when our CI system found it (the StorPool driver overrides _attach_volume() unnecessarily, os-brick knows how to do that, and the result is that StorPool cannot mount encrypted volumes) | 15:43 |
enriquetaso | i think rajat fix something related to that | 15:43 |
enriquetaso | but he's on PTO today | 15:44 |
Roamer` | ("this one" was about 1939241) | 15:44 |
enriquetaso | #topic Glance with multistore bugs | 15:44 |
rosmaita | https://review.opendev.org/c/openstack/cinder/+/755654 | 15:44 |
enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1939242 | 15:44 |
enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1939241 | 15:44 |
enriquetaso | oh it was rosmaita sorry | 15:45 |
Roamer` | hmmmmm, yeah, 755654 is my fix done in the right way :) | 15:45 |
Roamer` | I mean, somebody else took the time to do it in the right way :) | 15:45 |
rosmaita | well, except i never finished, rajat wanted me to fix somethihng | 15:45 |
rosmaita | do you want to take it over? | 15:45 |
Roamer` | I can do that, yeah | 15:45 |
rosmaita | cool | 15:45 |
enriquetaso | Great | 15:46 |
enriquetaso | OK, i think that's all we have | 15:47 |
eharney | please close the new multistore bug as a dupe | 15:47 |
Roamer` | ahhh, right, I see rajat's comment, it makes sense... sure, I'll think about it | 15:47 |
Roamer` | and yes, I will close the new one | 15:47 |
enriquetaso | sure, need to search for the original bug report | 15:47 |
eharney | https://bugs.launchpad.net/cinder/+bug/1898075 | 15:48 |
Roamer` | @link https://bugs.launchpad.net/cinder/+bug/1898075 | 15:48 |
Roamer` | #link https://bugs.launchpad.net/cinder/+bug/1898075 | 15:48 |
enriquetaso | #action(enriquetaso) mark 1939242 as duplicate of 1898075 | 15:48 |
enriquetaso | thank you!! | 15:48 |
enriquetaso | excellent, any other topic for today? | 15:48 |
Roamer` | BTW just to make sure everything is clear: https://bugs.launchpad.net/cinder/+bug/1939241 is not about Glance multistore, it is a StorPool driver mess-up | 15:49 |
enriquetaso | thanks for point this bugs Roamer` not sure what happened there i forgot to tag them | 15:50 |
Roamer` | no worries, no worries at all, you're doing a lot of work! | 15:50 |
enriquetaso | #endmeeting | 15:51 |
opendevmeet | Meeting ended Wed Aug 11 15:51:03 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:51 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/cinder_bs/2021/cinder_bs.2021-08-11-15.04.html | 15:51 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cinder_bs/2021/cinder_bs.2021-08-11-15.04.txt | 15:51 |
opendevmeet | Log: https://meetings.opendev.org/meetings/cinder_bs/2021/cinder_bs.2021-08-11-15.04.log.html | 15:51 |
manoj_katari | @rosmaita @enriqutaso: Regarding Storwize bugs, can you share the details of bugs which doesn't explain the issue completely, now onwards, we will ensure to raise bugs with detailed information | 15:51 |
enriquetaso | manoj_katari, for example https://bugs.launchpad.net/cinder/+bug/1939145 | 15:52 |
enriquetaso | please check my last comment | 15:53 |
manoj_katari | Thanks sofia, problem is that bugs in storwize will be raised by different teams, infact the one you pointed above is raised by pVC (which is a fork of cinder) | 15:56 |
rosmaita | manoj_katari: what we're looking for is a bug report so that if an operator hits a problem, they can look and see if there's a bug | 15:56 |
rosmaita | "use system_id in mkrelationship" says what you're going to do to fix it, but it's not obvious where that surfaces as a problem | 15:56 |
enriquetaso | we used to have recommendations about what a bug report needs | 15:58 |
enriquetaso | https://wiki.openstack.org/wiki/BugFilingRecommendations | 15:58 |
manoj_katari | yes rosmaita, completely agree with you, this defect is explaining the fix rather than the actual issue. | 15:59 |
rosmaita | if you could try to communicate that back to the teams, that would be helpful | 16:00 |
manoj_katari | Thanks sofia, i will ensure that we follow this recommendations while reporting a bug. | 16:00 |
manoj_katari | Sure Rsomaita, i will cascade it to the teams | 16:00 |
rosmaita | thanks! | 16:00 |
enriquetaso | thanks! | 16:01 |
manoj_katari | @core: I have addressed all the review comments for this minor bug, https://review.opendev.org/c/openstack/cinder/+/787115 , please review it. | 16:09 |
opendevreview | Peter Penchev proposed openstack/cinder master: StorPool: drop _attach_volume() and _detach_volume() https://review.opendev.org/c/openstack/cinder/+/787296 | 16:14 |
opendevreview | Peter Penchev proposed openstack/cinder master: StorPool driver: remove the obsolete backup_volume() method https://review.opendev.org/c/openstack/cinder/+/803823 | 16:14 |
opendevreview | Peter Penchev proposed openstack/cinder master: StorPool driver: implement revert_to_snapshot https://review.opendev.org/c/openstack/cinder/+/680889 | 16:14 |
opendevreview | Peter Penchev proposed openstack/cinder master: StorPool: drop _attach_volume() and _detach_volume() https://review.opendev.org/c/openstack/cinder/+/787296 | 16:16 |
opendevreview | Peter Penchev proposed openstack/cinder master: StorPool driver: remove the obsolete backup_volume() method https://review.opendev.org/c/openstack/cinder/+/803823 | 16:16 |
opendevreview | Peter Penchev proposed openstack/cinder master: StorPool driver: implement revert_to_snapshot https://review.opendev.org/c/openstack/cinder/+/680889 | 16:16 |
*** dviroel is now known as dviroel|away | 16:19 | |
Roamer` | sfernand, thanks for the review on the _attach/_detach_volume drop! | 16:20 |
sfernand | yw :) | 16:20 |
zenkuro | ls | 16:22 |
zenkuro | rosmaita: sorry, here is a blueprint -> https://blueprints.launchpad.net/cinder/+spec/open-e-joviandss-minor-documentation-and-code-fixes | 16:43 |
amar_ | Hi enriquetaso, Could you pls have a look at this patch : https://review.opendev.org/c/openstack/cinder/+/790910. Hope the bug information is complete. ^ ^ | 16:44 |
opendevreview | Brian Rosmaita proposed openstack/cinder master: Test glance with cinder backend optimization https://review.opendev.org/c/openstack/cinder/+/757936 | 16:44 |
rosmaita | zenkuro: ty | 16:44 |
rosmaita | zenkuro: it should show up in https://blueprints.launchpad.net/cinder/xena now | 16:46 |
zenkuro | rosmaita: thanks! | 16:48 |
venkatakrishnat | Hi enriquetaso, eharney, hemna, Waiting for workflow +2 for https://review.opendev.org/c/openstack/cinder/+/774594 . This patch is to provide volume-extend support to Hyperswap volume on the IBM svc cinder driver. | 16:49 |
zenkuro | 5~ | 17:21 |
venkatakrishnat | Hi jungleboyj, rosmaita, could you please review the following patches for IBM SVC cinder driver https://review.opendev.org/c/openstack/cinder/+/786524 https://review.opendev.org/c/openstack/cinder/+/784140 | 17:42 |
venkatakrishnat | the former one to manage volumes on separate storage pools & later one to fix Extend Issue for Mirroring volumes | 17:42 |
opendevreview | Benny Kopilov proposed openstack/cinder-tempest-plugin master: Rename cinder plugin config option variable https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/801603 | 18:06 |
opendevreview | Eric Harney proposed openstack/cinder master: Tests: Split test_create_snapshot_force into two tests https://review.opendev.org/c/openstack/cinder/+/804293 | 18:57 |
*** dviroel|away is now known as dviroel | 19:09 | |
opendevreview | saikrishnagk proposed openstack/cinder master: [SVF]: Get RCCG State of a Group https://review.opendev.org/c/openstack/cinder/+/800431 | 19:09 |
gksk | To the Core reviewers pls review the below patch related to update rep properties fix for empty values | 19:13 |
gksk | https://review.opendev.org/c/openstack/cinder/+/801617/2 | 19:13 |
gksk | To the core reviewers pls review the below patch related to get rccg state of a group | 19:14 |
gksk | https://review.opendev.org/c/openstack/cinder/+/800431 | 19:14 |
opendevreview | Eric Harney proposed openstack/cinder master: Snapshot in-use volumes without force flag https://review.opendev.org/c/openstack/cinder/+/789564 | 19:25 |
opendevreview | Brian Rosmaita proposed openstack/cinder master: Turn off inline comments for mypy zuul job https://review.opendev.org/c/openstack/cinder/+/804294 | 19:26 |
opendevreview | Eric Harney proposed openstack/cinder master: mypy: filter scheduler https://review.opendev.org/c/openstack/cinder/+/788365 | 19:44 |
opendevreview | Fábio Oliveira proposed openstack/cinder master: NetApp Solidfire: Fix duplicate volume name exception https://review.opendev.org/c/openstack/cinder/+/804296 | 19:45 |
*** dviroel is now known as dviroel|ruck | 20:35 | |
*** dviroel|ruck is now known as dviroel|ruck|out | 21:46 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!