| opendevreview | zhaoleilc proposed openstack/cinder master: Modify erroneous annotation https://review.opendev.org/c/openstack/cinder/+/805916 | 00:15 |
|---|---|---|
| opendevreview | zhaoleilc proposed openstack/cinder master: Erroneous log location causes a misconception https://review.opendev.org/c/openstack/cinder/+/790014 | 00:48 |
| opendevreview | Merged openstack/cinder stable/wallaby: Support Images API v2.11 https://review.opendev.org/c/openstack/cinder/+/805877 | 02:25 |
| opendevreview | GirishIBM proposed openstack/cinder master: [SVF]:Fix multiple lshost calls during attach. https://review.opendev.org/c/openstack/cinder/+/772623 | 03:59 |
| opendevreview | Rajat Dhasmana proposed openstack/cinder master: Add user messages for backup operations https://review.opendev.org/c/openstack/cinder/+/786627 | 04:36 |
| opendevreview | Merged openstack/cinder stable/train: NFS: Update connection info on online snap create https://review.opendev.org/c/openstack/cinder/+/802048 | 06:20 |
| opendevreview | Rajat Dhasmana proposed openstack/cinder master: WIP: Add support for qcow2 image optimization in glance cinder config https://review.opendev.org/c/openstack/cinder/+/805949 | 06:34 |
| *** akekane_ is now known as abhishekk | 08:19 | |
| opendevreview | Venkata krishna Thumu proposed openstack/cinder master: [SVF] Update rccg details for mirror volumes https://review.opendev.org/c/openstack/cinder/+/788782 | 08:52 |
| stephenfin | Morning o/ Friendly reminder that the remove-sqlalchemy-migrate series is still available and needs another reviewer. Nova closed out the effort last week \o/ https://review.opendev.org/q/topic:%2522bp/remove-sqlalchemy-migrate%2522+project:openstack/cinder | 09:04 |
| whoami-rajat | stephenfin, hey, can you take a look at my comment and see if it makes sense? https://review.opendev.org/c/openstack/cinder/+/786928 | 09:16 |
| stephenfin | whoami-rajat: sure | 09:17 |
| stephenfin | whoami-rajat: Replied. tl;dr: I think it's necessary and I _could_ check to prove it, but I don't think it's not a big issue in any case and it could easily be addressed in a follow-up if necessary | 09:21 |
| stephenfin | so I'd be tempted to plough on, get this merged before M3 and then tidy it up after | 09:22 |
| stephenfin | if that's okay? | 09:22 |
| whoami-rajat | stephenfin, sounds good, +W | 09:25 |
| stephenfin | ty! | 09:25 |
| whoami-rajat | stephenfin, also i had a doubt with the initial refactor patch, the sqlalchemy docs mention the type of import we're currently using, wanted to know if it's required for alembic work? https://review.opendev.org/c/openstack/cinder/+/786927 | 09:30 |
| stephenfin | whoami-rajat: It's certainly not mandatory, no. The reason I did that was because it was done in nova and I wanted to keep things as similar as possible to make reviewing easier (nova people could look at the cinder patches and vice versa) | 09:34 |
| stephenfin | and it was done in nova because we did a lot of refactoring of the nova.db module, and importing modules rather than objects resulted in smaller, more sensible imports and less chance of conflicts as the refactoring happened | 09:35 |
| stephenfin | I _could_ strip it out, but it's going to result in a huge merge conflicts that will be very tedious to resolve. I'll also lose the +2s I have higher up the series. Given it's not wrong and it is kept separate from more functional changes, I'd like to keep it if at all possible | 09:36 |
| whoami-rajat | yeah for cinder we've few imports that doesn't seem to be conflicting much with sa imports so i was confused, although it makes sense to import modules instead of classes for clarity (not sure why sqlalchemy docs doesn't mention it that way) and since smcginnis and eharney already voted so i won't object to it | 09:38 |
| stephenfin | 🙏 thanks, I really did not want to do that horrible rebase 😅 | 09:39 |
| stephenfin | I suspect the sqlalchemy docs (and sqlalchemy) don't use the "Do not import objects, only modules" rule from hacking like we do, though tbf sqlalchemy is one of the few exceptions carved out for whatever reason https://docs.openstack.org/hacking/latest/user/hacking.html#imports | 09:40 |
| stephenfin | anyway, keep the questions coming :) | 09:41 |
| whoami-rajat | stephenfin, np, thanks for your work on this | 09:43 |
| *** dviroel|ruck|afk is now known as dviroel|ruck | 10:59 | |
| opendevreview | Merged openstack/cinder master: db: Use 'import sqlalchemy as sa' pattern https://review.opendev.org/c/openstack/cinder/+/786927 | 11:04 |
| opendevreview | Merged openstack/cinder master: db: Reorder initial migration https://review.opendev.org/c/openstack/cinder/+/786928 | 11:18 |
| enriquetaso | rosmaita, do we support stein? | 13:34 |
| smcginnis | Stein is currently in extended maintenance: https://opendev.org/openstack/releases/src/branch/master/deliverables/stein/cinder.yaml#L66 | 13:36 |
| smcginnis | Though not sure if there have been any discussions to move to EOL. | 13:36 |
| rosmaita | enriquetaso: it's in extended maintenance, so we don't release from it any more, fixes get backported ... maybe | 13:36 |
| rosmaita | i think the oldest EOL branch is pike | 13:37 |
| rosmaita | we were a bit ahead on that , but i think pike is EOL in most projects at this point (not sure though) | 13:37 |
| tosky | before EOLing stein, we should EOL queens and rocky | 13:37 |
| tosky | (or all a the same time) | 13:37 |
| tosky | rosmaita: well, I wish it was, but ocata finally transitioned to EOL not long ago (days, maybe a few weeks) | 13:38 |
| opendevreview | Merged openstack/cinder stable/victoria: Fix PowerFlex volume type conversion https://review.opendev.org/c/openstack/cinder/+/790839 | 13:38 |
| rosmaita | tosky: ok, thanks ... at least pike is EOL for cinder! | 13:38 |
| tosky | uhm, no, ocata EOL-ingis still onging (just seen a message on #openstack-release) | 13:39 |
| rosmaita | ok, that's good to know | 13:48 |
| opendevreview | Gorka Eguileor proposed openstack/cinder master: 3PAR: Fix race in concurrent attachments https://review.opendev.org/c/openstack/cinder/+/756711 | 13:50 |
| rosmaita | Early reminder: today's cinder meeting is on video + #openstack-meeting-alt at 1400 UTC | 13:56 |
| rosmaita | connection info: https://bluejeans.com/3228528973 | 13:56 |
| rosmaita | jungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard sfernand enriquetaso hemna ^^ | 13:56 |
| enriquetaso | thanks | 13:57 |
| jungleboyj | rosmaita: Thanks. Will join as soon as I can. | 14:01 |
| tosky | same | 14:04 |
| opendevreview | Eric Harney proposed openstack/cinder master: Tests: Remove brick_lvm mocks from all unit tests https://review.opendev.org/c/openstack/cinder/+/806005 | 14:21 |
| enriquetaso | whoami-rajat++ | 14:21 |
| venkatakrishnat | Hi eharney, geguileo, jungleboyj, rosmaita, whoami-rajat: Could you please review https://review.opendev.org/c/openstack/cinder/+/786524 which is to manage Global mirror change volumes on separate storage pools on IBM SVC cinder driver. This patch got one CR +2 and waiting for workflow +2 | 14:21 |
| *** lbragstad_ is now known as lbragstad | 14:39 | |
| enriquetaso | #startmeeting cinder_bs | 14:54 |
| opendevmeet | Meeting started Wed Aug 25 14:54:30 2021 UTC and is due to finish in 60 minutes. The chair is enriquetaso. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:54 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:54 |
| opendevmeet | The meeting name has been set to 'cinder_bs' | 14:54 |
| enriquetaso | Full list of bugs: | 14:54 |
| enriquetaso | #link http://lists.openstack.org/pipermail/openstack-discuss/2021-August/024431.html | 14:54 |
| rosmaita | o/ | 14:54 |
| enriquetaso | #topic bug_1 [oslo.utils] Usage of human output is deprecated in QemuImgInfo | 14:54 |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1940540 | 14:54 |
| enriquetaso | Takashi proposed a fix for this, please feel free to review it | 14:55 |
| enriquetaso | #link https://review.opendev.org/c/openstack/cinder/+/799663 | 14:55 |
| enriquetaso | #topic bug_2 [os-brick] flush failed when both host and vm use lvm the multipath | 14:55 |
| enriquetaso | #link https://bugs.launchpad.net/os-brick/+bug/1940608 | 14:55 |
| opendevreview | Eric Harney proposed openstack/cinder stable/victoria: LVM: Retry lvextend commands on code 139 https://review.opendev.org/c/openstack/cinder/+/805825 | 14:56 |
| opendevreview | Eric Harney proposed openstack/cinder stable/victoria: LVM: Use --readonly for lvdisplay in lv_has_snapshot https://review.opendev.org/c/openstack/cinder/+/806007 | 14:56 |
| opendevreview | Eric Harney proposed openstack/cinder stable/victoria: LVM: Retry lvdisplay and lvcreate calls on segfault https://review.opendev.org/c/openstack/cinder/+/806008 | 14:56 |
| enriquetaso | #topic bug_3 cinder-manage commands crash during db sync | 15:00 |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1941068 | 15:00 |
| enriquetaso | #topic bug_4 Tests: Swift + S3 backup driver unit tests fail w/ RunTimeError | 15:04 |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1941011 | 15:04 |
| enriquetaso | #topic bug_5 [Stein] Multipathd delivers wrong path to Cinder | 15:07 |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1940859 | 15:07 |
| enriquetaso | #topic bug_6 [Doc] Cinder retype installation is missing nova config | 15:08 |
| *** abhishekk is now known as akekane|home | 15:08 | |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1941062 | 15:08 |
| *** akekane|home is now known as abhishekk | 15:08 | |
| opendevreview | Merged openstack/cinder stable/ussuri: PowerMax Driver - Fix for create snapshot https://review.opendev.org/c/openstack/cinder/+/805477 | 15:10 |
| opendevreview | efineshi proposed openstack/os-brick master: flush failed when both host and vm use lvm the multipath https://review.opendev.org/c/openstack/os-brick/+/806009 | 15:14 |
| enriquetaso | #endmeeting | 15:15 |
| opendevmeet | Meeting ended Wed Aug 25 15:15:59 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:15 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cinder_bs/2021/cinder_bs.2021-08-25-14.54.html | 15:15 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cinder_bs/2021/cinder_bs.2021-08-25-14.54.txt | 15:15 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cinder_bs/2021/cinder_bs.2021-08-25-14.54.log.html | 15:15 |
| rosmaita | thanks, sofia! | 15:16 |
| opendevreview | Eric Harney proposed openstack/cinder master: Change 'host' option from HostAddressOpt to StrOpt https://review.opendev.org/c/openstack/cinder/+/806010 | 15:16 |
| enriquetaso | thanks you rosmaita | 15:16 |
| opendevreview | Gorka Eguileor proposed openstack/cinder master: Change the host config option type https://review.opendev.org/c/openstack/cinder/+/806011 | 15:19 |
| sfernand | if some core could take a look on netapp feature patches :) We are quite desperate for community reviews. | 15:20 |
| sfernand | https://blueprints.launchpad.net/cinder/+spec/ontap-storage-assisted-migration | 15:20 |
| sfernand | https://blueprints.launchpad.net/cinder/+spec/ontap-revert-to-snapshot | 15:20 |
| sfernand | https://blueprints.launchpad.net/cinder/+spec/ontap-report-provisioned-capacity | 15:20 |
| sfernand | Also,I have some time to work on review so send me a message if needed. I'm not able to give a +2 but can antecipate some issues | 15:20 |
| geguileo | eharney: you were faster than me... | 15:20 |
| eharney | geguileo: oh oops | 15:20 |
| geguileo | on the string patch, though mine has the release note | 15:20 |
| geguileo | lol | 15:20 |
| geguileo | eharney: add the release note and I'll abandon mine | 15:20 |
| opendevreview | Eric Harney proposed openstack/cinder master: Change 'host' option from HostAddressOpt to StrOpt https://review.opendev.org/c/openstack/cinder/+/806010 | 15:33 |
| amar___ | jungleboyj: rosmaita: Addressed all your comments https://review.opendev.org/c/openstack/cinder/+/790910 really need it get merged in xena, CI is also green | 15:39 |
| opendevreview | Gorka Eguileor proposed openstack/cinder master: Update snapshot api microversion docs and tests https://review.opendev.org/c/openstack/cinder/+/791240 | 16:16 |
| opendevreview | Gorka Eguileor proposed openstack/cinder master: Fix notifications of migration temp volume https://review.opendev.org/c/openstack/cinder/+/786383 | 16:16 |
| opendevreview | Gorka Eguileor proposed openstack/cinder master: Clear OVO history and compatibility https://review.opendev.org/c/openstack/cinder/+/786384 | 16:16 |
| opendevreview | Gorka Eguileor proposed openstack/cinder master: Improve quota usage for temporary resources https://review.opendev.org/c/openstack/cinder/+/786385 | 16:16 |
| opendevreview | Gorka Eguileor proposed openstack/cinder master: Expose volume & snapshot use_quota field https://review.opendev.org/c/openstack/cinder/+/786386 | 16:16 |
| opendevreview | Gorka Eguileor proposed openstack/cinder master: RBD: Don't flatten temporary resources https://review.opendev.org/c/openstack/cinder/+/790492 | 16:16 |
| hemna | mep | 17:38 |
| opendevreview | Sofia Enriquez proposed openstack/cinder master: WIP Try regular delete for snapshot or deferred deletion https://review.opendev.org/c/openstack/cinder/+/805887 | 18:04 |
| opendevreview | Brian Rosmaita proposed openstack/cinder stable/victoria: Support Images API v2.11 https://review.opendev.org/c/openstack/cinder/+/806038 | 18:18 |
| opendevreview | Brian Rosmaita proposed openstack/python-cinderclient master: Add consumes quota field support https://review.opendev.org/c/openstack/python-cinderclient/+/787407 | 21:22 |
| *** dviroel|ruck is now known as dviroel|out | 22:59 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!