| venkatakrishnat | Hi eharney, hemna: Could you please review this simple code-change patch https://review.opendev.org/c/openstack/cinder/+/788782 | 01:04 |
|---|---|---|
| opendevreview | Fernando Ferraz proposed openstack/cinder master: NetApp ONTAP: Add storage assisted migration support https://review.opendev.org/c/openstack/cinder/+/799668 | 01:23 |
| opendevreview | Fernando Ferraz proposed openstack/cinder master: NetApp ONTAP: Add storage assisted migration support https://review.opendev.org/c/openstack/cinder/+/799668 | 04:17 |
| opendevreview | Brian Rosmaita proposed openstack/python-cinderclient master: Support Block Storage API mv 3.66 https://review.opendev.org/c/openstack/python-cinderclient/+/806817 | 05:13 |
| opendevreview | Jorhson Deng proposed openstack/python-cinderclient master: update some scripts https://review.opendev.org/c/openstack/python-cinderclient/+/789971 | 06:30 |
| opendevreview | Jorhson Deng proposed openstack/python-cinderclient master: update some scripts https://review.opendev.org/c/openstack/python-cinderclient/+/789971 | 07:47 |
| *** yoctozepto1 is now known as yoctozepto | 07:49 | |
| opendevreview | liujiong proposed openstack/cinder master: Move librbd diff_iterate to a separate thread https://review.opendev.org/c/openstack/cinder/+/804470 | 08:02 |
| opendevreview | liujiong proposed openstack/cinder master: Move librbd diff_iterate to a separate thread https://review.opendev.org/c/openstack/cinder/+/804470 | 08:34 |
| opendevreview | Andrei proposed openstack/cinder master: JovianDSS: add multy-attach support https://review.opendev.org/c/openstack/cinder/+/806726 | 08:35 |
| opendevreview | Seena Fallah proposed openstack/cinder master: snapshot: allow revert to any point for rbd driver https://review.opendev.org/c/openstack/cinder/+/806807 | 08:40 |
| raghavendrat | hi geguileo: in case you get free time, can you please have a look at: | 09:44 |
| raghavendrat | https://review.opendev.org/c/openstack/cinder/+/805796 | 09:44 |
| raghavendrat | Add HPE Alletra 9k related information | 09:45 |
| geguileo | raghavendrat: added a couple of questions on the patch | 09:57 |
| raghavendrat | thanks geguileo: for quick review. I will make minor changes & add a release note | 10:02 |
| venkatakrishnat | Hi core-reviewers: In your free time, please review this patch https://review.opendev.org/c/openstack/cinder/+/784140 which is to fix Mirror volumes extend operation related issues | 10:33 |
| opendevreview | Amar proposed openstack/cinder master: [SVF]: Fix mkvdisk volume name length issue https://review.opendev.org/c/openstack/cinder/+/790910 | 10:34 |
| opendevreview | Amar proposed openstack/cinder master: [SVF]: Fix mkvdisk volume name length issue https://review.opendev.org/c/openstack/cinder/+/790910 | 10:40 |
| opendevreview | Venkata krishna Thumu proposed openstack/cinder master: [SVF] Update rccg details for mirror volumes https://review.opendev.org/c/openstack/cinder/+/788782 | 10:46 |
| opendevreview | Raghavendra Tilay proposed openstack/cinder master: HPE 3PAR: Add HPE Alletra 9k related information https://review.opendev.org/c/openstack/cinder/+/805796 | 10:54 |
| opendevreview | Andrei proposed openstack/cinder master: JovianDSS: add multy-attach support https://review.opendev.org/c/openstack/cinder/+/806726 | 11:15 |
| *** brinzhang_ is now known as brinzhang | 12:00 | |
| manoj_katari | @core team: This SVF change https://review.opendev.org/c/openstack/cinder/+/776307 is on wait for a long time, please review it. thanks! | 12:53 |
| geguileo | rosmaita: I know we are no longer supposed to do nakes rechecks on patches, but I don't remembber the recommended format and it's not in our contributor docs | 13:19 |
| geguileo | rosmaita: I remember seeing one of your comments doing the recheck with a nice format, but can't find the comment now | 13:19 |
| geguileo | oh, found it | 13:20 |
| geguileo | nothing like bothering you to find it | 13:20 |
| geguileo | example: recheck tempest-integrated-storage : intermittent failure nova bug #1836754 | 13:20 |
| geguileo | sorry for the ping | 13:21 |
| rosmaita | geguileo: np, happy to be helpful! | 13:22 |
| geguileo | yeah, I even remembered the discussion on IRC. I just forget the useful part of it all | 13:22 |
| geguileo | rosmaita: does the recheck comment only work for single-liner comments? | 13:32 |
| venkatakrishnat | Hi sfernand, I have addressed your comments on https://review.opendev.org/c/openstack/cinder/+/788782. Please take a look. | 13:33 |
| rosmaita | geguileo: i think as long as your comment begins with 'recheck', you can add as much other stuff as you want to the comment | 13:34 |
| geguileo | rosmaita: mmmmmm, then I don't know why my comment was ignored | 13:35 |
| rosmaita | but if Zuul is in the middle of running jobs on a patch, it ignores recheck | 13:35 |
| rosmaita | at least that's my experience | 13:35 |
| rosmaita | you have to wait until it stamps a -1 or -2 on your review | 13:35 |
| geguileo | it already posted a -1 | 13:36 |
| geguileo | and the patch # doesn't appear in Zuul Status | 13:36 |
| geguileo | will try with a single line now | 13:36 |
| geguileo | aaaaand, it's there | 13:37 |
| geguileo | probably only works for single lines | 13:37 |
| sfernand | venkatakrishnat: great thanks! I will see | 13:45 |
| rosmaita | Courtesy reminder: Cinder meeting in #openstack-meeting-alt at 1400 UTC | 13:58 |
| rosmaita | jungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard sfernand enriquetaso hemna ^^ | 13:58 |
| whoami-rajat | thanks rosmaita | 13:58 |
| rosmaita | :) | 13:58 |
| geguileo | rosmaita: thanks | 13:58 |
| venkatakrishnat | Hi eharney, enriquetaso, geguileo, hemna, rosmaita: Could you please review https://review.opendev.org/c/openstack/cinder/+/784140 which is to fix Mirror volumes extend operation issues | 14:07 |
| L4rS6 | Hi all, can someone tell me how to configure the block size for cinder volumes as mentioned here https://bugs.launchpad.net/nova/+bug/1195913/comments/8? I want to adjust the volume block size from 512 to 4096 to match the underlaying storage block size. | 14:14 |
| opendevreview | Fábio Oliveira proposed openstack/cinder master: Netapp ONTAP: Add support to revert to snapshot https://review.opendev.org/c/openstack/cinder/+/804093 | 14:20 |
| zenkuro | hay! this patch was review and Ive addressed recommendatyions and issues please review it https://review.opendev.org/c/openstack/cinder/+/806191 | 14:33 |
| zenkuro | also here is verry small patch that enables feature for driver https://review.opendev.org/c/openstack/cinder/+/806726/3 | 14:34 |
| zenkuro | and here is a naming and code style fix https://review.opendev.org/c/openstack/cinder/+/806559/5 | 14:34 |
| zenkuro | rosmaita: can you please advertize this patches =) plz | 14:35 |
| rosmaita | zenkuro: ok, make sure they are listed on your blueprint | 14:37 |
| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Reset state robustification for group os-reset_status https://review.opendev.org/c/openstack/cinder/+/804735 | 14:39 |
| whoami-rajat | rosmaita, update the release patch https://review.opendev.org/c/openstack/releases/+/806831 | 14:45 |
| zenkuro | rosmait: yes, every patch have proper blueprint, and Ive places list of all patches in original blueprint https://blueprints.launchpad.net/cinder/+spec/open-e-joviandss-add-multy-attach-support | 14:47 |
| opendevreview | Helen Walsh proposed openstack/cinder master: PowerMax Driver - refactoring feedback https://review.opendev.org/c/openstack/cinder/+/806757 | 14:50 |
| opendevreview | Andrei proposed openstack/cinder master: JovianDSS: add multyattach support https://review.opendev.org/c/openstack/cinder/+/806726 | 14:51 |
| enriquetaso | L4rS6 o/. I'm not 100% sure but as far as understand the way to configure this depends on the backend. i.e SolidFire uses the self.configuration.sf_emulate_512 | 14:53 |
| opendevreview | Andrei proposed openstack/cinder master: JovianDSS: add multiattach support https://review.opendev.org/c/openstack/cinder/+/806726 | 15:03 |
| eharney | whoami-rajat: so do we need to backport the grenade fix to stable branches? | 15:06 |
| enriquetaso | hi | 15:06 |
| enriquetaso | so | 15:06 |
| enriquetaso | #startmeeting cinder_bs | 15:06 |
| opendevmeet | Meeting started Wed Sep 1 15:06:40 2021 UTC and is due to finish in 60 minutes. The chair is enriquetaso. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:06 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:06 |
| opendevmeet | The meeting name has been set to 'cinder_bs' | 15:06 |
| enriquetaso | Hello, really short meeting today. Nine new bugs were reported this week. | 15:06 |
| enriquetaso | Full list of reported bugs: | 15:06 |
| enriquetaso | #link http://lists.openstack.org/pipermail/openstack-discuss/2021-September/024593.html | 15:06 |
| enriquetaso | Six of them are driver related and have people looking over them. One is Incomplete and I'm going to talk about the last 2: | 15:07 |
| whoami-rajat | eharney, do we plan to backport this fix further i.e. victoria and ussuri? https://review.opendev.org/c/openstack/cinder/+/800268 | 15:07 |
| enriquetaso | #topic bug_1 "Online database schema migrations to Xena always fail" | 15:07 |
| rosmaita | probably to train! | 15:07 |
| eharney | whoami-rajat: it would be a good idea | 15:07 |
| rosmaita | enriquetaso: sorry to be interrupting | 15:07 |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1942077 | 15:08 |
| enriquetaso | Summary: Wallaby deploys fine and upgrade to Xena fails with 2021-08-30 10:44:07.275 16 ERROR cinder.cmd.manage TypeError: cannot unpack non-iterable NoneType object | 15:08 |
| enriquetaso | Maybe we should talked about the granade fix here | 15:08 |
| enriquetaso | i don't know | 15:08 |
| whoami-rajat | eharney, then yes, we need to backport the grenade patch as well | 15:08 |
| enriquetaso | I'm not sure how to handle this. Because I'm not sure if we have a tool upstream for upgrading to Xena. However, I'd like to heads up this bugs. (regarding bug/1942077) | 15:09 |
| whoami-rajat | sorry sofia for interrupting | 15:09 |
| eharney | enriquetaso: 1942077 looks like a potential bug in our data migrations, which is concerning | 15:09 |
| rosmaita | enriquetaso: snapshot_use_quota_online_data_migration was just added very recently | 15:09 |
| eharney | this should be investigated | 15:09 |
| enriquetaso | I'll move it to high importance then | 15:09 |
| enriquetaso | Not sure how to debug tho, can I perform this with devstack? | 15:10 |
| eharney | i think the volume.migration_status.startswith() check needs a volume.migration_status is not None check added before it | 15:10 |
| eharney | compare volume_use_quota_online_data_migration doing this to _volume_data_get_for_project which both examine for this "target:" string | 15:11 |
| eharney | i think the latter handles migration_status being None but the former (this failure) doesn't | 15:11 |
| eharney | i added a comment | 15:13 |
| rosmaita | ok, thanks Eric | 15:13 |
| enriquetaso | thanks for the comment, so we need some is not none check | 15:13 |
| enriquetaso | before anything | 15:13 |
| enriquetaso | OK.. moving on | 15:14 |
| enriquetaso | #topic bug_2 "ssh exec timeout" | 15:14 |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1930267 | 15:14 |
| enriquetaso | I'm really lost regarding this bug, I'm not sure if I'm missing something or it's a valid bug. I guess the reporter could have added more information but I'd like to heads up on this one as well. | 15:14 |
| eharney | there isn't much info on this one... is there actually a patch, since it's "In Progress"? | 15:14 |
| enriquetaso | I couldn't found any | 15:15 |
| eharney | https://review.opendev.org/c/openstack/cinder/+/793264 | 15:15 |
| eharney | https://review.opendev.org/q/project:openstack/cinder+and+message:1930267 finds it | 15:15 |
| rosmaita | nice search-fu eharney | 15:16 |
| rosmaita | enriquetaso: that is a handy search to know | 15:16 |
| enriquetaso | oh, i filter by '-bug:<number>' | 15:16 |
| enriquetaso | yes, noted. use message:1930267 | 15:17 |
| rosmaita | looks like eharney already -2d it a few months ago | 15:17 |
| enriquetaso | https://review.opendev.org/q/project:openstack/cinder+and+bug:1930267 isn't working | 15:17 |
| eharney | enriquetaso: the field is "message" | 15:17 |
| eharney | rosmaita: yeah i guess i'll take another look but i think there isn't a lot to go on with this one | 15:17 |
| rosmaita | doesn't sound like an emergency | 15:18 |
| enriquetaso | it's not | 15:18 |
| enriquetaso | we can focus on the reviews before Friday for sure | 15:18 |
| enriquetaso | OK, nothing else | 15:18 |
| enriquetaso | #topic open discussion | 15:19 |
| enriquetaso | If you have any bugs to discuss, please feel free to add there it now | 15:20 |
| rosmaita | eharney: could use your opinion on https://review.opendev.org/c/openstack/python-cinderclient/+/806817 | 15:20 |
| rosmaita | (sorry, not a bug) | 15:20 |
| rosmaita | eharney: it would be much easier to simply make 'force' illegal for mv >= 3.66, but that kind of goes against what we did in cinder ... lmk what you think | 15:21 |
| eharney | rosmaita: started looking at it, still trying to wrap my head around what's going on there | 15:21 |
| enriquetaso | OK, looks like we are done for today | 15:21 |
| enriquetaso | thanks!! | 15:21 |
| enriquetaso | #endmeeting | 15:21 |
| opendevmeet | Meeting ended Wed Sep 1 15:21:56 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:21 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cinder_bs/2021/cinder_bs.2021-09-01-15.06.html | 15:21 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cinder_bs/2021/cinder_bs.2021-09-01-15.06.txt | 15:21 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cinder_bs/2021/cinder_bs.2021-09-01-15.06.log.html | 15:21 |
| rosmaita | eharney: the problem is that cinderclient was always sending 'force' in the request body | 15:22 |
| eharney | rosmaita: oh. ugh | 15:22 |
| rosmaita | yeah | 15:22 |
| rosmaita | but the simplest fix would be to use the end_version on 'force' and make a small change so it's not always included in the body | 15:23 |
| eharney | yeah, makes sense | 15:23 |
| rosmaita | but i did the more complicated fix of hiding 'force' as a parameter for 3.66 and then accepting --force True but rejecting any other value | 15:24 |
| rosmaita | (roughly) | 15:24 |
| rosmaita | so scripts that call the shell should still work | 15:25 |
| rosmaita | but i don't know that that's a big concern | 15:25 |
| eharney | it generally is | 15:26 |
| rosmaita | ok, then maybe my patch actually is the simplest thing we can do | 15:26 |
| rosmaita | :( | 15:26 |
| eharney | yeah, i like the idea | 15:27 |
| rosmaita | enriquetaso: btw, thanks for your review on https://review.opendev.org/c/openstack/cinder/+/789564 | 15:32 |
| enriquetaso | i guess jay forgot the workflow +1 :P | 15:35 |
| rosmaita | i think he wanted to let eric take a look first | 15:36 |
| eharney | changes on https://review.opendev.org/c/openstack/cinder/+/789564 look good to me | 15:38 |
| rosmaita | enriquetaso: +A, please, when you have a minute | 15:38 |
| rosmaita | i'll put up a quick followup to remove that extra space | 15:39 |
| opendevreview | Brian Rosmaita proposed openstack/cinder master: Remove extraneous space from error message https://review.opendev.org/c/openstack/cinder/+/806945 | 15:42 |
| opendevreview | Merged openstack/python-cinderclient master: update some scripts https://review.opendev.org/c/openstack/python-cinderclient/+/789971 | 15:43 |
| enriquetaso | sure | 15:50 |
| enriquetaso | done | 15:50 |
| venkatakrishnat | Hi core-reviewers: Please have a look at this patch https://review.opendev.org/c/openstack/cinder/+/784140 which is to fix Mirror volumes extend operation issues | 16:30 |
| opendevreview | Helen Walsh proposed openstack/cinder master: PowerMax Driver - RDF checks https://review.opendev.org/c/openstack/cinder/+/768105 | 16:37 |
| amar_ | rosmaita: Addressed all your comments https://review.opendev.org/c/openstack/cinder/+/790910 really need it get merged in xena, CI is also green. | 17:14 |
| amar_ | jungleboyj: Hey I have resolved the merge conflict for this patch https://review.opendev.org/c/openstack/cinder/+/790910. Could you plz give your +2 again. Tq in adv. :) | 17:16 |
| opendevreview | Merged openstack/cinder master: Snapshot in-use volumes without force flag https://review.opendev.org/c/openstack/cinder/+/789564 | 17:36 |
| venkatakrishnat | Hi, Can someone please review this simple code-change patch https://review.opendev.org/c/openstack/cinder/+/788782 which is to update missing RCCG property to volume-metadata. Thanks in adv | 17:49 |
| opendevreview | Alan Bishop proposed openstack/cinder master: Implement project personas for volume actions https://review.opendev.org/c/openstack/cinder/+/806965 | 18:17 |
| opendevreview | Alan Bishop proposed openstack/cinder master: Implement project personas for groups and group_types https://review.opendev.org/c/openstack/cinder/+/806968 | 18:29 |
| abishop | lbragstad: any objection to me working on https://review.opendev.org/c/openstack/cinder/+/760038? | 18:53 |
| abishop | lbragstad: I can also help with https://review.opendev.org/c/openstack/cinder/+/759996 | 18:54 |
| opendevreview | Seena Fallah proposed openstack/cinder master: snapshot: allow revert to any point for rbd driver https://review.opendev.org/c/openstack/cinder/+/806807 | 19:41 |
| lbragstad | abishop feel free to take those on | 20:08 |
| lbragstad | abishop i was going to leave the admin APIs alone (WIP) until yoga but if you want to abandon and re-propose that's fine too | 20:08 |
| abishop | lbragstad: ack; I think the qos patch can be abandoned/deferred, and I'll work on the quotas patch | 20:15 |
| lbragstad | ok | 20:27 |
| opendevreview | Brian Rosmaita proposed openstack/python-brick-cinderclient-ext master: Use cinderclient v3 in tests https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/806981 | 20:32 |
| opendevreview | Alan Bishop proposed openstack/cinder master: Implement project personas for quotas and quota_classes https://review.opendev.org/c/openstack/cinder/+/760038 | 20:33 |
| opendevreview | Brian Rosmaita proposed openstack/python-brick-cinderclient-ext master: Update requirements for Xena https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/806983 | 20:43 |
| rosmaita | if any cores are around, need ^^ to un-bork the brick-cinderclient-ext gate | 21:13 |
| rosmaita | e0ne eharney geguileo hemna jungleboyj smcginnis whoami-rajat enriquetaso ^^ | 21:13 |
| enriquetaso | sure | 21:14 |
| enriquetaso | I'll wait for Zuul and I'll review | 21:15 |
| rosmaita | zuul says +1 | 21:15 |
| jungleboyj | Zuul no likey | 21:15 |
| rosmaita | what??? | 21:15 |
| rosmaita | sorry, that's the wrong patch | 21:15 |
| rosmaita | https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/806981 | 21:16 |
| jungleboyj | Oh. | 21:16 |
| rosmaita | sorry about the confusion, i should have put the link instead of the ^^ | 21:16 |
| jungleboyj | Ok. That one looks good. | 21:16 |
| rosmaita | cool, ty | 21:17 |
| geguileo | rosmaita: done | 21:28 |
| rosmaita | geguileo: ty! | 21:28 |
| opendevreview | Gorka Eguileor proposed openstack/cinder master: Docs: Discourage using naked rechecks https://review.opendev.org/c/openstack/cinder/+/806989 | 21:28 |
| rosmaita | thank you! | 21:28 |
| geguileo | rosmaita: ^ that's what I've written regarding naked recheds | 21:28 |
| geguileo | it's not much, but at least we have a place of reference for ourselves and to point others to | 21:29 |
| rosmaita | i like this example, it is very lifelike: recheck cinder-plugin-ceph-tempest timed out, errors all over the place | 21:29 |
| rosmaita | geguileo: very nicely written, thanks | 21:30 |
| rosmaita | that will be helpful to have in the docs | 21:31 |
| geguileo | rosmaita: I think that example is from one of your comments lol | 21:31 |
| geguileo | from this patch https://review.opendev.org/c/openstack/cinder/+/786385 | 21:32 |
| geguileo | lol | 21:32 |
| rosmaita | yeah, i think that patch had like 50 rechecks | 21:32 |
| opendevreview | Alan Bishop proposed openstack/cinder master: Update project personas for default_types https://review.opendev.org/c/openstack/cinder/+/806991 | 21:49 |
| opendevreview | Merged openstack/python-brick-cinderclient-ext master: Use cinderclient v3 in tests https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/806981 | 21:51 |
| rosmaita | \o/ | 21:54 |
| enriquetaso | :) | 22:34 |
| enriquetaso | it's merged already, yay | 22:34 |
| *** dviroel|ruck is now known as dviroel|out | 22:43 | |
| opendevreview | Merged openstack/python-brick-cinderclient-ext master: Dropping lower constraints testing https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/789066 | 23:05 |
| opendevreview | Merged openstack/python-brick-cinderclient-ext master: Changed minversion in tox to 3.18.0 https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/797856 | 23:29 |
| opendevreview | Merged openstack/python-brick-cinderclient-ext master: Enable tls-proxy support in test job https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/796787 | 23:29 |
| opendevreview | Seena Fallah proposed openstack/cinder master: snapshot: allow revert to any point for rbd driver https://review.opendev.org/c/openstack/cinder/+/806807 | 23:41 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!