opendevreview | Merged openstack/cinder master: Implement user visible extra specs https://review.opendev.org/c/openstack/cinder/+/806260 | 00:00 |
---|---|---|
opendevreview | Merged openstack/cinder master: JovianDSS: fix iscsi target recovery function https://review.opendev.org/c/openstack/cinder/+/806191 | 00:42 |
opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Reset state robustification for group os-reset_status https://review.opendev.org/c/openstack/cinder/+/804735 | 01:16 |
opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Reset state robustification for snapshot os-reset_status https://review.opendev.org/c/openstack/cinder/+/804035 | 01:17 |
sfernand | zenkuro: keep track of patch https://review.opendev.org/c/openstack/cinder/+/806726. Tomorrow is the deadline for patches adding new features like yours | 03:03 |
opendevreview | Rajat Dhasmana proposed openstack/cinder master: Update project personas for default_types https://review.opendev.org/c/openstack/cinder/+/806991 | 06:18 |
*** bhagyashris__ is now known as bhagyashris | 07:27 | |
opendevreview | Andrei proposed openstack/cinder master: JovianDSS: add multiattach and 16K block support https://review.opendev.org/c/openstack/cinder/+/806726 | 07:46 |
opendevreview | Rajat Dhasmana proposed openstack/cinder master: Support volume re-image https://review.opendev.org/c/openstack/cinder/+/606346 | 09:09 |
opendevreview | Rajat Dhasmana proposed openstack/cinder master: Implement project personas for volume API https://review.opendev.org/c/openstack/cinder/+/760199 | 10:37 |
*** dviroel|out is now known as dviroel | 11:21 | |
rosmaita | whoami-rajat: responded to your comments on https://review.opendev.org/c/openstack/python-cinderclient/+/806817 | 11:35 |
zenkuro | hi, how can I find https://18067d745aec8d3e03b6-99456abad161e1f28f9c3ec49cb7f2f5.ssl.cf5.rackcdn.com/806726/6/check/build-openstack-releasenotes/64ebf20/docs/unreleased.html#new-features for patch Ive submitted? | 11:36 |
zenkuro | as I understand each of this pages get generated for specific patches | 11:37 |
rosmaita | geguileo: could use your feedback on https://review.opendev.org/c/openstack/python-cinderclient/+/807219 (release note that covers your mv 3.65) | 11:44 |
rosmaita | zenkuro: on your review, go to the "Zuul Summary" tab | 11:45 |
rosmaita | one of the listed jobs should be named "build-openstack-releasenotes" | 11:45 |
rosmaita | click on that | 11:45 |
rosmaita | then go to the "Artifacts" tab | 11:46 |
rosmaita | click on "Docs preview site" | 11:46 |
rosmaita | then click on "Current Series Release Notes" | 11:46 |
zenkuro | rosmaita: thanks! | 11:46 |
opendevreview | Venkata krishna Thumu proposed openstack/cinder master: [SVF] Update rccg details for mirror volumes https://review.opendev.org/c/openstack/cinder/+/788782 | 12:01 |
opendevreview | Andrei proposed openstack/cinder master: JovianDSS: fix code style and naming https://review.opendev.org/c/openstack/cinder/+/806559 | 12:05 |
zenkuro | rosmaita: thanks for review. Ive addressed your comments and would love if you take a look at patches again | 12:08 |
enriquetaso | rosmaita good morning o/ is https://review.opendev.org/c/openstack/python-cinderclient/+/806817 ready for review? do we need it for today's deadline, right? | 12:09 |
opendevreview | Kazumasa Nomura proposed openstack/cinder master: Hitachi: Add generic volume groups https://review.opendev.org/c/openstack/cinder/+/782910 | 12:14 |
rosmaita | enriquetaso: yes it is and yes we do | 12:18 |
enriquetaso | merged :D | 12:25 |
rosmaita | enriquetaso: if you have a few minutes, could you look over the release note: https://review.opendev.org/c/openstack/python-cinderclient/+/807219 | 12:28 |
enriquetaso | sure | 12:28 |
sfernand | hey cores! Anyone could review these patches for Xena? Brian already gave +2 :D | 12:46 |
sfernand | https://blueprints.launchpad.net/cinder/+spec/ontap-storage-assisted-migration | 12:46 |
sfernand | https://blueprints.launchpad.net/cinder/+spec/ontap-revert-to-snapshot | 12:46 |
sfernand | https://blueprints.launchpad.net/cinder/+spec/ontap-report-provisioned-capacity | 12:46 |
opendevreview | Eric Harney proposed openstack/cinder master: mypy: service.py https://review.opendev.org/c/openstack/cinder/+/788367 | 13:08 |
opendevreview | Alan Bishop proposed openstack/cinder master: Clean up user visible extra specs release note https://review.opendev.org/c/openstack/cinder/+/807313 | 13:08 |
opendevreview | Sofia Enriquez proposed openstack/cinder master: Implement project personas for group_actions https://review.opendev.org/c/openstack/cinder/+/759955 | 13:26 |
opendevreview | Sofia Enriquez proposed openstack/cinder master: Implement project personas for group_actions https://review.opendev.org/c/openstack/cinder/+/759955 | 13:32 |
opendevreview | Sofia Enriquez proposed openstack/cinder master: RBD: Call trash operation when plain deletion fails https://review.opendev.org/c/openstack/cinder/+/805887 | 13:34 |
opendevreview | Sofia Enriquez proposed openstack/cinder master: Implement project personas for group_actions https://review.opendev.org/c/openstack/cinder/+/759955 | 13:41 |
opendevreview | Eric Harney proposed openstack/cinder master: mypy: RBD driver https://review.opendev.org/c/openstack/cinder/+/774288 | 13:42 |
opendevreview | Sofia Enriquez proposed openstack/cinder master: Implement project personas for group snapshots https://review.opendev.org/c/openstack/cinder/+/759961 | 13:45 |
opendevreview | Rajat Dhasmana proposed openstack/cinder master: Fix: Online migration for volume_use_quota_online_data_migration https://review.opendev.org/c/openstack/cinder/+/807083 | 13:46 |
zenkuro | hi cores! please check small driver feature update that have two +1 https://review.opendev.org/c/openstack/cinder/+/806726 | 13:54 |
opendevreview | Merged openstack/python-cinderclient master: Support Block Storage API mv 3.66 https://review.opendev.org/c/openstack/python-cinderclient/+/806817 | 14:00 |
opendevreview | Merged openstack/python-cinderclient master: Prepare for Xena cinderclient release https://review.opendev.org/c/openstack/python-cinderclient/+/807219 | 14:00 |
rosmaita | whoami-rajat: when you have a minute, please verify the hash on https://review.opendev.org/c/openstack/releases/+/806583 | 14:06 |
whoami-rajat | looking | 14:07 |
rosmaita | ty | 14:08 |
opendevreview | Sofia Enriquez proposed openstack/cinder master: Implement project personas for group snapshots https://review.opendev.org/c/openstack/cinder/+/759961 | 14:12 |
sfernand | enriquetaso: many thanks for the review on the migration patch :) | 14:34 |
enriquetaso | \o/ | 14:35 |
zenkuro | rosmaita: sorry for bothering you with same patch again, but can you check https://review.opendev.org/c/openstack/cinder/+/806726 , Ive followed your recommendations | 14:52 |
opendevreview | OpenStack Release Bot proposed openstack/python-cinderclient stable/xena: Update .gitreview for stable/xena https://review.opendev.org/c/openstack/python-cinderclient/+/807349 | 14:56 |
opendevreview | OpenStack Release Bot proposed openstack/python-cinderclient stable/xena: Update TOX_CONSTRAINTS_FILE for stable/xena https://review.opendev.org/c/openstack/python-cinderclient/+/807350 | 14:56 |
opendevreview | OpenStack Release Bot proposed openstack/python-cinderclient master: Update master for stable/xena https://review.opendev.org/c/openstack/python-cinderclient/+/807351 | 14:56 |
opendevreview | OpenStack Release Bot proposed openstack/python-cinderclient master: Add Python3 yoga unit tests https://review.opendev.org/c/openstack/python-cinderclient/+/807352 | 14:56 |
rosmaita | zenkuro: done | 14:58 |
rosmaita | zenkuro: https://review.opendev.org/c/openstack/cinder/+/806559 should be an easy fix, left a note for you | 15:06 |
opendevreview | Merged openstack/cinder master: NetApp ONTAP: Add storage assisted migration support https://review.opendev.org/c/openstack/cinder/+/799668 | 15:07 |
opendevreview | Merged openstack/cinder master: Add cinder permissions matrix https://review.opendev.org/c/openstack/cinder/+/763306 | 15:08 |
zenkuro | rosmaita: thanks again! | 15:10 |
opendevreview | Andrei proposed openstack/cinder master: JovianDSS: fix code style and naming https://review.opendev.org/c/openstack/cinder/+/806559 | 15:10 |
zenkuro | rosmaita: fixed. Should I ping you once zuul pass with OK? | 15:11 |
rosmaita | zenkuro: sure, that will be helpful | 15:12 |
opendevreview | Rajat Dhasmana proposed openstack/cinder master: Fix: Online migration for volume_use_quota_online_data_migration https://review.opendev.org/c/openstack/cinder/+/807083 | 15:26 |
opendevreview | Alan Bishop proposed openstack/cinder master: Implement project personas for snapshots https://review.opendev.org/c/openstack/cinder/+/760178 | 15:40 |
rosmaita | could i get some eyes on https://review.opendev.org/c/openstack/cinder/+/803533 -- removes the 'enable_v3_api' option | 15:45 |
opendevreview | Alan Bishop proposed openstack/cinder master: Implement project personas for the limits API https://review.opendev.org/c/openstack/cinder/+/759987 | 15:48 |
opendevreview | Alan Bishop proposed openstack/cinder master: Implement project personas for volume groups https://review.opendev.org/c/openstack/cinder/+/759962 | 15:56 |
opendevreview | Merged openstack/python-cinderclient stable/xena: Update .gitreview for stable/xena https://review.opendev.org/c/openstack/python-cinderclient/+/807349 | 15:57 |
opendevreview | Merged openstack/python-cinderclient stable/xena: Update TOX_CONSTRAINTS_FILE for stable/xena https://review.opendev.org/c/openstack/python-cinderclient/+/807350 | 16:00 |
opendevreview | Merged openstack/python-cinderclient master: Update master for stable/xena https://review.opendev.org/c/openstack/python-cinderclient/+/807351 | 16:00 |
opendevreview | Merged openstack/cinder master: Clean up user visible extra specs release note https://review.opendev.org/c/openstack/cinder/+/807313 | 16:14 |
knomura | rosmaita: Hi, I updated the patch. Please continue to review for CTG feature in Hitachi driver. https://review.opendev.org/c/openstack/cinder/+/782910 | 16:19 |
rosmaita | knomura: ack, will take a look after lunch | 16:20 |
knomura | rosmaita: thanks in advance. | 16:20 |
zenkuro | nice and small patch https://review.opendev.org/c/openstack/cinder/+/806726 is looking for a second "+2" =) | 16:36 |
opendevreview | Alan Bishop proposed openstack/cinder master: Implement project personas for snapshot metadata https://review.opendev.org/c/openstack/cinder/+/760153 | 16:41 |
opendevreview | Alan Bishop proposed openstack/cinder master: WIP: Implement Xena project personas for volume metadata API https://review.opendev.org/c/openstack/cinder/+/760193 | 16:49 |
opendevreview | Venkata krishna Thumu proposed openstack/cinder master: [SVF] Update rccg details for mirror volumes https://review.opendev.org/c/openstack/cinder/+/788782 | 17:09 |
opendevreview | Fábio Oliveira proposed openstack/cinder master: Netapp ONTAP: Add support to revert to snapshot https://review.opendev.org/c/openstack/cinder/+/804093 | 17:10 |
fabiooliveira | hello, rosmaita, thank you for merging sfernand patch. I've just submitted a new patch resolving the merge conflicts https://review.opendev.org/c/openstack/cinder/+/804093 | 17:13 |
whoami-rajat__ | rosmaita, just fyi, we need to merge this before RC-1 to fix our online migrations https://review.opendev.org/c/openstack/cinder/+/807083 | 17:17 |
whoami-rajat__ | also if you get time and don't have issues with the backup messages work, can you W+1 this? https://review.opendev.org/c/openstack/cinder/+/786627 | 17:18 |
zenkuro | smcginnis: hi can you please check https://review.opendev.org/c/openstack/cinder/+/806726, I have approve from rosmaita and Im missing single +2 | 17:37 |
opendevreview | Alan Bishop proposed openstack/cinder master: Implement secure RBAC for snapshot actions https://review.opendev.org/c/openstack/cinder/+/760152 | 17:51 |
zenkuro | rosmaita: code style patch passed https://review.opendev.org/c/openstack/cinder/+/806559 | 17:52 |
rosmaita | zenkuro: ack | 17:52 |
opendevreview | Eric Harney proposed openstack/cinder master: mypy: service.py https://review.opendev.org/c/openstack/cinder/+/788367 | 18:03 |
opendevreview | Alan Bishop proposed openstack/cinder master: Implement project personas for the limits API https://review.opendev.org/c/openstack/cinder/+/759987 | 18:28 |
opendevreview | Alan Bishop proposed openstack/cinder master: Implement secure RBAC for snapshot actions https://review.opendev.org/c/openstack/cinder/+/760152 | 18:31 |
opendevreview | Alan Bishop proposed openstack/cinder master: Implement project personas for snapshots https://review.opendev.org/c/openstack/cinder/+/760178 | 18:32 |
opendevreview | Fernando Ferraz proposed openstack/cinder master: NetApp ONTAP: Add option to report storage provisioned capacity https://review.opendev.org/c/openstack/cinder/+/798198 | 18:33 |
sfernand | rosmaita: the provisioned capacity patch also needed to fix conflicts. I've just submitted a new patchset https://review.opendev.org/c/openstack/cinder/+/798198 | 18:35 |
rosmaita | ok, thanks, feel free to ping me when zuul approves | 18:36 |
sfernand | sure will do | 18:36 |
rosmaita | ty | 18:36 |
opendevreview | Alan Bishop proposed openstack/cinder master: Implement project personas for volume groups https://review.opendev.org/c/openstack/cinder/+/759962 | 18:43 |
opendevreview | Alan Bishop proposed openstack/cinder master: Implement project personas for snapshot metadata https://review.opendev.org/c/openstack/cinder/+/760153 | 18:48 |
zenkuro | sfernand: hi, can you explain/show how the merge fail will looks like and how to know if merge will fail? | 18:53 |
abishop | rosmaita: lbragstad makes an interesting observation of how/where we define the deprecated rules, see https://review.opendev.org/c/openstack/cinder/+/759955/20/cinder/policies/group_actions.py#48 | 18:54 |
sfernand | hi zenkuro, not sure I got you question | 18:55 |
sfernand | which patch you are worried about | 18:55 |
zenkuro | https://review.opendev.org/c/openstack/cinder/+/806726 | 18:55 |
zenkuro | and https://review.opendev.org/c/openstack/cinder/+/806559 | 18:55 |
rosmaita | abishop: yes, i had seen lbragstad do that on an earlier patch, but i decided not to change the pattern we had going | 18:58 |
abishop | rosmaita: ack, then I'll leave things alone and not fiddle with them | 19:01 |
sfernand | zenkuro: I believe your patches will not run into merge conflicts since only one of them are updating common stuff like history | 19:06 |
sfernand | you will know for sure when one of them gets merged | 19:07 |
sfernand | also, I think that gerrit tells which patchs might result in merge conflicts | 19:07 |
zenkuro | sfernand: my problem is that both of them have merge conflicts on the gerrit page | 19:11 |
zenkuro | sfernand: I see, in gerrit "Dashboard" I can identify commits that have conflicts for sure | 19:13 |
sfernand | you can cherry pick one in top of the other | 19:13 |
sfernand | then after the parent gets merged, the second should go smoothly | 19:14 |
zenkuro | sfernand: rebase and resolve conflicts should work as well. | 19:15 |
zenkuro | I hope | 19:15 |
zenkuro | another problem is that Im not able to see my patch on zuul dashboard https://zuul.opendev.org/t/openstack/status | 19:16 |
zenkuro | there is no 806726 | 19:17 |
sfernand | anyone from hitachi online? | 19:18 |
sfernand | zenkuro: hum I see | 19:21 |
zenkuro | sfernand: if Im not mistaken, by now zuul should start running gate job, but it is missing | 19:22 |
sfernand | I think you are not | 19:24 |
sfernand | we should see it queue and a comment in your patch at least.. | 19:25 |
sfernand | rosmaita: a patch from zenkuro should be in gate but there is no job queued in the status, a recheck would work in this case? https://review.opendev.org/c/openstack/cinder/+/806726 | 19:26 |
rosmaita | looking | 19:26 |
zenkuro | rosmaita: thanks! | 19:30 |
rosmaita | not sure why it's going through the check again | 19:30 |
zenkuro | rosmaita: it appeared in check, but not in gate | 19:31 |
zenkuro | rosmaita: ok now in merge check | 19:31 |
zenkuro | rosmaita: no, my bad it is just an arm check | 19:33 |
rosmaita | yeah, looks like it will be going through check + gate, oh well | 19:34 |
zenkuro | yah... | 19:34 |
*** dviroel is now known as dviroel|af | 19:35 | |
*** dviroel|af is now known as dviroel|afk | 19:35 | |
zenkuro | rosmaita: tox-py38 failed because where not able to install something https://zuul.opendev.org/t/openstack/build/8d67466e4963446e9a0cfe8903917d18 | 19:38 |
zenkuro | should I restart? | 19:38 |
sfernand | rosmaita, is it time to request the FFEs? I'm considering to take the liberty to request it for hitachi as well :P | 19:39 |
rosmaita | wait until 20:00 utc :) | 19:39 |
rosmaita | zenkuro: you sometimes see those errors when the pip mirrors are out of date, or had a bad update | 19:40 |
zenkuro | rosmaita: so should I "recheck" in such cases? | 19:41 |
opendevreview | Alan Bishop proposed openstack/cinder master: Implement project personas for snapshots https://review.opendev.org/c/openstack/cinder/+/760178 | 19:41 |
rosmaita | zenkuro: i believe that zuul ignores rechecks until all jobs have finished on a patch | 19:41 |
opendevreview | Alan Bishop proposed openstack/cinder master: Implement secure RBAC for snapshot actions https://review.opendev.org/c/openstack/cinder/+/760152 | 19:42 |
opendevreview | Alan Bishop proposed openstack/cinder master: Implement project personas for the limits API https://review.opendev.org/c/openstack/cinder/+/759987 | 19:43 |
opendevreview | Alan Bishop proposed openstack/cinder master: Implement project personas for snapshot metadata https://review.opendev.org/c/openstack/cinder/+/760153 | 19:44 |
sfernand | rosmaita: ok, so should I request for hitachi as well or they can ask for it later? asking because I don't know what would happen if they just realize there patch didn't make on Sunday for example | 19:45 |
zenkuro | sfernand: will it be possible to merge during Sunday? | 19:46 |
rosmaita | i will send out an email shortly after 20:00 utc this afternoon about the feature freeze and announcing the deadline and process for FFEs | 19:46 |
rosmaita | deadline will be 20:00 UTC tuesday (or whenever i said at the meeting this week ... will have to check) | 19:47 |
opendevreview | Alan Bishop proposed openstack/cinder master: Implement project personas for volume groups https://review.opendev.org/c/openstack/cinder/+/759962 | 19:47 |
rosmaita | zenkuro: openstack never closes! but this is a holiday weekend for reviewers in the USA | 19:47 |
zenkuro | rosmaita: for me as well, but the patch is holly as well | 19:49 |
rosmaita | :) | 19:49 |
zenkuro | rosmaita: my question Will it pass to release and what can I do to make it pass? | 19:52 |
zenkuro | I mean I will monitor it through Saturday and Sunday but will it be enoungh | 19:53 |
rosmaita | as long as it's been approved, we will just need to keep issuing rechecks ... probably don't need to worry about a merge conflict | 19:53 |
zenkuro | also this one https://review.opendev.org/c/openstack/cinder/+/806559 | 20:01 |
zenkuro | it is not so critical but Im not sure if it will be merged with feature update | 20:01 |
rosmaita | zenkuro: i don't think that's a controversial patch, it's mostly just making the code more consistent style-wise, and making the docs more consistent about the name of the storage system you support | 20:04 |
sfernand | rosmaita: his patch looks more like a fix so it could get until the RC may be | 20:05 |
sfernand | get merged* | 20:05 |
rosmaita | either way | 20:06 |
rosmaita | i could use some eyes on the cycle highlights if anyone feels like proofreading: https://review.opendev.org/c/openstack/releases/+/807398 | 20:14 |
rosmaita | smcginnis: jungleboyj: ^^ | 20:14 |
opendevreview | Alan Bishop proposed openstack/cinder master: WIP: Implement Xena project personas for volume access API https://review.opendev.org/c/openstack/cinder/+/760184 | 20:15 |
zenkuro | rosmaita: ok, so I hope I will manage to push both of them through recheck/zuul >_< | 20:15 |
rosmaita | hemna: ty | 20:19 |
hemna | np | 20:19 |
rosmaita | hemna: while you're here, can you take a look at https://review.opendev.org/c/openstack/rbd-iscsi-client/+/799914 ... drops l-c testing on rbd-iscsi-client repo | 20:20 |
rosmaita | we've removed it on everything else (at least i hope so) | 20:21 |
opendevreview | Alan Bishop proposed openstack/cinder master: WIP: Implement Xena project personas for volume types https://review.opendev.org/c/openstack/cinder/+/760197 | 20:49 |
rosmaita | xena feature freeze is in effect: http://lists.openstack.org/pipermail/openstack-discuss/2021-September/024651.html | 20:55 |
opendevreview | Merged openstack/python-cinderclient master: Add Python3 yoga unit tests https://review.opendev.org/c/openstack/python-cinderclient/+/807352 | 20:57 |
sfernand | rosmaita: CI voted on https://review.opendev.org/c/openstack/cinder/+/804093 | 21:00 |
opendevreview | Merged openstack/cinder master: Test glance with cinder backend optimization https://review.opendev.org/c/openstack/cinder/+/757936 | 21:00 |
sfernand | hey cores! anyone have some time to take a look at this one? https://review.opendev.org/c/openstack/cinder/+/804093 | 21:01 |
rosmaita | would be nice to knock this one out right now so it doesn't need an FFE ^^ | 21:02 |
sfernand | that would be awesome :) | 21:11 |
sfernand | also worths a beer when we meet in person in a future PTG/summit :P, | 21:13 |
sfernand | hope we will still have them locally some day | 21:13 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!