| opendevreview | Chris M proposed openstack/cinder master: Dell PowerVault driver: Fix documentation typos https://review.opendev.org/c/openstack/cinder/+/809965 | 04:25 |
|---|---|---|
| opendevreview | Chris M proposed openstack/cinder master: Seagate driver: fix get_volume_size() https://review.opendev.org/c/openstack/cinder/+/809968 | 05:25 |
| opendevreview | Stephen Finucane proposed openstack/cinder master: Fix cinder-manage db version https://review.opendev.org/c/openstack/cinder/+/810000 | 11:26 |
| stephenfin | ^ FYI, I haven't tested that since I can get tox to run (it's complaining about package mismatches and I haven't had time to investigate). However, as noted in the bug, nova had this issue and the code is the same so... | 11:27 |
| *** dviroel|out is now known as dviroel | 11:36 | |
| opendevreview | Giulio Fidente proposed openstack/devstack-plugin-ceph master: Use Ceph Pacific for devstack-plugin-ceph-tempest-py3 jobs https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/807706 | 11:56 |
| opendevreview | Brian Rosmaita proposed openstack/cinder master: Raise min of oslo.policy to 3.8.1 https://review.opendev.org/c/openstack/cinder/+/810004 | 12:25 |
| rosmaita | whoami-rajat: when you have a minute, see what you think of Thierry's comment on https://review.opendev.org/c/openstack/releases/+/809892 | 12:36 |
| whoami-rajat | rosmaita, I looked but didn't know how to respond, In cinder we allow driver feature backports and we are mostly going to end up with driver features in every stable release and a minor version bump for every cinder release | 12:44 |
| whoami-rajat | I think i will just go with what the majority thinks it's right | 12:44 |
| rosmaita | whoami-rajat: i think he had a good point about https://docs.openstack.org/releasenotes/cinder/victoria.html#upgrade-notes | 12:45 |
| rosmaita | so it's not necessarily something we should do every time, but it might make sense for this one | 12:46 |
| whoami-rajat | hmm, that upgrade note is specific to rbd which already had that option and we just changed the default value of it and is not a feature but if his concern is more towards the upgrade notes then makes sense to me | 12:48 |
| rosmaita | whoami-rajat: ok, why don't you update the patch and you can mention something about incrementing the minor release number to draw attention to the upgrade note, that way you won't be stuck with a precedent to have to do it when feature-y changes are included in a driver | 12:52 |
| whoami-rajat | rosmaita, ok, will do, my concern is that, from time to time, the release team asks for a change and I'm not sure about if we are defining a new rule to do this from now on and if not then what's the reason for doing it this time | 12:56 |
| rosmaita | whoami-rajat: i understand ... you can always say something on the patch, and if they actually put a negative vote on a change that you disagree with, you can always put it on the agenda for a release team meeting for a discussion | 13:02 |
| whoami-rajat | rosmaita, ack, thanks :) | 13:15 |
| rosmaita | :) | 13:16 |
| zigo | FYI, cinder must require a higher version of oslo.log that contains XENA, otherwise, we get: | 14:04 |
| zigo | File "/<<PKGBUILDDIR>>/cinder/policies/base.py", line 264, in <module> | 14:04 |
| zigo | DEPRECATED_SINCE = versionutils.deprecated.XENA | 14:04 |
| zigo | AttributeError: type object 'deprecated' has no attribute 'XENA' | 14:04 |
| zigo | (during unit tests discovery) | 14:04 |
| zigo | Now I'm getting this: | 14:09 |
| zigo | http://paste.debian.net/1212507/ | 14:09 |
| zigo | Any clue what's going on? | 14:09 |
| raghavendrat | hi core reviewers, this is regarding https://review.opendev.org/c/openstack/cinder/+/804698 | 14:27 |
| raghavendrat | HPE 3PAR: Reuse existing session - its bugfix | 14:27 |
| raghavendrat | It would be great if someone can take a look. Thanks. | 14:28 |
| rosmaita | zigo: https://review.opendev.org/c/openstack/cinder/+/809891 | 14:33 |
| zigo | rosmaita: Thanks. Any clue regarding http://paste.debian.net/1212507/ ? | 14:33 |
| rosmaita | zigo: looking at that now, not sure | 14:33 |
| rosmaita | zigo: i think i need to bump min version for SQLAlchemy, sqlalchemy-migrate and SQLAlchemy-Utils | 14:37 |
| zigo | Oh, sqlalchemy-utils is probably the one. | 14:37 |
| zigo | I had this with other projects. | 14:37 |
| zigo | Thanks. | 14:37 |
| rosmaita | zigo: ty for bringing it up | 14:37 |
| rosmaita | zigo: i thought we had already upped SQLAlchemy to 1.4.0 and fixed some backward incompatibilities, but maybe we fixed and didn't change requirements.txt | 14:38 |
| zigo | FYI, when I package a new OpenStack release, everything is taken from Debian Unstable, except what I explicitely force to the version of Experimental, so I quickly see breakages ... | 14:39 |
| rosmaita | zigo: any objection to SQLAlchemy>=1.4.22, sqlalchemy-migrate>=0.13.0, SQLAlchemy-Utils>=0.37.8 ? | 14:40 |
| zigo | python3-sqlalchemy-utils was the one ! | 14:40 |
| zigo | It didn't work with 0.36.8 (from unstable) but it worked with 0.37.6 (from experimental). | 14:40 |
| zigo | rosmaita: 0.37.6 is enough, as much as I can see. | 14:40 |
| rosmaita | zigo: i am ok with 0.37.6 | 14:41 |
| zigo | FYI, I use SQLAlchemy 1.4.23 | 14:41 |
| rosmaita | ok, so >=1.4.22 won't hurt you | 14:42 |
| zigo | (I'm not the package maintainer for that one, but the person doing it learned to be cooperative) | 14:42 |
| zigo | Yeah, that's fine to me. | 14:42 |
| rosmaita | i'll put up a quick patch for sqlalchemy changes, and then review the rest of requirements.txt ... i did not think that it needed an update for release, but i am clearly mistaken | 14:42 |
| zigo | https://github.com/openstack/requirements/blob/master/upper-constraints.txt#L155 <--- This says 1.4.23 as well now. | 14:43 |
| rosmaita | zigo: i will rerun my local tests and see what gets pulled down | 14:43 |
| * zigo got a successful unit test run and a ready-to-be-uploaded Cinder package... :) | 14:45 | |
| rosmaita | zigo: ok, i will go with SQLAlchemy>=1.4.23, sqlalchemy-migrate>=0.13.0, SQLAlchemy-Utils>=0.37.8 | 14:55 |
| opendevreview | Brian Rosmaita proposed openstack/cinder master: Update SQLAlchemy related requirements https://review.opendev.org/c/openstack/cinder/+/810035 | 15:08 |
| opendevreview | Sofia Enriquez proposed openstack/cinder stable/ussuri: Allow removing NFS snapshots in error status https://review.opendev.org/c/openstack/cinder/+/809669 | 15:08 |
| mloza | hello, does cinder backup support multi backend? I have two backends enabled: rbd-1 and rbd-2, when I a backup on that volumes from rbd-2, it goes to rbd-1 backup pool. This is my cinder-backup config https://pastebin.com/raw/AQ4bRwrk | 15:43 |
| mloza | I added backup_use_same_host = True in [DEFAULT] and restarted cinder but after that, doing backups on both backends no longer work. | 15:46 |
| enriquetaso | mloza, cinder doesn't support backup multi backend as far as I know, there is a discussion in the mailing list regarding this: http://lists.openstack.org/pipermail/openstack-discuss/2021-September/024682.html | 15:55 |
| mloza | enriquetaso: I see. Thanks for the info | 16:16 |
| mloza | is it possible to disable backup on a backend? | 16:46 |
| mloza | while waiting for backup multi backend to get implemented, as a workaround, I would want to disable backup on the backend | 16:49 |
| enriquetaso | yes, the c-bak is optional | 16:53 |
| opendevreview | Merged openstack/cinder master: Raise minimum oslo.log to 4.5.0 https://review.opendev.org/c/openstack/cinder/+/809891 | 18:38 |
| whoami-rajat | rosmaita, hey, any reason for using 3.8.1 and not 3.8.0, there's no functional difference between the two and I think the idea is to keep the min possible version here (or maybe I'm wrong) https://review.opendev.org/c/openstack/cinder/+/810004 | 19:00 |
| opendevreview | Fábio Oliveira proposed openstack/cinder master: NetApp Solidfire: Fix retype volume fail due to status https://review.opendev.org/c/openstack/cinder/+/806616 | 19:17 |
| rosmaita | whoami-rajat: we could probably go with 3.8.0, but all the validation jobs were run with 3.8.1, so i figured it would be safest | 19:19 |
| rosmaita | plus, it's about 4 months old | 19:20 |
| whoami-rajat | rosmaita, if there's no point regarding using the min possible version then 3.8.1 sounds good to me | 19:20 |
| rosmaita | yeah, since we don't have lower constraints anymore, i think it makes sense to go with what we know works | 19:22 |
| whoami-rajat | ack, +Wed! | 19:23 |
| whoami-rajat | also we can propose backport of https://review.opendev.org/c/openstack/cinder/+/809891 , (if you're not planning to do all 4 backports together) | 19:24 |
| whoami-rajat | rosmaita, ^ | 19:24 |
| rosmaita | go ahead and propose the backport, we can do them separately | 19:25 |
| rosmaita | i need to propose os-brick 5.0.0 | 19:26 |
| rosmaita | and i'm going to run a local kind of lower-constraints job to see if anything else breaks | 19:26 |
| opendevreview | Rajat Dhasmana proposed openstack/cinder stable/xena: Raise minimum oslo.log to 4.5.0 https://review.opendev.org/c/openstack/cinder/+/810052 | 19:27 |
| whoami-rajat | done ^ | 19:28 |
| whoami-rajat | ack | 19:28 |
| opendevreview | Brian Rosmaita proposed openstack/cinder master: Specify xena os-brick series in requirements https://review.opendev.org/c/openstack/cinder/+/810118 | 19:29 |
| opendevreview | Nahim Alves de Souza proposed openstack/cinder master: NetApp ONTAP: Fix sub-clone zapi call https://review.opendev.org/c/openstack/cinder/+/798208 | 19:57 |
| opendevreview | Merged openstack/devstack-plugin-ceph master: Use Ceph Pacific for devstack-plugin-ceph-tempest-py3 jobs https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/807706 | 19:57 |
| *** dviroel is now known as dviroel|out | 21:09 | |
| opendevreview | Merged openstack/cinder stable/xena: Raise minimum oslo.log to 4.5.0 https://review.opendev.org/c/openstack/cinder/+/810052 | 21:29 |
| opendevreview | Chris M proposed openstack/cinder master: Seagate driver: fix get_volume_size() https://review.opendev.org/c/openstack/cinder/+/809968 | 22:20 |
| opendevreview | Chris M proposed openstack/cinder master: Seagate driver: fix get_volume_size() https://review.opendev.org/c/openstack/cinder/+/809968 | 22:21 |
| opendevreview | Chris M proposed openstack/cinder master: Dell PowerVault driver: Fix documentation typos https://review.opendev.org/c/openstack/cinder/+/809965 | 22:22 |
| opendevreview | Chris M proposed openstack/cinder master: Dell PowerVault: Fix "cinder manageable-list" https://review.opendev.org/c/openstack/cinder/+/808837 | 22:45 |
| opendevreview | Brian Rosmaita proposed openstack/cinder master: DNM: add tox env to check requirements https://review.opendev.org/c/openstack/cinder/+/810131 | 22:49 |
| pots | rosmaita Thanks for your guidance on Friday--I've split https://review.opendev.org/c/openstack/cinder/+/808837 into 3 bugs: https://review.opendev.org/c/openstack/cinder/+/809965 is doc-only and https://review.opendev.org/c/openstack/cinder/+/809968 is just 1 line. | 22:51 |
| rosmaita | pots: ok, thanks | 23:04 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!