| opendevreview | zhaoleilc proposed openstack/cinder master: Amend the meaning of ratio lower than 1.0 https://review.opendev.org/c/openstack/cinder/+/820289 | 03:30 |
|---|---|---|
| *** akekane_ is now known as abhishekk | 06:56 | |
| *** hemna8 is now known as hemna | 07:37 | |
| *** _pewp__ is now known as _pewp_ | 07:38 | |
| yuval | Hey, small question | 09:09 |
| yuval | I know I can checkout a branch using git review -d <id> | 09:10 |
| yuval | is there a way to do: git checkout <branch> | 09:10 |
| whoami-rajat__ | yuval, do you want to checkout a branch like stable/train, stable/wallaby etc or a review patch branch? | 09:36 |
| yuval | review a patch for third party ci | 09:37 |
| whoami-rajat__ | any problem you're facing with git review -d? | 09:38 |
| whoami-rajat__ | yuval, if you go down in the gerrit review, you will see a download option, you can checkout using that command | 09:38 |
| yuval | I to fix git review on my nodes | 09:39 |
| yuval | yes, its working thanks | 09:46 |
| yuval | is there a standard flow for third party ci's? if I test patch x, I should checkout patch and then cherry-pick my changes (the lightos driver) | 09:48 |
| yuval | is there a smarter way to do it? | 09:48 |
| yuval | I concern I will face git conflict issues | 09:48 |
| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Reset state robustification for volume os-reset_status https://review.opendev.org/c/openstack/cinder/+/773985 | 11:18 |
| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Reset state robustification for snapshot os-reset_status https://review.opendev.org/c/openstack/cinder/+/804035 | 11:19 |
| *** dviroel|afk is now known as dviroel | 11:22 | |
| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Reset state robustification for group-snapshot os-reset_status https://review.opendev.org/c/openstack/cinder/+/804757 | 11:23 |
| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Reset state robustification for group os-reset_status https://review.opendev.org/c/openstack/cinder/+/804735 | 11:23 |
| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Reset state robustification for backup os-reset_status https://review.opendev.org/c/openstack/cinder/+/778193 | 11:23 |
| haailani | hi | 13:06 |
| haailani | [SVF] Fixed Detach operation for multi-attach volumes where second detach was failing. | 13:07 |
| haailani | https://review.opendev.org/c/openstack/cinder/+/809518 | 13:07 |
| haailani | Requesting the core reviewers to please review the changes. | 13:07 |
| haailani | [SVF] Added cleanrate in volume-type extra specs : https://review.opendev.org/c/openstack/cinder/+/811877 | 13:08 |
| haailani | Requesting the core reviewers to please review the changes. | 13:08 |
| venkatakrishnat | Hi core-reviewers, Waiting for CR +2 for the patch https://review.opendev.org/c/openstack/cinder/+/810917 . Could someone please have a look. Thanks in adv. | 15:00 |
| *** dviroel is now known as dviroel|lunch | 15:02 | |
| opendevreview | Merged openstack/cinder-tempest-plugin master: Refactor test_volume_backup due to leftovers https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/812265 | 15:21 |
| caiqilong | enriquetaso,hemna: the previous reviewing "https://review.opendev.org/c/openstack/cinder/+/816443" needs a recheck. The locally unit test and other CI tests all passed. Could you please take a look? | 15:48 |
| hemna | https://review.opendev.org/c/openstack/cinder/+/815582. this one is kinda weird | 15:58 |
| hemna | looks like a branding driver | 15:58 |
| rosmaita | yeah, we discussed at a meeting at some point and decided that's ok. Key thing is to check that they handle options correctly and report the correct options | 16:05 |
| *** dviroel|lunch is now known as dviroel | 16:07 | |
| elodilles | rosmaita: hi, I have a release management related question: | 16:07 |
| elodilles | release management's consistency check showed that | 16:07 |
| elodilles | rbd-iscsi-client | 16:07 |
| elodilles | is missing a deliverable for Yoga. | 16:08 |
| elodilles | Do you aim to release it in Yoga or is it intentionally left out from you deliverables? | 16:08 |
| rosmaita | elodilles: we haven't released that officially from openstack yet | 16:08 |
| rosmaita | there are some CI problems that still need to be resolved | 16:08 |
| elodilles | rosmaita: and you don't want it in Yoga eiher :) | 16:09 |
| rosmaita | it's on an independent release model | 16:09 |
| elodilles | hmmm, ok, sorry, then it is not yoga related | 16:09 |
| rosmaita | elodilles: well, independent was our intention, not sure i filled out all the paperwork correctly, though | 16:10 |
| elodilles | rosmaita: i think our consistency check is against independent deliverables as well, | 16:11 |
| elodilles | rosmaita: but of course it is not related to yoga then | 16:11 |
| rosmaita | ok, cool ... thanks for checking! | 16:11 |
| elodilles | rosmaita: thanks too for the answer :) | 16:12 |
| walshh_ | If anyway has a some time could they take a look at https://review.opendev.org/c/openstack/cinder/+/803773 and https://review.opendev.org/c/openstack/cinder/+/803785. Both have clean CI | 16:21 |
| walshh_ | anyone* | 16:22 |
| walshh_ | Thank you | 16:22 |
| caiqilong | hemna: Thanks for your reviewing. I will follow your suugestion using the trace facility from volume_utils according to your provided example in a future new patch after the integrated tests. | 16:29 |
| opendevreview | Eric Harney proposed openstack/cinder master: tests: pylint: Fix E0213 no-self-argument https://review.opendev.org/c/openstack/cinder/+/787632 | 16:36 |
| yuval | Hey, I created a third party ci, I tested it on sandbox. Can create a dummy patch set to test it? | 16:49 |
| opendevreview | yuval proposed openstack/cinder master: NO merge, test lightbits third party ci https://review.opendev.org/c/openstack/cinder/+/824031 | 16:57 |
| caiqilong | yuval: of course, the sandbox project "https://opendev.org/opendev/sandbox" is used to do this. | 16:59 |
| yuval | I mean, I tested on sandbox, but the transtion to cinder need test as well | 17:00 |
| caiqilong | yuval: the real revewing workflow of cinder needs at least two core reviewer's +2. | 17:04 |
| caiqilong | if you just test in a dummy patch, it will not be merged to the "https://opendev.org/opendev/cinder". | 17:05 |
| yuval | yes, I dont want to merge it, just to see how my ci reacts | 17:06 |
| caiqilong | yes, your ci will response according to your zuul configuration. | 17:07 |
| venkatakrishnat | Hi core-reviewers, Waiting for CR +2 for the patch https://review.opendev.org/c/openstack/cinder/+/810917 . In your free time, could someone please have a look. Thanks in adv. | 17:07 |
| caiqilong | I set my ci response just to new patch of cinder or specific comments like "run-TOYOU ACS5000 CI". | 17:08 |
| opendevreview | yuval proposed openstack/cinder master: NO merge, test lightbits third party ci https://review.opendev.org/c/openstack/cinder/+/824031 | 17:11 |
| hemna | caiqilong cool. I would add the trace around the initialize_connection calls too. | 17:18 |
| caiqilong | hemna: thanks for your praise, my colleagues use debug information to do detailed debugging during development. | 17:29 |
| opendevreview | Sofia Enriquez proposed openstack/cinder master: rbd: fix full restore ceph backups https://review.opendev.org/c/openstack/cinder/+/750782 | 20:22 |
| opendevreview | Sofia Enriquez proposed openstack/cinder master: rbd: fix full restore ceph backups https://review.opendev.org/c/openstack/cinder/+/750782 | 20:23 |
| *** dviroel is now known as dviroel|out | 21:28 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!