*** hemna5 is now known as hemna | 01:45 | |
*** _pewp___ is now known as _pewp_ | 03:17 | |
*** hemna5 is now known as hemna | 03:21 | |
opendevreview | Rajat Dhasmana proposed openstack/os-brick master: Remove unused host driver https://review.opendev.org/c/openstack/os-brick/+/822871 | 06:41 |
---|---|---|
opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Reset state robustification for volume os-reset_status https://review.opendev.org/c/openstack/cinder/+/773985 | 07:41 |
*** dviroel|out is now known as dviroel | 10:54 | |
opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Reset state robustification for group os-reset_status https://review.opendev.org/c/openstack/cinder/+/804735 | 11:22 |
opendevreview | Atsushi Kawai proposed openstack/cinder master: Hitachi: add GAD volume support https://review.opendev.org/c/openstack/cinder/+/829877 | 11:24 |
opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Reset state robustification for group-snapshot os-reset_status https://review.opendev.org/c/openstack/cinder/+/804757 | 11:25 |
raghavendrat | hi rosmaita: this is regarding https://blueprints.launchpad.net/cinder/+spec/nimble-replication-support | 13:25 |
raghavendrat | i updated "Milestone target" to "zed-2" | 13:26 |
rosmaita | ok | 13:26 |
raghavendrat | and "Series goal" as "zed" | 13:26 |
rosmaita | oh, ok, i thought you were going to ask why I did that, and i could not remember moving that BP! | 13:26 |
raghavendrat | somehow, it is not seen under https://blueprints.launchpad.net/cinder/zed | 13:27 |
rosmaita | ok, that's because the "Series goal" says "Proposed for zed" | 13:28 |
rosmaita | take a look now | 13:28 |
raghavendrat | now visible. Thank you for quick help | 13:29 |
rosmaita | np | 13:29 |
rosmaita | i still don't understand how Launchpad handles blueprints, so always ask if you see something weird | 13:29 |
raghavendrat | sure | 13:29 |
TusharTgite | rosmaita: zuul test passed take a look https://review.opendev.org/c/openstack/cinder/+/773985 | 13:48 |
rosmaita | looking | 13:48 |
rosmaita | what did you change? | 13:50 |
TusharTgite | rosmaita: i added "ing " condition checks and i was checking same state twice in the code like available to available | 13:52 |
TusharTgite | thats what cause error | 13:52 |
rosmaita | ok, good job | 13:54 |
rosmaita | TusharTgite: left a comment, i think you may have a typo in one of your messages, but otherwise looks good | 13:57 |
rosmaita | though i need to look at the tests carefully on my next review | 13:57 |
rosmaita | but, looking good! | 13:57 |
TusharTgite | rosmaita: is there anything else left cause it almost patchset35 i'll push a final patchset then | 13:58 |
rosmaita | well, like i said, i want to look at the UTs to check what situations you are covering, so no promises! | 13:59 |
rosmaita | that's all i saw on this run-through | 13:59 |
TusharTgite | rosmaita: ok i'll wait for that and will push patch tommorow then | 14:01 |
rosmaita | reminder: Cinder Festival of Reviews today, 1400-1600 UTCjoin us in meetpad: https://meetpad.opendev.org/cinder-festival-of-reviewsor go directly to the etherpad: https://etherpad.opendev.org/p/cinder-festival-of-reviewsjungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard sfernand enriquetaso hemna fabiooliveira | 14:01 |
rosmaita | well, that was a formatting fail | 14:01 |
* enriquetaso having bandwidth problems | 14:03 | |
rosmaita | festival etherpad: https://etherpad.opendev.org/p/cinder-festival-of-reviews | 14:03 |
jungleboyj | :-) | 14:08 |
jungleboyj | Will join as I am able today. | 14:08 |
whoami-rajat | rosmaita, I don't remember the reason but why we don't do this in Bluejeans ? :) | 14:12 |
rosmaita | because you can't see as many people at once | 14:12 |
whoami-rajat | oh | 14:13 |
enriquetaso | I'm not really familiar with availability zones but I thought that backups could have their own. That's why I'm not sure what to do about https://review.opendev.org/c/openstack/cinder/+/816104 . If anyone is familiar with this please add a comment on the patch. | 14:15 |
opendevreview | Merged openstack/cinder master: DOC: Add cinder modules on initial configuration https://review.opendev.org/c/openstack/cinder/+/818233 | 14:21 |
TusharTgite | i need final call on this one shall i really abandon this https://review.opendev.org/c/openstack/cinder/+/799631 it's a good clean up i've covered entire cinder repo. | 14:26 |
hemna | mep | 14:28 |
enriquetaso | TusharTgite, think geguileo has a good point regarding 799631 | 14:32 |
TusharTgite | enriquetaso: ok i'll abandon it then | 14:37 |
enriquetaso | :( | 14:40 |
dswebb | apologies, totally spaced on this meeting. Is it too late to try and get this reviewed? https://review.opendev.org/c/openstack/cinder/+/820027 | 14:46 |
rosmaita | dswebb: that is kind of not an XS patch, so maybe later | 14:48 |
dswebb | ah ok, no worries, will remove it from the meeting notes then | 14:48 |
rosmaita | you can leave it, maybe someone will follow up after the meeting | 14:48 |
rosmaita | we do want to try to power through as many XS reviews as possible | 14:49 |
dswebb | XS? | 14:50 |
jungleboyj | rosmaita: Has the meeting started already? Thought it started in 10 minutes. | 14:51 |
rosmaita | 1400 utc!!! | 14:52 |
jungleboyj | Ugh. I logged onto the meetpad and didn't see anyone. | 14:53 |
rosmaita | dswebb: "extra small" -- <=10 lines | 14:53 |
rosmaita | jungleboyj: that's weird, there are 8 of us there | 14:53 |
jungleboyj | Let me try again. | 14:54 |
rosmaita | meetpad link above is incorrect due to formatting ... here is where we are: https://etherpad.opendev.org/p/cinder-festival-of-reviews | 14:57 |
rosmaita | (sorry about that) | 14:57 |
hemna | meeting? | 14:58 |
jungleboyj | We hear you. | 14:59 |
* enriquetaso lost connection | 15:10 | |
opendevreview | Merged openstack/cinder-specs master: Add zed directory for specs https://review.opendev.org/c/openstack/cinder-specs/+/829828 | 15:11 |
rosmaita | hemna: you've done a lot of work with backups, can you take a look at https://review.opendev.org/c/openstack/cinder/+/816104 ? | 15:12 |
hemna | ok checking | 15:12 |
rosmaita | it's only 1 line, but i wonder whether it could cause a regression | 15:12 |
rosmaita | (but not for any good reason, i am just a worrier) | 15:13 |
rosmaita | thanks! | 15:13 |
opendevreview | Iago Filipe proposed openstack/cinder master: Improving delete volumes exception log https://review.opendev.org/c/openstack/cinder/+/828150 | 15:14 |
hemna | rosmaita, I'm wondering how the AZ could be different in this case. the original backup could be on 1 AZ and a new volume being created from that backup is in a different AZ? | 15:19 |
hemna | how could that be? | 15:19 |
opendevreview | Merged openstack/cinder master: PowerFlex documentation contains invalid paths https://review.opendev.org/c/openstack/cinder/+/772875 | 15:20 |
rosmaita | hemna: Environment: | 15:20 |
rosmaita | 2 azs, each with a c-vol and c-bak | 15:20 |
rosmaita | cinder servers at each az have their own ceph and the ceph is only accessible within the AZ | 15:20 |
rosmaita | cinder backup uses swift driver and swift is globally accessible | 15:20 |
hemna | I guess I wasn't sure they'd be able to see the backup in the list being in 2 different AZ's for the project | 15:21 |
hemna | cinder backup-list | 15:21 |
rosmaita | hemna: yeah, take a look at the description in the bug: https://bugs.launchpad.net/cinder/+bug/1949313 | 15:21 |
hemna | maybe I'm thinking of our deployment too much. we don't have cinder managing multiple AZs. they are totally separate deployments | 15:22 |
rosmaita | i'm slightly worried that this change may work great in his deployment, but may cause a problem elsewhere | 15:22 |
rosmaita | though the change does seem to make sense | 15:23 |
hemna | so, I guess the question is, if there are multiple AZ's in a cinder deployment, will that logic always be the case, where a backup backend always has access to both AZs? | 15:23 |
hemna | I'm not sure that's a guarantee | 15:25 |
hemna | maybe it makes sense to have a config option to allow cross AZ restores/creates from backups. the admin would know if that same backend was available in both AZs | 15:26 |
hemna | ok added a -1 on it and those comments | 15:28 |
opendevreview | OpenStack Release Bot proposed openstack/os-brick stable/yoga: Update .gitreview for stable/yoga https://review.opendev.org/c/openstack/os-brick/+/829907 | 15:32 |
opendevreview | OpenStack Release Bot proposed openstack/os-brick stable/yoga: Update TOX_CONSTRAINTS_FILE for stable/yoga https://review.opendev.org/c/openstack/os-brick/+/829908 | 15:32 |
opendevreview | OpenStack Release Bot proposed openstack/os-brick master: Update master for stable/yoga https://review.opendev.org/c/openstack/os-brick/+/829909 | 15:32 |
rosmaita | hemna: thank you | 15:33 |
rosmaita | looks like yoga os-brick has been released! | 15:33 |
jungleboyj | Need to jump to another meeting. Good to see you guys. | 15:34 |
rosmaita | jungleboyj: thanks for attending, have a good weekend | 15:35 |
jungleboyj | Thanks. You too! | 15:36 |
whoami-rajat | fabiooliveira, is the bug report for a local run or a gate job? https://bugs.launchpad.net/cinder/+bug/1934459 | 15:40 |
hemna | so I'm running into another backup issue. A volume exists on a pool that has limited space leftover and a user wants to do a backup. The volume is attached, so that requires a snapshot of the volume being made and on our backend that results in a clone effectively. Since there isn't enough space on that pool to hold the clone, the backup fails | 15:41 |
hemna | 100% of the time. | 15:41 |
hemna | that's not very 'cloudy' | 15:41 |
fabiooliveira | whoami-rajat: from a local run | 15:41 |
hemna | if I migrate the volume, it could end up on another pool that has the same problem. | 15:42 |
hemna | I have a similar problem with extend volume too. | 15:42 |
whoami-rajat | fabiooliveira, can you share the final part of the stack trace (omitted in the bug report) if handy | 15:42 |
hemna | customers just want the actions to work. they don't care where the volumes live. | 15:42 |
hemna | kinda need an option for some of these actions that auto migrate to pools that have space for the actions to work. | 15:45 |
hemna | and migrations can take a while, so it needs to be async. | 15:45 |
hemna | I also think cinder needs transaction tracking for actions on volumes as a paper trail. | 15:46 |
hemna | we have so many inconsistent volumes from attaches, migrations it's overwhelming at this point. | 15:46 |
rosmaita | well, if we're going to start auto migrating stuff, we definitely need some kind of transaction trail | 15:47 |
hemna | yes | 15:47 |
rosmaita | but if an operator runs pools real close to capacity, they have to expect there will be some problems | 15:48 |
hemna | for sure. if there isn't space, there isn't space | 15:49 |
hemna | but the scheduler would know that. | 15:49 |
hemna | in our case we are always on the edge, but when we reach low capacity, we add more storage | 15:49 |
whoami-rajat | I will be leaving now, happy weekend everyone! | 15:49 |
hemna | if the auto migrate was available, then it would just keep things working and re-balancing basically | 15:49 |
rosmaita | bye Rajat! | 15:50 |
fabiooliveira | whoami-rajat: don't have it, right now, but I can provide it soon | 15:50 |
fabiooliveira | whoami-rajat: bye, have a nice weekend | 15:50 |
whoami-rajat | fabiooliveira, ack, i will remove my -1 as i see the shuffling between the base and Iscsi driver __getattr__ methods but just want to confirm it | 15:51 |
whoami-rajat | bye! | 15:52 |
opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Deleting a volume in 'downloading' state https://review.opendev.org/c/openstack/cinder/+/826607 | 15:55 |
hemna | extend volume already goes through the scheduler | 15:59 |
*** dviroel is now known as dviroel|lunch | 16:29 | |
zigo | What new feature of PBR is os-brick using? | 16:32 |
zigo | I mean, it now declares pbr >= 5.8.0, I'd like to know why. | 16:32 |
zigo | Same for all the 12 other updated depends... | 16:33 |
rosmaita | zigo: doesn't matter, we've been testing with the new versions only for the number of months specified in the commit message | 16:33 |
rosmaita | i mean, we've only been testing with the new versions for the number of months specified | 16:34 |
zigo | rosmaita: It does mater, requiring a version which is not already in Xena is very bad practice and is very annoying for in production deployments upgrades. | 16:35 |
zigo | If that's what's going to happen, then we MUST re-introduce lower-constraints testing quickly. | 16:35 |
zigo | I'm opening a list thread right away... | 16:37 |
rosmaita | ok, that is a good idea | 16:37 |
opendevreview | Merged openstack/cinder master: zuul: configure irrelevant-files for the rally job https://review.opendev.org/c/openstack/cinder/+/793367 | 16:48 |
opendevreview | Merged openstack/cinder master: Remove unused variable https://review.opendev.org/c/openstack/cinder/+/825546 | 16:48 |
opendevreview | Merged openstack/cinder master: PowerMax docs - Include a note in cinder backup section https://review.opendev.org/c/openstack/cinder/+/825360 | 16:48 |
sreerammounika | Hi reviewers, Requesting you to review the commit https://review.opendev.org/c/openstack/cinder/+/823015. | 17:01 |
opendevreview | Merged openstack/cinderlib master: setup.cfg: Replace dashes by underscores https://review.opendev.org/c/openstack/cinderlib/+/827988 | 17:12 |
opendevreview | Merged openstack/os-brick master: Update master for stable/yoga https://review.opendev.org/c/openstack/os-brick/+/829909 | 17:20 |
opendevreview | Merged openstack/os-brick stable/yoga: Update .gitreview for stable/yoga https://review.opendev.org/c/openstack/os-brick/+/829907 | 17:20 |
opendevreview | Merged openstack/os-brick stable/yoga: Update TOX_CONSTRAINTS_FILE for stable/yoga https://review.opendev.org/c/openstack/os-brick/+/829908 | 17:20 |
*** dviroel|lunch is now known as dviroel | 17:32 | |
opendevreview | Lucas Morais de oliveira proposed openstack/cinder master: WIP api-ref: Add docs for clusters https://review.opendev.org/c/openstack/cinder/+/795785 | 17:47 |
*** dviroel is now known as dviroel|afk | 20:09 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!