Wednesday, 2022-02-23

*** dviroel is now known as dviroel|out00:20
opendevreviewyuval proposed openstack/cinder master: lightos - bugfix compression stats should be True  https://review.opendev.org/c/openstack/cinder/+/83053800:20
opendevreviewTushar Trambak Gite proposed openstack/cinder master: Reset state robustification for volume os-reset_status  https://review.opendev.org/c/openstack/cinder/+/77398504:19
*** bhagyashris_ is now known as bhagyashris06:28
opendevreviewTushar Trambak Gite proposed openstack/cinder master: Reset state robustification for snapshot os-reset_status  https://review.opendev.org/c/openstack/cinder/+/80403507:26
opendevreviewTushar Trambak Gite proposed openstack/cinder master: Reset state robustification for backup os-reset_status  https://review.opendev.org/c/openstack/cinder/+/77819307:27
opendevreviewTushar Trambak Gite proposed openstack/cinder master: Reset state robustification for snapshot os-reset_status  https://review.opendev.org/c/openstack/cinder/+/80403508:47
opendevreviewyuval proposed openstack/cinder master: lightos - bugfix compression stats should be True  https://review.opendev.org/c/openstack/cinder/+/83053808:52
opendevreviewTushar Trambak Gite proposed openstack/cinder master: Reset state robustification for snapshot os-reset_status  https://review.opendev.org/c/openstack/cinder/+/80403509:15
*** bhagyashris_ is now known as bhagyashris09:25
yuvaldear pewp your reconnections are spamming the chat - consider using a different client10:33
toskyhemna: it looks like pewp is a bot of yours, or at least an instance of a bot developed by you :) maybe it should change its hosting?10:35
*** dviroel|out is now known as dviroel11:26
opendevreviewyuval proposed openstack/cinder master: lightos - bugfix compression stats should be True  https://review.opendev.org/c/openstack/cinder/+/83053813:03
hemnatosky, yah my internets has been odd lately13:22
hemnamy isp is ipv6 only basically and it's not playing nice at times13:23
rosmaitahemna: i put pewp on the agenda for today's cinder meeting, can you explain what it's for?  It pre-dates my involvement in cinder, and afaik, only you and jungleboyj use it intentionally ... maybe if people understood it better, they will cut it some slack with its recent connectivity problems13:35
hemnait's really nothing important13:35
rosmaitamy impression is that it's kind of a fun thing?13:35
hemnayah it's just a fun thing that we used 13:35
jungleboyjHe he.  rosmaita wants to know about pewp .13:35
hemnalolz13:35
jungleboyj@h13:36
jungleboyjI can't remember how to use pewp.13:36
* hemna looks at pewp logs13:36
rosmaitarofl, jungleboyj can't remember how to pewp13:36
rosmaitai think it's an autonomic function, if you think about it too much, you can't do it13:36
jungleboyj*rofl*13:37
jungleboyjSince we have a video meeting this week I have a conflict ... So, won't make it.  :-(13:38
rosmaitaok13:38
hemnasopel.irc.backends   ERROR    - Server timeout detected after 121.266824s; closing.13:38
jungleboyjWe can't pewp ?13:39
hemnasome connectivity issue.   I've had to learn ipv6 quickly with my new firewall at home and I'm not sure if I've got it setup correctly just yet.  It's quite complicated13:39
opendevreviewTushar Trambak Gite proposed openstack/cinder master: Reset state robustification for snapshot os-reset_status  https://review.opendev.org/c/openstack/cinder/+/80403513:40
jungleboyjYour ISP has switched to IPv6.13:40
hemnaI shut it down for now13:41
hemnaI'll mess with it later13:41
hemnawell, yes and no.  they only give out ipv4 BOGON ips, which aren't routable, but give out an ipv6 /64 subnet13:41
hemnaipv4 behind a NAT, which sux0rs13:42
jungleboyjUgh, I had to pay for a non-nated IP address to avoid that mess.13:45
opendevreviewTushar Trambak Gite proposed openstack/cinder master: Reset state robustification for snapshot os-reset_status  https://review.opendev.org/c/openstack/cinder/+/80403513:51
TusharTgiterosmaita: updated the patch https://review.opendev.org/c/openstack/cinder/+/77398513:52
rosmaitaTusharTgite: ack13:53
rosmaitareminder: today's cinder meeting is on video + #openstack-meeting-alt at 1400 UTC13:59
rosmaitaconnection info: https://bluejeans.com/322852897313:59
rosmaitajungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard sfernand enriquetaso hemna fabiooliveira yuval ^^13:59
*** whoami-rajat__ is now known as whoami-rajat13:59
whoami-rajatthanks rosmaita 14:00
geguileorosmaita: thanks14:00
hemna jungleboyj I tried to get the isp to sell me a static ipv4, but they refused.  I just think ipv4 is pretty much out of addresses for new ISPs now.    14:01
hemnafibre to the home 1gbps up and down...so I had to try and make it work14:01
jungleboyjhemna:  Wow, that is crazy.  Yeah, that is what I have as well.  But have to pay an extra $5 a month for a static IP or something.14:02
hemnahah $5 lol.  yah that's a no brainer14:02
jungleboyjExactly, to avoid all the issues that can come with having a NATed IP.14:02
* enriquetaso bj freeze all the time14:04
jungleboyj*sad trombone.wav*14:05
whoami-rajatgeguileo, you're not in the meeting channel so https://review.opendev.org/c/openstack/cinder/+/82204014:10
geguileowhoami-rajat: oh, my bad14:12
hemnahttps://github.com/hemna/sopel-tableflip14:31
hemnaThe help for it.  https://github.com/hemna/sopel-tableflip/blob/master/sopel_modules/tableflip/tableflip.py#L84-L10014:31
coreycbHi enriquetaso, by any chance would you be able to revisit https://review.opendev.org/c/openstack/cinder/+/815560 ?14:37
enriquetasosure coreycb, I'll do it after the meetings14:43
coreycbenriquetaso: thank you, appreciate it14:43
enriquetaso#startmeeting cinder_bs15:00
opendevmeetMeeting started Wed Feb 23 15:00:13 2022 UTC and is due to finish in 60 minutes.  The chair is enriquetaso. Information about MeetBot at http://wiki.debian.org/MeetBot.15:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.15:00
opendevmeetThe meeting name has been set to 'cinder_bs'15:00
enriquetaso13 new bugs reported this period.15:00
enriquetasoFull list of bugs:15:00
enriquetaso#link http://lists.openstack.org/pipermail/openstack-discuss/2022-February/027391.html15:00
fabiooliveirao/15:00
yuvalmy favorite meeting :)15:00
enriquetasohttps://bugs.launchpad.net/os-brick/+bug/196110215:01
enriquetasoNVMe-oF doesn't disconnect15:01
enriquetaso#topic NVMe-oF doesn't disconnect15:01
enriquetaso#link https://bugs.launchpad.net/os-brick/+bug/1961102 15:01
enriquetaso#topic Request ID15:03
enriquetaso#link https://bugs.launchpad.net/cinder/+bug/1960329 15:03
enriquetasoWrong request ID on API middleware filters. ^15:03
enriquetaso#link https://bugs.launchpad.net/cinder/+bug/1960021 15:03
enriquetaso#link https://bugs.launchpad.net/cinder/+bug/196002015:03
enriquetaso#link https://bugs.launchpad.net/cinder/+bug/1960019 15:04
enriquetasoyuval++15:05
enriquetasoThe idea is to get them in yoga and backport them. 15:08
enriquetaso#endmeeting15:09
opendevmeetMeeting ended Wed Feb 23 15:09:33 2022 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)15:09
opendevmeetMinutes:        https://meetings.opendev.org/meetings/cinder_bs/2022/cinder_bs.2022-02-23-15.00.html15:09
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/cinder_bs/2022/cinder_bs.2022-02-23-15.00.txt15:09
opendevmeetLog:            https://meetings.opendev.org/meetings/cinder_bs/2022/cinder_bs.2022-02-23-15.00.log.html15:09
opendevreviewTushar Trambak Gite proposed openstack/cinder master: Reset state robustification for group-snapshot os-reset_status  https://review.opendev.org/c/openstack/cinder/+/80475715:10
opendevreviewTushar Trambak Gite proposed openstack/cinder master: Reset state robustification for group-snapshot os-reset_status  https://review.opendev.org/c/openstack/cinder/+/80475715:12
opendevreviewGorka Eguileor proposed openstack/cinder master: Fix request id mess on Cinder-API  https://review.opendev.org/c/openstack/cinder/+/82786015:13
geguileoeharney: ^ done15:13
geguileorosmaita: Could you review it again?  I only removed 1 comment15:13
rosmaitageguileo: sure, no problem15:27
geguileorosmaita: thanks15:27
rosmaita(was outside, that mouse is still stuck in my window well)15:27
opendevreviewEric Harney proposed openstack/cinder master: Don't init backup API code for each create volume request  https://review.opendev.org/c/openstack/cinder/+/83063215:27
yuvalhey, small question in volume type property we allow a property to have value "True" or "<is> True"15:28
yuvalwhy like this?15:28
yuvalI mean the "<is> True" forcing us to parse the value "understand" it15:29
rosmaitai think because they are really strings, this way there's no confusion15:29
yuvalis that some legacy thing15:29
rosmaitawhat i mean is bool("False") is True in python15:30
yuvalyes, but the "<is> " is cinder convention right? its something python support15:31
yuval?15:31
rosmaitayuval: yes, it's a cinder thing15:32
yuvalthe result are functions like this:https://opendev.org/openstack/cinder/src/branch/master/cinder/volume/drivers/qnap.py#L28115:32
jungleboyjA Cinder thing that has always baffled me to some extent.  :-)15:36
opendevreviewMerged openstack/cinder master: Remove the need for project_id from API endpoints  https://review.opendev.org/c/openstack/cinder/+/82204015:40
rosmaita\o/15:40
opendevreviewEric Harney proposed openstack/cinder master: Only init message API in create volume when needed  https://review.opendev.org/c/openstack/cinder/+/83063415:41
rosmaitageguileo: looks like https://review.opendev.org/c/openstack/cinder/+/827860/ has gone into merge conflict15:43
geguileorofl rofl15:44
rosmaitayou win some, you lose some15:44
rosmaitawhoami-rajat: if you're still around, alan's project_id patch has merged15:46
geguileoit's abishop's patch to not require the project id15:46
geguileorosmaita: that's precisely the one that broke mine15:46
geguileolol15:46
rosmaita:D15:46
hemnahttps://github.com/openstack/cinder/blob/master/cinder/scheduler/filters/capacity_filter.py#L131-L132. shouldn't that be provisioned + requested / available_total15:48
hemnawhere available_total is total - (total * reserved %)15:49
whoami-rajatrosmaita, great, will update15:49
opendevreviewGorka Eguileor proposed openstack/cinder master: Fix request id mess on Cinder-API  https://review.opendev.org/c/openstack/cinder/+/82786015:49
hemnainstead of subtracting the reserved space from the reported free space15:49
geguileorosmaita: eharney  ^ let's try again without the merge conflict15:49
hemnareserved_percent is defined as 'The percentage of backend capacity is reserved', so why is it being applied to free space.   The total available is the capacity, not the currently free.15:54
hemnathe filter scheduler's algorithm is not right IMHO15:56
yuvalhemna what you mean?15:57
hemnathe calculations for the overprovisioning and available space isn't right I think15:57
hemnaand it's being done differently in a few places within cinder15:58
yuvalot: sorry for missing the meeting today15:58
rosmaitayuval: ack15:59
rosmaitahemna: i got sidetracked yesterday and never found that doc about how cinder computes available space15:59
*** gmann is now known as gmann_afk15:59
hemnawell, I'm looking at the code and it seems quite weird and inconsistent16:00
hemnaI'm working on another gist with some of my findings.   16:00
rosmaitacool, that will be helpful16:02
rosmaitai guess we need to abstract these computations out to common utility code16:02
hemnaI think the current way of calculating the provisioned ratio leads to under reporting of the ratio because it uses the total space instead of the available space (total - reserved)16:02
hemnaheh16:02
opendevreviewHarsh Ailani proposed openstack/cinder master: [SVf]:Fix multiple lsvdisk calls for GMCV create volume operation.  https://review.opendev.org/c/openstack/cinder/+/82911016:02
hemnayou mean like this? https://review.opendev.org/c/openstack/cinder/+/83045616:03
rosmaita:D16:03
hemnaanyway, the provisioned ration for one of my pools is reporting 0.81 16:03
hemnawhen it's actually over provisioned already16:04
hemna> 116:04
hemnabecause it's allocated_capacity / total16:04
hemnaintead of allocated / (total - reserved)16:04
hemnaand the free space is free reported - reserved16:04
hemnareserved is supposed to be applied to the total capacity, not the currently free, which changes16:05
hemnathe reason I'm going over this, is because I'm seeing provisioning requests going through in my scheduler that thinks there is enough free space, but there isn't.16:06
hemnaso the create fails16:06
hemnaso at least I'd like to get a consistent answer for what it means to be provisioning ratio, virtual free, actual available, etc16:06
hemnait's probably been overlooked for years because not many have run into low available pools deployments16:07
rosmaitai suspect you are correct about that16:07
hemnawe tend to run our individual pools down to low left, then alert with our tooling on that and then create new pools when needed.16:08
*** gmann_afk is now known as gmann16:17
opendevreviewTushar Trambak Gite proposed openstack/cinder master: Reset state robustification for group os-reset_status  https://review.opendev.org/c/openstack/cinder/+/80473516:58
opendevreviewTushar Trambak Gite proposed openstack/cinder master: Reset state robustification for group os-reset_status  https://review.opendev.org/c/openstack/cinder/+/80473516:58
whoami-rajatrosmaita, hey, was rebasing on top of Alan's patch and found one issue (non-fatal) on his patch17:10
whoami-rajatrosmaita, it's missing an entry in the microversions.py file17:10
rosmaitaoops17:10
whoami-rajati think one way to go about this is to propose a quick patch to update it and we can ninja approve?17:11
rosmaitayes17:11
rosmaitai can't believe i missed that one17:12
rosmaitawe have too many weird places you need to update when adding a mv17:12
whoami-rajatit's easy to miss since we use that reference in our code to allow/disallow things and in case of Alan's patch we don't have any condition check for mv.SUPPORT_PROJECT_ID (or something)17:13
rosmaita... and that's the file that tells you where all those places are!17:13
opendevreviewTushar Trambak Gite proposed openstack/cinder master: Reset state robustification for snapshot os-reset_status  https://review.opendev.org/c/openstack/cinder/+/80403517:13
rosmaitawhoami-rajat: do you have time to propose the patch or do you want me to do it?17:14
opendevreviewTushar Trambak Gite proposed openstack/cinder master: Reset state robustification for snapshot os-reset_status  https://review.opendev.org/c/openstack/cinder/+/80403517:14
whoami-rajatrosmaita, I can do it17:15
rosmaitaok, thanks17:15
rosmaitawhoami-rajat: PROJECT_ID_OPTIONAL_IN_URL17:16
rosmaita(call it that)17:16
whoami-rajatthanks, i was thinking about the right name to give17:16
rosmaita:)17:16
opendevreviewRajat Dhasmana proposed openstack/cinder master: Add missing microversion entry for 3.67  https://review.opendev.org/c/openstack/cinder/+/83066917:22
whoami-rajatrosmaita, ^17:22
rosmaitaty17:22
rosmaitawhoami-rajat: is going to fail pep8, left a comment on the patch17:27
whoami-rajatah blank space, will update it thanks17:29
rosmaitahemna: finally found that doc, don't know if it will be helpful, but it has the "Cinder" definitions of some terminology: https://specs.openstack.org/openstack/cinder-specs/specs/queens/provisioning-improvements.html17:31
opendevreviewRajat Dhasmana proposed openstack/cinder master: Add missing microversion entry for 3.67  https://review.opendev.org/c/openstack/cinder/+/83066917:34
rosmaitawhoami-rajat: ty!  i went ahead and workflowed it, but since it touches a .py file, it's going to go through full check and gate, so probably won't merge for a few hours17:39
whoami-rajatrosmaita, np, I hope we could do something about it in the future (at least not run the full job stack for small changes)17:40
whoami-rajatI will go ahead and update my patch17:40
whoami-rajatand rebase on top of this in the morning17:40
eharneythat missing microversion in microversions.py looks like a fun thing to add a unit test for, i might poke at that17:41
whoami-rajateharney++17:41
rosmaitaeharney: i was thinking about that, maybe checking that the max reported in the versions response is represented in the constants in microversions.py17:43
eharneyrosmaita: yup, that was my plan17:43
rosmaitacool17:43
opendevreviewBrian Rosmaita proposed openstack/cinder master: Update doc8 ignore-path  https://review.opendev.org/c/openstack/cinder/+/83067417:59
opendevreviewRajat Dhasmana proposed openstack/cinder master: Support volume re-image  https://review.opendev.org/c/openstack/cinder/+/60634618:00
opendevreviewEric Harney proposed openstack/cinder master: Add a unit test to keep microversions.py up to date  https://review.opendev.org/c/openstack/cinder/+/83067618:18
eharneyrosmaita: whoami-rajat: that does it ^18:18
whoami-rajatgreat!18:19
opendevreviewyuval proposed openstack/cinder master: lightos - bugfix compression stats should be True  https://review.opendev.org/c/openstack/cinder/+/83053818:38
hemnarosmaita thanks, checking it out19:17
hemnaheh only 4 or 5 drivers report provisioned_capacity_gb, even though that doc says it's required19:21
rosmaitai guess not everyone got the memo19:22
hemnaah yah and that document describes the reserved percentage too, which is what I thought it would be19:28
hemnabut it's not implemented that way in the capacity filter19:28
hemnaso provisioned capacity is the allocated capacity in cinder19:29
hemnawhich is often incorrect at startup time19:29
hemnathat value is only calculated by the volume service when it starts from available and in-use volumes19:29
hemnait doesn't take into account migrating, attaching, reserved, deleting, detaching, maintenance19:30
hemnaso what I'm seeing quite often is that allocated capacity going negative 19:31
opendevreviewRajat Dhasmana proposed openstack/python-cinderclient master: Add volume reimage command  https://review.opendev.org/c/openstack/python-cinderclient/+/60689119:31
opendevreviewEric Harney proposed openstack/cinder master: Add a unit test to keep microversions.py up to date  https://review.opendev.org/c/openstack/cinder/+/83067620:56
*** dviroel is now known as dviroel|out21:18

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!