opendevreview | Rico Lin proposed openstack/cinder master: Add disable_image_conversion config https://review.opendev.org/c/openstack/cinder/+/839793 | 04:21 |
---|---|---|
ricolin | rosmaita: jbernard | 04:22 |
ricolin | thanks for the review | 04:23 |
ricolin | just update the patch accordingly | 04:23 |
ricolin | let me know if that update works for you, thanks | 04:24 |
opendevreview | Tobias Urdin proposed openstack/cinder master: backup/swift: Add support sending service user token https://review.opendev.org/c/openstack/cinder/+/840289 | 07:30 |
*** dviroel|out is now known as dviroel | 11:20 | |
opendevreview | Arun KV proposed openstack/cinder master: Reintroduce DataCore driver https://review.opendev.org/c/openstack/cinder/+/836996 | 13:03 |
whoami-rajat | Cinder meeting in #openstack-meeting-alt at 1400 UTC | 13:59 |
whoami-rajat | jungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard sfernand enriquetaso hemna fabiooliveira yuval | 13:59 |
rosmaita | whoami-rajat: ty | 13:59 |
whoami-rajat | np | 13:59 |
hemna | doink | 13:59 |
geguileo | whoami-rajat: thanks! | 13:59 |
whoami-rajat | np! | 13:59 |
enriquetaso | thanks | 14:01 |
opendevreview | Eric Harney proposed openstack/cinder master: Groups: remove unneeded "status" variable https://review.opendev.org/c/openstack/cinder/+/840493 | 14:03 |
simondodsley | Can I get a +W on https://review.opendev.org/c/openstack/cinder/+/832130 please? | 14:09 |
opendevreview | Simon Dodsley proposed openstack/cinder stable/xena: PureStorage FlashArray: Add active/active replication https://review.opendev.org/c/openstack/cinder/+/829630 | 14:12 |
enriquetaso | Hello | 15:01 |
whoami-rajat | hi | 15:01 |
rosmaita | hola! | 15:01 |
fabiooliveira | hi | 15:01 |
enriquetaso | #startmeeting cinder_bs | 15:01 |
opendevmeet | Meeting started Wed May 4 15:01:31 2022 UTC and is due to finish in 60 minutes. The chair is enriquetaso. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:01 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:01 |
opendevmeet | The meeting name has been set to 'cinder_bs' | 15:01 |
enriquetaso | Hello, 5 new bugs were reported this period. | 15:01 |
enriquetaso | #link https://etherpad.opendev.org/p/cinder-bug-squad-meeting | 15:01 |
enriquetaso | #link http://lists.openstack.org/pipermail/openstack-discuss/2022-May/028404.html | 15:01 |
enriquetaso | #topic Temporary volume accepts deletion while it is used | 15:02 |
enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1970768 | 15:02 |
enriquetaso | A temporary volume is created when an attached volume is backing up. This temporary volume can be deleted by DELETE API because its status is 'available'. | 15:02 |
enriquetaso | The fix is already merged on master. | 15:02 |
enriquetaso | #link https://review.opendev.org/c/openstack/cinder/+/826949 | 15:02 |
enriquetaso | Moving on with a related bug | 15:02 |
enriquetaso | #topic Temporary volume could be deleted with force | 15:02 |
enriquetaso | Fix proposed to master | 15:02 |
enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1971483 | 15:03 |
enriquetaso | #link https://review.opendev.org/c/openstack/cinder/+/830901 | 15:04 |
enriquetaso | Moving on | 15:06 |
enriquetaso | #topic Volume reset-state API validation state checking is incorrect | 15:06 |
enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1970624 | 15:06 |
enriquetaso | eharney, Code from I0a53dfee "Reset state robustification for volume os-reset_status" aims to reject volume state updates to "error_deleting" and "detaching" but fails to do so due to a typo. | 15:06 |
enriquetaso | Original fix: | 15:07 |
enriquetaso | #link https://review.opendev.org/c/openstack/cinder/+/773985 | 15:07 |
enriquetaso | Fix proposed to master: | 15:07 |
enriquetaso | #link https://review.opendev.org/c/openstack/cinder/+/839416 | 15:07 |
eharney | yeah i'm going to rework the patch for this based on rosmaita's input | 15:07 |
eharney | 773985 isn't an original fix, it's where the bug was introduced | 15:07 |
enriquetaso | oh, my bad | 15:07 |
enriquetaso | sounds good, please cinder team review :) | 15:08 |
enriquetaso | moving on | 15:08 |
enriquetaso | #topic rbd_store_chunk_size in megabytes is an unwanted limitation | 15:08 |
enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1971154 | 15:08 |
enriquetaso | The report requests some changes regarding rbd_store_chunk_size. The reporter proposed two alternatives. | 15:09 |
enriquetaso | I need help to understand if this makes sense or if I should ask more questions about the problem. | 15:09 |
eharney | well there are restrictions on what we can set it to, since glance and cinder in many configurations need to agree on the chunk size | 15:09 |
eharney | we should look into this area, there are some deficiencies we still need to address w/ RBD as far as sector sizes too (512 vs 4k) | 15:10 |
eharney | but i don't think the suggestion to just add a new config value that lets deployers set whatever is necessarily the right answer | 15:10 |
eharney | as usual, we don't have much concrete performance data to analyze, so more info on the actual problem would be helpful | 15:11 |
enriquetaso | OK, so this bug is not trivial then. | 15:12 |
enriquetaso | I'll ask for concrete data and point out all this | 15:13 |
eharney | right, it's a good idea to improve this, but it needs a lot of thought | 15:13 |
enriquetaso | makes sense | 15:13 |
rosmaita | i think his question #2 is a good one | 15:14 |
eharney | it is | 15:14 |
rosmaita | all i can think is it's leftover from the days before there were dedicated pools? | 15:15 |
eharney | well, specifying the chunk size helps prevent situations where you end up with images that can't be moved between pools during migration, cinder<->glance, etc | 15:17 |
eharney | but i don't have a nice clear answer at the moment | 15:17 |
rosmaita | gotcha | 15:18 |
*** dviroel is now known as dviroel|lunch | 15:18 | |
enriquetaso | OK, so this looks like something interested to look for in the future. I can bring it back later, as Eric pointed out, it needs more thought. | 15:20 |
enriquetaso | Last but not least | 15:20 |
enriquetaso | #topic Could not find any paths for the volume | 15:20 |
enriquetaso | #link https://bugs.launchpad.net/os-brick/+bug/1961613 | 15:20 |
enriquetaso | In an environment using NVMeoF with SPDK, when an instance is shut off or hard restarted, it is not able to find the volume again. The volume is visible on the node with "nvme list" but nova reports: "Could not find any paths for the volume." | 15:21 |
enriquetaso | geguileo, I'm not familiar with NVMeoF. The reporter mentioned that this could be an os-brick problem. I think the bug report makes sense. | 15:21 |
geguileo | it's an os-brick problem | 15:21 |
geguileo | it's already reported, and I will be fixing it shortly | 15:22 |
enriquetaso | \o/ | 15:22 |
geguileo | (there's a patch proposed now, but I'm making changes) | 15:22 |
enriquetaso | sure, thanks Gorka | 15:22 |
geguileo | I'm saying it without looking at the bug report | 15:22 |
enriquetaso | :P | 15:22 |
geguileo | I mean, it can be one of 2 cases... | 15:23 |
geguileo | that I'm fixing... | 15:23 |
geguileo | let's not forget that I'm fixing close to 12 nvmeof bugs... | 15:23 |
geguileo | this is most likely the one where you cannot call os-brick with an already existing subsystem | 15:23 |
geguileo | mixed with the not disconnecting a subsystem on volume_disconnect | 15:24 |
eharney | we should probably just reevaluate any nvmeof bugs after geguileo's current stuff lands | 15:24 |
geguileo | if they wait for 10 minutes it probably works lol | 15:24 |
enriquetaso | of course, well, i can bring it back later when you update the patches, sounds like the right thing to do | 15:24 |
geguileo | because the nvmeof timeout will kick in and remove it... | 15:24 |
rosmaita | those bugs are great, by the time you get help from support, there is no problem | 15:24 |
geguileo | lol | 15:24 |
enriquetaso | ha | 15:25 |
enriquetaso | OK, that's all i have for today's meeting | 15:25 |
enriquetaso | thanks! | 15:25 |
rosmaita | i have 2 quick questons | 15:25 |
enriquetaso | sure | 15:25 |
rosmaita | i came across this when i was looking into eharney's patch that he mentioned earlier | 15:26 |
rosmaita | #link https://review.opendev.org/c/openstack/cinder/+/839825 | 15:26 |
rosmaita | i didn't file a bug, but wonder if i should | 15:26 |
eharney | does it have any observable behavior impacts? | 15:27 |
rosmaita | not now, my concern is that if someone actually uses this and then backports the usage, it will break without this patch | 15:27 |
rosmaita | (does that make sense?) | 15:27 |
eharney | i think so, but i wouldn't be inclined to file a bug for it myself | 15:28 |
rosmaita | ok, works for me | 15:28 |
enriquetaso | no bug then | 15:28 |
rosmaita | ok, my other issue is test-only, so i won't file a bug for it either | 15:29 |
rosmaita | ok, sorry i wasted our time | 15:29 |
enriquetaso | don't worry | 15:29 |
enriquetaso | :D | 15:30 |
enriquetaso | OK, running out of time | 15:30 |
enriquetaso | #endmeeting | 15:30 |
opendevmeet | Meeting ended Wed May 4 15:30:15 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:30 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/cinder_bs/2022/cinder_bs.2022-05-04-15.01.html | 15:30 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cinder_bs/2022/cinder_bs.2022-05-04-15.01.txt | 15:30 |
opendevmeet | Log: https://meetings.opendev.org/meetings/cinder_bs/2022/cinder_bs.2022-05-04-15.01.log.html | 15:30 |
rosmaita | thanks enriquetaso! | 15:30 |
eharney | https://review.opendev.org/c/openstack/cinder/+/775008 was +Workflow'd by rosmaita, whoami-rajat__, and jungleboyj in April 2021. maybe it could use another look? | 15:31 |
rosmaita | oh no | 15:33 |
rosmaita | what did we do? | 15:33 |
eharney | it went into merge conflict or something and then just got lost | 15:33 |
rosmaita | oh, i thought we let something bad slip into the code base | 15:33 |
eharney | rosmaita: i'm almost certain that this new test was written based on a discussion we had in here (also needs review): https://review.opendev.org/c/openstack/cinder/+/737618 | 15:37 |
rosmaita | i would've sworn that i had reviewed that, but i guess not | 15:42 |
*** dviroel|lunch is now known as dviroel | 16:15 | |
opendevreview | Prajakta Swapnil Belapurkar proposed openstack/cinder master: Volume Deletion rejection message does not include "awaiting-transfer" in invalid state https://review.opendev.org/c/openstack/cinder/+/840511 | 16:23 |
opendevreview | Prajakta Swapnil Belapurkar proposed openstack/cinder master: Volume Deletion rejection message does not include "awaiting-transfer" in invalid volume state https://review.opendev.org/c/openstack/cinder/+/840511 | 16:25 |
opendevreview | Prajakta Swapnil Belapurkar proposed openstack/cinder master: Volume Deletion rejection message does not include "awaiting-transfer" in invalid volume state https://review.opendev.org/c/openstack/cinder/+/840511 | 16:32 |
opendevreview | Brian Rosmaita proposed openstack/cinder master: Remove use of mock CONF object https://review.opendev.org/c/openstack/cinder/+/840512 | 16:32 |
opendevreview | Rico Lin proposed openstack/cinder master: Add image_conversion_disable config https://review.opendev.org/c/openstack/cinder/+/839793 | 16:36 |
opendevreview | Rico Lin proposed openstack/cinder master: Add image_conversion_disable config https://review.opendev.org/c/openstack/cinder/+/839793 | 16:44 |
ricolin | rosmaita: ^^^ updated and depends on your patch, thanks for the mock fix :) | 16:45 |
opendevreview | David White proposed openstack/cinder master: Seagate/Lenovo drivers: Update get_driver_options https://review.opendev.org/c/openstack/cinder/+/840516 | 16:50 |
opendevreview | Prajakta Swapnil Belapurkar proposed openstack/cinder master: Volume Deletion rejection message does not include "awaiting-transfer" in invalid volume state https://review.opendev.org/c/openstack/cinder/+/840511 | 17:09 |
opendevreview | Merged openstack/cinder stable/yoga: Handle the case when tempest fails https://review.opendev.org/c/openstack/cinder/+/840374 | 17:11 |
opendevreview | Merged openstack/cinder master: mypy: policy.py https://review.opendev.org/c/openstack/cinder/+/775008 | 17:11 |
*** whoami-rajat__ is now known as whoami-rajat | 17:25 | |
hemna | sorry to interrupt the meeting earlier | 17:53 |
hemna | but we should start thinking about how to add a volume action transaction tracking in cinder | 17:54 |
hemna | right now, there is really no way to see if cinder is 'busy' working on a volume or not, which is problematic for bouncing the service. | 17:54 |
hemna | also would be helpful in debugging stuck volumes | 17:54 |
opendevreview | Gorka Eguileor proposed openstack/cinder master: TOX: Document install_command usage https://review.opendev.org/c/openstack/cinder/+/840525 | 17:55 |
hemna | I'd be able to write another script to do a 'top' like action against cinder to have it show the live actions being taken against volumes | 17:55 |
geguileo | rosmaita: whoami-rajat__ ^ as agreed in todays bug scrub meeting | 17:55 |
geguileo | hemna: we have it for some operations (those that are cleanable) | 17:56 |
geguileo | in the workers table | 17:56 |
geguileo | but I'm not sure if that's the right table for what you want to do | 17:56 |
hemna | workers table? | 17:58 |
hemna | hrmm my workers table is basically empty | 18:00 |
hemna | there are a few creating and deleting rows, but that's it. | 18:03 |
hemna | what is the workers table used for? | 18:03 |
rosmaita | geguileo: ty | 18:04 |
geguileo | np | 18:04 |
geguileo | hemna: the workers table is used to track ongoing operations that are cleanable | 18:04 |
geguileo | it's used because if cinder-volume is deployed in a cluster (active-active) a different node may need to clean up the operation | 18:05 |
hemna | ok, so it's kinda useful | 18:05 |
hemna | but in my case not really. | 18:05 |
geguileo | so while the operation is ongoing it is kept there saying which node is currently working on it (first the API, then the scheduler, finally the volume) | 18:05 |
geguileo | you cannot see the history, but you can see those ongoing operations | 18:06 |
opendevreview | Merged openstack/cinder stable/xena: Handle the case when tempest fails https://review.opendev.org/c/openstack/cinder/+/840375 | 18:41 |
opendevreview | Merged openstack/cinder stable/wallaby: Handle the case when tempest fails https://review.opendev.org/c/openstack/cinder/+/840376 | 18:50 |
opendevreview | Merged openstack/cinder stable/victoria: Handle the case when tempest fails https://review.opendev.org/c/openstack/cinder/+/840377 | 19:58 |
opendevreview | Walt proposed openstack/cinder master: Fix tracking allocated_capacity_gb https://review.opendev.org/c/openstack/cinder/+/836083 | 20:40 |
hemna | found another problem with tracking allocated_capacity_gb | 20:41 |
hemna | for volume migration from one host to another that's running in a separate c-vol service. | 20:41 |
hemna | required adding a new rpcapi entry to call the remote host to update it's allocated_capacity_gb, since the source host gets the migrate_volume call. the destination host was never notified and hence had out of date allocated_capacity_gb | 20:42 |
hemna | https://review.opendev.org/c/openstack/cinder/+/836083 has a fix for it | 20:42 |
opendevreview | Merged openstack/cinder-tempest-plugin master: Replace the CentOS Stream 8 lvm job with a CS9 one https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/828743 | 20:45 |
*** dviroel is now known as dviroel|out | 21:50 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!