| *** dviroel is now known as dviroel|out | 00:04 | |
| opendevreview | Merged openstack/cinder master: db: Migrate "volume type", "group type" APIs to enginefacade https://review.opendev.org/c/openstack/cinder/+/837522 | 09:20 |
|---|---|---|
| opendevreview | Merged openstack/cinder master: db: Migrate "volume type specs", "group type specs" APIs to enginefacade https://review.opendev.org/c/openstack/cinder/+/837523 | 09:20 |
| opendevreview | Merged openstack/cinder master: db: Migrate "qos specs" APIs to enginefacade https://review.opendev.org/c/openstack/cinder/+/837524 | 10:50 |
| *** dviroel|out is now known as dviroel | 11:29 | |
| stephenfin | whoami-rajat__: did you forget to leave +2/+W on this? https://review.opendev.org/c/openstack/cinder/+/837525/ | 11:32 |
| whoami-rajat__ | stephenfin, yep, done now, thanks | 11:42 |
| stephenfin | sweet, cheers :) | 11:42 |
| rosmaita | whoami-rajat__: left a response on https://review.opendev.org/c/openstack/cinder/+/839793/11..13/cinder/volume/flows/manager/create_volume.py#b1025 | 13:06 |
| whoami-rajat__ | rosmaita, ack thanks | 13:42 |
| *** whoami-rajat__ is now known as whoami-rajat | 13:42 | |
| ricolin | whoami-rajat: rosmaita: thanks for the review, will update accordingly | 13:44 |
| opendevreview | Merged openstack/cinder master: db: Migrate "volume type encryption" APIs to enginefacade https://review.opendev.org/c/openstack/cinder/+/837525 | 13:45 |
| opendevreview | Merged openstack/cinder master: db: Migrate "volume glance metadata" APIs to enginefacade https://review.opendev.org/c/openstack/cinder/+/837526 | 13:45 |
| opendevreview | Merged openstack/cinder master: db: Migrate "backup", "backup metadata" APIs to enginefacade https://review.opendev.org/c/openstack/cinder/+/837527 | 13:45 |
| opendevreview | Rico Lin proposed openstack/cinder master: Add image_conversion_disable config https://review.opendev.org/c/openstack/cinder/+/839793 | 13:49 |
| ricolin | ^^^ whoami-rajat: rosmaita updated! | 13:50 |
| rosmaita | ricolin: that was fast! | 13:50 |
| whoami-rajat | still not sure what's the drawback/reason for not creating the message before raising the ImageUnacceptable exception here https://review.opendev.org/c/openstack/cinder/+/839793/14/cinder/image/image_utils.py#711 | 13:54 |
| whoami-rajat | Also one other way, if we want to do it, is to create a new exception and raise and catch that to create the message | 13:55 |
| ricolin | whoami-rajat: create a new exception sounds like a good option | 13:58 |
| whoami-rajat | cool, that would be much better for me than parsing and comparing error messages | 13:59 |
| opendevreview | Merged openstack/devstack-plugin-ceph stable/ussuri: Cap cinder-tempest-plugin version for stable/ussuri|victoria https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/843355 | 15:12 |
| rosmaita | ricolin: whoami-rajat: wish i'd read the scrollback earlier ... new exception definitely is a good idea | 15:17 |
| *** dviroel is now known as dviroel|lunch | 15:22 | |
| ricolin | rosmaita: whoami-rajat cool, will update the patch accordingly ASAP | 15:28 |
| gmann | whoami-rajat: rosmaita : can you check tempest plugin pin for stable/victoria too https://review.opendev.org/c/openstack/cinder/+/843305 | 15:39 |
| rosmaita | gmann: ack | 15:39 |
| gmann | whoami-rajat: rosmaita : and this is quick one for job description update https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/843685 | 15:40 |
| gmann | thanks | 15:40 |
| rosmaita | gmann: left a comment for you on https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/843685, see what you think | 15:57 |
| gmann | rosmaita: sure, sounds good to add details, will update | 15:58 |
| rosmaita | gmann: ok, cool | 15:58 |
| *** dviroel|lunch is now known as dviroel | 16:24 | |
| opendevreview | Ghanshyam proposed openstack/cinder-tempest-plugin master: Fixing job description for stable branch job https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/843685 | 16:46 |
| gmann | rosmaita: ^^ check if that looks good | 16:46 |
| rosmaita | ok | 16:46 |
| rosmaita | gmann: LGTM, thanks | 16:47 |
| opendevreview | Rico Lin proposed openstack/cinder master: Add image_conversion_disable config https://review.opendev.org/c/openstack/cinder/+/839793 | 17:31 |
| ricolin | rosmaita: whoami-rajat patch updated, please kindly take a look on it again. Thanks | 17:33 |
| whoami-rajat | ack, looking | 17:41 |
| melwitt | geguileo: hi, I ran across a tempest patch you have proposed to propose to run some LUKSv2 tests in the nova and saw one test hit a AttributeError https://review.opendev.org/c/openstack/tempest/+/836065/2#message-fa386a97290d4c96c6fb775e308d6573066c8519 not sure if it's because we need a requirements bump for os-brick or something else | 17:41 |
| geguileo | melwitt: we need the os-brick patch to merge and then the bump | 17:42 |
| geguileo | melwitt: the nova patch should have merged by now (/me goes to check) | 17:42 |
| melwitt | geguileo: it did. ok yeah I didn't realize there are a few more things in flight | 17:42 |
| whoami-rajat | ricolin, left a comment, I think we should create a new test for the failure case and not modify existing one https://review.opendev.org/c/openstack/cinder/+/839793 | 18:16 |
| whoami-rajat | s/failure/reimage | 18:17 |
| opendevreview | Merged openstack/cinder stable/ussuri: Cap cinder-tempest-plugin version for stable/ussuri|victoria https://review.opendev.org/c/openstack/cinder/+/843092 | 19:55 |
| opendevreview | Rico Lin proposed openstack/cinder master: Add image_conversion_disable config https://review.opendev.org/c/openstack/cinder/+/839793 | 19:56 |
| *** dviroel is now known as dviroel|afk | 20:25 | |
| opendevreview | Ghanshyam proposed openstack/cinder-tempest-plugin master: Remove stable/victoria job and fixing job description https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/843685 | 20:43 |
| opendevreview | Ghanshyam proposed openstack/cinder-tempest-plugin master: Remove stable/victoria job and fixing job description https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/843685 | 20:43 |
| opendevreview | Harsh Ailani proposed openstack/cinder master: [SVf] : Fix multiple SVC CLI calls for rc-relationship operations https://review.opendev.org/c/openstack/cinder/+/844140 | 21:35 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!