Friday, 2022-06-03

*** dviroel|afk is now known as dviroel00:19
*** dviroel is now known as dviroel|out01:01
*** bhagyashris|rover is now known as bhagyashris07:37
opendevreviewRafael Weingartner proposed openstack/cinder master: Filter reserved image properties
opendevreviewOleg proposed openstack/cinder master: PowerMax Driver -- Add support for Unisphere for PowerMax 10.0
opendevreviewJean Pierre Roquesalane proposed openstack/cinder master: WIP: Add Cinder NFS driver for Dell EMC PowerStore
lpetrutgeguileo: hi, thanks for reviewing the os-brick multipathd fix. I've added the missing test, should be good to go now:
opendevreviewHarsh Ailani proposed openstack/cinder master: [SVf] : Fix the SVC code level for lsfcportsetmember call
*** dviroel|out is now known as dviroel11:22
opendevreviewOleg proposed openstack/cinder master: PowerMax Driver -- Add support for Unisphere for PowerMax 10.0
opendevreviewOleg proposed openstack/cinder master: PowerMax Driver - Check for moving to same target
opendevreviewOleg proposed openstack/cinder master: PowerMax Driver - Fix for renaming GVG
opendevreviewOleg proposed openstack/cinder master: PowerMax Driver - Allow for retype to _DEFAULT__ VT
ricolinjungleboyj:  can you kindly do another review on thanks :)13:17
rosmaitaricolin: it has two +2s, the holdup is the parent patch is still in the gate14:04
opendevreviewMerged openstack/cinder master: Remove use of mock CONF object
opendevreviewWalt proposed openstack/cinder master: Fix and unify capacity calculations
opendevreviewWalt proposed openstack/cinder master: Add reporting of capacity factors in API
*** dviroel is now known as dviroel|lunch14:53
opendevreviewBrian Rosmaita proposed openstack/cinder stable/wallaby: Prohibit volume manage to an encrypted volume type
opendevreviewArun KV proposed openstack/cinder master: Reintroduce DataCore driver
ricolinrosmaita: oh, that explian a lot :)15:43
rosmaitanp, your patch is in the gate now15:45
opendevreviewMerged openstack/cinder master: Add image_conversion_disable config
rosmaitaricolin: ^^ !!15:52
ricolinrosmaita: super! thanks for all helps:)15:53
rosmaitahey everybody ... grenade job is broken in stable/wallaby ... looks like this may fix it: , but it hasn't merged yet15:53
hemnageguileo, you around?16:01
hemnaor rosmaita16:01
rosmaitahemna: hey16:02
hemnawith this patch I have added returning the capacity factors in the get pools api16:02
hemnawhich looks like this.
hemnaso the real question is how to format the output of the pool table and what's in it for the cmdln output16:03
hemnacurrently everything in the capabilities is what is shown in the table output16:04
hemnacapabilities is what's reported by the driver the last time get_volume_stats is called.   the capacity_factors is what the scheduler has for values at the time the get pools call is made16:04
hemnawhich can be different from the capabilities.16:04
hemnain terms of allocated capacity and free capacity 16:05
hemnaso there are 2 competing ideas here of what should be shown16:05
hemnascheduler vs capabilities16:06
rosmaitai'm not sure what the capabilities of pretty-table are16:06
hemnaat least from the cmdln output.   from the API we are good, as both are reported separately, as they should16:06
hemnaI am not sure you can have a dict formatted in the Value column16:06
hemnawithout some new magic16:06
rosmaitawell, python-cinderclient is using prettytable>=0.7.2, and they are at like 3.something now16:08
rosmaitaso there may be capabilities we aren't currently using16:08
rosmaitai'm trying to think whether there's any other output like this that we display16:09
hemnajamming the capacity_factors dict into the output looks like.....
rosmaitayeah, you don't want that16:11
hemnaheh yah16:12
hemnapretty table inside a pretty table?16:13
rosmaitaapparently you can add a title to a prettytable, so maybe something like 2 tables with: "Capabilities:  focal@lvmdriver-1#lvmdriver-1" as the heading on the first one, and then "Capacity Report: focal@lvmdriver-1#lvmdriver-1" for the second?16:14
rosmaitai don't know if you can nest pretty tables16:14
hemnalooks like there might be some special sauce in there?16:16
*** dviroel|lunch is now known as dviroel16:20
rosmaitathat's not bad!16:20
rosmaitai think it would make sense to do the same thing for the capabilities16:21
hemnaso every field in that output is the capabilities16:22
hemnaother than the capacity_factors_thin 16:22
rosmaitait's weird how the "name" shows up in the table16:24
rosmaitain any case, that looks like a good start16:26
hemnayah I wish the table was more like the rich library16:27
hemnayou can create a table title with that, which in this case would be the pool name16:28
hemnathe format we currently have makes it hard to see what pool I'm looking at when I have 155 pools output16:28
rosmaitayeah, i can see how that would be a problem16:30
hemnanot sure how receptive we'd be to adding the rich library to python-cinderclient 16:31
hemnathat's rendering the same data with the python rich library17:05
hemnaI put a sleep of 5 seconds in between the output from rich vs. the original output using prettytable17:06
hemnajust so you can see it in asciinema, since It can't scroll back17:06
hemnathis has gotten me into a black hole of converting all of cinder client's output to using rich library17:27
hemnawhich looks nicer IMHO17:27
rosmaitai wonder what the openstackclient uses17:34
hemnalooks like prettytable output from osc17:40
hemnawell, it uses some custom lib called 'cliff'17:43
hemnawhich internally uses prettytable17:43
hemnaopenstack reinvents everything17:43
opendevreviewWalt proposed openstack/python-cinderclient master: WIP: Use rich library
hemnarosmaita ^^ if you want to mess around with it18:25
rosmaitahemna: ack18:25
hemnait's a total hack job, but works for the most part.  18:25
hemnaoh and I think it includes my updates for the capacity_factors output for cinder get-pools --detail18:26
hemnait's a WIP just to show rich really.18:26
hemnaI just installed that version in a venv and then aliased it  with something like mycinder=/home/waboring/python-cinderclient/.venv/bin/cinder18:27
hemnathen you can to back to back comparisons.   18:27
hemnacinder list18:27
hemnamycinder list18:27
*** dviroel is now known as dviroel|out21:21

Generated by 2.17.3 by Marius Gedminas - find it at!