| *** dviroel|afk is now known as dviroel | 00:19 | |
| *** dviroel is now known as dviroel|out | 01:01 | |
| *** bhagyashris|rover is now known as bhagyashris | 07:37 | |
| opendevreview | Rafael Weingartner proposed openstack/cinder master: Filter reserved image properties https://review.opendev.org/c/openstack/cinder/+/812685 | 08:17 |
|---|---|---|
| opendevreview | Oleg proposed openstack/cinder master: PowerMax Driver -- Add support for Unisphere for PowerMax 10.0 https://review.opendev.org/c/openstack/cinder/+/844563 | 08:56 |
| opendevreview | Jean Pierre Roquesalane proposed openstack/cinder master: WIP: Add Cinder NFS driver for Dell EMC PowerStore https://review.opendev.org/c/openstack/cinder/+/797608 | 09:09 |
| lpetrut | geguileo: hi, thanks for reviewing the os-brick multipathd fix. I've added the missing test, should be good to go now: https://review.opendev.org/c/openstack/os-brick/+/762776 | 10:57 |
| opendevreview | Harsh Ailani proposed openstack/cinder master: [SVf] : Fix the SVC code level for lsfcportsetmember call https://review.opendev.org/c/openstack/cinder/+/844572 | 11:16 |
| *** dviroel|out is now known as dviroel | 11:22 | |
| opendevreview | Oleg proposed openstack/cinder master: PowerMax Driver -- Add support for Unisphere for PowerMax 10.0 https://review.opendev.org/c/openstack/cinder/+/844563 | 12:04 |
| opendevreview | Oleg proposed openstack/cinder master: PowerMax Driver - Check for moving to same target https://review.opendev.org/c/openstack/cinder/+/779540 | 12:13 |
| opendevreview | Oleg proposed openstack/cinder master: PowerMax Driver - Fix for renaming GVG https://review.opendev.org/c/openstack/cinder/+/801354 | 12:22 |
| opendevreview | Oleg proposed openstack/cinder master: PowerMax Driver - Allow for retype to _DEFAULT__ VT https://review.opendev.org/c/openstack/cinder/+/803773 | 12:31 |
| ricolin | jungleboyj: can you kindly do another review on https://review.opendev.org/c/openstack/cinder/+/839793 thanks :) | 13:17 |
| rosmaita | ricolin: it has two +2s, the holdup is the parent patch is still in the gate | 14:04 |
| opendevreview | Merged openstack/cinder master: Remove use of mock CONF object https://review.opendev.org/c/openstack/cinder/+/840512 | 14:14 |
| opendevreview | Walt proposed openstack/cinder master: Fix and unify capacity calculations https://review.opendev.org/c/openstack/cinder/+/831247 | 14:32 |
| opendevreview | Walt proposed openstack/cinder master: Add reporting of capacity factors in API https://review.opendev.org/c/openstack/cinder/+/844601 | 14:32 |
| *** dviroel is now known as dviroel|lunch | 14:53 | |
| opendevreview | Brian Rosmaita proposed openstack/cinder stable/wallaby: Prohibit volume manage to an encrypted volume type https://review.opendev.org/c/openstack/cinder/+/844605 | 15:15 |
| opendevreview | Arun KV proposed openstack/cinder master: Reintroduce DataCore driver https://review.opendev.org/c/openstack/cinder/+/836996 | 15:20 |
| ricolin | rosmaita: oh, that explian a lot :) | 15:43 |
| ricolin | thanks | 15:43 |
| rosmaita | np, your patch is in the gate now | 15:45 |
| opendevreview | Merged openstack/cinder master: Add image_conversion_disable config https://review.opendev.org/c/openstack/cinder/+/839793 | 15:51 |
| rosmaita | ricolin: ^^ !! | 15:52 |
| ricolin | rosmaita: super! thanks for all helps:) | 15:53 |
| rosmaita | hey everybody ... grenade job is broken in stable/wallaby ... looks like this may fix it: https://review.opendev.org/c/openstack/devstack/+/805008 , but it hasn't merged yet | 15:53 |
| hemna | geguileo, you around? | 16:01 |
| hemna | or rosmaita | 16:01 |
| rosmaita | hemna: hey | 16:02 |
| hemna | with this patch https://review.opendev.org/c/openstack/cinder/+/844601/ I have added returning the capacity factors in the get pools api | 16:02 |
| hemna | which looks like this. https://paste.openstack.org/show/beWS0LKuHm64oxv34VFq/ | 16:02 |
| hemna | so the real question is how to format the output of the pool table and what's in it for the cmdln output | 16:03 |
| hemna | currently everything in the capabilities is what is shown in the table output | 16:04 |
| hemna | capabilities is what's reported by the driver the last time get_volume_stats is called. the capacity_factors is what the scheduler has for values at the time the get pools call is made | 16:04 |
| hemna | which can be different from the capabilities. | 16:04 |
| hemna | in terms of allocated capacity and free capacity | 16:05 |
| rosmaita | right | 16:05 |
| hemna | so there are 2 competing ideas here of what should be shown | 16:05 |
| hemna | scheduler vs capabilities | 16:06 |
| rosmaita | i'm not sure what the capabilities of pretty-table are | 16:06 |
| hemna | at least from the cmdln output. from the API we are good, as both are reported separately, as they should | 16:06 |
| hemna | I am not sure you can have a dict formatted in the Value column | 16:06 |
| hemna | without some new magic | 16:06 |
| rosmaita | well, python-cinderclient is using prettytable>=0.7.2, and they are at like 3.something now | 16:08 |
| rosmaita | so there may be capabilities we aren't currently using | 16:08 |
| rosmaita | i'm trying to think whether there's any other output like this that we display | 16:09 |
| hemna | jamming the capacity_factors dict into the output looks like..... https://paste.opendev.org/show/bmFUqrPhzIAaW8C6IwyB/ | 16:11 |
| rosmaita | looking | 16:11 |
| rosmaita | yeah, you don't want that | 16:11 |
| hemna | heh yah | 16:12 |
| hemna | pretty table inside a pretty table? | 16:13 |
| rosmaita | apparently you can add a title to a prettytable, so maybe something like 2 tables with: "Capabilities: focal@lvmdriver-1#lvmdriver-1" as the heading on the first one, and then "Capacity Report: focal@lvmdriver-1#lvmdriver-1" for the second? | 16:14 |
| rosmaita | i don't know if you can nest pretty tables | 16:14 |
| hemna | https://github.com/openstack/python-cinderclient/blob/master/cinderclient/utils.py#L218-L232 | 16:16 |
| hemna | looks like there might be some special sauce in there? | 16:16 |
| hemna | w00t | 16:18 |
| hemna | https://paste.opendev.org/show/bO1xhuGCk8HvKuYatNfH/ | 16:18 |
| *** dviroel|lunch is now known as dviroel | 16:20 | |
| rosmaita | that's not bad! | 16:20 |
| rosmaita | i think it would make sense to do the same thing for the capabilities | 16:21 |
| hemna | so every field in that output is the capabilities | 16:22 |
| hemna | other than the capacity_factors_thin | 16:22 |
| rosmaita | it's weird how the "name" shows up in the table | 16:24 |
| rosmaita | in any case, that looks like a good start | 16:26 |
| hemna | yah I wish the table was more like the rich library | 16:27 |
| hemna | you can create a table title with that, which in this case would be the pool name | 16:28 |
| hemna | the format we currently have makes it hard to see what pool I'm looking at when I have 155 pools output | 16:28 |
| rosmaita | yeah, i can see how that would be a problem | 16:30 |
| hemna | not sure how receptive we'd be to adding the rich library to python-cinderclient | 16:31 |
| hemna | https://asciinema.org/a/8aRsjOQdtLcNcIxF1FK4v7DKZ | 16:34 |
| hemna | or https://asciinema.org/a/GnziXZD95dTaSWPblWPDw5Jwu | 16:34 |
| hemna | https://asciinema.org/a/QcHfyiAkn2ip3g9jX9KYgi0ER | 17:05 |
| hemna | that's rendering the same data with the python rich library | 17:05 |
| hemna | I put a sleep of 5 seconds in between the output from rich vs. the original output using prettytable | 17:06 |
| hemna | just so you can see it in asciinema, since It can't scroll back | 17:06 |
| hemna | this has gotten me into a black hole of converting all of cinder client's output to using rich library | 17:27 |
| hemna | which looks nicer IMHO | 17:27 |
| rosmaita | i wonder what the openstackclient uses | 17:34 |
| hemna | looks like prettytable output from osc | 17:40 |
| hemna | well, it uses some custom lib called 'cliff' | 17:43 |
| hemna | which internally uses prettytable | 17:43 |
| hemna | openstack reinvents everything | 17:43 |
| opendevreview | Walt proposed openstack/python-cinderclient master: WIP: Use rich library https://review.opendev.org/c/openstack/python-cinderclient/+/844631 | 18:24 |
| hemna | rosmaita ^^ if you want to mess around with it | 18:25 |
| rosmaita | hemna: ack | 18:25 |
| hemna | it's a total hack job, but works for the most part. | 18:25 |
| hemna | fwiw | 18:25 |
| hemna | oh and I think it includes my updates for the capacity_factors output for cinder get-pools --detail | 18:26 |
| hemna | it's a WIP just to show rich really. | 18:26 |
| hemna | I just installed that version in a venv and then aliased it with something like mycinder=/home/waboring/python-cinderclient/.venv/bin/cinder | 18:27 |
| rosmaita | ok | 18:27 |
| hemna | then you can to back to back comparisons. | 18:27 |
| hemna | cinder list | 18:27 |
| hemna | mycinder list | 18:27 |
| *** dviroel is now known as dviroel|out | 21:21 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!