Friday, 2022-06-17

opendevreviewJean Pierre Roquesalane proposed openstack/cinder master: PowerMax Driver - Manage volume into correct storage group
*** elodilles_pto is now known as elodilles06:46
opendevreviewJean Pierre Roquesalane proposed openstack/cinder master: PowerMax Driver - Allow for retype to _DEFAULT__ VT
opendevreviewVictoria Martinez de la Cruz proposed openstack/devstack-plugin-ceph master: Deploy with cephadm
opendevreviewVictoria Martinez de la Cruz proposed openstack/devstack-plugin-ceph master: Deploy with cephadm
opendevreviewVictoria Martinez de la Cruz proposed openstack/devstack-plugin-ceph master: Deploy with cephadm
whoami-rajatrosmaita, hey, around?10:25
opendevreviewJesper Schmitz Mouridsen proposed openstack/cinder master: Add values of message_* properties to RequestContext
opendevreviewStephen Finucane proposed openstack/cinder master: db: Remove use of 'as_scalar()'
opendevreviewStephen Finucane proposed openstack/cinder master: db: Remove resolved TODO
opendevreviewStephen Finucane proposed openstack/cinder master: tests: Fix invalid test
opendevreviewStephen Finucane proposed openstack/cinder master: db: Fix up some API signatures, other style issues
opendevreviewStephen Finucane proposed openstack/cinder master: tests: Address UserWarning in tests
opendevreviewStephen Finucane proposed openstack/cinder master: db: Move helpers to cinder.db.sqlalchemy.api
opendevreviewStephen Finucane proposed openstack/cinder master: db: Use cinder.db.api directly
opendevreviewStephen Finucane proposed openstack/cinder master: db: Remove unnecessary sqlalchemy abstraction
*** whoami-rajat__ is now known as whoami-rajat11:33
opendevreviewGorka Eguileor proposed openstack/os-brick stable/xena: Fix encryption symlink issues
hemnawhoami-rajat Did a bunch of driver reviews on that list you emailed out.   3 of the FC drivers I reviewed don't use the FCZM, hence -112:24
*** dviroel|out is now known as dviroel13:00
whoami-rajathemna, ack, thanks for taking a look. are FC drivers required to use zone manager or it's optional? I think only brocade used it but not sure13:49
hemnaFor FC drivers if they don't use the FCZM, then they probably aren't going to be able to attach/detach volumes correctly.13:49
hemnaif the FCZM isn't deployed/configured then it's a noop13:49
hemnaso, IMO the FCZM is a requirement for FC drivers13:50
whoami-rajatack, then they should do it. also it's a good point to retrospect our current FC drivers in tree13:51
hemnadid we nuke the cisco driver from the tree?13:52
hemnaok cisco is still there13:53
whoami-rajatyou mean the ZM cisco driver? it's here
hemnaI looked and it's still there :)13:56
whoami-rajatreminder: Cinder Festival of Reviews today, 1400-1600 UTC14:00
whoami-rajatjoin us in meetpad:
whoami-rajator go directly to the etherpad:
whoami-rajatjungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard sfernand enriquetaso hemna fabiooliveira14:00
*** dviroel is now known as dviroel|pto14:03
whoami-rajatwe will be reviewing driver patches today (since they don't get much attention from reviewers and sitting idle for long, also deadline is approaching for new drivers)14:05
jungleboyjwhoami-rajat:  I am double and triple booked so, not sure I will be able to join today.14:06
jungleboyjAs the driver patches get closer to being ready let me know and I can help to get them merged.14:07
whoami-rajatjungleboyj, no problem Jay and thanks14:10
whoami-rajatalso if you get some time, can you help these stable/wallaby patches get merged14:11
whoami-rajatcurrently stable/wallaby gate is broken, probably because of a os-brick change we merged14:11
whoami-rajatbut we can recheck after that is fixed14:11
jungleboyjOh sure.  I will take a look at this in a few minutes here.14:12
whoami-rajatthese are required for the stable release we wanted to happen 1-2 weeks ago :D14:12
whoami-rajatjungleboyj, thank you!14:12
nahimsouza[m]hello guys, I tried to join the meetpad, but it does not work for me :( I will try to follow the etherpad and help with some reviews14:12
rosmaitanahimsouza[m]: sorry it's not working, make sure you add your name to the attendees list on the etherpad (line #39)14:16
whoami-rajatnahimsouza[m], sure, thanks, you can write your name in the attendees list on the etherpad and also ask any queries here if you've any doubts14:16
whoami-rajatas rosmaita said14:16
nahimsouza[m]tks :) 14:16
whoami-rajatas i type slower :P14:16
opendevreviewVladislav Belogrudov proposed openstack/cinder master: Initial commit for Yadro Tatlin.UNIFIED driver
whoami-rajatgeguileo, unrelated to the festival of reviews, we merged a os-brick patch in stable/wallaby and it's breaking cinderlib tests on cinder gate14:24
whoami-rajatbrick patch:
whoami-rajatcinder patch:
whoami-rajatfailing tests:
geguileooh, it's because of the privileged code14:26
geguileommmmm, that should not be it... because we merged the privsep support patch...14:28
whoami-rajat__not sure but this is stable/wallaby so things can go out of sync in different projects, cinder, brick, privsep14:42
*** whoami-rajat__ is now known as whoami-rajat14:43
geguileowhoami-rajat: it's weird, because it should be there...14:49
geguileowhoami-rajat: I'm trying to run functional tests locally and it's even crazier... In my case it cannot find ddt (which is available)14:50
whoami-rajatwow, only time i face that issue is when I've not sourced ../bin/activate14:51
geguileowell, the 'VIRTUAL_ENV' variable is there... but doesn't seem to be added to the search paths14:56
whoami-rajatleaving meetpad, will be available here for rest of festival of reviews15:16
HappyStacker1dropping for the week-end. have an excellent week-end. Talk to you soon team15:25
whoami-rajatHappyStacker1, thanks for staying around for festival of XS reviews, have a great weekend!15:26
whoami-rajatrosmaita, hey, I'm confused on one backport patch, it is merged in master but it is a fix and required a releasenote, is it worth asking for a releasenote in master and squashing it in the backport or let the backport slide?
whoami-rajatactually there is another patch with same issue
rosmaitaboth of those looked like fixes that weren't user-visible, there weren't bugs filed, they were just problems helen found while working on the code, so we didn't require a release note15:32
whoami-rajathmm, but what we recently discussed was to file a bug and include a releasenote for any driver fix (although these are from yoga)15:35
whoami-rajatand this one looks user visible ... For a PowerMax volume to be manageable it can not be in15:36
whoami-rajatmore than one storage group.  Filtering manageable volumes15:36
whoami-rajatlist to remove all devices that are in more than one storage15:36
whoami-rajatif a user is able to see a list of volumes to be managed and after this fix, they see less volumes, it is surely a user visible change15:36
whoami-rajatmaybe we can let them pass this time and be more careful from future15:37
rosmaitawell, -2 the backport and request a release note  patch be made directly to stable/yoga and then it can be squashed in with the backport15:37
whoami-rajatthanks for the input15:40
geguileorosmaita: do you remember the discussion we had the other day about cinderlib?15:41
rosmaitahow can i forget?15:42
geguileothe part about using released vs using repo?15:42
geguileoI think that's what making it fail now on wallaby15:42
geguileowhoami-rajat: ^15:42
geguileoor at least I suspect it15:43
rosmaita(reading the scrollback now, i wasn't paying attention)15:44
whoami-rajatrosmaita, so the latest os-brick change in stable/wallaby broke cinderlib tests in the cinder gate15:45
rosmaitaright, and probably only cinderlib because i think the other tests use the released os-brick?15:45
geguileothis is my working theory in my head15:46
rosmaitasounds plausible15:46
geguileocinderlib runs in a virtual environment with os-brick repo code15:46
rosmaitakind of sucks that no actual os-brick tests caught this15:47
geguileobut launches privsep, which then goes and uses the system wide installed package from pip15:47
geguileowhich is missing that specific part of the code15:47
geguileoos-brick could not have caught it if my theory is the right one15:47
whoami-rajatso do we need to modify cinderlib to work better with privsep or it's a gate thing?15:48
rosmaitai think probably a gate thing, need to get the correct privsep available to cinderlib15:49
geguileonot sure...15:49
rosmaitai just realized that i am the only person in meetpad15:49
geguileoI think this could be that privsep is not getting the right paths to look for things15:49
geguileothings = libraries15:49
whoami-rajatrosmaita, yeah it was dead silent for 1.5 hours and also facing some bandwidth issues so i left15:50
rosmaitathis sounds too complicated for Friday evening15:51
geguileorosmaita: I agree, but a broken stable CI is not fun ;-)15:55
whoami-rajattrue and the wallaby CI is important as jbernard was planning to do stable releases and 3 stable/wallaby patches remain to be merged ...15:57
geguileomaybe it's this code that's not working as it should...
whoami-rajatwe are towards the end of festival of reviews, thanks everyone for attending, have a great weekend!16:00
jbernardwhoami-rajat: yes, i plan to get those patches to release up soon, even if we have to hold for a bit on the wallaby patches17:18
opendevreviewMerged openstack/cinder master: NetApp ONTAP: Fixed get_ontap_version

Generated by 2.17.3 by Marius Gedminas - find it at!