| opendevreview | Jean Pierre Roquesalane proposed openstack/cinder master: PowerMax Driver - Manage volume into correct storage group https://review.opendev.org/c/openstack/cinder/+/797333 | 06:35 |
|---|---|---|
| *** elodilles_pto is now known as elodilles | 06:46 | |
| opendevreview | Jean Pierre Roquesalane proposed openstack/cinder master: PowerMax Driver - Allow for retype to _DEFAULT__ VT https://review.opendev.org/c/openstack/cinder/+/803773 | 07:19 |
| opendevreview | Victoria Martinez de la Cruz proposed openstack/devstack-plugin-ceph master: Deploy with cephadm https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/826484 | 08:08 |
| opendevreview | Victoria Martinez de la Cruz proposed openstack/devstack-plugin-ceph master: Deploy with cephadm https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/826484 | 08:23 |
| opendevreview | Victoria Martinez de la Cruz proposed openstack/devstack-plugin-ceph master: Deploy with cephadm https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/826484 | 08:25 |
| whoami-rajat | rosmaita, hey, around? | 10:25 |
| opendevreview | Jesper Schmitz Mouridsen proposed openstack/cinder master: Add values of message_* properties to RequestContext https://review.opendev.org/c/openstack/cinder/+/846303 | 10:41 |
| opendevreview | Stephen Finucane proposed openstack/cinder master: db: Remove use of 'as_scalar()' https://review.opendev.org/c/openstack/cinder/+/837356 | 10:49 |
| opendevreview | Stephen Finucane proposed openstack/cinder master: db: Remove resolved TODO https://review.opendev.org/c/openstack/cinder/+/837546 | 10:49 |
| opendevreview | Stephen Finucane proposed openstack/cinder master: tests: Fix invalid test https://review.opendev.org/c/openstack/cinder/+/846171 | 10:49 |
| opendevreview | Stephen Finucane proposed openstack/cinder master: db: Fix up some API signatures, other style issues https://review.opendev.org/c/openstack/cinder/+/837542 | 10:49 |
| opendevreview | Stephen Finucane proposed openstack/cinder master: tests: Address UserWarning in tests https://review.opendev.org/c/openstack/cinder/+/846172 | 10:49 |
| opendevreview | Stephen Finucane proposed openstack/cinder master: db: Move helpers to cinder.db.sqlalchemy.api https://review.opendev.org/c/openstack/cinder/+/837543 | 10:50 |
| opendevreview | Stephen Finucane proposed openstack/cinder master: db: Use cinder.db.api directly https://review.opendev.org/c/openstack/cinder/+/846173 | 10:50 |
| opendevreview | Stephen Finucane proposed openstack/cinder master: db: Remove unnecessary sqlalchemy abstraction https://review.opendev.org/c/openstack/cinder/+/813229 | 10:52 |
| *** whoami-rajat__ is now known as whoami-rajat | 11:33 | |
| opendevreview | Gorka Eguileor proposed openstack/os-brick stable/xena: Fix encryption symlink issues https://review.opendev.org/c/openstack/os-brick/+/846343 | 11:46 |
| hemna | whoami-rajat Did a bunch of driver reviews on that list you emailed out. 3 of the FC drivers I reviewed don't use the FCZM, hence -1 | 12:24 |
| *** dviroel|out is now known as dviroel | 13:00 | |
| whoami-rajat | hemna, ack, thanks for taking a look. are FC drivers required to use zone manager or it's optional? I think only brocade used it but not sure | 13:49 |
| hemna | For FC drivers if they don't use the FCZM, then they probably aren't going to be able to attach/detach volumes correctly. | 13:49 |
| hemna | if the FCZM isn't deployed/configured then it's a noop | 13:49 |
| hemna | so, IMO the FCZM is a requirement for FC drivers | 13:50 |
| whoami-rajat | ack, then they should do it. also it's a good point to retrospect our current FC drivers in tree | 13:51 |
| hemna | yup | 13:51 |
| hemna | did we nuke the cisco driver from the tree? | 13:52 |
| hemna | ok cisco is still there | 13:53 |
| whoami-rajat | you mean the ZM cisco driver? it's here https://github.com/openstack/cinder/tree/master/cinder/zonemanager/drivers/cisco | 13:56 |
| hemna | yah | 13:56 |
| hemna | I looked and it's still there :) | 13:56 |
| whoami-rajat | ack | 13:57 |
| whoami-rajat | reminder: Cinder Festival of Reviews today, 1400-1600 UTC | 14:00 |
| whoami-rajat | join us in meetpad: https://meetpad.opendev.org/cinder-festival-of-reviews | 14:00 |
| whoami-rajat | or go directly to the etherpad: https://etherpad.opendev.org/p/cinder-festival-of-reviews | 14:00 |
| whoami-rajat | jungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard sfernand enriquetaso hemna fabiooliveira | 14:00 |
| *** dviroel is now known as dviroel|pto | 14:03 | |
| whoami-rajat | we will be reviewing driver patches today (since they don't get much attention from reviewers and sitting idle for long, also deadline is approaching for new drivers) | 14:05 |
| jungleboyj | whoami-rajat: I am double and triple booked so, not sure I will be able to join today. | 14:06 |
| jungleboyj | As the driver patches get closer to being ready let me know and I can help to get them merged. | 14:07 |
| whoami-rajat | jungleboyj, no problem Jay and thanks | 14:10 |
| whoami-rajat | also if you get some time, can you help these stable/wallaby patches get merged | 14:11 |
| whoami-rajat | 1) https://review.opendev.org/c/openstack/cinder/+/844605 | 14:11 |
| whoami-rajat | 2) https://review.opendev.org/c/openstack/cinder/+/844474 | 14:11 |
| whoami-rajat | currently stable/wallaby gate is broken, probably because of a os-brick change we merged | 14:11 |
| whoami-rajat | but we can recheck after that is fixed | 14:11 |
| jungleboyj | Oh sure. I will take a look at this in a few minutes here. | 14:12 |
| whoami-rajat | these are required for the stable release we wanted to happen 1-2 weeks ago :D | 14:12 |
| whoami-rajat | jungleboyj, thank you! | 14:12 |
| nahimsouza[m] | hello guys, I tried to join the meetpad, but it does not work for me :( I will try to follow the etherpad and help with some reviews | 14:12 |
| rosmaita | nahimsouza[m]: sorry it's not working, make sure you add your name to the attendees list on the etherpad (line #39) | 14:16 |
| whoami-rajat | nahimsouza[m], sure, thanks, you can write your name in the attendees list on the etherpad and also ask any queries here if you've any doubts | 14:16 |
| rosmaita | :) | 14:16 |
| whoami-rajat | as rosmaita said | 14:16 |
| nahimsouza[m] | tks :) | 14:16 |
| whoami-rajat | as i type slower :P | 14:16 |
| opendevreview | Vladislav Belogrudov proposed openstack/cinder master: Initial commit for Yadro Tatlin.UNIFIED driver https://review.opendev.org/c/openstack/cinder/+/825492 | 14:22 |
| whoami-rajat | geguileo, unrelated to the festival of reviews, we merged a os-brick patch in stable/wallaby and it's breaking cinderlib tests on cinder gate | 14:24 |
| whoami-rajat | brick patch: https://review.opendev.org/c/openstack/os-brick/+/834604 | 14:24 |
| whoami-rajat | cinder patch: https://review.opendev.org/c/openstack/cinder/+/845799 | 14:24 |
| whoami-rajat | failing tests: https://4d426b9917a9f7962308-d3c6167007a6d8477c4cec901604a1c7.ssl.cf1.rackcdn.com/845799/1/check/cinder-tempest-plugin-lvm-lio-barbican/4befcb8/testr_results.html | 14:24 |
| geguileo | oh, it's because of the privileged code | 14:26 |
| geguileo | mmmmm, that should not be it... because we merged the privsep support patch... | 14:28 |
| whoami-rajat__ | not sure but this is stable/wallaby so things can go out of sync in different projects, cinder, brick, privsep | 14:42 |
| *** whoami-rajat__ is now known as whoami-rajat | 14:43 | |
| geguileo | whoami-rajat: it's weird, because it should be there... | 14:49 |
| geguileo | whoami-rajat: I'm trying to run functional tests locally and it's even crazier... In my case it cannot find ddt (which is available) | 14:50 |
| whoami-rajat | wow, only time i face that issue is when I've not sourced ../bin/activate | 14:51 |
| geguileo | well, the 'VIRTUAL_ENV' variable is there... but doesn't seem to be added to the search paths | 14:56 |
| whoami-rajat | leaving meetpad, will be available here for rest of festival of reviews | 15:16 |
| HappyStacker1 | dropping for the week-end. have an excellent week-end. Talk to you soon team | 15:25 |
| whoami-rajat | HappyStacker1, thanks for staying around for festival of XS reviews, have a great weekend! | 15:26 |
| whoami-rajat | rosmaita, hey, I'm confused on one backport patch, it is merged in master but it is a fix and required a releasenote, is it worth asking for a releasenote in master and squashing it in the backport or let the backport slide? https://review.opendev.org/c/openstack/cinder/+/821739 | 15:29 |
| whoami-rajat | actually there is another patch with same issue https://review.opendev.org/c/openstack/cinder/+/821744 | 15:30 |
| rosmaita | looking | 15:30 |
| rosmaita | both of those looked like fixes that weren't user-visible, there weren't bugs filed, they were just problems helen found while working on the code, so we didn't require a release note | 15:32 |
| whoami-rajat | hmm, but what we recently discussed was to file a bug and include a releasenote for any driver fix (although these are from yoga) | 15:35 |
| whoami-rajat | and this one looks user visible ... For a PowerMax volume to be manageable it can not be in | 15:36 |
| whoami-rajat | more than one storage group. Filtering manageable volumes | 15:36 |
| whoami-rajat | list to remove all devices that are in more than one storage | 15:36 |
| whoami-rajat | group. | 15:36 |
| whoami-rajat | if a user is able to see a list of volumes to be managed and after this fix, they see less volumes, it is surely a user visible change | 15:36 |
| whoami-rajat | s/user/operator | 15:36 |
| whoami-rajat | maybe we can let them pass this time and be more careful from future | 15:37 |
| rosmaita | well, -2 the backport and request a release note patch be made directly to stable/yoga and then it can be squashed in with the backport | 15:37 |
| whoami-rajat | ack | 15:39 |
| whoami-rajat | thanks for the input | 15:40 |
| geguileo | rosmaita: do you remember the discussion we had the other day about cinderlib? | 15:41 |
| rosmaita | how can i forget? | 15:42 |
| rosmaita | :) | 15:42 |
| geguileo | the part about using released vs using repo? | 15:42 |
| rosmaita | right | 15:42 |
| geguileo | I think that's what making it fail now on wallaby | 15:42 |
| geguileo | s/what/what's | 15:42 |
| geguileo | whoami-rajat: ^ | 15:42 |
| geguileo | or at least I suspect it | 15:43 |
| rosmaita | (reading the scrollback now, i wasn't paying attention) | 15:44 |
| whoami-rajat | rosmaita, so the latest os-brick change in stable/wallaby broke cinderlib tests in the cinder gate | 15:45 |
| rosmaita | right, and probably only cinderlib because i think the other tests use the released os-brick? | 15:45 |
| geguileo | this is my working theory in my head | 15:46 |
| rosmaita | sounds plausible | 15:46 |
| geguileo | cinderlib runs in a virtual environment with os-brick repo code | 15:46 |
| rosmaita | kind of sucks that no actual os-brick tests caught this | 15:47 |
| geguileo | but launches privsep, which then goes and uses the system wide installed package from pip | 15:47 |
| geguileo | which is missing that specific part of the code | 15:47 |
| geguileo | os-brick could not have caught it if my theory is the right one | 15:47 |
| rosmaita | ok | 15:48 |
| whoami-rajat | so do we need to modify cinderlib to work better with privsep or it's a gate thing? | 15:48 |
| rosmaita | i think probably a gate thing, need to get the correct privsep available to cinderlib | 15:49 |
| geguileo | not sure... | 15:49 |
| rosmaita | i just realized that i am the only person in meetpad | 15:49 |
| geguileo | I think this could be that privsep is not getting the right paths to look for things | 15:49 |
| geguileo | things = libraries | 15:49 |
| whoami-rajat | rosmaita, yeah it was dead silent for 1.5 hours and also facing some bandwidth issues so i left | 15:50 |
| rosmaita | this sounds too complicated for Friday evening | 15:51 |
| geguileo | rosmaita: I agree, but a broken stable CI is not fun ;-) | 15:55 |
| whoami-rajat | true and the wallaby CI is important as jbernard was planning to do stable releases and 3 stable/wallaby patches remain to be merged ... | 15:57 |
| geguileo | maybe it's this code that's not working as it should... https://review.opendev.org/c/openstack/cinderlib/+/735935/12/cinderlib/cinderlib.py | 15:57 |
| whoami-rajat | we are towards the end of festival of reviews, thanks everyone for attending, have a great weekend! | 16:00 |
| jbernard | whoami-rajat: yes, i plan to get those patches to release up soon, even if we have to hold for a bit on the wallaby patches | 17:18 |
| opendevreview | Merged openstack/cinder master: NetApp ONTAP: Fixed get_ontap_version https://review.opendev.org/c/openstack/cinder/+/829529 | 19:21 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!