*** dviroel|afk is now known as dviroel | 00:07 | |
opendevreview | OpenStack Proposal Bot proposed openstack/cinder master: Imported Translations from Zanata https://review.opendev.org/c/openstack/cinder/+/846842 | 02:13 |
---|---|---|
opendevreview | Brian Rosmaita proposed openstack/cinderlib master: [docs] add tox, zuul maintenance tasks https://review.opendev.org/c/openstack/cinderlib/+/847114 | 02:24 |
whoami-rajat | hemna, thanks, will take a look | 04:36 |
whoami-rajat | hemna, looks like there's a line from some other spec that needs to be removed, else LGTM | 04:53 |
opendevreview | Arun KV proposed openstack/cinder master: Reintroduce DataCore driver https://review.opendev.org/c/openstack/cinder/+/836996 | 05:02 |
*** vishalmanchanda_ is now known as vishalmanchanda | 06:12 | |
*** masayukig_ is now known as masayukig | 06:12 | |
*** carloss_ is now known as carloss | 06:12 | |
*** arne_wiebalck_ is now known as arne_wiebalck | 06:19 | |
opendevreview | Merged openstack/cinderlib master: Update Ceph version on CI job https://review.opendev.org/c/openstack/cinderlib/+/846034 | 07:57 |
opendevreview | Peter Penchev proposed openstack/cinder master: Send the correct location URI to the Glance v2 API https://review.opendev.org/c/openstack/cinder/+/845178 | 07:58 |
opendevreview | Peter Penchev proposed openstack/cinder master: StorPool: drop _attach_volume() and _detach_volume() https://review.opendev.org/c/openstack/cinder/+/787296 | 07:58 |
opendevreview | Peter Penchev proposed openstack/cinder master: StorPool: really detach after copy to/from image. https://review.opendev.org/c/openstack/cinder/+/845990 | 07:58 |
opendevreview | Peter Penchev proposed openstack/cinder master: StorPool driver: remove the obsolete backup_volume() https://review.opendev.org/c/openstack/cinder/+/803823 | 07:58 |
opendevreview | Peter Penchev proposed openstack/cinder master: StorPool: create_cloned_volume() improvements https://review.opendev.org/c/openstack/cinder/+/843277 | 07:58 |
opendevreview | Peter Penchev proposed openstack/cinder master: Add the clone_across_pools driver capability https://review.opendev.org/c/openstack/cinder/+/847131 | 07:58 |
opendevreview | Peter Penchev proposed openstack/cinder master: StorPool: declare the clone_across_pools capability https://review.opendev.org/c/openstack/cinder/+/847132 | 07:58 |
Roamer` | ...argh... I meant to reorder those... sorry for the upcoming noise | 07:59 |
Roamer` | nah, it's fine, the bot reported them in the wrong order | 08:00 |
opendevreview | Merged openstack/cinderlib master: Use stable/yoga override for CI jobs (conclusion) https://review.opendev.org/c/openstack/cinderlib/+/845272 | 08:22 |
geguileo | whoami-rajat: finally figured out what's going on with the cinderlib stable gate failures !!! | 09:43 |
whoami-rajat | geguileo, oh nice! | 09:44 |
whoami-rajat | is it an easy or a complex fix? | 09:45 |
geguileo | I have to figure out how to fix it in the gate, locally is easy to fix, just edit a system file and make a change... | 09:46 |
geguileo | In file /usr/local/bin/privsep-helper it forces usage of the system's python with "#!/usr/bin/python3.6" so the privsep running ignores the virtual environment completely and uses libraries from the host system. | 09:46 |
geguileo | If we replace it with "#!/usr/bin/env python" then it works fine | 09:46 |
whoami-rajat | oh cool, so the assumption was right that privsep is not using the venv | 09:48 |
whoami-rajat | maybe tosky has idea how/if we can make this change in a gate run | 09:48 |
whoami-rajat | geguileo, but isn't that an issue for all projects that privsep is using host packages and not venv ones, and we only faced the issue in cinderlib | 10:08 |
whoami-rajat | maybe it's about the usage and our tests that catch this problem | 10:08 |
geguileo | whoami-rajat: exactly, that is the problem | 10:08 |
geguileo | this happens for us because we are using the same run from tempest | 10:09 |
geguileo | if the system didn't have the privsep package then it would be installed in the virtualenv and it would work | 10:09 |
geguileo | there is an easy fix, which is modify the tox to force the installation of the package in the virtual env | 10:11 |
geguileo | but that's not a proper fix, because then outside of the tox tests cinderlib could have the same issue when working inside virtual envs | 10:11 |
geguileo | I'm exploring an alternative fix | 10:12 |
whoami-rajat | ack, thanks for looking into this | 10:13 |
tosky | whoami-rajat: no, I have no idea :/ | 10:46 |
whoami-rajat | oh ... | 11:01 |
opendevreview | Alexander Malashenko proposed openstack/cinder master: Cinder displays the volume size provided by the driver, when creating the volume with enabled cache. https://review.opendev.org/c/openstack/cinder/+/836973 | 11:02 |
opendevreview | Francesco Pantano proposed openstack/devstack-plugin-ceph master: Deploy with cephadm https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/826484 | 11:02 |
*** dviroel__ is now known as dviroel | 11:28 | |
opendevreview | Atsushi Kawai proposed openstack/cinder master: Hitachi and OEM: Support multi pool https://review.opendev.org/c/openstack/cinder/+/846977 | 11:39 |
*** mattia is now known as Guest2939 | 12:48 | |
*** Guest2939 is now known as mattia | 12:51 | |
*** mattia is now known as blmt | 12:52 | |
opendevreview | Gorka Eguileor proposed openstack/cinderlib master: Fix privsep issues inside virtual env https://review.opendev.org/c/openstack/cinderlib/+/847170 | 13:07 |
geguileo | whoami-rajat: ^ The fix | 13:07 |
whoami-rajat | geguileo, looking | 13:48 |
geguileo | whoami-rajat: thanks. Let me know if something is not clear enough | 13:49 |
whoami-rajat | sure, as far as i understand, we are using a custom privsep-helper which is same as original but just runs inside venv | 13:51 |
whoami-rajat | geguileo, so are we using cinderlib master in cinder stable/wallaby and this patch will fix the gate situation or we would need to backport it till stable/wallaby? | 13:55 |
hemna | morning | 13:55 |
opendevreview | Walt proposed openstack/cinder-specs master: Add reporting of capacity factors https://review.opendev.org/c/openstack/cinder-specs/+/837768 | 13:57 |
whoami-rajat | Cinder meeting in #openstack-meeting-alt at 1400 UTC | 13:58 |
whoami-rajat | jungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard sfernand enriquetaso hemna fabiooliveira yuval tobias-urdin | 13:58 |
jungleboyj | whoami-rajat: Getting pulled into internal meetings today. Will join when I can. | 13:58 |
whoami-rajat | sure, no worries | 13:59 |
enriquetaso | thanks | 13:59 |
hemna | this may be a dumb question, but is there a mechanism to throttle/queue the number of backups being done at any time? | 14:00 |
geguileo | hemna: yes, we have the mechanism, whoami-rajat and I worked on it | 14:01 |
whoami-rajat | hemna, is this what you're looking for https://review.opendev.org/c/openstack/cinder/+/710297 ? | 14:01 |
whoami-rajat | yep, mostly geguileo but it's there | 14:02 |
geguileo | hemna: 'backup_max_operations' | 14:03 |
geguileo | they are per node | 14:04 |
geguileo | so if you have 3 backup services it will be able to do 3 * backup_max_operations | 14:04 |
geguileo | the mechanism is not great because what's happening is that they are queued on the service | 14:04 |
geguileo | not on the scheduler | 14:05 |
geguileo | so there is room for improvement | 14:05 |
hemna | ok thank you that's at least something. I had 107 backups kicked off on 1 deployment within 13 minutes. crushed | 14:09 |
hemna | ah that's Victoria? I'm still on train.....backport time. | 14:17 |
geguileo | lol | 14:25 |
geguileo | you are the backport master ;-) | 14:25 |
geguileo | hemna: I'm sure you'll be interested in making the changes I'm making to devstack and triple-o | 14:26 |
geguileo | hemna: they reduce the peak memory usage by 50% and the fix the high watermark memory issue | 14:26 |
geguileo | hemna: Just passing some env variables does that https://review.opendev.org/c/openstack/devstack/+/845805/5/lib/cinder | 14:30 |
*** dviroel is now known as dviroel|lunch | 14:59 | |
tosky | (another reminder for https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/782624 which enriquetaso raised last week IIRC, it allows us to set the minimal compatibility feature set for ceph; it is already supported by the cephadm patch, we need it for the current codebase) | 15:00 |
whoami-rajat | enriquetaso, bug squad meeting? | 15:02 |
enriquetaso | thanks tos | 15:04 |
enriquetaso | Luigi | 15:04 |
enriquetaso | Hey, no bug meeting today becuase i only have one bug http://lists.openstack.org/pipermail/openstack-discuss/2022-June/029188.html | 15:08 |
enriquetaso | regarding StorPool driver | 15:08 |
hillpd | enriquetaso, I wanted to discuss https://bugs.launchpad.net/cinder/+bug/1945500 | 15:09 |
enriquetaso | oh cool! | 15:10 |
hillpd | there was a fix proposed here: https://review.opendev.org/c/openstack/cinder/+/812685 | 15:11 |
enriquetaso | #startmeeting cinder_bs | 15:11 |
opendevmeet | Meeting started Wed Jun 22 15:11:22 2022 UTC and is due to finish in 60 minutes. The chair is enriquetaso. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:11 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:11 |
opendevmeet | The meeting name has been set to 'cinder_bs' | 15:11 |
enriquetaso | #link http://lists.openstack.org/pipermail/openstack-discuss/2022-June/029188.html | 15:11 |
enriquetaso | #topic It's not possible to upload a volume that was build from an image back to glance, if multistore (glance) is enabled. | 15:11 |
enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1945500 | 15:11 |
enriquetaso | Fix proposed to master https://review.opendev.org/c/openstack/cinder/+/812685 | 15:12 |
enriquetaso | go on hillpd | 15:12 |
hillpd | the last comment was on Mar 7th, and I wanted to know what's needed to help push this fix forward? | 15:13 |
enriquetaso | I think whoami-rajat may be interested in ^ since it's using cinder as glance backend | 15:13 |
enriquetaso | hillpd, since the bug it's Medium importance it would be nice to have a release note for it | 15:14 |
enriquetaso | I'll review it late this week (adding it to my TO Review List) | 15:14 |
hillpd | ack, I'll add a draft release note | 15:15 |
hillpd | thanks! | 15:16 |
whoami-rajat | enriquetaso, will take a look thansk | 15:16 |
whoami-rajat | thanks | 15:16 |
hillpd | I had one other fix that I was interested in discussing: https://review.opendev.org/c/openstack/python-openstackclient/+/818683 | 15:16 |
hillpd | but I don't know if this is the right forum | 15:17 |
*** blmt is now known as mattia | 15:19 | |
*** mattia is now known as blmt | 15:20 | |
enriquetaso | mmm merge conflict, i don't think the team review it with that red flag there | 15:20 |
enriquetaso | please consider to rebase it | 15:20 |
hillpd | okay, I can do that | 15:21 |
enriquetaso | i'll review it as well and create a launchpad bug for it since I'm not sure if we plan to migrate to Story for now | 15:21 |
enriquetaso | maybe it's a good question for next cinder meeting | 15:22 |
enriquetaso | OK, any other bug to discuss hillpd ? | 15:22 |
hillpd | nope, those were the only two I had to raise | 15:22 |
enriquetaso | thanks ! | 15:28 |
enriquetaso | #topic StorPool: detach volumes and snapshots after copying to/from an image. | 15:29 |
enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1978825 | 15:29 |
enriquetaso | there's a fix proposed to master | 15:30 |
enriquetaso | feel free to review it! | 15:30 |
enriquetaso | #link https://review.opendev.org/c/openstack/cinder/+/845990 | 15:30 |
enriquetaso | #topic open discussion | 15:30 |
enriquetaso | feel free to proposed any bug now :) | 15:31 |
whoami-rajat | hillpd, I've proposed a similar patch like the one you mentioned for OSC https://review.opendev.org/c/openstack/python-openstackclient/+/844268 | 15:32 |
whoami-rajat | i think someone raised this issue on the ML | 15:32 |
hillpd | ah, yeah that fix addresses the same issue | 15:33 |
enriquetaso | whoami-rajat++ | 15:33 |
whoami-rajat | ack, i added some new tests since the volume arg was not tested at all | 15:34 |
hillpd | instead of rebasing the other patch, I'll review yours | 15:34 |
whoami-rajat | cool, let me know if it fixes the issue (if you're facing this as well) | 15:35 |
whoami-rajat | i think i was able to reproduce it on master | 15:35 |
opendevreview | Jan Hartkopf proposed openstack/cinder master: Ceph: add option to keep only last n snapshots per backup https://review.opendev.org/c/openstack/cinder/+/810457 | 15:46 |
whoami-rajat | geguileo, hey, can you update the patch, it's failing on pep8 https://review.opendev.org/c/openstack/cinderlib/+/847170 | 15:49 |
geguileo | darn, I forgot to run pep8 locally | 15:50 |
* geguileo facepalms | 15:50 | |
whoami-rajat | it's a one line change, hopefully we can get that patch in today and update the release patch | 15:51 |
whoami-rajat | i am thinking of proposing a DNM to stable wallaby to test if this fixes the gate | 15:52 |
opendevreview | Gorka Eguileor proposed openstack/cinderlib master: Fix privsep issues inside virtual env https://review.opendev.org/c/openstack/cinderlib/+/847170 | 15:52 |
geguileo | whoami-rajat: I find your lack of faith disturbing | 15:53 |
geguileo | kidding. It's a good idea | 15:53 |
whoami-rajat | :D I've heard always, more testing is never bad | 15:54 |
opendevreview | Rajat Dhasmana proposed openstack/cinder stable/wallaby: DNM: Test cinderlib fix for privsep https://review.opendev.org/c/openstack/cinder/+/847189 | 15:58 |
hemna | 50% ram reduction in devstack!? | 16:02 |
hemna | is this something that can be done outside of devstack?! | 16:03 |
enriquetaso | #endmeeting | 16:14 |
opendevmeet | Meeting ended Wed Jun 22 16:14:27 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:14 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/cinder_bs/2022/cinder_bs.2022-06-22-15.11.html | 16:14 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cinder_bs/2022/cinder_bs.2022-06-22-15.11.txt | 16:14 |
opendevmeet | Log: https://meetings.opendev.org/meetings/cinder_bs/2022/cinder_bs.2022-06-22-15.11.log.html | 16:14 |
enriquetaso | forgot to end the meeting | 16:14 |
* enriquetaso facepalms | 16:14 | |
*** dviroel|lunch is now known as dviroel | 16:31 | |
opendevreview | Walt proposed openstack/cinder-specs master: Add reporting of capacity factors https://review.opendev.org/c/openstack/cinder-specs/+/837768 | 17:13 |
opendevreview | Rafael Weingartner proposed openstack/cinder master: Filter reserved image properties https://review.opendev.org/c/openstack/cinder/+/812685 | 17:43 |
whoami-rajat | geguileo, privsep failures on the cinderlib patch :( https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_829/847170/2/check/cinderlib-os-brick-src-tempest-lvm-lio-barbican-yoga/8292c1f/testr_results.html | 17:53 |
enriquetaso | one +2 left https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/782624 \o/ | 18:41 |
opendevreview | Gorka Eguileor proposed openstack/cinder master: Log when waiting to acquire coordinator lock https://review.opendev.org/c/openstack/cinder/+/847216 | 18:43 |
*** dviroel is now known as dviroel|afk | 19:48 | |
*** dviroel|afk is now known as dviroel | 20:43 | |
*** dviroel is now known as dviroel|afk | 21:22 | |
*** hemna6 is now known as hemna | 23:37 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!