Tuesday, 2022-08-09

*** osmanlicilegi is now known as Guest001:48
opendevreviewMerged openstack/cinder master: Address G004 in flake8-logging-format 0.7.4  https://review.opendev.org/c/openstack/cinder/+/85246104:46
opendevreviewchenwei proposed openstack/cinder master: Remove unicode literal from code  https://review.opendev.org/c/openstack/cinder/+/85251406:18
*** pots5 is now known as pots08:33
opendevreviewHarsh Ailani proposed openstack/cinder master: [SVf] As part of Flashcopy 2.0 adding support for volumegroup  https://review.opendev.org/c/openstack/cinder/+/85236409:42
opendevreviewchenwei proposed openstack/cinder master: Remove unicode literal from code  https://review.opendev.org/c/openstack/cinder/+/85251410:32
opendevreviewMerged openstack/cinder stable/xena: Pin flake8-logging-format to 0.6.0  https://review.opendev.org/c/openstack/cinder/+/85245810:32
*** tosky is now known as Guest7110:46
*** tosky_ is now known as tosky10:46
*** dviroel|out is now known as dviroel11:32
opendevreviewAlexander Deiter proposed openstack/cinder master: Fix Infinidat driver consistency groups feature  https://review.opendev.org/c/openstack/cinder/+/85236911:37
*** bhagyashris is now known as bhagyashris|afk11:44
*** tosky is now known as Guest7712:01
*** tosky__ is now known as tosky12:01
opendevreviewBrian Rosmaita proposed openstack/cinder stable/victoria: DNM: checking flake8-logging-format==0.7.4 damage  https://review.opendev.org/c/openstack/cinder/+/85256512:06
opendevreviewBrian Rosmaita proposed openstack/cinder stable/ussuri: DNM: checking flake8-logging-format==0.7.4 damage  https://review.opendev.org/c/openstack/cinder/+/85256612:09
jhartkopfHey there, I am currently working on a new integration test in cinder-tempest-plugin for this proposed optimization in the Ceph driver (https://review.opendev.org/c/openstack/cinder/+/810457). We talked about this in the Cinder meeting two weeks ago.12:22
jhartkopfCurrently my plan is to add these two tests:12:22
jhartkopf1. Set option to keep all snapshots. Create volume with 3 backups. Verify that all backups are present at the end.12:22
jhartkopf2. Set option to keep only 1 snapshot. Create volume with 3 backups. Verify that only the latest backup is present at the end.12:23
jhartkopfHowever, how could we check this via Tempest? As far as I am aware, only Ceph knows how many source snapshots are actually stored, while Cinder returns all backups.12:23
*** tosky is now known as Guest7812:30
*** tosky_ is now known as tosky12:30
opendevreviewBrian Rosmaita proposed openstack/cinder stable/xena: Unpin flake8-logging-format  https://review.opendev.org/c/openstack/cinder/+/85257012:33
opendevreviewHarsh Ailani proposed openstack/cinder master: [SVf] As part of Flashcopy 2.0 adding support for volumegroup  https://review.opendev.org/c/openstack/cinder/+/85236412:49
*** bhagyashris|afk is now known as bhagyashris12:50
enriquetasojhartkopf, i'm not a tempest expert but I'm interesting in this. 12:58
enriquetasoFrom #810457 commit message "This change also creates a new special case which was not present before: If a user deletes at least n backup snapshots, the next incremental snapshot creation would fail (due to how RBD works). This will be handled by forcing a full backup instead." 12:59
enriquetasoI think you could test that with tempest [[12:59
*** tosky is now known as Guest8513:13
*** tosky__ is now known as tosky13:13
jhartkopfenriquetaso: You're right, that would definitely be another case to test.13:13
opendevreviewEric Harney proposed openstack/cinder master: mypy: cinder/volume/flows/api/manage_existing  https://review.opendev.org/c/openstack/cinder/+/85258113:20
opendevreviewWalt proposed openstack/cinder master: Fix and unify capacity calculations  https://review.opendev.org/c/openstack/cinder/+/83124713:24
opendevreviewWalt proposed openstack/cinder master: Bugfix: Account for consumed space better  https://review.opendev.org/c/openstack/cinder/+/82651013:24
opendevreviewWalt proposed openstack/cinder master: Fix tracking allocated_capacity_gb  https://review.opendev.org/c/openstack/cinder/+/83608313:26
opendevreviewMerged openstack/cinder stable/xena: SF: Remove compat clone image code  https://review.opendev.org/c/openstack/cinder/+/84824914:21
geguileoeharney: whoami-rajat  when you have a minute... https://review.opendev.org/c/openstack/cinder/+/84989014:28
geguileoyou already reviewed that patch before14:28
whoami-rajatgeguileo, I've rerun the CI multiple times but not able to get any passing result ...14:46
opendevreviewBrian Rosmaita proposed openstack/cinder stable/victoria: Address G001 in flake8-logging-format 0.7.4  https://review.opendev.org/c/openstack/cinder/+/85259514:54
opendevreviewBrian Rosmaita proposed openstack/cinder stable/victoria: Add virtualenv requirement to tox.ini  https://review.opendev.org/c/openstack/cinder/+/85259614:55
jungleboyjrosmaita: whoami-rajat  Hey guys, I have had a family commitment come up tomorrow that conflicts with the Mid-cycle.  Apologies.15:01
rosmaitajungleboyj: ack, and hope it's nothing serious15:01
jungleboyjNothing too serious.15:01
opendevreviewBrian Rosmaita proposed openstack/cinder stable/ussuri: Address G001 in flake8-logging-format 0.7.4  https://review.opendev.org/c/openstack/cinder/+/85260015:08
opendevreviewEric Harney proposed openstack/os-brick master: mypy: work around mypy bug #13214  https://review.opendev.org/c/openstack/os-brick/+/85261015:13
*** sfinucan is now known as stephenfin15:16
whoami-rajatjungleboyj, ack, no worries15:22
*** dviroel is now known as dviroel|lunch15:39
rosmaitawhoami-rajat: i finally got the flake8-logging-format thing figured out15:39
rosmaitai think what we should do is15:39
rosmaitamerge https://review.opendev.org/c/openstack/cinder/+/852570 into xena15:39
rosmaitawallaby has no problem15:39
rosmaitamerge https://review.opendev.org/c/openstack/cinder/+/852595 into victoria15:39
rosmaitaand probably also merge https://review.opendev.org/c/openstack/cinder/+/852596 into victoria15:39
rosmaita(the gate doesn't seem to need it, but I can't run pep8 locally in victoria without it)15:39
rosmaitaand then for ussuri, merge https://review.opendev.org/c/openstack/cinder/+/85260015:40
rosmaitatrain and older don't use flake8-logging-format, so no other changes needed15:40
whoami-rajatrosmaita, looks like we should look more carefully into drivers, all fixes are there only!15:46
whoami-rajatand thanks for working on this, i will take a look at the proposed patches15:46
rosmaitacool15:48
whoami-rajatrosmaita, don't we have u-c or some sort of version limit for flake8-logging-format package for every stable branch?15:55
rosmaitano, no u-c on test requirements15:57
whoami-rajatok, bummer that for any backward incompatible change, we've to deal with it in all stable branches ...15:59
rosmaitayeah, we can cap it ourselves in test-requirements, but i figure since they were small fixes, it's better to have them all be able to handle the same version16:01
opendevreviewTushar Trambak Gite proposed openstack/cinder master: Update volume delete api-ref  https://review.opendev.org/c/openstack/cinder/+/82660816:22
whoami-rajatyeah, i was thinking more in general way but this one looks addressable16:33
*** dviroel|lunch is now known as dviroel16:51
hemnayough17:19
opendevreviewPete Zaitcev proposed openstack/cinder master: WIP: Restore into sparse volumes  https://review.opendev.org/c/openstack/cinder/+/85265418:06
*** lifeless_ is now known as lifeless18:24
*** dviroel is now known as dviroel|biab19:34
*** dviroel|biab is now known as dviroel20:13
opendevreviewBrian Rosmaita proposed openstack/os-brick master: Add flake8-logging-format extension  https://review.opendev.org/c/openstack/os-brick/+/85267220:25
opendevreviewAlan Bishop proposed openstack/python-cinderclient master: Bump API max version to 3.70  https://review.opendev.org/c/openstack/python-cinderclient/+/85267420:54
opendevreviewAlan Bishop proposed openstack/cinder-tempest-plugin master: WIP: Test ability to transfer encrypted volumes  https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/85267521:03
*** dviroel is now known as dviroel|out21:17

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!