opendevreview | Merged openstack/cinder master: NetApp ONTAP: Add REST Client for ONTAP https://review.opendev.org/c/openstack/cinder/+/836027 | 00:14 |
---|---|---|
opendevreview | Felipe Rodrigues proposed openstack/cinder master: NetApp ONTAP: Add volume replication functions on REST client https://review.opendev.org/c/openstack/cinder/+/852209 | 00:33 |
opendevreview | Felipe Rodrigues proposed openstack/cinder master: NetApp ONTAP: Add volume replication functions on REST client https://review.opendev.org/c/openstack/cinder/+/852209 | 00:36 |
opendevreview | Felipe Rodrigues proposed openstack/cinder master: NetApp ONTAP: Add volume replication functions on REST client https://review.opendev.org/c/openstack/cinder/+/852209 | 00:38 |
opendevreview | Felipe Rodrigues proposed openstack/cinder master: NetApp ONTAP: Add volume replication functions on REST client https://review.opendev.org/c/openstack/cinder/+/852209 | 00:50 |
opendevreview | Felipe Rodrigues proposed openstack/cinder master: NetApp ONTAP: Add volume migration functions on REST client https://review.opendev.org/c/openstack/cinder/+/852210 | 00:58 |
opendevreview | Felipe Rodrigues proposed openstack/cinder master: NetApp ONTAP: Add revert to snapshot functions on REST client https://review.opendev.org/c/openstack/cinder/+/852211 | 01:03 |
opendevreview | Merged openstack/cinder master: NetApp ONTAP: Add core functions on REST client https://review.opendev.org/c/openstack/cinder/+/852208 | 03:34 |
opendevreview | OpenStack Proposal Bot proposed openstack/cinder master: Imported Translations from Zanata https://review.opendev.org/c/openstack/cinder/+/856002 | 03:58 |
opendevreview | Masayuki Igawa proposed openstack/os-brick stable/wallaby: Fix encryption symlink issues https://review.opendev.org/c/openstack/os-brick/+/856576 | 05:58 |
opendevreview | Masayuki Igawa proposed openstack/os-brick stable/wallaby: Fix encryption symlink issues https://review.opendev.org/c/openstack/os-brick/+/856576 | 06:14 |
harshailani | yuval: I have addressed the comments on the review: https://review.opendev.org/c/openstack/cinder/+/852364 | 07:05 |
*** bhagyashris is now known as bhagyashris|ruck | 07:57 | |
*** marlinc is now known as Guest2357 | 08:13 | |
opendevreview | OpenStack Release Bot proposed openstack/os-brick stable/zed: Update .gitreview for stable/zed https://review.opendev.org/c/openstack/os-brick/+/856708 | 10:27 |
opendevreview | OpenStack Release Bot proposed openstack/os-brick stable/zed: Update TOX_CONSTRAINTS_FILE for stable/zed https://review.opendev.org/c/openstack/os-brick/+/856709 | 10:27 |
opendevreview | OpenStack Release Bot proposed openstack/os-brick master: Update master for stable/zed https://review.opendev.org/c/openstack/os-brick/+/856710 | 10:27 |
opendevreview | OpenStack Release Bot proposed openstack/os-brick master: Add Python3 antelope unit tests https://review.opendev.org/c/openstack/os-brick/+/856711 | 10:27 |
opendevreview | OpenStack Release Bot proposed openstack/python-brick-cinderclient-ext stable/zed: Update .gitreview for stable/zed https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/856712 | 10:27 |
opendevreview | OpenStack Release Bot proposed openstack/python-brick-cinderclient-ext stable/zed: Update TOX_CONSTRAINTS_FILE for stable/zed https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/856713 | 10:27 |
opendevreview | OpenStack Release Bot proposed openstack/python-brick-cinderclient-ext master: Update master for stable/zed https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/856714 | 10:27 |
opendevreview | OpenStack Release Bot proposed openstack/python-brick-cinderclient-ext master: Add Python3 antelope unit tests https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/856715 | 10:27 |
opendevreview | OpenStack Release Bot proposed openstack/python-cinderclient stable/zed: Update .gitreview for stable/zed https://review.opendev.org/c/openstack/python-cinderclient/+/856716 | 10:28 |
opendevreview | OpenStack Release Bot proposed openstack/python-cinderclient stable/zed: Update TOX_CONSTRAINTS_FILE for stable/zed https://review.opendev.org/c/openstack/python-cinderclient/+/856717 | 10:28 |
opendevreview | OpenStack Release Bot proposed openstack/python-cinderclient master: Update master for stable/zed https://review.opendev.org/c/openstack/python-cinderclient/+/856718 | 10:28 |
opendevreview | OpenStack Release Bot proposed openstack/python-cinderclient master: Add Python3 antelope unit tests https://review.opendev.org/c/openstack/python-cinderclient/+/856719 | 10:28 |
opendevreview | Atsushi Kawai proposed openstack/cinder master: Hitachi: fix to output resource lock message correctly https://review.opendev.org/c/openstack/cinder/+/856385 | 10:34 |
opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Dell EMC Unity driver in cinder https://review.opendev.org/c/openstack/cinder/+/856460 | 10:48 |
opendevreview | Merged openstack/cinder master: Lightos - add lightos new volume states https://review.opendev.org/c/openstack/cinder/+/856259 | 10:56 |
opendevreview | Nahim Alves de Souza proposed openstack/cinder master: NetApp ONTAP: Add volume migration functions on REST client https://review.opendev.org/c/openstack/cinder/+/852210 | 11:23 |
opendevreview | Nahim Alves de Souza proposed openstack/cinder master: NetApp ONTAP: Add revert to snapshot functions on REST client https://review.opendev.org/c/openstack/cinder/+/852211 | 11:30 |
opendevreview | Walt proposed openstack/cinder master: Fix and unify capacity calculations https://review.opendev.org/c/openstack/cinder/+/831247 | 12:34 |
opendevreview | Merged openstack/os-brick stable/zed: Update .gitreview for stable/zed https://review.opendev.org/c/openstack/os-brick/+/856708 | 12:35 |
opendevreview | Merged openstack/os-brick stable/zed: Update TOX_CONSTRAINTS_FILE for stable/zed https://review.opendev.org/c/openstack/os-brick/+/856709 | 12:38 |
opendevreview | Merged openstack/os-brick master: Update master for stable/zed https://review.opendev.org/c/openstack/os-brick/+/856710 | 12:39 |
opendevreview | Merged openstack/python-brick-cinderclient-ext stable/zed: Update .gitreview for stable/zed https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/856712 | 12:40 |
opendevreview | Merged openstack/python-brick-cinderclient-ext stable/zed: Update TOX_CONSTRAINTS_FILE for stable/zed https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/856713 | 12:41 |
opendevreview | Merged openstack/python-brick-cinderclient-ext master: Update master for stable/zed https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/856714 | 12:41 |
opendevreview | Merged openstack/python-cinderclient stable/zed: Update .gitreview for stable/zed https://review.opendev.org/c/openstack/python-cinderclient/+/856716 | 12:48 |
opendevreview | Merged openstack/python-cinderclient stable/zed: Update TOX_CONSTRAINTS_FILE for stable/zed https://review.opendev.org/c/openstack/python-cinderclient/+/856717 | 12:55 |
opendevreview | Merged openstack/python-cinderclient master: Update master for stable/zed https://review.opendev.org/c/openstack/python-cinderclient/+/856718 | 13:08 |
opendevreview | Merged openstack/python-brick-cinderclient-ext master: Add Python3 antelope unit tests https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/856715 | 13:20 |
opendevreview | Brian Rosmaita proposed openstack/python-cinderclient master: Update bindep for ubuntu jammy https://review.opendev.org/c/openstack/python-cinderclient/+/856765 | 13:39 |
opendevreview | Brian Rosmaita proposed openstack/python-cinderclient master: Add Python3 antelope unit tests https://review.opendev.org/c/openstack/python-cinderclient/+/856719 | 13:44 |
nahimsouza[m] | Hello, cores, the latest 3 patches related to NetApp ONTAP REST API migration are ready for reviews. Zuul is voting +1 and the first [1] already has a +2 from whoami-rajat. Thanks a lot for the help so far :)... (full message at https://matrix.org/_matrix/media/r0/download/matrix.org/yMUbBgWzLEslFCNmqTguseQT) | 13:56 |
rosmaita | jungleboyj: while you're in a reviewing mood, i would like to get these 2 small patches out of my life: https://review.opendev.org/q/project:openstack%252Frbd-iscsi-client+status:open | 14:06 |
opendevreview | Merged openstack/os-brick master: Add Python3 antelope unit tests https://review.opendev.org/c/openstack/os-brick/+/856711 | 14:09 |
akawai | whoami-rajat: Thx for reviewing my patch "Hitachi: Add port scheduler | https://review.opendev.org/c/openstack/cinder/+/828696". | 14:14 |
akawai | whoami-rajat: But the workflow for the patch was failed with invocation error in openstack-tox-py38. Could you help the patch? | 14:14 |
opendevreview | Merged openstack/cinder master: Imported Translations from Zanata https://review.opendev.org/c/openstack/cinder/+/856002 | 14:14 |
whoami-rajat | akawai, I've rechecked it, it should merge this time | 14:17 |
akawai | whoam-rajat: thx! | 14:19 |
opendevreview | Merged openstack/rbd-iscsi-client master: Replace testing template with individual jobs https://review.opendev.org/c/openstack/rbd-iscsi-client/+/852783 | 14:31 |
rosmaita | jungleboyj: ty! | 14:31 |
admin17 | i have 2 volumes, one stuck in deleting and one in creating . ( backed by ceph) .. but it does not produce any errors in any logs file .. how do I troubleshoot this on where the issue lies ? | 14:42 |
*** dviroel is now known as dviroel|lunch | 14:52 | |
*** abishop_ is now known as abishop | 15:12 | |
opendevreview | Walt proposed openstack/cinder master: Fix and unify capacity calculations https://review.opendev.org/c/openstack/cinder/+/831247 | 15:50 |
*** dviroel|lunch is now known as dviroel | 15:53 | |
opendevreview | Merged openstack/cinder master: Tests: fix quobyte breaking other tests https://review.opendev.org/c/openstack/cinder/+/854263 | 16:50 |
opendevreview | Merged openstack/cinder master: Tests: Fix 3par https://review.opendev.org/c/openstack/cinder/+/854264 | 16:50 |
opendevreview | Merged openstack/cinder master: Tests: Fix IBM XIV https://review.opendev.org/c/openstack/cinder/+/854265 | 16:50 |
whoami-rajat | sfernand, hi, I've seen the netapp FC CI fail quite a few times, can you check if it's a valid issue? https://review.opendev.org/c/openstack/cinder/+/852211 | 17:10 |
opendevreview | Felipe Rodrigues proposed openstack/cinder master: NetApp ONTAP: Add volume migration functions on REST client https://review.opendev.org/c/openstack/cinder/+/852210 | 17:29 |
opendevreview | Felipe Rodrigues proposed openstack/cinder master: NetApp ONTAP: Add revert to snapshot functions on REST client https://review.opendev.org/c/openstack/cinder/+/852211 | 17:30 |
nahimsouza[m] | hi, whoami-rajat, currently, our FC jobs are unstable, we are monitoring and trying to solve that - for now, I believe the best we can do is to run the CI again | 17:34 |
whoami-rajat | felipe_rodrigues, the same (result, expected) pattern is repeated throughout the tests, can you fix that quickly? | 17:35 |
felipe_rodrigues | really ? for sure, I'll check it and submit a fix soon. Thanks :) | 17:36 |
whoami-rajat | nahimsouza[m], ack, just wanted to be sure that the changes added recently are not causing the failure right? | 17:36 |
whoami-rajat | felipe_rodrigues, yeah just fix it in the tests that are added by the patch, I don't mind if there are in existing code which we can fix later | 17:37 |
nahimsouza[m] | whoami-rajat: right, these failures are not related to the lastest changes | 17:37 |
whoami-rajat | nahimsouza[m], cool, then we're good | 17:37 |
opendevreview | Felipe Rodrigues proposed openstack/cinder master: NetApp ONTAP: Add volume migration functions on REST client https://review.opendev.org/c/openstack/cinder/+/852210 | 17:56 |
opendevreview | Felipe Rodrigues proposed openstack/cinder master: NetApp ONTAP: Add revert to snapshot functions on REST client https://review.opendev.org/c/openstack/cinder/+/852211 | 17:56 |
opendevreview | Merged openstack/cinder master: Hitachi: Add port scheduler https://review.opendev.org/c/openstack/cinder/+/828696 | 18:14 |
hemna | It's like Friday and stuff or something | 18:30 |
hemna | man I'm seeing some really odd stuff in some drivers | 18:56 |
hemna | first, if a driver doesn't report thin_provisioning_support or thick_provisioning_support, then thick is presumed according to the capacity_filter. | 18:57 |
hemna | also WTF is this sh*t ? https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/qnap.py#L699 | 18:59 |
hemna | and https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/qnap.py#L307 | 19:00 |
hemna | cinder is going to track volumes on qnap as thick provisioned, but their driver is creating then as thin provisioned. | 19:01 |
hemna | smh | 19:01 |
hemna | I was always under the assumption that thin provisioning was the default, but that's not true according to the capacity filter | 19:02 |
hemna | The host_manager, which populates the PoolState (after get_volume_stats() is called and reported to the scheduler), will default both thin_ and thick_ as False | 19:03 |
hemna | the capacity filter will check specifically for thin being True. else it's thick | 19:03 |
hemna | so if neither thin_* and thick_* is returned in the driver's get_volume_stats, it's thick. | 19:04 |
hemna | and there are several drivers that don't report either. | 19:07 |
hemna | smh | 19:07 |
opendevreview | Rajat Dhasmana proposed openstack/cinder master: Support os-brick specific lock_path https://review.opendev.org/c/openstack/cinder/+/849325 | 19:47 |
rosmaita | hemna: can you hit https://review.opendev.org/c/openstack/rbd-iscsi-client/+/852738 to turn pep8 back on for rbd-iscsi-client ? | 19:47 |
sfernand | whoami-rajat: FCP tests passed now | 19:57 |
whoami-rajat | sfernand, great! | 19:58 |
sfernand | sorry about that this box is in its last days | 19:58 |
whoami-rajat | no issues, good to know it's fixed | 20:01 |
*** dviroel is now known as dviroel|out | 20:02 | |
sfernand | hemna: I'm looking on it | 20:02 |
sfernand | yep that is weird, driver reports both True and False as capabilities to the scheduler hahaha | 20:08 |
sfernand | since it will alsho appears in get-pools info maybe the developer though it as a good way to show to operators which options they can set in the volume type. I don't know :P | 20:08 |
hemna | sfernand the qnap driver? | 20:08 |
sfernand | problem is that it kind of mess with the scheduler that is the only purpose of having the function call | 20:08 |
sfernand | yep | 20:08 |
hemna | well, that's not even reporting correctly at all | 20:08 |
hemna | qnap_thin_privision isn't a scheduler thing at all. | 20:09 |
sfernand | yes that is totally wrong IMO =x | 20:09 |
hemna | it needs to be thin_provisioning_suport | 20:09 |
hemna | qnap is thick provisioned from cinder's perspective as a result | 20:10 |
hemna | rosmaita done | 20:10 |
sfernand | from the perspective of the scheduler right? because cinder itself wont keep track if a volume is thick or thin I guess | 20:10 |
sfernand | buy I may be wrong | 20:10 |
rosmaita | hemna: ty | 20:11 |
hemna | correct, and the scheduler needs to know to decide how much it will allow against a pool | 20:11 |
hemna | which could be really really bad | 20:11 |
sfernand | yep | 20:11 |
hemna | specifically tracking the allocated_capacity_gb | 20:11 |
opendevreview | Walt proposed openstack/cinder master: Fix and unify capacity calculations https://review.opendev.org/c/openstack/cinder/+/831247 | 20:13 |
sfernand | wow patch is from 2017 https://review.opendev.org/c/openstack/cinder/+/470188 | 20:13 |
hemna | damn that's bad that was +2'd at all | 20:14 |
sfernand | looking if that was some discussion around that in the past | 20:14 |
sfernand | nope | 20:14 |
hemna | technically you can return whatever you want in get_volume_stats, but if you want your driver to work correctly with cinder's scheduler that's another thing entirely | 20:15 |
opendevreview | Merged openstack/rbd-iscsi-client master: Address G002 in flake8-logging-format 0.7.4 https://review.opendev.org/c/openstack/rbd-iscsi-client/+/852738 | 20:21 |
sfernand | rosmaita: thanks for doing the recheck | 20:48 |
sfernand | I was about to do that but saw your comment first :P | 20:49 |
rosmaita | :D | 20:49 |
felipe_rodrigues | hi guys, My driver patch is very close to merge. whoami-rajat and yuval already approved. The driver CI and Zuul passed. It still more one core reviews, could you review the patch ? https://review.opendev.org/c/openstack/cinder/+/847732 | 21:20 |
opendevreview | Merged openstack/python-cinderclient master: Update bindep for ubuntu jammy https://review.opendev.org/c/openstack/python-cinderclient/+/856765 | 21:28 |
opendevreview | Merged openstack/python-cinderclient master: Add Python3 antelope unit tests https://review.opendev.org/c/openstack/python-cinderclient/+/856719 | 21:28 |
opendevreview | Alexander Deiter proposed openstack/cinder master: Fix Infinidat driver multi-attach feature https://review.opendev.org/c/openstack/cinder/+/850321 | 22:29 |
opendevreview | Merged openstack/cinder master: NetApp ONTAP: Add volume replication functions on REST client https://review.opendev.org/c/openstack/cinder/+/852209 | 23:19 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!