Friday, 2022-09-09

opendevreviewMerged openstack/cinder master: NetApp ONTAP: Add REST Client for ONTAP  https://review.opendev.org/c/openstack/cinder/+/83602700:14
opendevreviewFelipe Rodrigues proposed openstack/cinder master: NetApp ONTAP: Add volume replication functions on REST client  https://review.opendev.org/c/openstack/cinder/+/85220900:33
opendevreviewFelipe Rodrigues proposed openstack/cinder master: NetApp ONTAP: Add volume replication functions on REST client  https://review.opendev.org/c/openstack/cinder/+/85220900:36
opendevreviewFelipe Rodrigues proposed openstack/cinder master: NetApp ONTAP: Add volume replication functions on REST client  https://review.opendev.org/c/openstack/cinder/+/85220900:38
opendevreviewFelipe Rodrigues proposed openstack/cinder master: NetApp ONTAP: Add volume replication functions on REST client  https://review.opendev.org/c/openstack/cinder/+/85220900:50
opendevreviewFelipe Rodrigues proposed openstack/cinder master: NetApp ONTAP: Add volume migration functions on REST client  https://review.opendev.org/c/openstack/cinder/+/85221000:58
opendevreviewFelipe Rodrigues proposed openstack/cinder master: NetApp ONTAP: Add revert to snapshot functions on REST client  https://review.opendev.org/c/openstack/cinder/+/85221101:03
opendevreviewMerged openstack/cinder master: NetApp ONTAP: Add core functions on REST client  https://review.opendev.org/c/openstack/cinder/+/85220803:34
opendevreviewOpenStack Proposal Bot proposed openstack/cinder master: Imported Translations from Zanata  https://review.opendev.org/c/openstack/cinder/+/85600203:58
opendevreviewMasayuki Igawa proposed openstack/os-brick stable/wallaby: Fix encryption symlink issues  https://review.opendev.org/c/openstack/os-brick/+/85657605:58
opendevreviewMasayuki Igawa proposed openstack/os-brick stable/wallaby: Fix encryption symlink issues  https://review.opendev.org/c/openstack/os-brick/+/85657606:14
harshailaniyuval: I have addressed the comments on the review: https://review.opendev.org/c/openstack/cinder/+/85236407:05
*** bhagyashris is now known as bhagyashris|ruck07:57
*** marlinc is now known as Guest235708:13
opendevreviewOpenStack Release Bot proposed openstack/os-brick stable/zed: Update .gitreview for stable/zed  https://review.opendev.org/c/openstack/os-brick/+/85670810:27
opendevreviewOpenStack Release Bot proposed openstack/os-brick stable/zed: Update TOX_CONSTRAINTS_FILE for stable/zed  https://review.opendev.org/c/openstack/os-brick/+/85670910:27
opendevreviewOpenStack Release Bot proposed openstack/os-brick master: Update master for stable/zed  https://review.opendev.org/c/openstack/os-brick/+/85671010:27
opendevreviewOpenStack Release Bot proposed openstack/os-brick master: Add Python3 antelope unit tests  https://review.opendev.org/c/openstack/os-brick/+/85671110:27
opendevreviewOpenStack Release Bot proposed openstack/python-brick-cinderclient-ext stable/zed: Update .gitreview for stable/zed  https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/85671210:27
opendevreviewOpenStack Release Bot proposed openstack/python-brick-cinderclient-ext stable/zed: Update TOX_CONSTRAINTS_FILE for stable/zed  https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/85671310:27
opendevreviewOpenStack Release Bot proposed openstack/python-brick-cinderclient-ext master: Update master for stable/zed  https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/85671410:27
opendevreviewOpenStack Release Bot proposed openstack/python-brick-cinderclient-ext master: Add Python3 antelope unit tests  https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/85671510:27
opendevreviewOpenStack Release Bot proposed openstack/python-cinderclient stable/zed: Update .gitreview for stable/zed  https://review.opendev.org/c/openstack/python-cinderclient/+/85671610:28
opendevreviewOpenStack Release Bot proposed openstack/python-cinderclient stable/zed: Update TOX_CONSTRAINTS_FILE for stable/zed  https://review.opendev.org/c/openstack/python-cinderclient/+/85671710:28
opendevreviewOpenStack Release Bot proposed openstack/python-cinderclient master: Update master for stable/zed  https://review.opendev.org/c/openstack/python-cinderclient/+/85671810:28
opendevreviewOpenStack Release Bot proposed openstack/python-cinderclient master: Add Python3 antelope unit tests  https://review.opendev.org/c/openstack/python-cinderclient/+/85671910:28
opendevreviewAtsushi Kawai proposed openstack/cinder master: Hitachi: fix to output resource lock message correctly  https://review.opendev.org/c/openstack/cinder/+/85638510:34
opendevreviewTushar Trambak Gite proposed openstack/cinder master: Dell EMC Unity driver in cinder  https://review.opendev.org/c/openstack/cinder/+/85646010:48
opendevreviewMerged openstack/cinder master: Lightos - add lightos new volume states  https://review.opendev.org/c/openstack/cinder/+/85625910:56
opendevreviewNahim Alves de Souza proposed openstack/cinder master: NetApp ONTAP: Add volume migration functions on REST client  https://review.opendev.org/c/openstack/cinder/+/85221011:23
opendevreviewNahim Alves de Souza proposed openstack/cinder master: NetApp ONTAP: Add revert to snapshot functions on REST client  https://review.opendev.org/c/openstack/cinder/+/85221111:30
opendevreviewWalt proposed openstack/cinder master: Fix and unify capacity calculations  https://review.opendev.org/c/openstack/cinder/+/83124712:34
opendevreviewMerged openstack/os-brick stable/zed: Update .gitreview for stable/zed  https://review.opendev.org/c/openstack/os-brick/+/85670812:35
opendevreviewMerged openstack/os-brick stable/zed: Update TOX_CONSTRAINTS_FILE for stable/zed  https://review.opendev.org/c/openstack/os-brick/+/85670912:38
opendevreviewMerged openstack/os-brick master: Update master for stable/zed  https://review.opendev.org/c/openstack/os-brick/+/85671012:39
opendevreviewMerged openstack/python-brick-cinderclient-ext stable/zed: Update .gitreview for stable/zed  https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/85671212:40
opendevreviewMerged openstack/python-brick-cinderclient-ext stable/zed: Update TOX_CONSTRAINTS_FILE for stable/zed  https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/85671312:41
opendevreviewMerged openstack/python-brick-cinderclient-ext master: Update master for stable/zed  https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/85671412:41
opendevreviewMerged openstack/python-cinderclient stable/zed: Update .gitreview for stable/zed  https://review.opendev.org/c/openstack/python-cinderclient/+/85671612:48
opendevreviewMerged openstack/python-cinderclient stable/zed: Update TOX_CONSTRAINTS_FILE for stable/zed  https://review.opendev.org/c/openstack/python-cinderclient/+/85671712:55
opendevreviewMerged openstack/python-cinderclient master: Update master for stable/zed  https://review.opendev.org/c/openstack/python-cinderclient/+/85671813:08
opendevreviewMerged openstack/python-brick-cinderclient-ext master: Add Python3 antelope unit tests  https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/85671513:20
opendevreviewBrian Rosmaita proposed openstack/python-cinderclient master: Update bindep for ubuntu jammy  https://review.opendev.org/c/openstack/python-cinderclient/+/85676513:39
opendevreviewBrian Rosmaita proposed openstack/python-cinderclient master: Add Python3 antelope unit tests  https://review.opendev.org/c/openstack/python-cinderclient/+/85671913:44
nahimsouza[m]Hello, cores, the latest 3 patches related to NetApp ONTAP REST API migration are ready for reviews. Zuul is voting +1 and the first [1] already has a +2 from whoami-rajat. Thanks a lot for the help so far :)... (full message at https://matrix.org/_matrix/media/r0/download/matrix.org/yMUbBgWzLEslFCNmqTguseQT)13:56
rosmaitajungleboyj: while you're in a reviewing mood, i would like to get these 2 small patches out of my life: https://review.opendev.org/q/project:openstack%252Frbd-iscsi-client+status:open14:06
opendevreviewMerged openstack/os-brick master: Add Python3 antelope unit tests  https://review.opendev.org/c/openstack/os-brick/+/85671114:09
akawaiwhoami-rajat: Thx for reviewing my patch "Hitachi: Add port scheduler | https://review.opendev.org/c/openstack/cinder/+/828696".14:14
akawaiwhoami-rajat: But the workflow for the patch was failed with invocation error in openstack-tox-py38. Could you help the patch? 14:14
opendevreviewMerged openstack/cinder master: Imported Translations from Zanata  https://review.opendev.org/c/openstack/cinder/+/85600214:14
whoami-rajatakawai, I've rechecked it, it should merge this time14:17
akawaiwhoam-rajat: thx!14:19
opendevreviewMerged openstack/rbd-iscsi-client master: Replace testing template with individual jobs  https://review.opendev.org/c/openstack/rbd-iscsi-client/+/85278314:31
rosmaitajungleboyj: ty!14:31
admin17i have 2 volumes, one stuck in deleting and one in creating . ( backed by ceph) .. but it does not produce any errors in any logs file .. how do I troubleshoot this on where the issue lies ? 14:42
*** dviroel is now known as dviroel|lunch14:52
*** abishop_ is now known as abishop15:12
opendevreviewWalt proposed openstack/cinder master: Fix and unify capacity calculations  https://review.opendev.org/c/openstack/cinder/+/83124715:50
*** dviroel|lunch is now known as dviroel15:53
opendevreviewMerged openstack/cinder master: Tests: fix quobyte breaking other tests  https://review.opendev.org/c/openstack/cinder/+/85426316:50
opendevreviewMerged openstack/cinder master: Tests: Fix 3par  https://review.opendev.org/c/openstack/cinder/+/85426416:50
opendevreviewMerged openstack/cinder master: Tests: Fix IBM XIV  https://review.opendev.org/c/openstack/cinder/+/85426516:50
whoami-rajatsfernand, hi, I've seen the netapp FC CI fail quite a few times, can you check if it's a valid issue? https://review.opendev.org/c/openstack/cinder/+/85221117:10
opendevreviewFelipe Rodrigues proposed openstack/cinder master: NetApp ONTAP: Add volume migration functions on REST client  https://review.opendev.org/c/openstack/cinder/+/85221017:29
opendevreviewFelipe Rodrigues proposed openstack/cinder master: NetApp ONTAP: Add revert to snapshot functions on REST client  https://review.opendev.org/c/openstack/cinder/+/85221117:30
nahimsouza[m]hi, whoami-rajat, currently, our FC jobs are unstable, we are monitoring and trying to solve that - for now, I believe the best we can do is to run the CI again17:34
whoami-rajatfelipe_rodrigues, the same (result, expected) pattern is repeated throughout the tests, can you fix that quickly?17:35
felipe_rodriguesreally ? for sure, I'll check it and submit a fix soon. Thanks :)17:36
whoami-rajatnahimsouza[m], ack, just wanted to be sure that the changes added recently are not causing the failure right?17:36
whoami-rajatfelipe_rodrigues, yeah just fix it in the tests that are added by the patch, I don't mind if there are in existing code which we can fix later17:37
nahimsouza[m]whoami-rajat: right, these failures are not related to the lastest changes17:37
whoami-rajatnahimsouza[m], cool, then we're good17:37
opendevreviewFelipe Rodrigues proposed openstack/cinder master: NetApp ONTAP: Add volume migration functions on REST client  https://review.opendev.org/c/openstack/cinder/+/85221017:56
opendevreviewFelipe Rodrigues proposed openstack/cinder master: NetApp ONTAP: Add revert to snapshot functions on REST client  https://review.opendev.org/c/openstack/cinder/+/85221117:56
opendevreviewMerged openstack/cinder master: Hitachi: Add port scheduler  https://review.opendev.org/c/openstack/cinder/+/82869618:14
hemnaIt's like Friday and stuff or something18:30
hemnaman I'm seeing some really odd stuff in some drivers18:56
hemnafirst, if a driver doesn't report thin_provisioning_support or thick_provisioning_support, then thick is presumed according to the capacity_filter.18:57
hemnaalso WTF is this sh*t ? https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/qnap.py#L69918:59
hemnaand https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/qnap.py#L30719:00
hemnacinder is going to track volumes on qnap as thick provisioned, but their driver is creating then as thin provisioned.19:01
hemnasmh19:01
hemnaI was always under the assumption that thin provisioning was the default, but that's not true according to the capacity filter19:02
hemnaThe host_manager, which populates the PoolState (after get_volume_stats() is called and reported to the scheduler), will default both thin_ and thick_ as False19:03
hemnathe capacity filter will check specifically for thin being True.  else it's thick19:03
hemnaso if neither thin_* and thick_* is returned in the driver's get_volume_stats, it's thick.19:04
hemnaand there are several drivers that don't report either.19:07
hemnasmh19:07
opendevreviewRajat Dhasmana proposed openstack/cinder master: Support os-brick specific lock_path  https://review.opendev.org/c/openstack/cinder/+/84932519:47
rosmaitahemna: can you hit https://review.opendev.org/c/openstack/rbd-iscsi-client/+/852738 to turn pep8 back on for rbd-iscsi-client ?19:47
sfernandwhoami-rajat: FCP tests passed now19:57
whoami-rajatsfernand, great!19:58
sfernandsorry about that this box is in its last days19:58
whoami-rajatno issues, good to know it's fixed20:01
*** dviroel is now known as dviroel|out20:02
sfernandhemna: I'm looking on it 20:02
sfernandyep that is weird, driver reports both True and False as capabilities to the scheduler hahaha20:08
sfernandsince it will alsho appears in get-pools info maybe the developer though it as a good way to show to operators which options they can set in the volume type. I don't know :P20:08
hemnasfernand the qnap driver?20:08
sfernandproblem is that it kind of mess with the scheduler that is the only purpose of having the function call20:08
sfernandyep20:08
hemnawell, that's not even reporting correctly at all20:08
hemnaqnap_thin_privision isn't a scheduler thing at all.20:09
sfernandyes that is totally wrong IMO =x20:09
hemnait needs to be thin_provisioning_suport20:09
hemnaqnap is thick provisioned from cinder's perspective as a result20:10
hemnarosmaita done20:10
sfernandfrom the perspective of the scheduler right? because cinder itself wont keep track if a volume is thick or thin I guess20:10
sfernandbuy I may be wrong20:10
rosmaitahemna: ty20:11
hemnacorrect, and the scheduler needs to know to decide how much it will allow against a pool20:11
hemnawhich could be really really bad20:11
sfernandyep20:11
hemnaspecifically tracking the allocated_capacity_gb20:11
opendevreviewWalt proposed openstack/cinder master: Fix and unify capacity calculations  https://review.opendev.org/c/openstack/cinder/+/83124720:13
sfernandwow patch is from 2017 https://review.opendev.org/c/openstack/cinder/+/47018820:13
hemnadamn that's bad that was +2'd at all20:14
sfernandlooking if that was some discussion around that in the past20:14
sfernandnope20:14
hemnatechnically you can return whatever you want in get_volume_stats, but if you want your driver to work correctly with cinder's scheduler that's another thing entirely20:15
opendevreviewMerged openstack/rbd-iscsi-client master: Address G002 in flake8-logging-format 0.7.4  https://review.opendev.org/c/openstack/rbd-iscsi-client/+/85273820:21
sfernandrosmaita: thanks for doing the recheck20:48
sfernand I was about to do that but saw your comment first :P20:49
rosmaita:D20:49
felipe_rodrigueshi guys, My driver patch is very close to merge. whoami-rajat and yuval already approved. The driver CI and Zuul passed. It still more one core reviews, could you review the patch ?  https://review.opendev.org/c/openstack/cinder/+/84773221:20
opendevreviewMerged openstack/python-cinderclient master: Update bindep for ubuntu jammy  https://review.opendev.org/c/openstack/python-cinderclient/+/85676521:28
opendevreviewMerged openstack/python-cinderclient master: Add Python3 antelope unit tests  https://review.opendev.org/c/openstack/python-cinderclient/+/85671921:28
opendevreviewAlexander Deiter proposed openstack/cinder master: Fix Infinidat driver multi-attach feature  https://review.opendev.org/c/openstack/cinder/+/85032122:29
opendevreviewMerged openstack/cinder master: NetApp ONTAP: Add volume replication functions on REST client  https://review.opendev.org/c/openstack/cinder/+/85220923:19

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!