| *** tkajinam is now known as Guest3966 | 00:09 | |
| *** tkajinam is now known as Guest3972 | 01:47 | |
| aneeeshp1 | rosmaita whoami-rajat I have addressed comments on the https://review.opendev.org/c/openstack/cinder/+/849143. Please review. | 03:38 |
|---|---|---|
| *** tkajinam is now known as Guest3986 | 05:43 | |
| *** tkajinam is now known as Guest3988 | 06:53 | |
| *** amoralej|off is now known as amoralej | 07:13 | |
| opendevreview | Rajat Dhasmana proposed openstack/cinder master: WIP: Add exception handling in copy volume https://review.opendev.org/c/openstack/cinder/+/862679 | 10:15 |
| opendevreview | Atsushi Kawai proposed openstack/cinder master: HPE: Cinder driver for HPE XP storage FC and iSCSI arrays https://review.opendev.org/c/openstack/cinder/+/815582 | 10:26 |
| *** amoralej is now known as amoralej|lunch | 10:55 | |
| *** dviroel|afk is now known as dviroel | 11:28 | |
| *** amoralej|lunch is now known as amoralej | 12:31 | |
| geguileo | rosmaita: I believe whoami-rajat was on PTO, did he ask you to host the IRC meeting_ | 14:02 |
| geguileo | ? | 14:02 |
| geguileo | s/was/is | 14:02 |
| eharney | https://etherpad.opendev.org/p/cinder-antelope-meetings says cancelled for today | 14:03 |
| rosmaita | geguileo: i thought he sent an email? | 14:04 |
| geguileo | eharney: I probably missed his upstream email... | 14:04 |
| enriquetaso | oh, can we have the bug meeting anyway? | 14:04 |
| rosmaita | sure, if you really want to, seems like we have a quorum here | 14:04 |
| geguileo | rosmaita: Haven't been paying much attention to emails | 14:04 |
| enriquetaso | i need help with 2 bugs | 14:04 |
| enriquetaso | #startmeeting cinder_bs | 14:04 |
| opendevmeet | Meeting started Wed Oct 26 14:04:47 2022 UTC and is due to finish in 60 minutes. The chair is enriquetaso. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:04 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:04 |
| opendevmeet | The meeting name has been set to 'cinder_bs' | 14:04 |
| rosmaita | geguileo: i replied to your osc question in an email! | 14:04 |
| enriquetaso | hey everyone | 14:04 |
| rosmaita | o/ | 14:05 |
| geguileo | rosmaita: I saw, but that looks like a lot of work and probably not the biggest reason why osc is soooooooooooooooooooooooooooooooooooooo slow | 14:05 |
| enriquetaso | Full list of bugs | 14:05 |
| enriquetaso | #link https://lists.openstack.org/pipermail/openstack-discuss/2022-October/031001.html | 14:05 |
| rosmaita | geguileo: yeah, it was disappointing | 14:05 |
| enriquetaso | I'm not sure how to prioritize the next two bugs: | 14:06 |
| enriquetaso | #topic The volume multiattach and in-use after retyping another backend, then can not detach it | 14:06 |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1994018 | 14:06 |
| enriquetaso | After retyping from Ceph to Huawei the volume can not be detached because the connection info volume_id has been changed. | 14:06 |
| enriquetaso | I haven't reproduced this bug yet. That's why I haven't assigned importance to the bug yet. Looks like Nova is involved but I'm not sure what to do with this bug. | 14:06 |
| geguileo | enriquetaso: We used to have that issue in Nova a while back | 14:08 |
| geguileo | enriquetaso: and it was fixed | 14:08 |
| geguileo | though this could be a different one | 14:08 |
| geguileo | once we know the openstack release we may look if it was fixed or not | 14:08 |
| geguileo | oh, wait it looks different | 14:09 |
| enriquetaso | yes, i've remember we discussed something like that a while ago | 14:09 |
| enriquetaso | oh | 14:09 |
| geguileo | but I see where the problem is... | 14:10 |
| geguileo | and we are in trouble... | 14:12 |
| rosmaita | i don't like the sound of that | 14:13 |
| geguileo | I'm 99% sure that's a legitimate bug | 14:13 |
| geguileo | and surprise, surprise, it's the multi-attach design/implementation | 14:13 |
| geguileo | that didn't take into account that the volume_id changes during a live migration | 14:13 |
| geguileo | but didn't we prevent multi-attach volume from live migrating/retyping? | 14:15 |
| enriquetaso | :/ | 14:15 |
| geguileo | wait, wait, wait | 14:17 |
| enriquetaso | "You can migrate only detached volumes with no snapshots." | 14:17 |
| geguileo | enriquetaso: what's that from? | 14:18 |
| enriquetaso | #link https://opendev.org/openstack/cinder/src/branch/master/doc/source/cli/cli-manage-volumes.rst#migrate-a-volume | 14:18 |
| geguileo | enriquetaso: afaik that is incorrect | 14:20 |
| geguileo | we can migrate in-use volumes | 14:21 |
| eharney | with retype, right? | 14:21 |
| geguileo | but I don't understand WHY we allow migrating/retyping with migration of multi-attach in-use volumes | 14:21 |
| eharney | i thought we didn't | 14:21 |
| geguileo | eharney: I'm looking at the code and unless I'm missing something, we do | 14:22 |
| geguileo | as long as both the source and target types are both multi-attach | 14:22 |
| geguileo | I'm pretty sure that's a bug | 14:22 |
| geguileo | WTF!! It's an if condition bug | 14:23 |
| geguileo | MF!!! | 14:23 |
| geguileo | apparently it was too much to ask to write an if clause | 14:23 |
| enriquetaso | :( | 14:23 |
| geguileo | it's a trivial fix | 14:23 |
| geguileo | it's a oneliner | 14:24 |
| enriquetaso | share link to the code please | 14:24 |
| geguileo | basically changing != with or | 14:24 |
| geguileo | it's in cinder/volume/api.py | 14:24 |
| geguileo | if src_is_multiattach != tgt_is_multiattach: | 14:24 |
| geguileo | s/!=/or/ | 14:24 |
| enriquetaso | #action(enriquetaso): open bug to fix https://opendev.org/openstack/cinder/src/branch/master/doc/source/cli/cli-manage-volumes.rst#migrate-a-volume . It's incorrect, with allow retype in-use volumes (without multi-attach). | 14:25 |
| enriquetaso | oops | 14:25 |
| geguileo | reading a bit more, we may want to make a couple more changes besides that one | 14:25 |
| geguileo | because, as expected, it looks like the whole check section is not properly thought of | 14:26 |
| geguileo | it should only complain if the source is multi-attach, it shouldn't matter about the target | 14:26 |
| eharney | if the source is a multi-attach type, or is attached to multiple instances? | 14:27 |
| eharney | because right now the check is based on the type | 14:28 |
| geguileo | eharney: I think it should check if the source is multi-attach and the volume is not available ==> error | 14:28 |
| geguileo | if the target is multi-attach and it's not authorized ==> error | 14:28 |
| eharney | geguileo: not sure why it matters if the source is multi-attach if it's not actually multiply attached | 14:28 |
| geguileo | and that should be it | 14:28 |
| geguileo | eharney: I think it would be possible to do the second attachment while we are migrating | 14:29 |
| geguileo | or have a race condition right there... | 14:29 |
| geguileo | eharney: ideally we would code a conditional DB update that takes into account the actual attachments | 14:30 |
| geguileo | that way we would allow a live migration of a multi-attach volume just by reducing the number of VMs using it | 14:31 |
| eharney | right | 14:31 |
| geguileo | the TL;DR, you are correct, that would be the right way to fix it | 14:31 |
| geguileo | but then it's not a small patch, but a large one to prevent races | 14:32 |
| enriquetaso | OK, so the bug is valid and we need to work on some bugfixes then | 14:39 |
| enriquetaso | and also in some doc fixes | 14:39 |
| enriquetaso | OK, thanks!! | 14:43 |
| enriquetaso | moving to the next one | 14:43 |
| enriquetaso | #topic Cinder cannot work when 1 node of 3 rabbit node cluster down | 14:43 |
| enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/1994021 | 14:43 |
| enriquetaso | There's a discussion on the mailling list regarding this problem. | 14:43 |
| enriquetaso | #link https://lists.openstack.org/pipermail/openstack-discuss/2022-October/030968.html | 14:43 |
| enriquetaso | is something we could do in cinder? | 14:43 |
| enriquetaso | should i link oslo project as well? | 14:50 |
| geguileo | enriquetaso: I think this has 0 to do with Cinder specifically... | 14:51 |
| geguileo | I mean, we get the transport_url parameter, and that's what gets used | 14:51 |
| geguileo | so it's either an oslo.messaging issue or a configuration/deployment issue | 14:52 |
| enriquetaso | thanks geguileo, makes sense, i'll update the bug report | 14:53 |
| geguileo | we could also be setting it incorrectly in our code, but I wouldn't think that's the issue... | 14:53 |
| enriquetaso | thanks geguileo | 14:54 |
| geguileo | enriquetaso: I have added a comment to the retype LP bug with the techincal discussion we had here | 14:55 |
| enriquetaso | cool! | 14:55 |
| enriquetaso | that always helps | 14:55 |
| enriquetaso | OK, we are running out of time. The bug meeting should be half an hour and I took one hour | 14:56 |
| enriquetaso | please check the bug email for all the bugs for this week. | 14:56 |
| enriquetaso | #endmeeting | 14:57 |
| opendevmeet | Meeting ended Wed Oct 26 14:57:48 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:57 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cinder_bs/2022/cinder_bs.2022-10-26-14.04.html | 14:57 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cinder_bs/2022/cinder_bs.2022-10-26-14.04.txt | 14:57 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cinder_bs/2022/cinder_bs.2022-10-26-14.04.log.html | 14:57 |
| *** dviroel is now known as dviroel|lunch | 15:08 | |
| *** dviroel|lunch is now known as dviroel | 16:26 | |
| *** amoralej is now known as amoralej|off | 16:43 | |
| opendevreview | Sofia Enriquez proposed openstack/cinder-tempest-plugin master: Add Backup Restore Multibackend Tests https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/835512 | 17:34 |
| *** dviroel is now known as dviroel|afk | 20:03 | |
| opendevreview | Sofia Enriquez proposed openstack/cinder-tempest-plugin master: DNM: LVM + Ceph Multibackend Job https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/862757 | 21:05 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!