| *** abhishekk is now known as akekane|home | 04:41 | |
| *** akekane|home is now known as abhishekk | 04:42 | |
| *** elodilles_pto is now known as elodilles | 08:42 | |
| enriquetaso | hi, I can't remember if we already discussed this but looks like a bit part of cinder unit test will fails with python 3.11 | 10:25 |
|---|---|---|
| enriquetaso | https://lists.openstack.org/pipermail/openstack-discuss/2023-January/031655.html | 10:25 |
| *** dviroe|out is now known as dviroe | 11:32 | |
| *** dviroe is now known as dviroel | 11:32 | |
| opendevreview | Merged openstack/cinder stable/train: [PURE] support IPv6 / add parameter pure_iscsi_cidr_list https://review.opendev.org/c/openstack/cinder/+/867345 | 11:46 |
| *** bhagyashris is now known as bhagyashris|afk | 13:17 | |
| opendevreview | Brian Rosmaita proposed openstack/python-cinderclient master: Get ready for tox 4 https://review.opendev.org/c/openstack/python-cinderclient/+/868317 | 13:43 |
| ganso | rosmaita: hi! could you please re-review patch https://review.opendev.org/c/openstack/cinder/+/812685 when you have some time? It has got a +2 from whoami-rajat | 13:44 |
| rosmaita | ganso: will do | 13:44 |
| ganso | rosmaita: thank you! | 13:44 |
| whoami-rajat | Cinder meeting in #openstack-meeting-alt at 1400 UTC | 13:59 |
| whoami-rajat | jungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard sfernand enriquetaso hemna fabiooliveira yuval tobias-urdin adiare | 13:59 |
| rosmaita | whoami-rajat: ty | 13:59 |
| whoami-rajat | np | 13:59 |
| opendevreview | Nicolas Bock proposed openstack/cinder master: Increase size of volume image metadata values https://review.opendev.org/c/openstack/cinder/+/868485 | 14:13 |
| opendevreview | Brian Rosmaita proposed openstack/python-cinderclient master: DNM: check functional jobs https://review.opendev.org/c/openstack/python-cinderclient/+/869226 | 14:54 |
| *** dviroel is now known as dviroel|lunch | 14:54 | |
| enriquetaso | Hey Argonauts: I need to run now and can't start the bug meeting today! | 15:01 |
| enriquetaso | The full list of bugs is https://lists.openstack.org/pipermail/openstack-discuss/2023-January/031649.html | 15:02 |
| rosmaita | enriquetaso: thanks! | 15:02 |
| whoami-rajat | enriquetaso, sure np, thanks | 15:02 |
| enriquetaso | thanks!! | 15:02 |
| rosmaita | eharney: this tox 4 stuff is getting to be a real PITA | 15:03 |
| eharney | rosmaita: yeah, the py38 tox env is installing python3.11 in the tox environment | 15:03 |
| eharney | and running tests w/ it | 15:03 |
| rosmaita | that is really weird ... what is you default system python version? | 15:04 |
| eharney | 3.11, but i can see that .tox/py38/bin/python is 3.11.1 | 15:04 |
| rosmaita | my system python is 3.10.9, maybe that's why it's not happening for me locally | 15:04 |
| rosmaita | yep | 15:05 |
| rosmaita | [master] wha'ppen? .tox/py38/bin/python --version | 15:05 |
| rosmaita | Python 3.10.9 | 15:05 |
| eharney | https://paste.opendev.org/show/b0l8V3VYAumUMK5MnKxI/ | 15:05 |
| eharney | so it hits the mock failures in unit tests and fails ^ | 15:05 |
| rosmaita | right | 15:05 |
| rosmaita | i wonder whether the auto-detect of base python version has been discontinued in 4? | 15:06 |
| eharney | is this autodetecting anything if i run "-e py38" ? | 15:06 |
| rosmaita | yes | 15:06 |
| rosmaita | actually, let me check real quick | 15:07 |
| eharney | maybe i'm not sure what "autodetect" means here | 15:07 |
| rosmaita | well, you used to be able to say -3 py38 and it would use py 38 even you dind't have a specific py38 testenv | 15:08 |
| rosmaita | but, i bet now that we have [testenv:py{3,38,39,310,311}] | 15:08 |
| rosmaita | in there, it's inheriting the basepython from [testenv] | 15:09 |
| rosmaita | dammit | 15:09 |
| eharney | so, i removed basepython from [testenv] and then "-e py38" does the right thing | 15:09 |
| rosmaita | cool | 15:10 |
| rosmaita | why don't you put up a patch removing that, because no one has a non-python-3 default at this point | 15:10 |
| rosmaita | not for master, anyway | 15:10 |
| eharney | yeah i was just wondering why that's actually there | 15:11 |
| eharney | will do | 15:11 |
| sathya_r | Hi Reviewers, I have doubt in cinder retype with --migration-policy | 15:11 |
| rosmaita | legacy cargo-cult! | 15:11 |
| sathya_r | I'm trying to implement the volume migration between two different storages | 15:11 |
| sathya_r | but the if i provide pool parameter in the volume type, it's entering the cinder generic migration code | 15:11 |
| sathya_r | instead of entering the driver code. | 15:11 |
| eharney | ignore_basepython_conflict=true seems "curious" too | 15:11 |
| sathya_r | bug report link : https://bugs.launchpad.net/cinder/+bug/2001619 | 15:12 |
| rosmaita | eharney: we may not need that anymore, but i don't think it hurts anything | 15:12 |
| opendevreview | Eric Harney proposed openstack/cinder master: tox: Remove [testenv] basepython setting https://review.opendev.org/c/openstack/cinder/+/869228 | 15:13 |
| whoami-rajat | sathya_r, are you trying to implement the retype support in your driver? | 15:15 |
| whoami-rajat | or it's already there but not working correctly | 15:15 |
| sathya_r | yes rajat | 15:15 |
| whoami-rajat | ok, so we do call driver specific retype from manager before even going to the migrate_volume method | 15:15 |
| whoami-rajat | https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L3087-L3091 | 15:16 |
| whoami-rajat | migrate_volume is only called if the driver wan't able to perform the retype | 15:17 |
| whoami-rajat | https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L3107-L3109 | 15:17 |
| sathya_r | can we take this on my personal chat, i have few more queries | 15:18 |
| sathya_r | whoami-rajat can we connect? | 15:21 |
| whoami-rajat | sathya_r, sure | 15:24 |
| harsh | Hi team, looking for a final +2 and +w on the SVf driver feature : https://review.opendev.org/c/openstack/cinder/+/852364 | 15:25 |
| harsh | Just got the +2 from jungleboyj | 15:26 |
| harsh | Thanks :) | 15:26 |
| jungleboyj | Welcome. | 15:26 |
| sfv880 | Hello reviewers, I addressed all the comments on https://review.opendev.org/c/openstack/cinder/+/852369 and https://review.opendev.org/c/openstack/cinder/+/864287 - our customers are waiting for these fixes to be merged. Also, these changes are required to pass the RHOSP certification. Could you please review it ? Thank you so much! | 15:34 |
| opendevreview | Eric Harney proposed openstack/cinder master: mypy: cover cinder/policies/* https://review.opendev.org/c/openstack/cinder/+/869231 | 15:37 |
| opendevreview | Eric Harney proposed openstack/cinder master: mypy: Add to cinder.policy.authorize annotation https://review.opendev.org/c/openstack/cinder/+/869232 | 15:37 |
| opendevreview | Brian Rosmaita proposed openstack/python-cinderclient master: DNM: check functional jobs https://review.opendev.org/c/openstack/python-cinderclient/+/869226 | 15:37 |
| rosmaita | eharney: I think the ignore_base_python_conflict is OK, but you could remove it, because it's true by default now: https://tox.wiki/en/latest/config.html#python-language-core-options | 15:56 |
| eharney | rosmaita: trying to parse what "Furthermore, we allow hard enforcing this rule by setting this flag to true." means in that doc... | 15:57 |
| rosmaita | beats me, all i know is that i added it a few years ago, so it used to be false by default | 15:58 |
| eharney | maybe that is stale text from before the default was changed | 15:58 |
| rosmaita | just re-read that text ... you're right, the "Furthermore" section implies that with ignore_basepython_conflict=true like we have it, tox should be using the implied version, not the basepython defined in [testenv] | 16:01 |
| *** dviroel|lunch is now known as dviroel | 16:06 | |
| opendevreview | Caique Mello proposed openstack/os-brick master: [DNM] NetApp CI test os-brick project https://review.opendev.org/c/openstack/os-brick/+/869234 | 16:09 |
| opendevreview | Eric Harney proposed openstack/python-cinderclient master: remove simplejson requirement https://review.opendev.org/c/openstack/python-cinderclient/+/868988 | 17:20 |
| opendevreview | Merged openstack/cinder master: [SVf] Optimize lsmdiskgrp calls in creation of replicated volumes https://review.opendev.org/c/openstack/cinder/+/848418 | 17:21 |
| opendevreview | Merged openstack/cinder master: [SVf] As part of Flashcopy 2.0 adding support for volumegroup https://review.opendev.org/c/openstack/cinder/+/852364 | 17:21 |
| opendevreview | Ghanshyam Mann proposed openstack/cinder stable/zed: DNM: tetsing tox<4 pin https://review.opendev.org/c/openstack/cinder/+/869251 | 18:20 |
| opendevreview | Ghanshyam Mann proposed openstack/cinder stable/yoga: DNM: tetsing tox<4 pin https://review.opendev.org/c/openstack/cinder/+/869187 | 18:21 |
| opendevreview | Ghanshyam Mann proposed openstack/cinder stable/xena: DNM: tetsing tox<4 pin https://review.opendev.org/c/openstack/cinder/+/869188 | 18:21 |
| opendevreview | Eric Harney proposed openstack/cinder master: Test run py311 unit tests https://review.opendev.org/c/openstack/cinder/+/869258 | 19:36 |
| opendevreview | Eric Harney proposed openstack/cinder master: Test run py311 unit tests https://review.opendev.org/c/openstack/cinder/+/869258 | 19:39 |
| eharney | rosmaita: i tried making a py311 job, but it ran w/ 3.10 anyway AFAICT ^ | 19:56 |
| rosmaita | eharney: i am liking tox 4 less and less | 19:57 |
| eharney | i noticed that cinderlib already has a py311 test job, but it is now broken | 19:59 |
| opendevreview | Eric Harney proposed openstack/cinder master: mypy: Annotate cinder/compute/nova.py https://review.opendev.org/c/openstack/cinder/+/869259 | 20:23 |
| opendevreview | Brian Rosmaita proposed openstack/python-cinderclient master: DNM: check functional jobs https://review.opendev.org/c/openstack/python-cinderclient/+/869226 | 20:24 |
| opendevreview | Brian Rosmaita proposed openstack/cinder stable/zed: [stable-only] Pin tox <4 https://review.opendev.org/c/openstack/cinder/+/868429 | 20:44 |
| rosmaita | if ^^ works, i will be updating all the patches for the stable branches | 20:45 |
| *** dviroel is now known as dviroel|ourt | 21:09 | |
| opendevreview | Brian Rosmaita proposed openstack/cinder stable/yoga: [stable-only] Pin tox <4 https://review.opendev.org/c/openstack/cinder/+/868444 | 23:11 |
| opendevreview | Brian Rosmaita proposed openstack/cinder stable/xena: [stable-only] Pin tox <4 https://review.opendev.org/c/openstack/cinder/+/868445 | 23:12 |
| opendevreview | Brian Rosmaita proposed openstack/cinder stable/wallaby: [stable-only] Pin tox <4 https://review.opendev.org/c/openstack/cinder/+/868446 | 23:13 |
| opendevreview | Brian Rosmaita proposed openstack/python-cinderclient stable/zed: [stable-only] Pin tox <4 https://review.opendev.org/c/openstack/python-cinderclient/+/869263 | 23:34 |
| opendevreview | Brian Rosmaita proposed openstack/python-cinderclient stable/yoga: [stable-only] Pin tox <4 https://review.opendev.org/c/openstack/python-cinderclient/+/869264 | 23:36 |
| opendevreview | Brian Rosmaita proposed openstack/python-cinderclient stable/xena: [stable-only] Pin tox <4 https://review.opendev.org/c/openstack/python-cinderclient/+/869265 | 23:37 |
| opendevreview | Brian Rosmaita proposed openstack/python-cinderclient stable/wallaby: [stable-only] Pin tox <4 https://review.opendev.org/c/openstack/python-cinderclient/+/869267 | 23:39 |
| rosmaita | I still can't get the python-cinderclient functional jobs to work in master ... I left a comment on https://review.opendev.org/c/openstack/python-cinderclient/+/869226/3 if anyone has time or interest in tox. I'm done for the day. | 23:45 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!