opendevreview | Merged openstack/cinder stable/yoga: Check VMDK subformat against an allowed list https://review.opendev.org/c/openstack/cinder/+/871620 | 02:28 |
---|---|---|
whoami-rajat | jbernard, ack, thanks, will take a look once everything merges | 03:43 |
whoami-rajat | enriquetaso, can you take another look at this? the CI is passing now https://review.opendev.org/c/openstack/cinder/+/815582 | 03:45 |
opendevreview | Merged openstack/cinder master: NVMe-TCP volume driver for Fungible Storage https://review.opendev.org/c/openstack/cinder/+/849143 | 05:11 |
*** bhagyashris_ is now known as bhagyashris|ruck | 07:34 | |
enriquetaso | sorry, ive remove the -1 rosmaita whoami-rajat | 10:00 |
whoami-rajat | enriquetaso, no worries, thanks! | 10:01 |
Kumar_Kanishka | Hi all, requesting review for my patch https://review.opendev.org/c/openstack/cinder/+/869305 | 11:02 |
*** dviroel_ is now known as dviroel | 11:21 | |
whoami-rajat | abdi, hi, around? | 13:01 |
enriquetaso | should I recheck the CVE patch https://review.opendev.org/c/openstack/releases/+/871656 ? | 13:20 |
whoami-rajat | enriquetaso, we still have to update with xena hash (which failed twice in recheck) | 13:24 |
enriquetaso | ack! | 13:24 |
gksk | Hi Team | 13:29 |
gksk | can some one pls review the below patch | 13:29 |
gksk | https://review.opendev.org/c/openstack/cinder/+/869704 | 13:29 |
whoami-rajat | gksk, the storwize CI hasn't responded on PS4 | 13:35 |
gksk | yes last time it passed but from yesterday our CI server has some issue it will be fixed in couple of days | 13:36 |
whoami-rajat | ack, until the CI passes it won't be possible to merge the change | 13:44 |
gksk | Ok Rajat Thank you then I will re run the CI on my patch once our CI servers restored | 13:47 |
whoami-rajat | great, thanks | 13:55 |
whoami-rajat | Cinder meeting in #openstack-meeting-alt at 1400 UTC | 13:59 |
whoami-rajat | jungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard sfernand enriquetaso hemna fabiooliveira yuval tobias-urdin adiare | 13:59 |
rosmaita | whoami-rajat: ty | 13:59 |
whoami-rajat | np | 13:59 |
opendevreview | Peter Penchev proposed openstack/cinder master: Add iSCSI export support to the StorPool driver https://review.opendev.org/c/openstack/cinder/+/847536 | 14:39 |
ganso | jungleboyj, whoami-rajat: I included an item in the request for review list in the agenda, it is pending only your re-reviews. rosmaita already re-reviewed. THanks in advance | 15:01 |
enriquetaso | #startmeeting cinder_bs | 15:01 |
opendevmeet | Meeting started Wed Jan 25 15:01:59 2023 UTC and is due to finish in 60 minutes. The chair is enriquetaso. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:01 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:01 |
opendevmeet | The meeting name has been set to 'cinder_bs' | 15:01 |
enriquetaso | Report of bugs | 15:02 |
enriquetaso | #link https://lists.openstack.org/pipermail/openstack-discuss/2023-January/031900.html | 15:02 |
enriquetaso | #topic Security issue with VMDK format | 15:02 |
enriquetaso | <happystacker> I have a question around it but we talk in our bug review | 15:02 |
rosmaita | o/ | 15:02 |
whoami-rajat | ganso, ack, i see it's in merge conflict | 15:02 |
whoami-rajat | but we can discuss later after the BS meeting | 15:02 |
whoami-rajat | hi | 15:02 |
enriquetaso | hi | 15:02 |
hemna | hi | 15:02 |
enriquetaso | i think happystacker is not here lol | 15:02 |
rosmaita | whoami-rajat: ganso: probably because it touches image_utils, and we just merged a big change in there | 15:02 |
ganso | whoami-rajat: oh I didn't spot the merge conflict in this new gerrit interface | 15:03 |
whoami-rajat | ah yes | 15:03 |
ganso | whoami-rajat: I will rebase it, thanks | 15:03 |
whoami-rajat | cool thanks | 15:03 |
rosmaita | ok, we can return to it if happystacker shows up later | 15:03 |
enriquetaso | ++ | 15:03 |
enriquetaso | #topic Group actions enable, disable and failover replication can leave volume's replication status in transient states enabling, disabling and failing-over respectively. | 15:03 |
enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/2003804 | 15:03 |
enriquetaso | "Consider a group(grp_1) has 3 volumes(vol_1, vol_2, vol_3) and initially all the volume's replication_status is 'disabled'. When a user executes below use-cases concurrently, there is a probability that volume's replication_status gets stuck in 'enabling' status." | 15:04 |
enriquetaso | Fix proposed to master: | 15:04 |
enriquetaso | #link https://review.opendev.org/c/openstack/cinder/+/871649 | 15:04 |
enriquetaso | Looks like a valid bug but the patch needs some update | 15:04 |
happystacker | sorry, I got disconnected, the question was more on why do we need to convert some format to .raw? | 15:05 |
enriquetaso | hey! | 15:06 |
happystacker | I have one bug affected by this conversion. | 15:06 |
rosmaita | happystacker: i think it's because volumes are usually in raw format, that's what nova expects (except for some weird cases) | 15:06 |
happystacker | Ok, but it may harms some operation like a server resize where the server expects a qcow2 but have a .raw instead | 15:07 |
happystacker | https://bugs.launchpad.net/cinder/+bug/2002535 | 15:07 |
rosmaita | but we convert in the other direction too, when we upload a volume as an image | 15:07 |
Roamer` | happystacker, if I understand your question correctly, in most (I believe) shared storage (at least) backends it is better for the volume to be raw, so the storage backend can expose it directly as a disk device, so that read/write operations are, well, fast | 15:08 |
happystacker | ok which makes sense | 15:08 |
rosmaita | yeah, NFS is a different beast | 15:08 |
happystacker | yeah as you substract one layer of presentation | 15:08 |
rosmaita | you're really "faking" a raw volume as a filesystem entity | 15:08 |
happystacker | but in case of NFS, it's preventing the server resize as you can see in the bug. server is expected one format but have another one | 15:09 |
eharney | yeah, we need to understand what is happening in that bug | 15:09 |
happystacker | I did a very basic investigation, we probably need to go deeper | 15:10 |
happystacker | I'm here again... | 15:11 |
happystacker | I did a very basic investigation, we probably need to go deeper | 15:11 |
happystacker | having some network issues at my office | 15:11 |
happystacker | sorry for that | 15:12 |
enriquetaso | i havent reproduced the bug yet, sorry about that, but ill try to add some input after finishing the encryption part | 15:12 |
enriquetaso | no worries happystacker | 15:12 |
happystacker | cool thanks | 15:12 |
enriquetaso | not sure how can we track all the NFS problems besides launchpad | 15:13 |
eharney | launchpad bugs should work? | 15:13 |
enriquetaso | i think so, using the tag `nfs` | 15:14 |
rosmaita | enriquetaso: ++ | 15:14 |
enriquetaso | okay, moving on | 15:14 |
enriquetaso | The last 2 bugs are driver related and both have patches proposed to master | 15:14 |
enriquetaso | #topic [HPE] cinder 3par FC driver not connecting to 3PAR storage | 15:14 |
enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/2003245 | 15:14 |
enriquetaso | I think this is a misunderstanding about how to deploy FC with HPE driver and not really a cinder related bug. However, since the bug has been really active and HPE are still having discussion there, I've left the question so they can reply with input. | 15:14 |
enriquetaso | #topic [SVf] : Enable support for replication volume with mirror pool option | 15:17 |
roquej | I have another bug but I think this is driver related, even if I'm not sure that's the expected bahavior | 15:17 |
opendevreview | Simon Dodsley proposed openstack/cinder master: [Pure Storage] Add support for 3-site, trisync, replication. https://review.opendev.org/c/openstack/cinder/+/862365 | 15:17 |
enriquetaso | roquej, sure, would you mind sharing it after the svf one? | 15:17 |
enriquetaso | #link https://bugs.launchpad.net/cinder/+bug/2003245 | 15:18 |
roquej | sure | 15:18 |
enriquetaso | Fix proposed to master: | 15:18 |
enriquetaso | #link https://review.opendev.org/c/openstack/cinder/+/870006 | 15:18 |
enriquetaso | Unit tests are not passing, waiting for update. | 15:18 |
enriquetaso | done | 15:18 |
enriquetaso | #topic open discussion | 15:18 |
enriquetaso | roquej, feel free now | 15:18 |
roquej | https://bugs.launchpad.net/cinder/+bug/2003179 | 15:18 |
opendevreview | Eric Harney proposed openstack/os-brick master: Bump bandit to release 1.7.0 https://review.opendev.org/c/openstack/os-brick/+/871260 | 15:18 |
sfv880_ | Hello eharney, rosmaita: I'm sorry to bother you! We are looking for a final +2 and +w on the Infinidat fix: https://review.opendev.org/c/openstack/cinder/+/864287 - could you please review it ? Thank you very much! | 15:19 |
roquej | when creating an image from volume, it turns out that a password is sent in plain text by privsep daemon in the logs | 15:19 |
enriquetaso | i forgot to add nova to 2003179 | 15:19 |
eharney | yeah we need to fix this | 15:19 |
rosmaita | sfv880_: ack | 15:19 |
sfv880_ | rosmaita: thank you very much! | 15:20 |
eharney | we have code that tries to automatically filter passwords like this, i haven't looked deep enough into why it's not covering this case | 15:20 |
enriquetaso | okay, maybe nova shoudnt be added | 15:20 |
eharney | maybe no identifying field to indicate that it's a password | 15:20 |
roquej | only when creating a volume from image | 15:21 |
enriquetaso | ooh okay | 15:21 |
eharney | it's because the password is fed to a CLI call via stdin? | 15:21 |
roquej | not sure, it's done via privsep | 15:21 |
roquej | I have posted the links to the code that I've identified as involved into this bug | 15:22 |
roquej | not sure where to start now | 15:22 |
eharney | oh it's reading the password from a file and returning it | 15:22 |
roquej | yes | 15:23 |
roquej | I tried with strutils to mask the password but didn't make it | 15:23 |
eharney | right | 15:23 |
roquej | maybe we need to change our way to get the password | 15:23 |
simondodsley | Cores: I just changed the commit message on https://review.opendev.org/c/openstack/cinder/+/862365. There was a typo. Our CI is currently down for maintenance and so our CI run failed with node failure. | 15:25 |
enriquetaso | okay, this looks like a bit change/new implementation.. In addition, this affects all nfs-related drivers, ill update the bug title, because i tought it was a dell-only bug | 15:25 |
eharney | there may be a short-term workaround by changing some options with how privsep is invoked for that particular call, but not sure | 15:25 |
simondodsley | Given there was no code change and the last Pure CI passed please take this into consideration when reviewing this patch | 15:25 |
roquej | this bug is not about nfs | 15:26 |
roquej | ok | 15:26 |
eharney | this is only going to affect the scaleio connector | 15:26 |
roquej | unless some other drivers used privsep to get password in the same manner, I'd say yes | 15:27 |
enriquetaso | sorry for the misunderstanding.. this is a bug about how privsep on how it handles passwords and it's going to affect the scaleio connector | 15:29 |
Sathya | Hi, https://bugs.launchpad.net/cinder/+bug/2001619 retype for volume migration with additional extra specs not entering driver specific code | 15:29 |
Sathya | geguileo had provided a general work flow for this issue | 15:29 |
Sathya | I have pushed a patch for the bug, along with ut's fix https://review.opendev.org/c/openstack/cinder/+/869999 | 15:30 |
enriquetaso | okay, running out of time eharney roquej | 15:30 |
Sathya | can i get some review for this patch https://review.opendev.org/c/openstack/cinder/+/869999 | 15:30 |
enriquetaso | do you mind if we continue the discussion on the launchpad bug? anyway I'll update the bug with this information | 15:30 |
enriquetaso | thanks!! | 15:30 |
enriquetaso | #endmeeting | 15:30 |
opendevmeet | Meeting ended Wed Jan 25 15:30:49 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:30 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/cinder_bs/2023/cinder_bs.2023-01-25-15.01.html | 15:30 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cinder_bs/2023/cinder_bs.2023-01-25-15.01.txt | 15:30 |
opendevmeet | Log: https://meetings.opendev.org/meetings/cinder_bs/2023/cinder_bs.2023-01-25-15.01.log.html | 15:30 |
roquej | thanks | 15:31 |
geguileo | tosky: do you know how to deploy multipathd on a CI job? | 15:47 |
geguileo | it's about https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/870889/ | 15:48 |
geguileo | failures are due to a bug in os-brick/nova/cinder that we assumed ALL multipathing would be with multipathd | 15:48 |
geguileo | but nvmeof doesn't need it so it's not installed and nova passes multipath enforcing to true when multipath is enabled | 15:48 |
geguileo | and since it's not present it fails | 15:49 |
geguileo | So I just need to deploy multipathd on that job | 15:49 |
geguileo | probably just a playbook... | 15:54 |
opendevreview | Rafael Weingartner proposed openstack/cinder master: Filter reserved image properties https://review.opendev.org/c/openstack/cinder/+/812685 | 16:01 |
opendevreview | Eric Harney proposed openstack/cinder master: Bump oslo.versionedobjects to 2.4.0+ https://review.opendev.org/c/openstack/cinder/+/871739 | 16:03 |
tosky | geguileo: erm, not exactly | 16:05 |
geguileo | tosky: I'm just writing a small playbook to install and start it | 16:06 |
tosky | geguileo: I mean, I remember us discussing this long ago and you mentioning it could be done with LVM with some magic setup for networking | 16:07 |
opendevreview | Merged openstack/cinder stable/xena: Check VMDK subformat against an allowed list https://review.opendev.org/c/openstack/cinder/+/871625 | 16:07 |
tosky | but then I couldn't investigate further | 16:07 |
tosky | so if you create one, yes, it's easy to setup a job | 16:07 |
geguileo | tosky: mmmmm, no, we can do multipathing with LVM using the local ip address in the secondary ip adresses config option | 16:07 |
geguileo | tosky: which is what I'm doing for nvmeof | 16:07 |
geguileo | tosky: but the host still needs multipathd | 16:08 |
tosky | that's what I call a magic setup for networking | 16:08 |
tosky | ok, not so magic | 16:08 |
tosky | still, networking | 16:08 |
*** dviroel is now known as dviroel|lunch | 16:08 | |
geguileo | yeah, but multipathd still needs to be installed | 16:08 |
geguileo | so playbook, right? | 16:08 |
geguileo | because devstack doesn't have support for it | 16:08 |
geguileo | and the job is not triple-o, which also has support | 16:08 |
tosky | I mean, you could also patch devstack to setup that configuration | 16:09 |
geguileo | tosky: I'm only trying to confirm that the patch series passes CI with a specific configuration... | 16:10 |
tosky | but on the other hand a playbook could be quickly used also on old releases | 16:10 |
opendevreview | Gorka Eguileor proposed openstack/cinder-tempest-plugin master: WIP: zuul: Test LVM/nvmet additional job https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/870889 | 16:15 |
tosky | 16:28 | |
tosky | geguileo: I will keep an eye on that | 16:29 |
opendevreview | Merged openstack/cinder master: Send the correct location URI to the Glance v2 API https://review.opendev.org/c/openstack/cinder/+/845178 | 16:30 |
*** dviroel|lunch is now known as dviroel | 17:14 | |
opendevreview | Merged openstack/os-brick master: Handle FileNotFoundError on get_system_uuid() https://review.opendev.org/c/openstack/os-brick/+/862542 | 17:40 |
opendevreview | Gorka Eguileor proposed openstack/cinder-tempest-plugin master: WIP: zuul: Test LVM/nvmet additional job https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/870889 | 18:37 |
opendevreview | Simon Dodsley proposed openstack/cinder master: [Pure Storage] Add new array status for replication capability https://review.opendev.org/c/openstack/cinder/+/871261 | 18:46 |
opendevreview | Simon Dodsley proposed openstack/cinder master: [Pure Storage] Add new array status for replication capability https://review.opendev.org/c/openstack/cinder/+/871261 | 19:30 |
*** dviroel is now known as dviroel|out | 20:52 | |
opendevreview | Brian Rosmaita proposed openstack/cinder stable/wallaby: [stable-em only] move grenade jobs to experimental https://review.opendev.org/c/openstack/cinder/+/871790 | 21:39 |
opendevreview | Brian Rosmaita proposed openstack/cinder stable/victoria: [stable-em only] move grenade jobs to experimental https://review.opendev.org/c/openstack/cinder/+/871791 | 21:43 |
opendevreview | Brian Rosmaita proposed openstack/cinder stable/ussuri: [stable-em only] move grenade jobs to experimental https://review.opendev.org/c/openstack/cinder/+/871792 | 21:46 |
opendevreview | Brian Rosmaita proposed openstack/cinder stable/train: [stable-em only] move grenade jobs to experimental https://review.opendev.org/c/openstack/cinder/+/871794 | 21:50 |
opendevreview | Brian Rosmaita proposed openstack/cinder stable/stein: [stable-em only] move grenade jobs to experimental https://review.opendev.org/c/openstack/cinder/+/871796 | 21:54 |
gmann | whoami-rajat: need your +1 on this https://review.opendev.org/c/openstack/releases/+/868581 | 21:58 |
opendevreview | Brian Rosmaita proposed openstack/cinder stable/rocky: [rocky-only] drop grenade jobs https://review.opendev.org/c/openstack/cinder/+/871799 | 21:59 |
opendevreview | Merged openstack/python-cinderclient master: Continue using tox 3 https://review.opendev.org/c/openstack/python-cinderclient/+/870971 | 22:07 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!