opendevreview | Atsushi Kawai proposed openstack/cinder master: Hitachi: add GAD volume support https://review.opendev.org/c/openstack/cinder/+/796170 | 06:11 |
---|---|---|
akawai | cores: Hi, would you mind rechecking to re-run workflow for https://review.opendev.org/c/openstack/cinder/+/796170 ? I've fixed rebase and the patch is ready. | 09:55 |
akawai | whoami-rajat: Hi, could you send how to request FFE? by you told me last Friday: >whoami -rajt: "then you will need to request a feature freeze exception on monday, I will send an email on monday describing the details | 09:58 |
*** akawai_ is now known as akawai | 11:02 | |
akawai | whoami-rajat: Thank you for sending the mail for FFE. Should I request FFE for https://review.opendev.org/c/openstack/cinder/+/850831? although you described the patch is targeted. | 11:05 |
whoami-rajat | akawai, yes, please. those were targeted for antelope but missed the deadline so you will need to request FFE | 11:06 |
akawai | whoami-rajat: I see. I'll request that. | 11:07 |
*** dviroel_ is now known as dviroel | 12:15 | |
akawai | To cores: Hi, please re-run the workflow for https://review.opendev.org/c/openstack/cinder/+/796170, whose status is `approved` in https://etherpad.opendev.org/p/cinder-antelope-features but terminated the workflow by merge conflict. | 12:38 |
akawai | The conflict has been fixed, Zuul for re-uploading has passed and our CI for new patchset has successed. | 12:40 |
*** geguileor is now known as geguileo | 12:44 | |
opendevreview | Sofia Enriquez proposed openstack/cinder-tempest-plugin master: Add Backup Restore Multibackend Tests https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/835512 | 13:10 |
opendevreview | Sofia Enriquez proposed openstack/cinder master: DNM: Add CI Job For lvm+ceph With c-bak Enabled https://review.opendev.org/c/openstack/cinder/+/784815 | 13:15 |
akawai | Cores: Thank you for re-running workflow! | 13:18 |
akawai | whoami-rajat: I sent the mail for adding FFE to Openstack-ML. Could you get it? If no, I'll send it again. | 14:04 |
whoami-rajat | akawai, I've received it and granted FFE, please continue to work on it and resolve the comments within this week | 14:50 |
akawai | whoami-rajat: I see. Thanks. | 14:52 |
whoami-rajat | no problem | 14:52 |
opendevreview | Sofia Enriquez proposed openstack/cinder master: RBD: Fix Restore Full Backups https://review.opendev.org/c/openstack/cinder/+/750782 | 14:55 |
opendevreview | Merged openstack/cinder master: Hitachi: add GAD volume support https://review.opendev.org/c/openstack/cinder/+/796170 | 14:57 |
ganso | whoami-rajat, rosmaita: Hi! I addressed the commit message change you requested, could you please take another look? https://review.opendev.org/c/openstack/cinder/+/873145 | 15:00 |
whoami-rajat | ganso, my comment is addressed but not sure about rosmaita , I think his idea was to move the conflict section below the (cherry picked from ...) line | 15:02 |
whoami-rajat | but i will let him comment | 15:02 |
rosmaita | whoami-rajat: i wasn't sure if i was being too picky, what do you think? | 15:04 |
whoami-rajat | rosmaita, well, the file name and description of the conflict are pretty clear | 15:05 |
whoami-rajat | ganso, till which branch are you planning to backport it? | 15:06 |
rosmaita | except the conflict happened with the 2nd cherry-pick, not the first (i think) | 15:08 |
ganso | whoami-rajat: hmmm let me double check, just a min | 15:08 |
ganso | whoami-rajat: Xena | 15:09 |
whoami-rajat | rosmaita, yes correct, it's from Zed->yoga and not Antelope->Zed | 15:10 |
whoami-rajat | ganso, ack | 15:10 |
whoami-rajat | ganso, can you quickly update the commit with rosmaita's suggestions and we will provide the votes on it? | 15:12 |
ganso | whoami-rajat: yea, I missed the intention that the positioning of the conflict was the most important thing | 15:13 |
ganso | rosmaita: just to be sure, should the conflict note be at the bottom, or between the 2 cherry-pick lines ? | 15:13 |
rosmaita | ganso: after the cherry-pick that produced the conflict (which i think is the 2nd, so that would be at the bottom) | 15:18 |
ganso | rosmaita: thanks! | 15:19 |
opendevreview | Rodrigo Barbieri proposed openstack/cinder stable/yoga: Filter reserved image properties https://review.opendev.org/c/openstack/cinder/+/874428 | 15:19 |
opendevreview | Atsushi Kawai proposed openstack/cinder master: Hitachi: support data deduplication and compression https://review.opendev.org/c/openstack/cinder/+/850831 | 15:22 |
ganso | rosmaita: I just noticed it changed the Change-Id ^ | 15:33 |
ganso | :\ | 15:33 |
ganso | the commit message on the new patch has 2 change-IDs... | 15:33 |
ganso | apparently gerrit needs the change-id to be in the last paragraph | 15:33 |
opendevreview | Rodrigo Barbieri proposed openstack/cinder stable/yoga: Filter reserved image properties https://review.opendev.org/c/openstack/cinder/+/873145 | 15:34 |
opendevreview | Rodrigo Barbieri proposed openstack/cinder stable/yoga: Filter reserved image properties https://review.opendev.org/c/openstack/cinder/+/873145 | 15:35 |
rosmaita | that looks ok now, i guess just abandon 874428 | 15:36 |
opendevreview | Rodrigo Barbieri proposed openstack/cinder stable/yoga: Filter reserved image properties https://review.opendev.org/c/openstack/cinder/+/873145 | 15:37 |
opendevreview | Rajat Dhasmana proposed openstack/python-cinderclient stable/yoga: [stable-only] Make python-cinderclient-functional-py39 non-voting https://review.opendev.org/c/openstack/python-cinderclient/+/874448 | 17:31 |
opendevreview | Rajat Dhasmana proposed openstack/python-cinderclient stable/yoga: [stable-only] Make python-cinderclient-functional-py39 non-voting https://review.opendev.org/c/openstack/python-cinderclient/+/874448 | 17:36 |
whoami-rajat | rosmaita, hey, can you take a look at this (when gate passes), it's unblocking cinderclient yoga gate https://review.opendev.org/c/openstack/python-cinderclient/+/874448 | 17:38 |
*** gmann is now known as gmann_afk | 18:37 | |
*** gmann_afk is now known as gmann | 18:51 | |
opendevreview | Brian Rosmaita proposed openstack/python-cinderclient stable/yoga: DNM: try functional-py39 job on focal https://review.opendev.org/c/openstack/python-cinderclient/+/874513 | 19:32 |
opendevreview | Brian Rosmaita proposed openstack/python-cinderclient stable/yoga: DNM: try functional-py39 job on focal https://review.opendev.org/c/openstack/python-cinderclient/+/874513 | 21:25 |
opendevreview | Brian Rosmaita proposed openstack/python-cinderclient stable/yoga: DNM: try functional-py39 job on focal https://review.opendev.org/c/openstack/python-cinderclient/+/874513 | 21:37 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!