| opendevreview | Toheeb Oyekola proposed openstack/cinder-tempest-plugin master: updated docstring for test_boot_cloned_encryted_volume function https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/876905 | 00:33 |
|---|---|---|
| *** chuanm1 is now known as chuanm | 00:34 | |
| opendevreview | Hao Wang proposed openstack/cinder master: Support multiple filters together for volume time comparison filter https://review.opendev.org/c/openstack/cinder/+/740146 | 01:24 |
| opendevreview | Hao Wang proposed openstack/cinder master: Support to query snapshot filter by updated_at/created_at https://review.opendev.org/c/openstack/cinder/+/733062 | 01:47 |
| opendevreview | OpenStack Proposal Bot proposed openstack/cinder master: Imported Translations from Zanata https://review.opendev.org/c/openstack/cinder/+/876907 | 02:20 |
| TusharTgite | whoami-rajat: got review from gorka take a look https://review.opendev.org/c/openstack/cinder/+/820994 | 02:54 |
| *** chuanm2 is now known as chuanm | 04:19 | |
| opendevreview | Masayuki Igawa proposed openstack/cinder stable/yoga: Add a check for virtual_size at API layer https://review.opendev.org/c/openstack/cinder/+/876913 | 05:11 |
| whoami-rajat | rosmaita, done | 07:59 |
| whoami-rajat | TusharTgite, done | 07:59 |
| opendevreview | Merged openstack/cinder master: Configure a storage node in cinder https://review.opendev.org/c/openstack/cinder/+/820994 | 08:14 |
| *** chuanm5 is now known as chuanm | 09:13 | |
| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: Deleting a volume in 'downloading' state https://review.opendev.org/c/openstack/cinder/+/826607 | 10:22 |
| *** chuanm5 is now known as chuanm | 10:35 | |
| *** chuanm2 is now known as chuanm | 11:02 | |
| *** chuanm6 is now known as chuanm | 12:03 | |
| opendevreview | Mounika Sreeram proposed openstack/cinder master: [SVf] Adding support of clone operation for volumegroup https://review.opendev.org/c/openstack/cinder/+/871257 | 12:38 |
| rosmaita | whoami-rajat: can you hit https://review.opendev.org/c/openstack/cinder/+/871631 ... finally a +1 from zuul, let's merge it before the train gate breaks again | 13:21 |
| rosmaita | any stable core, actually: e0ne eharney enriquetaso geguileo hemna jungleboyj ^^ | 14:20 |
| *** sfinucan is now known as stephenfin | 14:44 | |
| opendevreview | Eric Harney proposed openstack/cinder master: RemoteFS: Fix messy string formatting https://review.opendev.org/c/openstack/cinder/+/876987 | 15:19 |
| whoami-rajat | rosmaita, done | 15:21 |
| rosmaita | thanks! | 15:21 |
| opendevreview | Eric Harney proposed openstack/cinder-tempest-plugin master: Add volume dependency test coverage https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/854287 | 15:30 |
| opendevreview | Walt proposed openstack/cinder master: Ensure driver is initialized before attach https://review.opendev.org/c/openstack/cinder/+/794001 | 15:34 |
| happystacker | good morning guys. Quick question: When I write a new driver, what's making the connection between the function within the driver and the action of cinder itself? | 15:37 |
| happystacker | for example I write a new driver for a new storage platform | 15:37 |
| happystacker | and I'm writing the function which creates a volume | 15:38 |
| happystacker | how is it connected to the openstack volume create command? | 15:38 |
| eharney | happystacker: are you wondering about the whole picture? there are a lot of layers of code between the openstack cli command and the volume driver | 15:47 |
| happystacker | I have to admit this quite a puzzle to me as of now | 15:47 |
| happystacker | but yes having a whole picture document would make me understand better | 15:50 |
| happystacker | if it exists | 15:50 |
| eharney | well, the client talks to the cinder API service (http), which talks to the cinder scheduler via rpc, which talks to the volume service via rpc, the volume manager in the volume service calls into the driver code's create_volume method | 15:50 |
| eharney | i'm sure it exists somewhere, but i'm not sure where... | 15:51 |
| happystacker | but how does the volume manager knows that it has to call the create_volume in the driver when the user creates a volume? | 15:52 |
| eharney | happystacker: not sure what your question means exactly, the volume service is designed to always do that for a create_volume request | 16:05 |
| happystacker | well, let's say I have a function called create_new_vol or something in my driver | 16:06 |
| happystacker | When I run an openstack volume create command | 16:07 |
| happystacker | how does that command know that he has to call the create_new_vol function inside my driver | 16:07 |
| happystacker | not sure if I'm clear ;-) | 16:07 |
| eharney | it only calls a method named "create_volume" in the driver: https://opendev.org/openstack/cinder/src/commit/3e5ba7a6119a420c04741b60d79f910f2449ab13/cinder/volume/flows/manager/create_volume.py#L1189 | 16:09 |
| eharney | the API for Cinder drivers says the method must be named that | 16:09 |
| happystacker | oh ok I see | 16:11 |
| happystacker | this is a naming convention | 16:11 |
| happystacker | then from this function, I can call others in my driver if required | 16:11 |
| eharney | whoami-rajat: rosmaita: shouldn't the setup.cfg metadata in antelope os-brick state that we support python 3.10? | 16:13 |
| eharney | right | 16:13 |
| opendevreview | Eric Harney proposed openstack/os-brick master: Set packages in setup.cfg https://review.opendev.org/c/openstack/os-brick/+/876992 | 16:16 |
| opendevreview | Eric Harney proposed openstack/cinder master: Set packages in setup.cfg https://review.opendev.org/c/openstack/cinder/+/875939 | 16:17 |
| whoami-rajat | eharney, yes correct, we do run py310 job in gate as part of antelope template | 16:19 |
| opendevreview | Eric Harney proposed openstack/os-brick master: Add Python 3.10 to setup.cfg metadata https://review.opendev.org/c/openstack/os-brick/+/876282 | 16:22 |
| eharney | whoami-rajat: yeah we should get ^ in | 16:22 |
| opendevreview | Eric Harney proposed openstack/cinder master: Add Python 3.10 to setup.cfg metadata' https://review.opendev.org/c/openstack/cinder/+/876993 | 16:25 |
| opendevreview | Eric Harney proposed openstack/cinder master: Add Python 3.10 to setup.cfg metadata https://review.opendev.org/c/openstack/cinder/+/876993 | 16:25 |
| opendevreview | Eric Harney proposed openstack/python-cinderclient master: Add Python 3.10 to setup.cfg metadata https://review.opendev.org/c/openstack/python-cinderclient/+/876994 | 16:31 |
| opendevreview | Brian Rosmaita proposed openstack/cinder master: doc: update setup.cfg file https://review.opendev.org/c/openstack/cinder/+/876996 | 16:35 |
| whoami-rajat | eharney, left one question on the patch | 16:36 |
| rosmaita | whoami-rajat: eharney: 3.9 is a supported version, we're just not required to test it in CI | 16:38 |
| eharney | right | 16:38 |
| whoami-rajat | ack | 16:38 |
| whoami-rajat | i missed the part Other than the above Python versions, Debian 11 has Python 3.9 as default which we are not suggesting to run unit tests. We assume that anything that works on Python 3.8 and 3.10 will also work on 3.9. | 16:39 |
| rosmaita | yeah, that doc is not as clear as it could be | 16:39 |
| whoami-rajat | yep, thanks for pointing it out | 16:43 |
| whoami-rajat | eharney, do we also want this change in cinder-tempest-plugin and python-brick-cinderclient-ext? | 16:44 |
| rosmaita | and possibly rbd-iscsi-client | 16:49 |
| Toheeb | I pushed a docstring update change to cinder-tempest-plugin, but zuul unit test failed, what step can I take to rectify that? | 17:18 |
| -opendevstatus- NOTICE: Yesterday's change to Gerrit configs to use submit-requirements had a boolean logic bug. This has now been corrected and any changes that did not merge as a result can be rechecked. We have reenqueued the changes we identified as being affected. | 17:23 | |
| opendevreview | Eric Harney proposed openstack/cinder-tempest-plugin master: Add test for 512-bit encryption keys https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/877030 | 17:42 |
| *** User__ is now known as Toheeb | 18:29 | |
| opendevreview | Tony Saad proposed openstack/os-brick master: Dell PowerFlex: Unnecessary login happen https://review.opendev.org/c/openstack/os-brick/+/876284 | 18:39 |
| opendevreview | Merged openstack/cinder master: Add Python 3.10 to setup.cfg metadata https://review.opendev.org/c/openstack/cinder/+/876993 | 18:41 |
| opendevreview | Merged openstack/cinder master: doc: update setup.cfg file https://review.opendev.org/c/openstack/cinder/+/876996 | 18:41 |
| opendevreview | Merged openstack/cinder master: Update master for stable/2023.1 https://review.opendev.org/c/openstack/cinder/+/876859 | 18:41 |
| opendevreview | Eric Harney proposed openstack/cinder-tempest-plugin master: Add Python 3.10 to setup.cfg metadata https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/877034 | 19:17 |
| opendevreview | Eric Harney proposed openstack/cinder-tempest-plugin master: Increase cinder volume quota for cbak job https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/877035 | 19:17 |
| opendevreview | Merged openstack/python-cinderclient master: Add Python 3.10 to setup.cfg metadata https://review.opendev.org/c/openstack/python-cinderclient/+/876994 | 19:35 |
| *** thelounge553 is now known as thelounge55 | 20:41 | |
| opendevreview | Eric Harney proposed openstack/cinder master: Bump pylint to 2.17.0 https://review.opendev.org/c/openstack/cinder/+/877043 | 20:57 |
| *** User__ is now known as toheeb | 20:58 | |
| *** toheeb is now known as Toheeb | 20:59 | |
| opendevreview | Eric Harney proposed openstack/os-brick master: import pylint tooling from cinder https://review.opendev.org/c/openstack/os-brick/+/853777 | 21:01 |
| *** User__ is now known as Toheeb | 22:49 | |
| opendevreview | Merged openstack/os-brick master: Add Python 3.10 to setup.cfg metadata https://review.opendev.org/c/openstack/os-brick/+/876282 | 23:07 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!