| opendevreview | Atsushi Kawai proposed openstack/cinder master: Hitachi: Fix to use correct pool number for secondary storage on GAD https://review.opendev.org/c/openstack/cinder/+/877672 | 06:08 |
|---|---|---|
| opendevreview | Raghavendra Tilay proposed openstack/cinder master: WIP - HPE 3PAR: Add HPE Arcus related information https://review.opendev.org/c/openstack/cinder/+/876279 | 07:03 |
| *** thelounge553 is now known as thelounge55 | 08:04 | |
| whoami-rajat | rosmaita, hey, what do you think about my comment here? https://review.opendev.org/c/openstack/cinder/+/877070 | 10:38 |
| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: [WIP] Update API returns https://review.opendev.org/c/openstack/cinder/+/856041 | 11:27 |
| opendevreview | OpenStack Release Bot proposed openstack/cinderlib stable/ussuri: Update .gitreview for stable/ussuri https://review.opendev.org/c/openstack/cinderlib/+/877783 | 12:14 |
| opendevreview | OpenStack Release Bot proposed openstack/cinderlib stable/ussuri: Update TOX_CONSTRAINTS_FILE for stable/ussuri https://review.opendev.org/c/openstack/cinderlib/+/877784 | 12:14 |
| opendevreview | OpenStack Release Bot proposed openstack/cinderlib master: Update master for stable/ussuri https://review.opendev.org/c/openstack/cinderlib/+/877785 | 12:14 |
| rosmaita | whoami-rajat: left a reply for you on https://review.opendev.org/c/openstack/cinder/+/877070 | 12:31 |
| opendevreview | Tushar Trambak Gite proposed openstack/python-brick-cinderclient-ext master: Add Python 3.10 to setup.cfg metadata https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/877789 | 13:12 |
| opendevreview | Eric Harney proposed openstack/cinder-tempest-plugin master: Add FIPS job for barbican case https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/847086 | 13:36 |
| whoami-rajat | rosmaita, you're right, i missed the queens-em and queens-eol tags, +Wed the patch | 13:53 |
| rosmaita | np, it was good to check | 13:54 |
| whoami-rajat | festival of XS reviews at https://bluejeans.com/556681290 | 14:00 |
| whoami-rajat | jungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard sfernand enriquetaso hemna fabiooliveira happystacker sfv880 | 14:00 |
| whoami-rajat | etherpad: https://etherpad.opendev.org/p/cinder-festival-of-reviews | 14:01 |
| opendevreview | Eric Harney proposed openstack/cinder master: Add fips check jobs https://review.opendev.org/c/openstack/cinder/+/790535 | 14:13 |
| opendevreview | Rajat Dhasmana proposed openstack/cinder stable/2023.1: Remove multiatttach request parameter https://review.opendev.org/c/openstack/cinder/+/877755 | 14:14 |
| *** User_ is now known as Toheeb19 | 14:18 | |
| opendevreview | Jon Bernard proposed openstack/cinder stable/2023.1: Restore into sparse volumes https://review.opendev.org/c/openstack/cinder/+/877799 | 14:24 |
| jbernard | whoami-rajat, rosmaita: ^ backport for pete's patch just so we have it up | 14:25 |
| opendevreview | Merged openstack/cinder stable/2023.1: Add Python 3.10 to setup.cfg metadata https://review.opendev.org/c/openstack/cinder/+/877504 | 14:41 |
| opendevreview | Pete Zaitcev proposed openstack/cinder master: Make PowerMax tests stable https://review.opendev.org/c/openstack/cinder/+/877717 | 15:16 |
| opendevreview | Tushar Trambak Gite proposed openstack/cinderlib master: update minversion in tox. https://review.opendev.org/c/openstack/cinderlib/+/877809 | 15:36 |
| opendevreview | Tushar Trambak Gite proposed openstack/python-cinderclient master: update minversion in tox. https://review.opendev.org/c/openstack/python-cinderclient/+/877811 | 15:38 |
| whoami-rajat | Stopping with the reviews now, thanks for attending/doing reviews in the festival of XS reivews, have a great weekend! | 15:51 |
| opendevreview | Merged openstack/python-brick-cinderclient-ext master: Add Python 3.10 to setup.cfg metadata https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/877789 | 16:27 |
| gmann | whoami-rajat: tempest change is merged now, i will pass now https://review.opendev.org/c/openstack/cinder/+/874865 | 16:31 |
| gmann | whoami-rajat: I have not recheck on that you might be best person to do as per cinder plan | 16:31 |
| gmann | whoami-rajat: I if you are planning to merge the cinder change in 2023.1 then I will also do the tempest new release for 2023.1 which will include those test change | 16:32 |
| whoami-rajat | gmann, sounds good, yes we will release the multiattach change in 2023.1 | 16:34 |
| gmann | whoami-rajat: perfect. starting the tempest release process | 16:34 |
| whoami-rajat | gmann, great, thanks! | 16:34 |
| gmann | whoami-rajat: thanks for all you hard work and putting things at the end especially test change requirement of doing devstack changes etc | 16:34 |
| whoami-rajat | gmann, np, thanks for all the help throughout, good to know that we could do the changes right way even during final days of release | 16:36 |
| gmann | +1 | 16:37 |
| opendevreview | Rajat Dhasmana proposed openstack/cinder master: Fix: PowerMax test with flipping force flag https://review.opendev.org/c/openstack/cinder/+/877826 | 16:46 |
| whoami-rajat | rosmaita, ^ another issue faced with powermax tests, the whole unit tests seems to be using the global values which might fail randomly depending on the execution, since i didn't want to refactor the whole UT code, just fixed the current issue ^ | 16:47 |
| opendevreview | Merged openstack/cinder master: Hitachi HBSD: Fix invalid "raise None" https://review.opendev.org/c/openstack/cinder/+/875977 | 17:59 |
| opendevreview | Merged openstack/cinder master: Bump pylint to 2.17.0 https://review.opendev.org/c/openstack/cinder/+/877043 | 18:00 |
| opendevreview | Rajat Dhasmana proposed openstack/cinder master: Fix: PowerMax test with flipping force flag https://review.opendev.org/c/openstack/cinder/+/877826 | 19:34 |
| whoami-rajat | rosmaita, hey, can you hit this again? looks like the extra specs were modified before we did a deepcopy so using this local reference should avoid any failure now https://review.opendev.org/c/openstack/cinder/+/877826 | 20:20 |
| rosmaita | whoami-rajat: ack | 20:23 |
| rosmaita | whoami-rajat: you know, looking at the code Pete changed, that conditional that did the del should have been a giveaway ... how could the flag have got into extra_specs unless another test was monkeying with the data? I bet Helen put it there because she ran into problems when working on those tests | 20:26 |
| whoami-rajat | rosmaita, yes correct, we need to correct those places which are modifying the global dict but that is an issue I would like to address after RC2 ... you can see how many UT files powermax has https://github.com/openstack/cinder/tree/master/cinder/tests/unit/volume/drivers/dell_emc/powermax | 20:31 |
| rosmaita | oh, i agree, i'm just making an observation | 20:32 |
| whoami-rajat | yep, i also realized after the gate failed again on my change, but thanks for pointing it out | 20:32 |
| opendevreview | Eric Harney proposed openstack/cinder master: Set packages in setup.cfg https://review.opendev.org/c/openstack/cinder/+/875939 | 21:02 |
| rosmaita | I'm starting to think that we need to revert https://review.opendev.org/#/q/I990b3e5d8505 and get the test problem sorted out offline | 21:59 |
| rosmaita | Eric's patch hit a failure again, even after a rebase | 22:03 |
| rosmaita | though now that i look more closely, https://review.opendev.org/c/openstack/cinder/+/877717 and https://review.opendev.org/c/openstack/cinder/+/877826 haven't merged yet | 22:03 |
| rosmaita | i guess let's see what happens after those merge | 22:04 |
| opendevreview | Merged openstack/cinder master: Remove multiatttach request parameter https://review.opendev.org/c/openstack/cinder/+/874865 | 22:35 |
| rosmaita | \o/ | 22:36 |
| rosmaita | at least https://review.opendev.org/#/q/I990b3e5d8505 isn't in 2023.1 | 22:37 |
| whoami-rajat | ^ that's a relief | 22:38 |
| whoami-rajat | we would still need to get this in https://review.opendev.org/c/openstack/cinder/+/877755 | 22:38 |
| rosmaita | whoami-rajat: is it ok if i ninja in the backport of the requst parameters patch? | 22:38 |
| rosmaita | not sure anyone else is around right now | 22:39 |
| whoami-rajat | i think it would make sense given our situation, but if jungleboyj eharney geguileo is around ? ^ | 22:39 |
| rosmaita | tell you what, i'll wait a half hour, and if no one has commented on it by 23:10 utc, i will ninja it | 22:40 |
| whoami-rajat | looks like you're correct and no one is around so whenever you feel like, you can +W it | 22:42 |
| rosmaita | got it | 23:10 |
| opendevreview | Merged openstack/cinder master: Make PowerMax tests stable https://review.opendev.org/c/openstack/cinder/+/877717 | 23:31 |
| opendevreview | Merged openstack/cinder master: Fix: PowerMax test with flipping force flag https://review.opendev.org/c/openstack/cinder/+/877826 | 23:32 |
| opendevreview | Pete Zaitcev proposed openstack/cinder master: Restore into sparse volumes https://review.opendev.org/c/openstack/cinder/+/852654 | 23:46 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!