opendevreview | Evelina Shames proposed openstack/cinder-tempest-plugin master: [srbac] Test srbac on snapshots https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/872986 | 09:41 |
---|---|---|
opendevreview | Poojan Shah proposed openstack/cinder master: [SVf] Adding support of extend operation for volumegroup https://review.opendev.org/c/openstack/cinder/+/880518 | 10:04 |
raghavendrat | hi whoami-rajat: are you around ? | 11:47 |
raghavendrat | whoami-rajat: if you get free time, could you please have a look at below patch. The review comments have been addressed. | 12:24 |
raghavendrat | https://review.opendev.org/c/openstack/cinder/+/862679 | 12:25 |
opendevreview | Luiz Felipe Looze dos Santos proposed openstack/cinder master: DNM - Netapp test to add upstream-check REST jobs with file filter to trigger only in Netapp driver on Cinder https://review.opendev.org/c/openstack/cinder/+/880513 | 13:32 |
opendevreview | Luiz Felipe Looze dos Santos proposed openstack/cinder master: DNM - Netapp test to add upstream-check REST jobs with file filter to trigger only in Netapp driver on Cinder https://review.opendev.org/c/openstack/cinder/+/880513 | 13:38 |
*** dviroel__ is now known as dviroel | 13:53 | |
opendevreview | Stephen Finucane proposed openstack/cinder master: db: Don't rely on branched connections https://review.opendev.org/c/openstack/cinder/+/880657 | 15:40 |
ganso | rosmaita: hi! just checking whether you had any time to work on the glance metadata fix | 15:58 |
rosmaita | ganso: thanks for checking in, no i didn't ... maybe we should split up the work? what i want to do first is redo the cinder unit tests to use a realistic representation of a glance response | 16:01 |
rosmaita | (at least for the tests that affect the non-inheritable-properties code, then for the rest) | 16:01 |
rosmaita | you don't happen to have an image-show response available that has some of the os_glance* properties on it? | 16:01 |
ganso | rosmaita: I have a volume show | 16:02 |
ganso | rosmaita: this? https://paste.ubuntu.com/p/HBQwm5M7Qr/ | 16:04 |
rosmaita | looking | 16:04 |
ganso | rosmaita: interestingly, if you look at that volume show, it seems like the os_glance properties are at the same level, but in the comment that I added to the LP, at the moment they are being processed they are not | 16:05 |
ganso | rosmaita: they are grouped under "properties: {}" | 16:05 |
rosmaita | ganso: yeah, internally, cinder is working with the old glance v1 model, where you had some core properties and then all the metadata was in its own dict | 16:06 |
rosmaita | when glance introduced v2, they had a "flat" image model, with just image properties | 16:07 |
rosmaita | so we have some compat code somewhere that's keeping the v1 model for internal use, and that's where i think something isn't quite right | 16:07 |
opendevreview | Stephen Finucane proposed openstack/cinder master: doc: Trivial typo fix https://review.opendev.org/c/openstack/cinder/+/880670 | 16:14 |
ganso | rosmaita: so maybe just removing/adding the compat code could make the current code parse the metadata dict as it should have? | 16:19 |
ganso | rosmaita: instead of reworking the logic | 16:19 |
rosmaita | ganso: yes, something like that | 16:22 |
TusharTgite | rosmaita put some comments on patch see https://review.opendev.org/c/openstack/cinder/+/880434 | 16:40 |
TusharTgite | rosmaita: put some comments on patch see https://review.opendev.org/c/openstack/cinder/+/880434 | 16:40 |
rosmaita | TusharTgite: ack | 16:40 |
opendevreview | Merged openstack/cinder master: Make paramiko import optional https://review.opendev.org/c/openstack/cinder/+/880062 | 17:30 |
eharney_ | why do we run functional and tempest jobs for cinder on python3.8, but skip unit tests for 3.8? | 17:46 |
eharney_ | shouldn't we also run the unit tests if we have to pass on that version of python anyway? | 17:46 |
opendevreview | Eric Harney proposed openstack/cinder master: mypy: Cover message code https://review.opendev.org/c/openstack/cinder/+/877967 | 17:53 |
opendevreview | Eric Harney proposed openstack/cinder master: Run py311 unit tests (non-voting) https://review.opendev.org/c/openstack/cinder/+/869258 | 18:24 |
opendevreview | Eric Harney proposed openstack/cinder master: Remove "from __future__ import annotations" https://review.opendev.org/c/openstack/cinder/+/880679 | 19:07 |
opendevreview | Merged openstack/cinder stable/xena: Fix Infinidat driver to return all iSCSI portals https://review.opendev.org/c/openstack/cinder/+/868178 | 19:53 |
opendevreview | Merged openstack/cinder stable/xena: mypy: Allow mypy to pass with requests-packaged urllib3 https://review.opendev.org/c/openstack/cinder/+/871179 | 19:53 |
opendevreview | Merged openstack/os-brick stable/2023.1: Add Python 3.10 to setup.cfg metadata https://review.opendev.org/c/openstack/os-brick/+/877505 | 20:48 |
opendevreview | Merged openstack/os-brick master: LVM: Fix supports_full_pool_create https://review.opendev.org/c/openstack/os-brick/+/877929 | 20:48 |
opendevreview | Merged openstack/os-brick master: Bump mypy to 1.1.1 https://review.opendev.org/c/openstack/os-brick/+/878090 | 20:48 |
opendevreview | Merged openstack/cinder master: test_rbd_iscsi: Make tests compatible with python 3.11 https://review.opendev.org/c/openstack/cinder/+/869396 | 20:58 |
opendevreview | Brian Rosmaita proposed openstack/cinder master: Update functional jobs for 2023.2 https://review.opendev.org/c/openstack/cinder/+/880684 | 21:35 |
opendevreview | Brian Rosmaita proposed openstack/python-cinderclient master: Use tox 4 https://review.opendev.org/c/openstack/python-cinderclient/+/868317 | 22:28 |
opendevreview | Brian Rosmaita proposed openstack/python-cinderclient master: DNM: check functional jobs https://review.opendev.org/c/openstack/python-cinderclient/+/869226 | 22:44 |
opendevreview | Brian Rosmaita proposed openstack/python-cinderclient master: Update functional jobs for 2023.2 https://review.opendev.org/c/openstack/python-cinderclient/+/880689 | 22:59 |
opendevreview | Brian Rosmaita proposed openstack/python-cinderclient master: DNM: check functional jobs https://review.opendev.org/c/openstack/python-cinderclient/+/869226 | 23:04 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!