| opendevreview | Goutham Pacha Ravi proposed openstack/devstack-plugin-ceph master: [WIP] Disable msgrv2 compatibility https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/881767 | 00:09 |
|---|---|---|
| opendevreview | Goutham Pacha Ravi proposed openstack/devstack-plugin-ceph master: [WIP] Disable msgrv2 compatibility https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/881767 | 00:10 |
| opendevreview | Goutham Pacha Ravi proposed openstack/devstack-plugin-ceph master: [WIP] Disable msgrv2 compatibility https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/881767 | 00:28 |
| opendevreview | 江治林 proposed openstack/cinder master: backup restore delete multipath of vm used https://review.opendev.org/c/openstack/cinder/+/881791 | 02:50 |
| opendevreview | 江治林 proposed openstack/cinder master: backup restore delete multipath of vm used https://review.opendev.org/c/openstack/cinder/+/881791 | 02:59 |
| opendevreview | Goutham Pacha Ravi proposed openstack/devstack-plugin-ceph master: [WIP] Disable msgrv2 compatibility https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/881767 | 03:11 |
| opendevreview | Tushar Trambak Gite proposed openstack/cinder master: update volume manager for backup fail https://review.opendev.org/c/openstack/cinder/+/880275 | 08:27 |
| Manish | hello team, need one help on my query. We have one customer on openstack stable stein release and not ready to upgrade the environment. We have fixed one issue in our cinder driver for that customer, very much related to case sensitive use of wwn in our driver. https://bugs.launchpad.net/cinder/+bug/2016840. How can we provide this fix to customer. | 10:42 |
| jbernard | manish: stein upstream is eol, so i think any fixes you provide will have to come from your downstream as we're not merging patches to stein anymore. | 12:01 |
| manish | @jbernard, thanks so you mean to say we need to ask customers to upgrade and we provide fix in latest master branch? | 12:55 |
| senrique | Hello, if you have time, feel free to review my ceph path https://review.opendev.org/c/openstack/cinder/+/880965 | 13:08 |
| *** dviroel_ is now known as dviroel | 14:30 | |
| ganso | rosmaita: hi! I have a very important question to ask you | 15:41 |
| rosmaita | sure | 15:41 |
| ganso | rosmaita: I found a workaround for that glance image properties bug, I detailed it in https://bugs.launchpad.net/cinder/+bug/1945500 | 15:42 |
| ganso | rosmaita: basically by tweaking the glance_core_properties config I can get the failed fix working | 15:42 |
| ganso | rosmaita: however, I am concerned about other impact of tweaking this option. The method _merge_volume_image_meta is invoked in other areas and it will change how the other areas see the resulting dictionary | 15:43 |
| ganso | rosmaita: do you know the other impact of the config tweaking ? | 15:43 |
| rosmaita | thinking | 15:45 |
| ganso | _merge_volume_image_meta is invoked only in copy_volume_to_image but this method in invoked in many places, including third-party drivers | 15:50 |
| rosmaita | still thinking ... | 15:58 |
| rosmaita | my gut feeling is that what you're proposing could be unsafe ... i wonder whether the thing to do is to change filter_out_reserved_namespaces_metadata() like this | 16:01 |
| rosmaita | https://opendev.org/openstack/cinder/src/branch/master/cinder/image/image_utils.py#L1302 | 16:01 |
| rosmaita | change line 1302 to see if metadata contains a 'properties' key | 16:02 |
| rosmaita | and then at line 1307, iterate over metadata['properties'].items() | 16:03 |
| rosmaita | something like that | 16:03 |
| ganso | rosmaita: yea I agree that is certainly the ideal solution. I will work on that. Meanwhile, I am considering the config tweaking as a potential interim workaround for the customer, but as you said, it could be unsafe | 16:05 |
| ganso | rosmaita: the customer has been waiting a very long time, and it is still a long way to go considering all the backports of the new fix | 16:05 |
| rosmaita | i understand | 16:06 |
| rosmaita | i think your proposal will probably be OK ... iirc, the core_properties config was to filter out the stuff that's read-only in glance | 16:06 |
| rosmaita | those os_whatever properties are so new that i can't imagine anyone is trying to consume them intentionally | 16:07 |
| rosmaita | (in cinder, i mean) | 16:07 |
| rosmaita | and we don't want to write them back to glance, so i think you're probably ok | 16:08 |
| ganso | rosmaita: thank you so much for the analysis! =) | 16:08 |
| rosmaita | good luck! | 16:08 |
| opendevreview | Merged openstack/cinderlib master: Continue 2023.1 (Antelope) development https://review.opendev.org/c/openstack/cinderlib/+/878943 | 16:31 |
| *** JayF is now known as Guest12444 | 18:27 | |
| *** JasonF is now known as JayF | 18:27 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!