kkula | Hello! In RDO we start to have failing tempest tests in puppet-openstack-integration jobs. It starts to happening after https://review.opendev.org/c/openstack/cinder/+/882835 change, logs (for zed) are available here https://logserver.rdoproject.org/openstack-periodic-integration-stable4/review.rdoproject.org/rdoinfo/master/weirdo-zed-promote-puppet-scenario002-centos-stream-9/a251542/logs/weirdo-project/logs/testr_results.html | 08:20 |
---|---|---|
kkula | . may you take a look? @amoralej @geguileo | 08:20 |
amoralej | a bunch of "cinder.api.middleware.fault cinder.exception.ConflictNovaUsingAttachment: Detach volume from instance 20770cae-df07-47ac-a75e-e32f2aba1e8a using the Compute API" in https://logserver.rdoproject.org/openstack-periodic-integration-stable4/review.rdoproject.org/rdoinfo/master/weirdo-zed-promote-puppet-scenario002-centos-stream-9/a251542/logs/weirdo-project/logs/cinder/cinder-api.txt.gz | 08:24 |
opendevreview | Gorka Eguileor proposed openstack/cinder master: Doc: Improve service token https://review.opendev.org/c/openstack/cinder/+/883360 | 08:28 |
amoralej | and there are iscsiadm related errors in https://logserver.rdoproject.org/openstack-periodic-integration-stable4/review.rdoproject.org/rdoinfo/master/weirdo-zed-promote-puppet-scenario002-centos-stream-9/a251542/logs/weirdo-project/logs/nova/nova-compute.txt.gz too | 08:30 |
geguileo | kkula: does RDO CI configure nova's service token? | 08:31 |
geguileo | kkula: ok, I just checked and the answer is no, and that's the problem :-( | 08:33 |
geguileo | kkula: amoralej what is the deployment tool used in those jobs? | 08:33 |
amoralej | puppet-openstack-integration | 08:34 |
amoralej | puppet-cinder | 08:34 |
amoralej | puppet-nova | 08:34 |
geguileo | :''''-( | 08:38 |
geguileo | Why did it had to be puppet! | 08:38 |
amoralej | :D | 08:39 |
amoralej | is it https://docs.openstack.org/cinder/latest/configuration/block-storage/service-token.html#configuration ? | 08:39 |
geguileo | amoralej: yes, and there is a patch updating it to make it even easier to follow | 08:41 |
geguileo | amoralej: https://review.opendev.org/c/openstack/cinder/+/883360/2/doc/source/configuration/block-storage/service-token.rst | 08:41 |
amoralej | apparently it's in puppet-cinder https://github.com/openstack/puppet-cinder/commit/c978ba07e77bb347fe88e9219438a117a9d3d1b6 | 08:41 |
amoralej | probably we are just missing it in p-o-i | 08:41 |
kkula | here are the logs from last successful build https://logserver.rdoproject.org/openstack-periodic-integration-stable4/review.rdoproject.org/rdoinfo/master/weirdo-zed-promote-puppet-scenario002-centos-stream-9/b4daf2d/ | 08:42 |
geguileo | amoralej: it also needs code in nova (it's the important part) | 08:42 |
amoralej | you mean specific config in nova, right? | 08:42 |
geguileo | oh, and there is code for the service_user in nova!! | 08:42 |
geguileo | https://github.com/openstack/puppet-nova/blob/51829b985f6791883e5591890b998a0c344b9b9a/manifests/keystone/service_user.pp | 08:43 |
geguileo | I think I can fix it fix a single patch | 08:43 |
amoralej | will you send it? | 08:44 |
amoralej | to p-o-i? i think we have ways to test p-o-i in-flight patches from rdo | 08:44 |
geguileo | amoralej: yes, I'll send it | 08:49 |
amoralej | kkula ^ | 08:49 |
amoralej | thanks! geguileo++ kkula++ | 08:50 |
kkula | thank you! | 08:51 |
opendevreview | Vladislav Belogrudov proposed openstack/cinder master: Yadro Tatlin Unified FC driver https://review.opendev.org/c/openstack/cinder/+/876743 | 08:52 |
geguileo | amoralej: kkula mmmm, the patch I was going to submit is most likely not going to be accepted, because they are going to want to change how to do it :-( | 09:02 |
amoralej | wdym ? | 09:02 |
amoralej | isn't your patch simply adding existing classes in puppet-nova and puppet-cinder into p-o-i existing manifests? | 09:03 |
amoralej | something like in https://review.opendev.org/c/openstack/puppet-tripleo/+/670424 | 09:05 |
amoralej | actually, checking at the topic https://review.opendev.org/q/topic:service_token it was added to tripleo but never to p-o-i :( | 09:05 |
geguileo | amoralej: there must be other changes somewhere else, because there there is a service project and the nova user has the service role as well, whereas that isn't the case in poi | 09:10 |
amoralej | so we need a new project named "service" ? | 09:13 |
geguileo | amoralej: kkula Any way to test if this fixes it? https://review.opendev.org/c/openstack/puppet-openstack-integration/+/883646 | 09:16 |
geguileo | it's hack-ish, but I think it should work | 09:17 |
amoralej | geguileo, give us a while | 09:19 |
amoralej | we'll try | 09:19 |
geguileo | amoralej:++ | 09:20 |
geguileo | thank you! | 09:20 |
amoralej | geguileo, all scenarios are passing with your patch and latest cinder commit https://review.rdoproject.org/r/c/testproject/+/48680 | 11:08 |
amoralej | https://logserver.rdoproject.org/80/48680/1/check/weirdo-bobcat-promote-puppet-scenario001-centos-stream-9/a320f44/logs/weirdo-project/logs/etc/nova/nova.conf.txt.gz | 11:09 |
amoralej | send_service_user_token=True | 11:09 |
*** amoralej is now known as amoralej|lunch | 12:34 | |
*** amoralej|lunch is now known as amoralej | 13:06 | |
whoami-rajat | reminder: Cinder Festival of Reviews today, 1400-1600 UTC | 14:00 |
whoami-rajat | join us in Google meet: https://meet.google.com/bro-gamt-fwj | 14:00 |
whoami-rajat | or go directly to the etherpad: https://etherpad.opendev.org/p/cinder-festival-of-reviews | 14:00 |
whoami-rajat | jungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard sfernand enriquetaso hemna fabiooliveira happystacker sfv880 | 14:00 |
whoami-rajat | ended the meeting since only two people were there (including me) but will be here on IRC | 14:10 |
whoami-rajat | if anyone else wants to do offline reviews then here is the dashboard https://review.opendev.org/dashboard/?title=Cinder+Festival+of+Reviews&foreach=(project:openstack/cinder+OR+project:openstack/os-brick+OR+project:openstack/python-cinderclient+OR+project:openstack/python-brick-cinderclient-ext+OR+project:openstack/cinderlib+OR+project:openstack/rbd-iscsi-client)+AND+branch:master+AND+status:open+AND+NOT+owner%3Aself+AND+is%3Amergeable+ | 14:10 |
whoami-rajat | AND+NOT+label%3AWorkflow%3C%3D-1+AND+label%3AVerified%3E%3D1+AND+NOT+reviewedby%3Aself+AND+NOT+label%3ACode-Review%3C%3D-1&XS+patches+proposed+to+master+that+are+not+mine,+have+passed+Zuul,+no+merge+conflict,+not+reviewed+by+me,+no+negative+reviews=size:%3C%3D10&Documentation+only+patches+to+master+that+are+not+mine,+have+passed+Zuul,+no+merge+conflict,+not+reviewed+by+me,+no+negative+reviews=(dir:doc+OR+dir:api-ref)+AND+-dir:cinder+AND+ | 14:10 |
whoami-rajat | -dir:os_brick+AND+-dir:cinderclient+AND+-dir:brick_cinderclient_ext+AND+-dir:cinderlib+AND+-dir:rbd_iscsi_client&Slightly%20larger%20patches+proposed+to+master+that+are+not+mine,+have+passed+Zuul,+no+merge+conflict,+not+reviewed+by+me,+no+negative+reviews=size:%3C%3D15+AND+size:%3E10 | 14:10 |
whoami-rajat | not a good idea to put the big dashboard here ... here is the tiny link http://tiny.cc/cinder-reviewfest | 14:10 |
nahimsouza[m] | hi, whoami-rajat, sorry, I was not able to enter in the meeting, but I'll try to help with some review in the list of patches | 14:14 |
whoami-rajat | nahimsouza[m], no problem, thanks for helping out with reviews, let me know if there are any doubts I will be available on IRC | 14:28 |
ganso | whoami-rajat, rosmaita: hi! if you have a minute could please review ? https://review.opendev.org/c/openstack/cinder/+/882087 | 14:31 |
whoami-rajat | ganso, ack, right now looking into XS patches but will do it after that | 14:31 |
ganso | whoami-rajat: thanks! | 14:32 |
opendevreview | Eric Harney proposed openstack/cinder-tempest-plugin master: [srbac] Testing Volume Actions https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/883182 | 15:06 |
opendevreview | Merged openstack/cinder master: Remove six from GPFS driver https://review.opendev.org/c/openstack/cinder/+/879965 | 15:50 |
opendevreview | Tony Saad proposed openstack/os-brick master: Dell PowerFlex: Unnecessary login happen https://review.opendev.org/c/openstack/os-brick/+/876284 | 16:51 |
*** amoralej is now known as amoralej|off | 16:55 | |
*** melwitt_ is now known as melwitt | 17:11 | |
opendevreview | Ashley Rodriguez proposed openstack/devstack-plugin-ceph master: [WIP][DNM] Remote Ceph with cephadm https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/876747 | 19:55 |
opendevreview | Ashley Rodriguez proposed openstack/devstack-plugin-ceph master: [WIP][DNM] Remote Ceph with cephadm https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/876747 | 20:04 |
opendevreview | Ashley Rodriguez proposed openstack/devstack-plugin-ceph master: [WIP][DNM] Remote Ceph with cephadm https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/876747 | 20:21 |
opendevreview | Damian Pietras proposed openstack/cinder master: LVM-nvmet: persist configuration after changing it https://review.opendev.org/c/openstack/cinder/+/878031 | 20:42 |
opendevreview | Ashley Rodriguez proposed openstack/devstack-plugin-ceph master: [WIP][DNM] Remote Ceph with cephadm https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/876747 | 20:42 |
opendevreview | Ashley Rodriguez proposed openstack/devstack-plugin-ceph master: [WIP][DNM] Remote Ceph with cephadm https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/876747 | 21:00 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!