Friday, 2023-05-19

kkulaHello! In RDO we start to have failing tempest tests in puppet-openstack-integration jobs. It starts to happening after https://review.opendev.org/c/openstack/cinder/+/882835 change, logs (for zed) are available here https://logserver.rdoproject.org/openstack-periodic-integration-stable4/review.rdoproject.org/rdoinfo/master/weirdo-zed-promote-puppet-scenario002-centos-stream-9/a251542/logs/weirdo-project/logs/testr_results.html08:20
kkula. may you take a look? @amoralej @geguileo08:20
amoraleja bunch of "cinder.api.middleware.fault cinder.exception.ConflictNovaUsingAttachment: Detach volume from instance 20770cae-df07-47ac-a75e-e32f2aba1e8a using the Compute API" in https://logserver.rdoproject.org/openstack-periodic-integration-stable4/review.rdoproject.org/rdoinfo/master/weirdo-zed-promote-puppet-scenario002-centos-stream-9/a251542/logs/weirdo-project/logs/cinder/cinder-api.txt.gz08:24
opendevreviewGorka Eguileor proposed openstack/cinder master: Doc: Improve service token  https://review.opendev.org/c/openstack/cinder/+/88336008:28
amoralejand there are iscsiadm related errors in https://logserver.rdoproject.org/openstack-periodic-integration-stable4/review.rdoproject.org/rdoinfo/master/weirdo-zed-promote-puppet-scenario002-centos-stream-9/a251542/logs/weirdo-project/logs/nova/nova-compute.txt.gz too08:30
geguileokkula: does RDO CI configure nova's service token?08:31
geguileokkula: ok, I just checked and the answer is no, and that's the problem  :-(08:33
geguileokkula: amoralej what is the deployment tool used in those jobs?08:33
amoralejpuppet-openstack-integration08:34
amoralejpuppet-cinder08:34
amoralejpuppet-nova08:34
geguileo:''''-(08:38
geguileoWhy did it had to be puppet!08:38
amoralej:D08:39
amoralejis it https://docs.openstack.org/cinder/latest/configuration/block-storage/service-token.html#configuration ?08:39
geguileoamoralej: yes, and there is a patch updating it to make it even easier to follow08:41
geguileoamoralej: https://review.opendev.org/c/openstack/cinder/+/883360/2/doc/source/configuration/block-storage/service-token.rst08:41
amoralejapparently it's in puppet-cinder https://github.com/openstack/puppet-cinder/commit/c978ba07e77bb347fe88e9219438a117a9d3d1b608:41
amoralejprobably we are just missing it in p-o-i08:41
kkulahere are the logs from last successful build https://logserver.rdoproject.org/openstack-periodic-integration-stable4/review.rdoproject.org/rdoinfo/master/weirdo-zed-promote-puppet-scenario002-centos-stream-9/b4daf2d/08:42
geguileoamoralej: it also needs code in nova (it's the important part)08:42
amoralejyou mean specific config in nova, right?08:42
geguileooh, and there is code for the service_user in nova!!08:42
geguileohttps://github.com/openstack/puppet-nova/blob/51829b985f6791883e5591890b998a0c344b9b9a/manifests/keystone/service_user.pp08:43
geguileoI think I can fix it fix a single patch08:43
amoralejwill you send it?08:44
amoralejto p-o-i? i think we have ways to test p-o-i in-flight patches from rdo08:44
geguileoamoralej: yes, I'll send it08:49
amoralejkkula ^08:49
amoralejthanks! geguileo++ kkula++08:50
kkulathank you!08:51
opendevreviewVladislav Belogrudov proposed openstack/cinder master: Yadro Tatlin Unified FC driver  https://review.opendev.org/c/openstack/cinder/+/87674308:52
geguileoamoralej: kkula mmmm, the patch I was going to submit is most likely not going to be accepted, because they are going to want to change how to do it  :-(09:02
amoralejwdym ?09:02
amoralejisn't your patch simply adding existing classes in puppet-nova and puppet-cinder into p-o-i existing manifests?09:03
amoralejsomething like in https://review.opendev.org/c/openstack/puppet-tripleo/+/67042409:05
amoralejactually, checking at the topic https://review.opendev.org/q/topic:service_token it was added to tripleo but never to p-o-i :(09:05
geguileoamoralej: there must be other changes somewhere else, because there there is a service project and the nova user has the service role as well, whereas that isn't the case in poi09:10
amoralejso we need a new project named "service" ?09:13
geguileoamoralej: kkula Any way to test if this fixes it?   https://review.opendev.org/c/openstack/puppet-openstack-integration/+/88364609:16
geguileoit's hack-ish, but I think it should work09:17
amoralejgeguileo, give us a while09:19
amoralejwe'll try09:19
geguileoamoralej:++09:20
geguileothank you!09:20
amoralejgeguileo, all scenarios are passing with your patch and latest cinder commit https://review.rdoproject.org/r/c/testproject/+/4868011:08
amoralejhttps://logserver.rdoproject.org/80/48680/1/check/weirdo-bobcat-promote-puppet-scenario001-centos-stream-9/a320f44/logs/weirdo-project/logs/etc/nova/nova.conf.txt.gz11:09
amoralejsend_service_user_token=True11:09
*** amoralej is now known as amoralej|lunch12:34
*** amoralej|lunch is now known as amoralej13:06
whoami-rajatreminder: Cinder Festival of Reviews today, 1400-1600 UTC14:00
whoami-rajatjoin us in Google meet: https://meet.google.com/bro-gamt-fwj14:00
whoami-rajator go directly to the etherpad: https://etherpad.opendev.org/p/cinder-festival-of-reviews14:00
whoami-rajatjungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard sfernand enriquetaso hemna fabiooliveira happystacker sfv88014:00
whoami-rajatended the meeting since only two people were there (including me) but will be here on IRC14:10
whoami-rajatif anyone else wants to do offline reviews then here is the dashboard https://review.opendev.org/dashboard/?title=Cinder+Festival+of+Reviews&foreach=(project:openstack/cinder+OR+project:openstack/os-brick+OR+project:openstack/python-cinderclient+OR+project:openstack/python-brick-cinderclient-ext+OR+project:openstack/cinderlib+OR+project:openstack/rbd-iscsi-client)+AND+branch:master+AND+status:open+AND+NOT+owner%3Aself+AND+is%3Amergeable+14:10
whoami-rajatAND+NOT+label%3AWorkflow%3C%3D-1+AND+label%3AVerified%3E%3D1+AND+NOT+reviewedby%3Aself+AND+NOT+label%3ACode-Review%3C%3D-1&XS+patches+proposed+to+master+that+are+not+mine,+have+passed+Zuul,+no+merge+conflict,+not+reviewed+by+me,+no+negative+reviews=size:%3C%3D10&Documentation+only+patches+to+master+that+are+not+mine,+have+passed+Zuul,+no+merge+conflict,+not+reviewed+by+me,+no+negative+reviews=(dir:doc+OR+dir:api-ref)+AND+-dir:cinder+AND+14:10
whoami-rajat-dir:os_brick+AND+-dir:cinderclient+AND+-dir:brick_cinderclient_ext+AND+-dir:cinderlib+AND+-dir:rbd_iscsi_client&Slightly%20larger%20patches+proposed+to+master+that+are+not+mine,+have+passed+Zuul,+no+merge+conflict,+not+reviewed+by+me,+no+negative+reviews=size:%3C%3D15+AND+size:%3E1014:10
whoami-rajatnot a good idea to put the big dashboard here ... here is the tiny link http://tiny.cc/cinder-reviewfest14:10
nahimsouza[m]hi, whoami-rajat, sorry, I was not able to enter in the meeting, but I'll try to help with some review in the list of patches14:14
whoami-rajatnahimsouza[m], no problem, thanks for helping out with reviews, let me know if there are any doubts I will be available on IRC14:28
gansowhoami-rajat, rosmaita: hi! if you have a minute  could please review ? https://review.opendev.org/c/openstack/cinder/+/882087 14:31
whoami-rajatganso, ack, right now looking into XS patches but will do it after that14:31
gansowhoami-rajat: thanks!14:32
opendevreviewEric Harney proposed openstack/cinder-tempest-plugin master: [srbac] Testing Volume Actions  https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/88318215:06
opendevreviewMerged openstack/cinder master: Remove six from GPFS driver  https://review.opendev.org/c/openstack/cinder/+/87996515:50
opendevreviewTony Saad proposed openstack/os-brick master: Dell PowerFlex: Unnecessary login happen  https://review.opendev.org/c/openstack/os-brick/+/87628416:51
*** amoralej is now known as amoralej|off16:55
*** melwitt_ is now known as melwitt17:11
opendevreviewAshley Rodriguez proposed openstack/devstack-plugin-ceph master: [WIP][DNM] Remote Ceph with cephadm  https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/87674719:55
opendevreviewAshley Rodriguez proposed openstack/devstack-plugin-ceph master: [WIP][DNM] Remote Ceph with cephadm  https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/87674720:04
opendevreviewAshley Rodriguez proposed openstack/devstack-plugin-ceph master: [WIP][DNM] Remote Ceph with cephadm  https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/87674720:21
opendevreviewDamian Pietras proposed openstack/cinder master: LVM-nvmet: persist configuration after changing it  https://review.opendev.org/c/openstack/cinder/+/87803120:42
opendevreviewAshley Rodriguez proposed openstack/devstack-plugin-ceph master: [WIP][DNM] Remote Ceph with cephadm  https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/87674720:42
opendevreviewAshley Rodriguez proposed openstack/devstack-plugin-ceph master: [WIP][DNM] Remote Ceph with cephadm  https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/87674721:00

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!