Wednesday, 2023-05-24

opendevreviewMerged openstack/cinder stable/xena: Reject unsafe delete attachment calls  https://review.opendev.org/c/openstack/cinder/+/88283902:23
opendevreviewGorka Eguileor proposed openstack/cinder master: Doc: Improve service token  https://review.opendev.org/c/openstack/cinder/+/88336008:17
geguileorosmaita: done, thanks08:17
yuvalgeguileo: I need to install the DLM on my deployment? I see my driver do use coordination decorator while creating snapshots08:23
geguileoyuval: yes yo need to install and configure the DLM08:54
geguileos/yo/you08:54
geguileoyuval: what installation tool are you using?08:54
yuvalI am running using kolla-ansible08:54
yuvalis there a suggested DLM?08:55
yuvalalso all the clients using this driver need to install a DLM?08:55
geguileoyuval: if customer wants to do A/A they need to install the DLM and configure cinder to use it08:55
yuvalI see08:56
geguileoyuval: if they are running A/P then the default in Cinder is to use file locks for those decorators, so no need to configure it08:56
geguileoyuval: there seems to exist some support for tooz and DLM in kolla-ansible, at least by the looks of this bug report: https://bugs.launchpad.net/kolla-ansible/+bug/184007008:58
yuvalyea I also see this: https://opendev.org/openstack/kolla-ansible/commit/03b4c706fae54a381b78c0f516499bfac986fb2609:06
yuvalgeguileo: I know that if I configure the cluster=yuval_cluster in cinder.conf I will get an a/a cluster. how do I set a a/p cluster?09:22
geguileoyuval: for the a/a cluster you do the cluster config and the DLM09:23
geguileoyuval: for a/p you just do the cluster config09:23
geguileoand for a/p non-cluster you don't do the cluster config09:23
yuvalnow I just configured the cluster in cinder.conf. I am running operations I see it round robin between the cinder's09:24
yuvalso its running as a/a right?09:24
yuvalis it possible I see it roundrobin because the backend name is the same in the 2 nodes?09:25
yuvaland its not related to cluster? I do see in the logs - "moving all resources to cluster yuval_cluster@<backend name>09:26
geguileoyuval: it's important to understand each part of the puzzle on the A/A madness09:34
yuval:))))09:34
yuvallol09:34
geguileoyuval: the round robin is done because they are using the same message queue in RabbitMQ, and they use the same one because you have configured the cluster09:35
geguileoso that part is probably working correctly09:35
yuvalgot it09:35
geguileonow, if your DLM is configured to use file locks09:35
yuvalthe coordination section is empty09:35
geguileoand you have your 2 cinder-volume services in different hosts, then you are not actually doing the locking you want09:35
yuvalso I think it is files locks09:35
geguileoyup09:36
yuvalI see09:36
opendevreviewSofia Enriquez proposed openstack/cinder master: Automate generation of backups api-ref samples  https://review.opendev.org/c/openstack/cinder/+/86149109:36
geguileoSo this is likely to have race conditions in the critical sections that you define in your code using the coordination lock decorators09:36
yuvalyes I see09:36
yuvalok, regarding the a/p and a/a. if the coordination is empty but exists that mean it is using the default DLM and have the cluster enabled - so its running a/a?09:38
geguileoyuval: it is running a/a in an unsafe manner09:39
yuvalyes09:39
yuvalgeguileo: so if I would like to run it in an a/p manner? I would need to disable the DLM? how can I do that?09:40
geguileothe cinder core code also expects the DLM to be properly configured when running a/a, so there will be operations that cinder will allow (and shouldn't) if incorrectly configured09:40
geguileoyuval: you don't need to disable anything, you just need to run 1 single cinder-volume service at a time09:40
yuvalah, I see. so the active-passive mode. is not like there is only 1 writer node which take care of all the operations and one passive which waits for the first 1 to die. its just mean I have 2 cinder nodes, some kind of a heartbeat on the active node and if its dead, I will init the passive node. is that correct?09:43
geguileoyuval: yes that is correct, we don't have the feature to do leader election09:48
geguileo(in Cinder I mean)09:49
yuvalI see now what you mean. if the passive node was not part of the cluster (and also the active one) the data of what happen would be saved only on the first cinder node, not in the cluster database. once I set it to be in the cluster mode, all the nodes know which data to look for.09:52
yuvalI would appreciate another review on this one liner: https://review.opendev.org/c/openstack/cinder/+/88379710:14
yuvalif I can help someone else with a review I am gladly open for requests10:14
opendevreviewRaghavendra Tilay proposed openstack/cinder stable/2023.1: HPE 3PAR: Few issues with new WSAPI (of 2023)  https://review.opendev.org/c/openstack/cinder/+/88278110:15
raghavendrathi, for below patch i received two +2 and +W on May 17.12:27
raghavendrathttps://review.opendev.org/c/openstack/cinder/+/882266/12:27
raghavendratHowever, zuul didn't pass in one week. Observed failure in below sub-tests of zuul:12:27
raghavendrat4 times by cinder-plugin-ceph-tempest, 2 times by grenade, and 12:27
raghavendrat1 time each by cinder-grenade-mn-sub-volbak, tempest-integrated-storage, cinder-tempest-plugin-lvm-lio-barbican, tempest-integrated-storage-ubuntu-focal, tempest-slow-py312:27
raghavendratNot sure if anybody else is facing this issue.12:28
raghavendratIt would be great if someone can provide pointers to resolve this. Thanks.12:28
raghavendrat-------12:28
raghavendratPlease note: From IRC logs of past one week, i observed few patches got merged into master(Bobcat).12:28
raghavendratHowever, those were trivial patches (having change in .rst/.txt files).12:28
raghavendratDidn't observe a patch having atleast 20+ lines of python code getting merged.12:28
opendevreviewEric Harney proposed openstack/cinder master: zuul: Extend timeout for cinder-plugin-ceph-tempest  https://review.opendev.org/c/openstack/cinder/+/88419412:42
eharneythis patch should help at least one of raghavendrat's zuul failures ^12:43
raghavendratthank you eharney: for quick help12:45
opendevreviewMerged openstack/cinder master: Doc: Improve service token  https://review.opendev.org/c/openstack/cinder/+/88336013:30
opendevreviewNahim Alves de Souza proposed openstack/cinder master: NetApp ONTAP: Fix create FlexVol pool replica  https://review.opendev.org/c/openstack/cinder/+/79838413:45
whoami-rajatCinder meeting in #openstack-meeting-alt at 1400 UTC13:59
whoami-rajatjungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney walshh_ jbernard sfernand enriquetaso hemna fabiooliveira yuval tobias-urdin adiare happystacker dosaboy hillpd13:59
enriquetasoHi I had a personal issue and I havent finished the bug report. I will send it later today but I wont be able to run the cinder bug meeting after the normal meeting 14:01
hillpdhello14:01
rosmaitaenriquetaso: that's ok, let's have a bug-free week in cinder!14:05
enriquetasothanks14:05
opendevreviewEric Harney proposed openstack/cinder-tempest-plugin master: zuul: Extend timeout for cinder-tempest-plugin-lvm-multiattach  https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/88420414:09
opendevreviewMerged openstack/cinder master: Allow lightos driver to run as active-active  https://review.opendev.org/c/openstack/cinder/+/88379714:22
opendevreviewEric Harney proposed openstack/cinder-tempest-plugin master: zuul: Exclude unneeded tests from multiattach job  https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/88420914:51
eharneytosky: ^14:51
toskyuhhh14:56
eharneyyeah14:57
opendevreviewEric Harney proposed openstack/cinder master: Tests: Provide filter arg to VolumeAttachmentNotFound()  https://review.opendev.org/c/openstack/cinder/+/88425316:43
opendevreviewEric Harney proposed openstack/cinder-tempest-plugin master: zuul: Extend timeout for cbak-ceph job  https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/88425817:43
opendevreviewGorka Eguileor proposed openstack/os-brick master: SCSI: Cleanup leftover devices and validate result  https://review.opendev.org/c/openstack/os-brick/+/88284118:40
opendevreviewAshley Rodriguez proposed openstack/devstack-plugin-ceph master: [WIP][DNM] Remote Ceph with cephadm  https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/87674720:56

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!