opendevreview | XuQi proposed openstack/cinder master: Fujitsu Driver: Add support for revert to snapshot https://review.opendev.org/c/openstack/cinder/+/904971 | 06:06 |
---|---|---|
crohmann | I picked up on an older change to improve cinder-backup finding the parent for an incremetal backup. I already rebased and reworked the code see https://review.opendev.org/c/openstack/cinder/+/484729. I know tests still fail, but I would greatly appreciate some feedback on my approach. If this is a valid (and good idea), I gladly work on fixing the tests. | 07:41 |
crohmann | In essence this replaces fetching all backups and finding the parent via a loop, a lambda and some conditions inside Python with a single DB query. | 07:43 |
raghavendrat | hi rosmaita: are you around ? | 13:18 |
rosmaita | raghavendrat: in meetings for a while | 13:28 |
rosmaita | you can leave me messages here and i will reply later | 13:29 |
raghavendrat | rosmaita: i have query related to backport of https://review.opendev.org/c/openstack/cinder/+/901961 | 13:37 |
raghavendrat | In case you get time, could you please respond. Thanks. | 13:37 |
rosmaita | ack, will be about 30 min | 13:38 |
raghavendrat | ok | 13:38 |
raghavendrat | i meant ... i had asked the query in patch itself | 13:39 |
rosmaita | raghavendrat: left a comment for you on the patch | 14:05 |
eharney | the failures in tempest-integrated-storage here look pretty strange: https://zuul.opendev.org/t/openstack/build/4386bed6cdaf45a9950b2dd6be555090 | 14:07 |
eharney | tempest.api.compute.admin.test_create_server.ServersWithSpecificFlavorTestJSON.test_verify_created_server_ephemeral_disk failed and it shows a number of segfaults inside the guest | 14:07 |
raghavendrat | thanks Brian for quick response | 14:25 |
tkajinam | https://bugs.launchpad.net/neutron/+bug/1682796 https://review.opendev.org/c/openstack/reno/+/518961 | 14:52 |
tkajinam | posting these links in case these may be useful for the others. "do not update old release notes" is what I learned in the past, but it's no longer necessary. I myself didn't know this improvement until stephenfin pointed it out a while ago. | 14:53 |
stephenfin | yeah, that hasn't been the case for about 6 years now (from back while dhellmann was still working on OpenStack) | 14:56 |
tkajinam | rosmaita, eharney ^^^ I've added comments about this in the CRLF removal patches | 14:56 |
tkajinam | always nice to see a problematic behavior has been already fixed by someone :-) | 15:02 |
wncslln | hello cinder o/, anyone could give some feedback on https://review.opendev.org/c/openstack/cinder/+/905608 please? | 16:20 |
eharney | wncslln: i had meant to actually review that after commenting on it before... will take a look again soon | 16:21 |
wncslln | eharney: ok, thanks! any suggestions im here | 16:24 |
opendevreview | Christian Rohmann proposed openstack/cinder master: Filters fetching parent backup for incremental backup https://review.opendev.org/c/openstack/cinder/+/484729 | 16:29 |
crohmann | I fixed the tests for the change to fetching the parent backup for a cinder-backup incremental backup now. If someone could kindly take a look at that one. To me it's quite an improvement, dropping two imports and lots of code in favor of a DB query. | 16:32 |
opendevreview | Merged openstack/cinder master: RBD: Use "RBD" capitalization in user-facing text https://review.opendev.org/c/openstack/cinder/+/891879 | 16:39 |
opendevreview | Bryan Neumann proposed openstack/cinder master: Dell EMC: PowerMax - Configurable SRDF snapshots https://review.opendev.org/c/openstack/cinder/+/899051 | 18:43 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!