| opendevreview | Yian Zong proposed openstack/cinder master: Dell PowerMax: Fix SnapVx unlink failure https://review.opendev.org/c/openstack/cinder/+/902262 | 04:19 |
|---|---|---|
| happystacker | Hey team. It looks like one Zuul is failing on this patch: https://review.opendev.org/c/openstack/cinder/+/910320 | 07:28 |
| happystacker | it seems that the error is because of a duplicate bug id found on two patches https://review.opendev.org/c/openstack/cinder/+/784140/10/releasenotes/notes/bug-1920870-ibm-svf-fix-extend-issue-for-mirroring-volumes-31b1a9119c49e112.yaml and https://review.opendev.org/c/openstack/cinder/+/813532/2/releasenotes/notes/bug-1951250-storwize-fix-multiple-ssh-calls-for-retype-d3b56379b7d8b049.yaml | 07:32 |
| happystacker | those patches were merged a long time ago, I don't know why this is happening now | 07:33 |
| frickler | happystacker: that issue seems unrelated to your patch, there are some reno fixes pending to get merged due to unmaintained branches, e.g. https://review.opendev.org/c/openstack/cinder/+/911348 | 07:38 |
| frickler | rosmaita: whoami-rajat: jbernard: ^^ | 07:39 |
| happystacker | frickler: I agree, it's not related | 07:56 |
| happystacker | but the error says | 07:57 |
| happystacker | Warning, treated as error: | 07:57 |
| happystacker | /home/zuul/src/opendev.org/openstack/cinder/releasenotes/source/zed.rst:3:Duplicate explicit target name: "bug #1920870". | 07:57 |
| happystacker | https://zuul.opendev.org/t/openstack/build/014a6072f6b544e4829290ba683360b4 | 07:57 |
| whoami-rajat | I've approved the patch for xena-eom | 07:59 |
| opendevreview | Merged openstack/python-brick-cinderclient-ext master: reno: Update master for xena Unmaintained status https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/911353 | 08:01 |
| frickler | whoami-rajat: you'll likely need to do the same for v+w | 08:02 |
| whoami-rajat | yeah, thanks for the reminder, i almost forgot about those patches | 08:02 |
| opendevreview | Merged openstack/python-cinderclient master: reno: Update master for xena Unmaintained status https://review.opendev.org/c/openstack/python-cinderclient/+/911355 | 08:03 |
| opendevreview | Merged openstack/os-brick master: reno: Update master for xena Unmaintained status https://review.opendev.org/c/openstack/os-brick/+/911351 | 08:05 |
| *** mklejn_ is now known as mklejn | 08:55 | |
| mnederlof | Hi, would someone be able to review this small patch? https://review.opendev.org/c/openstack/cinder/+/911650 | 09:12 |
| jbernard | mnederlof: i see a conflict with this other patch https://review.opendev.org/c/openstack/cinder/+/811032 are they addressing the same problem? | 10:37 |
| mnederlof | imho that patch is addressing changes which have been implemented in another way already in current master branch (https://review.opendev.org/c/openstack/cinder/+/785099) | 10:41 |
| mnederlof | in my patch i am only addressing the issue that the AZ field is actually filled whenever a backup is created | 10:42 |
| mnederlof | with the AZ of the service it is picked up by | 10:42 |
| jbernard | mnederlof: will take a look today | 10:45 |
| mnederlof | thanks! | 10:45 |
| *** geguileo is now known as Guest2520 | 10:52 | |
| *** Guest2520 is now known as geguileo | 11:39 | |
| opendevreview | Merged openstack/python-cinderclient stable/2024.1: Update .gitreview for stable/2024.1 https://review.opendev.org/c/openstack/python-cinderclient/+/912121 | 12:26 |
| opendevreview | Merged openstack/python-cinderclient stable/2024.1: Update TOX_CONSTRAINTS_FILE for stable/2024.1 https://review.opendev.org/c/openstack/python-cinderclient/+/912122 | 12:26 |
| opendevreview | Merged openstack/python-brick-cinderclient-ext stable/2024.1: Update .gitreview for stable/2024.1 https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/912118 | 12:27 |
| opendevreview | Merged openstack/python-brick-cinderclient-ext stable/2024.1: Update TOX_CONSTRAINTS_FILE for stable/2024.1 https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/912119 | 12:27 |
| opendevreview | Merged openstack/os-brick stable/2024.1: Update .gitreview for stable/2024.1 https://review.opendev.org/c/openstack/os-brick/+/912115 | 13:07 |
| opendevreview | Merged openstack/os-brick stable/2024.1: Update TOX_CONSTRAINTS_FILE for stable/2024.1 https://review.opendev.org/c/openstack/os-brick/+/912116 | 13:07 |
| bryanneumann | Hi All, is it appropriate to rebase an approved pull request or wait? https://review.opendev.org/c/openstack/cinder/+/910320 has a test failing that should be resolved by rebase | 15:37 |
| clarkb | bryanneumann: if the fix is merged then all you should need is a recheck because zuul runs all jobs against the current state of the tree (auto rebasing essentially) | 15:47 |
| clarkb | if you do rebase then you will lose your approval. So it probably depends on how quickly you think the fix will merge. If it will merge soon then I would just wait and recheck once the fix is merged otherwise you can rebase and try to get a new approval | 15:48 |
| bryanneumann | Thank you very much clarkb | 15:55 |
| opendevreview | Merged openstack/python-cinderclient master: reno: Update master for wallaby Unmaintained status https://review.opendev.org/c/openstack/python-cinderclient/+/911346 | 18:30 |
| opendevreview | Merged openstack/python-brick-cinderclient-ext master: reno: Update master for wallaby Unmaintained status https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/911344 | 18:30 |
| opendevreview | Merged openstack/os-brick master: reno: Update master for wallaby Unmaintained status https://review.opendev.org/c/openstack/os-brick/+/911342 | 18:31 |
| opendevreview | Merged openstack/python-brick-cinderclient-ext master: reno: Update master for victoria Unmaintained status https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/911335 | 18:33 |
| opendevreview | Merged openstack/os-brick master: reno: Update master for victoria Unmaintained status https://review.opendev.org/c/openstack/os-brick/+/911333 | 18:34 |
| opendevreview | Merged openstack/python-cinderclient master: reno: Update master for victoria Unmaintained status https://review.opendev.org/c/openstack/python-cinderclient/+/911337 | 18:34 |
| opendevreview | Rajat Dhasmana proposed openstack/cinder master: Correct releasenote bug-1951250 https://review.opendev.org/c/openstack/cinder/+/912630 | 18:42 |
| opendevreview | Rajat Dhasmana proposed openstack/cinder master: Correct releasenote bug-1951250 https://review.opendev.org/c/openstack/cinder/+/912630 | 19:12 |
| opendevreview | Rajat Dhasmana proposed openstack/cinder master: Correct releasenote bug-1951250 https://review.opendev.org/c/openstack/cinder/+/912630 | 20:20 |
| opendevreview | Rajat Dhasmana proposed openstack/cinder stable/zed: Correct releasenote bug-1951250 https://review.opendev.org/c/openstack/cinder/+/912650 | 20:25 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!