| yuval | <yuval> Hey I have 4 Patches that I need review on, if anyone is available I would appreciate | 07:58 |
|---|---|---|
| yuval | <yuval> https://review.opendev.org/c/openstack/cinder/+/885587 - XS https://review.opendev.org/c/openstack/cinder/+/904531 - S https://review.opendev.org/c/openstack/cinder/+/903573 - M https://review.opendev.org/c/openstack/os-brick/+/903574 - M | 07:58 |
| yuval | Hey there patches are heavily tested in our CI and I added UT it passed zuul | 07:58 |
| yuval | can someone take a look? | 07:59 |
| yuval | geguileo whoami-rajat simondodsley eharney | 08:11 |
| *** geguileo is now known as Guest402 | 08:54 | |
| *** Guest402 is now known as geguileo | 09:02 | |
| opendevreview | yuval proposed openstack/cinder master: add IPACL support to the Lightbits Cinder driver https://review.opendev.org/c/openstack/cinder/+/903573 | 10:49 |
| yuval | Raghavendra Tilay - hey thanks for the comment, I fixed the commit msg | 10:50 |
| opendevreview | yuval proposed openstack/cinder master: add IPACL support to the Lightbits Cinder driver https://review.opendev.org/c/openstack/cinder/+/924323 | 11:05 |
| yuval | I see gerrit decide to open a new patch:https://review.opendev.org/c/openstack/cinder/+/924323 instead of https://review.opendev.org/c/openstack/cinder/+/903573 what should I do - which one should I close? | 11:08 |
| kpdev | hi all, i need review on https://review.opendev.org/c/openstack/cinder/+/847131 .. most likely from core-team at this stage | 12:14 |
| rosmaita | Cinder meeting in #openstack-meeting-alt at 1400 UTC | 13:58 |
| rosmaita | jungleboyj rosmaita smcginnis tosky whoami-rajat m5z e0ne geguileo eharney jbernard hemna fabiooliveira yuval tobias-urdin adiare happystacker dosaboy hillpd msaravan sp-bmilanov Luzi zaitcev ^^ | 13:58 |
| opendevreview | yuval proposed openstack/cinder master: add IPACL support to the Lightbits Cinder driver https://review.opendev.org/c/openstack/cinder/+/924323 | 14:45 |
| opendevreview | yuval proposed openstack/cinder master: add IPACL support to the Lightbits Cinder driver https://review.opendev.org/c/openstack/cinder/+/903573 | 14:47 |
| yuval | msaravan whoami-rajat - doing basic qemu-img testing I see the output for info is in Bytes | 15:27 |
| yuval | qemu-img create -f raw myimage.qcow2 2G | 15:28 |
| yuval | qemu-img info --output=json myimage.qcow2 | 15:28 |
| yuval | { | 15:28 |
| yuval | "virtual-size": 2147483648, | 15:28 |
| yuval | "filename": "myimage.qcow2", | 15:28 |
| yuval | "format": "raw", | 15:28 |
| yuval | "actual-size": 4096, | 15:28 |
| yuval | "dirty-flag": false | 15:28 |
| yuval | } | 15:28 |
| yuval | ah this is for a raw format | 15:28 |
| yuval | also for qcow2 its bytes | 15:29 |
| yuval | (cinder-volume)[root@rack03-server55 images_yuval]# qemu-img info --output=json myimage2.qcow2 | 15:29 |
| yuval | { | 15:29 |
| yuval | "virtual-size": 2147483648, | 15:29 |
| yuval | "filename": "myimage2.qcow2", | 15:29 |
| yuval | "cluster-size": 65536, | 15:29 |
| yuval | "format": "qcow2", | 15:29 |
| yuval | "actual-size": 200704, | 15:29 |
| yuval | "format-specific": { | 15:29 |
| yuval | "type": "qcow2", | 15:29 |
| yuval | "data": { | 15:29 |
| yuval | "compat": "1.1", | 15:29 |
| yuval | "lazy-refcounts": false, | 15:29 |
| yuval | "refcount-bits": 16, | 15:29 |
| yuval | "corrupt": false | 15:29 |
| yuval | } | 15:29 |
| yuval | }, | 15:29 |
| yuval | "dirty-flag": false | 15:29 |
| yuval | } | 15:29 |
| yuval | the Unittest is passing because the mock is using Gi units | 15:31 |
| yuval | ah the log is miss leading it prints "and real size is 1" but in the condition is multiplying with 1024^3 | 16:07 |
| yuval | but still there is a miss-match 1024^3=1073741824 while the volume is 117440512 | 16:08 |
| opendevreview | Nguye Luu Hoang Minh proposed openstack/cinder master: Allow creating full backup on a backing-up volume which is previously in-use https://review.opendev.org/c/openstack/cinder/+/924121 | 17:38 |
| opendevreview | Nguye Luu Hoang Minh proposed openstack/cinder master: Allow creating full backup on a backing-up volume which is previously in-use https://review.opendev.org/c/openstack/cinder/+/924121 | 17:39 |
| opendevreview | Nguye Luu Hoang Minh proposed openstack/cinder master: Allow creating full backup on a backing-up volume which is previously in-use https://review.opendev.org/c/openstack/cinder/+/924121 | 18:04 |
| opendevreview | Nguye Luu Hoang Minh proposed openstack/cinder master: Allow full backup on backing-up vol previously in-use https://review.opendev.org/c/openstack/cinder/+/924121 | 18:05 |
| opendevreview | Nguye Luu Hoang Minh proposed openstack/cinder master: Allow full backup on backing-up vol previously in-use https://review.opendev.org/c/openstack/cinder/+/924121 | 18:18 |
| opendevreview | Nguye Luu Hoang Minh proposed openstack/cinder master: Allow full backup on backing-up vol previously in-use https://review.opendev.org/c/openstack/cinder/+/924121 | 18:32 |
| opendevreview | Merged openstack/devstack-plugin-ceph stable/2023.1: Bump to Reef https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/915146 | 23:08 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!