| *** geguileo is now known as Guest936 | 08:04 | |
| opendevreview | yuval proposed openstack/cinder master: Create multiple snapshots from same volume https://review.opendev.org/c/openstack/cinder/+/904531 | 08:54 |
|---|---|---|
| yuval | Again I am asking for you support in review the patch request ^ | 08:55 |
| opendevreview | Josephine Seifert proposed openstack/cinder master: Add volume type metadata table to database https://review.opendev.org/c/openstack/cinder/+/918316 | 09:12 |
| opendevreview | yuval proposed openstack/cinder master: Create multiple snapshots from same volume https://review.opendev.org/c/openstack/cinder/+/904531 | 09:33 |
| lajoskatona | Hi, I would like to ask about the backports for https://bugs.launchpad.net/nova/+bug/2059809 | 11:34 |
| lajoskatona | I checked the unmaintained/yoga patch: https://review.opendev.org/c/openstack/cinder/+/923873/1 , and as I see the issue is around that bionic is used for even py36 execution and the qemu-img create .... commands fail (in my local env I have the same if I used py36 on bionic) | 11:36 |
| lajoskatona | I am not sure if there is precedence for such issue in Cinder, and what should be the preferred way of moving forward | 11:50 |
| frickler | lajoskatona: I can't speak for the cinder team, but from what I'm seeing, they are struggling to even keep up with reviews on master, I very much expect them to treat unmaintained branches as a do-not-care item | 12:39 |
| lajoskatona | frickler: ack, I had the same feeling, but writing it down and let people think about it makes it more visible | 12:59 |
| opendevreview | yuval proposed openstack/cinder master: Create multiple snapshots from same volume https://review.opendev.org/c/openstack/cinder/+/904531 | 13:28 |
| yuval | lajoskatona what error do you see? | 13:33 |
| lajoskatona | yuval: Hi, https://a72cfe21c2592d86f1a0-632ff0f5bf18f30fe81cecd4fd5ff676.ssl.cf1.rackcdn.com/923873/1/check/openstack-tox-py36/29cf766/testr_results.html | 13:53 |
| rosmaita | lajoskatona: looks to me like the qemu-img on that operating system is old enough that it doesn't understand how to create a qcow2 with external datafile | 13:54 |
| rosmaita | the failure is happening when the unit test creates a "bad" image for the format inspector to reject | 13:54 |
| opendevreview | Eric Harney proposed openstack/cinder master: Pass with mypy 1.11.0 https://review.opendev.org/c/openstack/cinder/+/924631 | 13:55 |
| lajoskatona | rosmaita, yuval: yes qemu version was my suspect also, I executed blindly the command in the exception in my env: $ qemu-img create -f qcow2 -o data_file=/tmp/tmpvfuo30p0/data9kz_8ou5,data_file_raw=on /tmp/tmpvfuo30p0/glance-unittest-formatinspector-4j8phcm6.qcow2 5242880 | 13:55 |
| lajoskatona | qemu-img: Invalid parameter 'data_file' | 13:55 |
| lajoskatona | qemu-img: /tmp/tmpvfuo30p0/glance-unittest-formatinspector-4j8phcm6.qcow2: Invalid options for file format 'qcow2' | 13:55 |
| rosmaita | yeah, that's it | 13:55 |
| rosmaita | i think maybe just skip that test | 13:55 |
| rosmaita | short term, i mean | 13:56 |
| lajoskatona | rosmaita: ack, I check it, another thing in my mind to add a small image sample to the repo for this test and skip qemu-img create just use the sample image file | 13:57 |
| rosmaita | lajoskatona: that was my thought, too, but i got some pushback about committing non-code artefacts to the repo | 13:58 |
| rosmaita | but i am not an unmaintained core ... it might make sense to do that for the unmaintained branches | 13:59 |
| lajoskatona | romsata: ahh, ok, that is always a question what to store under git :-) | 13:59 |
| rosmaita | i think you have a good case for the unmaintained branches, because (q) you want to know that the code works, and (b) if someone updated qemu-img, the skipped tests would suddenly become relevant | 14:00 |
| yuval | shouldnt you mock the qemu-img? in the unittests? | 14:01 |
| yuval | or its a tempest? | 14:01 |
| rosmaita | yuval: ordinarily yes, but we're calling qemu-img to create the image to run the tests on | 14:01 |
| lajoskatona | yuval it is unit tests, in master: https://opendev.org/openstack/cinder/src/commit/8a6ffb36c90379984836b3d04406277020b72445/cinder/tests/unit/image/test_format_inspector.py#L54-L82 | 14:02 |
| yuval | I see | 14:05 |
| opendevreview | Brian Rosmaita proposed openstack/cinder master: Enhance mypy job https://review.opendev.org/c/openstack/cinder/+/924660 | 16:29 |
| *** geguileo is now known as Guest970 | 16:37 | |
| opendevreview | Merged openstack/cinder master: Pass with mypy 1.11.0 https://review.opendev.org/c/openstack/cinder/+/924631 | 18:19 |
| opendevreview | Yosi Ben Shimon proposed openstack/cinder-tempest-plugin master: Add functions to srbac base file https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/920168 | 19:26 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!