*** mhen_ is now known as mhen | 02:19 | |
opendevreview | Shogo Takazawa proposed openstack/cinder master: Hitachi: support extending volume has snapshot(s) https://review.opendev.org/c/openstack/cinder/+/850830 | 02:27 |
---|---|---|
opendevreview | DongHun, Kim proposed openstack/cinder master: Fix PowerFlex volume size mismatch with volume cache https://review.opendev.org/c/openstack/cinder/+/935473 | 03:16 |
*** geguileo is now known as Guest1096 | 09:00 | |
greatgatsby | Good day. I think we've found a bug in os-brick fibre_channel.py, just wondering if someone is around to have a quick discussion before I create a ticket or PR (I have a working fix)? Thanks. | 14:55 |
greatgatsby | the problem we're seeing is when fibre_channel.py calls find_sysfs_multipath_dm in the connect_volume function, this can return None if mpath/Pure (in our case) has not yet plumbed up the devices in /sys/block/<device>/holders/. There's no check that mpath is not None, and there's no retries. So in our case, fibre_channel.py would then go on to run a `multipath -C None` which of course fails. | 15:09 |
greatgatsby | My current patch uses loopingcall.FixedIntervalLoopingCall as I've seen used elsewhere in os-brick: | 15:09 |
greatgatsby | https://bpa.st/raw/QXTA | 15:09 |
greatgatsby | https://bugs.launchpad.net/os-brick/+bug/2089694 | 16:30 |
frickler | jbernard: rosmaita: ^^ not sure who is most knowledgable in that area? | 17:23 |
rosmaita | greatgatsby: frickler: most of the team is out this week (or will be out shortly) ... bug report looks good, but unlikely anyone will be looking at it before next week (no cinder meeting tomorrow) | 17:28 |
greatgatsby | appreciate any help, I think we'll patch it locally ourselves for now and monitor that ticket to see how upstream decides to handle it. My proof-of-concept solution is just something we came up with ourselves, trying to anticipate what upstream might do, but we're not active contributors to these projects, so please take it as testing/unproven code (although it works for us) | 17:45 |
*** geguileo is now known as Guest1145 | 19:27 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!