opendevreview | Takashi Kajinami proposed openstack/os-brick master: Use oslo.utils to strip scope from an IPv6 address https://review.opendev.org/c/openstack/os-brick/+/937697 | 00:26 |
---|---|---|
*** mhen_ is now known as mhen | 02:51 | |
opendevreview | Raghavendra Tilay proposed openstack/cinder master: HPE 3par - Fix retype volume https://review.opendev.org/c/openstack/cinder/+/928599 | 13:04 |
opendevreview | Raghavendra Tilay proposed openstack/cinder master: HPE 3par - Fix retype volume https://review.opendev.org/c/openstack/cinder/+/928599 | 13:20 |
opendevreview | Pavlo Shchelokovskyy proposed openstack/cinder master: Apply non-default qemu process limits https://review.opendev.org/c/openstack/cinder/+/873249 | 14:41 |
opendevreview | Simon Dodsley proposed openstack/cinder master: [Pure Storage] Remove SafeMode PGs from Replication Pods https://review.opendev.org/c/openstack/cinder/+/938063 | 16:15 |
SvenKieske | hey folks, anybody around here know's how cinder documents deprecated stuff? I'm specifically asking, because this feature from the netapp-volume-driver is deprecated but it seems the docs have been forgotten to change as well: https://docs.openstack.org/cinder/latest/configuration/block-storage/drivers/netapp-volume-driver.html#netapp-nfs-copy-offload-client | 16:25 |
SvenKieske | the merged deprecation patch: https://review.opendev.org/c/openstack/cinder/+/847733 | 16:25 |
SvenKieske | I would post an update to the docs myself, but I'm not sure if there is a - documented? - way of handling how cinder marks deprecated options, if it should be deleted from the docs or whatever. | 16:26 |
SvenKieske | I guess someting like this should suffice? https://review.opendev.org/c/openstack/cinder/+/657511/2/doc/source/configuration/block-storage/nested-quota.rst | 16:33 |
rosmaita | SvenKieske: yes, a note like that in your docs would be good | 16:45 |
rosmaita | SvenKieske: also, you can put up a patch to actually remove the option deprecated by https://review.opendev.org/c/openstack/cinder/+/847733 | 16:46 |
rosmaita | SvenKieske: and include a release note, saying that it's no longer available ... iirc, that goes into the 'upgrade' section of a release note | 16:47 |
rosmaita | you can look at other notes in the release notes dir for examples | 16:47 |
rosmaita | there are probably some notes that have "remove" in the file name | 16:48 |
SvenKieske | yeah, I need to get my git config in order first, just recently started at the red hat..maybe I'll just post the patch from my private machine, that should still work I guess :D | 16:48 |
SvenKieske | thx for the pointers | 16:49 |
SvenKieske | fwiw when looking at other patches that deprecated stuff it's almost never marked as deprecated in the docs, that could lead to dangerous situations, maybe worth it to remind people of this in the next meeting? | 16:50 |
SvenKieske | especially if downstream is only looking at the docs, not at release notes, at least it's in the renos, so probably it's okay. | 16:51 |
*** jbernard_ is now known as jbernard | 17:31 | |
opendevreview | Rajat Dhasmana proposed openstack/os-brick master: Wrap librbd calls in native threads https://review.opendev.org/c/openstack/os-brick/+/938095 | 23:33 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!