| *** bauzas1 is now known as bauzas | 00:52 | |
| *** mhen_ is now known as mhen | 02:09 | |
| opendevreview | Markus Hentsch proposed openstack/cinder-specs master: Re-propose Spec for the Cinder part of the Image Encryption https://review.opendev.org/c/openstack/cinder-specs/+/964777 | 09:21 |
|---|---|---|
| opendevreview | Markus Hentsch proposed openstack/cinder master: Adopt image encryption standardization https://review.opendev.org/c/openstack/cinder/+/926298 | 10:06 |
| zigo | Hi there! | 11:12 |
| zigo | A few weeks ago, we had a rabbitmq outage on one of our cluster (because of a disk full, that's not interesting, anyways). | 11:12 |
| zigo | So we restarted all of our rabbit cluster, and waited for the cinder services to be up, which they apparently did. | 11:12 |
| zigo | Today, I discovered that the heatbeat thread was up, but not the main thread of our cinder-volume / cinder-backup. | 11:12 |
| zigo | So we had a false positive that our Cinder volumes were all up. | 11:12 |
| zigo | We thought about how to improve it all. My idea right now is that the heatbeat thread could send a ping message to the node itself, and if it's not recieving the pong message, it would declare itself as down in the control plane. That's not very invasive, it's just an improvement of the current heatbeat thread so that it would make sure the main thread is down. My intention is to write this in an oslo lib (possibly oslo.messaging?) and push | 11:12 |
| zigo | this in all projects, starting with Cinder. | 11:12 |
| zigo | What's your thoughts on this idea? | 11:12 |
| zigo | What I'm not sure about: is it that sometimes, the main thread is busy and will take a long time to reply, or is it that each new Cinder task spawns a new thread? | 11:33 |
| opendevreview | Raghavendra Tilay proposed openstack/cinder master: DNM - do not merge. this is test patch https://review.opendev.org/c/openstack/cinder/+/969373 | 12:43 |
| jbernard | VolodymyrBoiko[m]: im not sure what you mean | 14:28 |
| VolodymyrBoiko[m] | jbernard: After receiving a +2, shouldn’t the gate pipeline start automatically? Is there anything else I need to do to get it merged? | 14:30 |
| jbernard | VolodymyrBoiko[m]: i have to have another core reviewer, i can't merge it by myself | 14:34 |
| jbernard | VolodymyrBoiko[m]: it needs another +2, and then we can have a +W | 14:35 |
| jbernard | VolodymyrBoiko[m]: that will start the gate check and merge processw | 14:35 |
| *** vhari_ is now known as vhari | 14:55 | |
| VolodymyrBoiko[m] | jbernard: is there place where I can find list of core reviewrs? Maybe I can also ping someone? | 15:05 |
| lutimura | VolodymyrBoiko[m]: you can take a look at https://review.opendev.org/admin/groups | 15:11 |
| lutimura | search for the <project>-core group and take a look at its members | 15:11 |
| *** raineszm5 is now known as raineszm | 16:23 | |
| opendevreview | Thomas Goirand proposed openstack/cinder master: WIP, do not merge: enhance heartbeats https://review.opendev.org/c/openstack/cinder/+/970653 | 16:48 |
| jbernard | zigo: the main thread will use tpools at times for longer running tasks, but it should be responsive | 16:56 |
| jbernard | zigo: your proposal seems reasonable to me, but maybe others will have input | 16:56 |
| opendevreview | Thomas Goirand proposed openstack/cinder master: WIP, do not merge: enhance heartbeats https://review.opendev.org/c/openstack/cinder/+/970653 | 23:07 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!