| opendevreview | Rajat Dhasmana proposed openstack/os-brick master: iSCSI: wait for multipathd to remove paths https://review.opendev.org/c/openstack/os-brick/+/971496 | 00:58 |
|---|---|---|
| *** mhen_ is now known as mhen | 03:01 | |
| rosmaita | reminder: Cinder Festival of Reviews today, 1400-1600 UTC | 14:01 |
| rosmaita | join us in Google meet: https://meet.google.com/ijz-ivqg-bam | 14:01 |
| rosmaita | or go directly to the etherpad: https://etherpad.opendev.org/p/cinder-festival-of-reviews | 14:01 |
| rosmaita | jungleboyj rosmaita tosky whoami-rajat m5z e0ne geguileo eharney jbernard sfernand hemna fabiooliveira happystacker sfv880 bryanneumann agalica erlon lutimura sp-bmilanov kaisers ^^ | 14:01 |
| opendevreview | Eric Harney proposed openstack/devstack-plugin-nfs master: Enable attach encrypted volume for master https://review.opendev.org/c/openstack/devstack-plugin-nfs/+/597145 | 14:20 |
| opendevreview | Eric Harney proposed openstack/cinder master: mypy: NFS driver https://review.opendev.org/c/openstack/cinder/+/841315 | 14:42 |
| opendevreview | Eric Harney proposed openstack/cinder master: mypy: NFS driver https://review.opendev.org/c/openstack/cinder/+/841315 | 14:47 |
| opendevreview | Merged openstack/cinder master: Bump zstd requirement to >1.5.0.0 https://review.opendev.org/c/openstack/cinder/+/967419 | 15:11 |
| opendevreview | Merged openstack/cinder master: Doc: Improve docs for Glance Cinder Store https://review.opendev.org/c/openstack/cinder/+/970969 | 15:11 |
| f0o_ | Hi, I think I found a bug within Cinder's NFS Driver. The volume attachment's connection_info object has `options` set to null despite the volume having nfs_mount_options and nas_mount_options defined. Subsequently Nova mounts the share with kernel defaults even if those contradict the set options in cinder (such as nolock,noatime,nconnect,timeo etc) | 16:03 |
| f0o_ | https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/remotefs.py#L576-L595C61 << This seems to populate only nas_mount_options into the self.shares which is then used https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/nfs.py#L149-L150 to create the connection information (at least it looks that way to me). | 16:07 |
| f0o_ | https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/remotefs.py#L579-L581 further confuses me as it seems to expect nas_host and nas_share_path configuration as part of the volume | 16:07 |
| f0o_ | but then there's also https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/remotefs.py#L601-L604 where it seems that the options should be part of the shares config and not in nfs_mount_options nor nas_mount_options | 16:08 |
| f0o_ | so now there are 3-ish places where you seemingly can define the NFS mount options with no clear direction on which to use when or why. nfs_mount_option is the only one referenced in the documentation but it does not make it into the connection_info whatsoever | 16:09 |
| f0o_ | It seems that https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/remotefs.py#L601-L604 is the correct way of specifying NFS mount options. nas/nfs_mount_options seem to be bogus and partially misleading | 16:22 |
| f0o_ | Offtopic; is there a reason why https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/remotefs.py#L530 always uses fetch_to_raw instead of the more versatile fetch_to_volume_format (https://github.com/openstack/cinder/blob/616f134ba98adbd46277334b2d6361a522662f77/cinder/image/image_utils.py#L944) with the format being whatever the volume already is? Every | 16:38 |
| f0o_ | time I create a volume from an image I see qemu-img create a QCOW2 just to be replaced by a qemu-img convert to a RAW image (through fetch_to_raw) | 16:38 |
| opendevreview | Rajat Dhasmana proposed openstack/os-brick master: iSCSI: wait for multipathd to remove paths https://review.opendev.org/c/openstack/os-brick/+/971496 | 16:40 |
| opendevreview | Merged openstack/cinder master: NFS driver: Set volume format for snapshot operations https://review.opendev.org/c/openstack/cinder/+/943660 | 17:26 |
| opendevreview | Merged openstack/cinder master: NFS driver: Use database format in initialize_connection https://review.opendev.org/c/openstack/cinder/+/941173 | 22:19 |
| opendevreview | Merged openstack/cinder master: NFS driver: Fix driver fails to verify virtual size for Glance with Cinder/NFS https://review.opendev.org/c/openstack/cinder/+/941174 | 22:20 |
| *** agalica_ is now known as agalica | 23:59 | |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!