| *** bauzas has quit IRC | 00:39 | |
| openstackgerrit | Nikolay Starodubtsev proposed a change to stackforge/climate: Add utils to work with openstack components https://review.openstack.org/52296 | 02:39 |
|---|---|---|
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 05:06 | |
| *** chandankumar_ has joined #openstack-climate | 05:14 | |
| *** SergeyLukjanov is now known as SergeyLukjanov_a | 06:12 | |
| *** SergeyLukjanov_a is now known as SergeyLukjanov_ | 06:13 | |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 06:42 | |
| *** SergeyLukjanov is now known as SergeyLukjanov_ | 07:29 | |
| *** bauzas has joined #openstack-climate | 08:08 | |
| bauzas | morning | 08:24 |
| bauzas | Nikolay_St: you there ? | 08:27 |
| bauzas | I'm reviewing one last time https://review.openstack.org/#/c/52296/37 | 08:27 |
| bauzas | and exceptions are not yet in manager/exceptions.py | 08:27 |
| bauzas | so, I would like to know if you have time for a new patchset or we raise a bug | 08:28 |
| bauzas | Nikolay_St: what do you think of it ? | 08:28 |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 08:37 | |
| *** DinaBelova_ is now known as DinaBelova | 08:43 | |
| Nikolay_St | bauzas: hi | 08:45 |
| Nikolay_St | bauzas: just arrived at the office | 08:46 |
| Nikolay_St | bauzas: I'll do next patchset in few minutes | 08:46 |
| bauzas | ok cool | 08:51 |
| bauzas | DinaBelova: could you please review https://review.openstack.org/#/c/59109/ ? | 08:54 |
| bauzas | I updated it | 08:54 |
| DinaBelova | I'm looking at it right now | 08:54 |
| bauzas | cool thanks | 08:54 |
| bauzas | scroiset is going to work on the latest comments for the PR plugin | 08:55 |
| bauzas | incl. the Jenkins ones :) | 08:55 |
| DinaBelova | ok :) | 08:56 |
| bauzas | once Nikolay_St provides a new patchset for utils, will give +2 to it | 08:56 |
| DinaBelova | nice to hear that :) | 08:56 |
| DinaBelova | great, thnx :) | 08:56 |
| bauzas | we will still have 3 review for VR usecase, and 4 reviews left for PR | 08:57 |
| bauzas | that's still possible | 08:57 |
| Nikolay_St | bauzas: one minute please | 09:00 |
| bauzas | I can increase test coverage for the Nova filter | 09:00 |
| Nikolay_St | about what exceptions do you talk? | 09:00 |
| bauzas | I'm just saying that exceptions are defined in climate/exceptions.py in the utls review | 09:03 |
| bauzas | they need to be created in climate/manager/exceptions.py | 09:03 |
| bauzas | I have to go to a meeting | 09:03 |
| bauzas | 1 hour around | 09:03 |
| bauzas | see the patch that has been merged about Exceptions | 09:04 |
| bauzas | you'll understand | 09:04 |
| bauzas | thanks | 09:04 |
| bauzas | brb in 1g | 09:04 |
| bauzas | 1h | 09:04 |
| openstackgerrit | Nikolay Starodubtsev proposed a change to stackforge/climate: Add utils to work with openstack components https://review.openstack.org/52296 | 09:15 |
| Nikolay_St | bauzas: please with +2 | 09:25 |
| Nikolay_St | bauzas: please wait | 09:25 |
| Nikolay_St | that what I mean | 09:25 |
| openstackgerrit | Nikolay Starodubtsev proposed a change to stackforge/climate: Add utils to work with openstack components https://review.openstack.org/52296 | 09:43 |
| Nikolay_St | bauzas: it's okay with +2 now | 09:44 |
| bauzas | back from meeting | 10:01 |
| bauzas | ok, looking at your patch | 10:01 |
| openstackgerrit | Nikolay Starodubtsev proposed a change to stackforge/climate: Implement keystone trust support https://review.openstack.org/48002 | 10:03 |
| openstackgerrit | Nikolay Starodubtsev proposed a change to stackforge/climate: Implement basic plugin for VM management https://review.openstack.org/49142 | 10:03 |
| DinaBelova | bauzas, we believe it's ok with utils and I see you gave +2 to it. We are running final testing now with Nick | 10:10 |
| DinaBelova | if last checking will show everything ok, I'll give my +2/A | 10:10 |
| bauzas | I gave +2 because I checked the diffs in between patchsets, and nothing is broken between those | 10:10 |
| DinaBelova | bauzas, I know :) thanks | 10:11 |
| bauzas | the exceptions are correcty located, either in the global ones for the API, or in the Manager ones for the ones raised by Manager | 10:11 |
| bauzas | the try:except: clause is correct | 10:11 |
| DinaBelova | we are just running now final full process checking for VM use case | 10:11 |
| DinaBelova | to be sure everything is ok with utils | 10:11 |
| bauzas | even if I think the text would have been a bit better :) | 10:11 |
| DinaBelova | :) | 10:11 |
| bauzas | but anyhow, I'm good to go | 10:12 |
| DinaBelova | ok | 10:12 |
| bauzas | I'm rewriting the filter queries as per your comment | 10:12 |
| bauzas | is Zuul broken ? | 10:16 |
| bauzas | can't see https://review.openstack.org/#/c/52296/ in the pipe | 10:16 |
| bauzas | even when asking for a recheck | 10:16 |
| DinaBelova | bauzas, don't know... | 10:18 |
| DinaBelova | I see that too.. | 10:18 |
| bauzas | http://status.openstack.org/zuul/ | 10:20 |
| bauzas | oops | 10:20 |
| bauzas | Queue lengths: 436 events, 4 results. | 10:20 |
| DinaBelova | :D | 10:21 |
| openstackgerrit | Sergey Lukjanov proposed a change to stackforge/climate: Fix malformed plugins table https://review.openstack.org/68061 | 10:30 |
| DinaBelova | bauzas, it seems like we found small degradation bug in keystone utils connected with trusts | 10:32 |
| DinaBelova | wait a second | 10:32 |
| DinaBelova | some patch sets ago we had no it :D | 10:32 |
| bauzas | uh | 10:34 |
| bauzas | ok, moving into -1 | 10:36 |
| DinaBelova | as you wish :D | 10:37 |
| bauzas | I trust you anyway | 10:37 |
| DinaBelova | :D | 10:37 |
| bauzas | ideally, if you find why it fails, code an unittest associated with :) | 10:37 |
| bauzas | (if possible of course ;) ) | 10:37 |
| DinaBelova | i hate word 'trust' already | 10:37 |
| bauzas | :p | 10:37 |
| DinaBelova | that's not really connected with some bug | 10:38 |
| DinaBelova | but with args pssed to keystoneclient | 10:38 |
| DinaBelova | passed* | 10:38 |
| bauzas | anyway, before changing from +2 to -1, are you sure it's related to this patch ? | 10:38 |
| openstackgerrit | Sylvain Bauza proposed a change to stackforge/climate: Filter DB queries per project_id https://review.openstack.org/59109 | 10:40 |
| DinaBelova | bauzas, can you git ve us several minutes to be sure? | 10:40 |
| DinaBelova | give* | 10:40 |
| bauzas | sure of course | 10:40 |
| bauzas | I'm rebasing one patch which failed to merge | 10:41 |
| DinaBelova | ok | 10:45 |
| *** SergeyLukjanov is now known as SergeyLukjanov_ | 11:15 | |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 11:19 | |
| *** DinaBelova is now known as DinaBelova_ | 12:37 | |
| *** SergeyLukjanov is now known as SergeyLukjanov_a | 13:02 | |
| *** SergeyLukjanov_a is now known as SergeyLukjanov_ | 13:03 | |
| *** DinaBelova_ is now known as DinaBelova | 13:07 | |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 13:09 | |
| bauzas | folks, please read -dev ML | 13:22 |
| bauzas | DinaBelova: you'll find that I'm discussing with Phil Day about reservations and dedicated instances | 13:22 |
| bauzas | DinaBelova: we're now visible, and that definitely forces us to deliver 0.1 asap | 13:23 |
| bauzas | DinaBelova: particularly as both plugins are not yet ready | 13:23 |
| bauzas | DinaBelova: in trunk I mean | 13:23 |
| DinaBelova | bauzas, I've seen that ml conversation | 13:29 |
| bauzas | all the concepts are mixed | 13:36 |
| bauzas | but that's interesting | 13:36 |
| bauzas | I still have one mail to reply | 13:36 |
| DinaBelova | and we have complete trash with keystone now... | 13:37 |
| DinaBelova | still debugging | 13:37 |
| bauzas | ok | 13:38 |
| *** YorikSar has quit IRC | 13:38 | |
| bauzas | I've seen all the -1 :( | 13:38 |
| bauzas | about VT | 13:39 |
| bauzas | VR | 13:39 |
| *** YorikSar has joined #openstack-climate | 13:40 | |
| bauzas | oh, the py27 are only due to the fact that Manager exceptions have changed | 13:40 |
| bauzas | py27 check error, I mean | 13:41 |
| DinaBelova | yep, I see that | 13:42 |
| DinaBelova | but we have problems with trusts now | 13:42 |
| DinaBelova | strange moment is | 13:43 |
| DinaBelova | that this piece of code has not changed for a while | 13:43 |
| DinaBelova | so now we are working on our testing lab | 13:43 |
| DinaBelova | to find out reason for that | 13:43 |
| *** YorikSar has quit IRC | 13:51 | |
| *** YorikSar has joined #openstack-climate | 13:52 | |
| bauzas | oh ok | 13:58 |
| DinaBelova | it seems that Nick had old devstack lab | 14:01 |
| DinaBelova | if so | 14:01 |
| DinaBelova | i'm going to become crazy :D | 14:01 |
| bauzas | :) | 14:03 |
| bauzas | I was Ops for 8 years, I'm glad having this experience for managing pressure :) | 14:03 |
| DinaBelova | of course, there were some more moments there | 14:04 |
| DinaBelova | including some comments Nick fixed and it turned out that these lines were still needed :) | 14:04 |
| bauzas | well, keep calm, everything will be cool :) | 14:04 |
| DinaBelova | yeeep :) | 14:05 |
| bauzas | DinaBelova: btw. I fixed your comment here : https://review.openstack.org/#/c/59109/ | 14:09 |
| bauzas | if you're happy with this code... :) | 14:09 |
| openstackgerrit | Sylvain Bauza proposed a change to stackforge/climate: Fix coverage for add_computehost with ID of host https://review.openstack.org/62685 | 14:09 |
| bauzas | (I'm not doing lobbying here... :D ) | 14:10 |
| *** YorikSar has quit IRC | 14:10 | |
| DinaBelova | I loved your code even from previous ps :) | 14:11 |
| bauzas | you saw the main thing, about the is_admin flag autopopulated ? | 14:12 |
| bauzas | I put the code at the API level, when creating context, because it was for me the best place for it | 14:12 |
| DinaBelova | yes, I saw that | 14:13 |
| DinaBelova | I'm ok with that | 14:13 |
| bauzas | ok | 14:13 |
| DinaBelova | also it seems that finally we fixed all f*ckup moments with code | 14:14 |
| DinaBelova | Nick will fix ly27 errors | 14:14 |
| openstackgerrit | Swann Croiset proposed a change to stackforge/climate: Physical host reservation (DB related things) https://review.openstack.org/64705 | 14:15 |
| DinaBelova | and we'll see WORKING 3 changes from him | 14:15 |
| bauzas | DinaBelova: cool | 14:19 |
| openstackgerrit | Nikolay Starodubtsev proposed a change to stackforge/climate: Implement keystone trust support https://review.openstack.org/48002 | 14:30 |
| openstackgerrit | Nikolay Starodubtsev proposed a change to stackforge/climate: Add utils to work with openstack components https://review.openstack.org/52296 | 14:30 |
| openstackgerrit | Nikolay Starodubtsev proposed a change to stackforge/climate: Implement basic plugin for VM management https://review.openstack.org/49142 | 14:30 |
| *** SergeyLukjanov is now known as SergeyLukjanov_a | 14:42 | |
| *** SergeyLukjanov_a is now known as SergeyLukjanov_ | 14:43 | |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 14:50 | |
| *** bauzas has quit IRC | 14:51 | |
| *** bauzas has joined #openstack-climate | 14:53 | |
| openstackgerrit | Swann Croiset proposed a change to stackforge/climate: Physical host reservation plugin https://review.openstack.org/54285 | 15:14 |
| DinaBelova | bauzas, scroiset has published some comment to your code https://review.openstack.org/#/c/59109/4/climate/db/sqlalchemy/api.py | 15:42 |
| DinaBelova | And i'm quite interested in your unswer | 15:42 |
| DinaBelova | may you please take a look? | 15:42 |
| scroiset | DinaBelova: FYI sbauza will come back soon IIUC | 15:44 |
| DinaBelova | scroiset, ok. thanks | 15:45 |
| scroiset | DinaBelova: I'm also interested to heard his answer :) | 15:45 |
| DinaBelova | :D | 15:45 |
| scroiset | DinaBelova: I'm looking your review about db things ... breaking my brain .. you maybe right but not yet sure | 15:46 |
| DinaBelova | scroiset I just think that should go after first part without any else as i see previous variant | 15:49 |
| DinaBelova | just see diff https://review.openstack.org/#/c/64705/5..6/climate/db/sqlalchemy/api.py | 15:51 |
| DinaBelova | that time it was | 15:51 |
| DinaBelova | for query in queries: work_with column_if_if_is | 15:51 |
| DinaBelova | and for query in queries: work_with_extra_filter | 15:52 |
| bauzas | well, this is a very good question :) | 15:52 |
| DinaBelova | bauzas :D | 15:52 |
| bauzas | speaking about https://review.openstack.org/#/c/59109/4/climate/db/sqlalchemy/api.py | 15:52 |
| bauzas | I would say I placed here for 2 reasons : | 15:52 |
| bauzas | 1. Olso/Nova/Cinder allowed this parameter to be passed | 15:53 |
| bauzas | 2. That makes sense | 15:53 |
| bauzas | :D | 15:53 |
| bauzas | ie. there are 2 possibilities for selecting an object with an empty tenant_id | 15:54 |
| DinaBelova | bauzas, we don | 15:54 |
| bauzas | either we consider it should be shown to the user | 15:54 |
| bauzas | or, we say that no project_id means this is a "shared" resource, which can be shown | 15:54 |
| DinaBelova | *don't say that's no logic here. We just say that param is used now nowhere* | 15:55 |
| DinaBelova | we are about 'allow_none' stuff | 15:55 |
| scroiset | I propose to remove this stuff until we need it .. | 15:57 |
| bauzas | ok for removing it, but in case we want it, we should enable it as it is | 15:57 |
| *** SergeyLukjanov is now known as SergeyLukjanov_ | 15:57 | |
| DinaBelova | bauzas, I may lost this point... May you explain how allow_none might be used now? | 15:57 |
| DinaBelova | I'm just a little bit crazy after today :) | 15:58 |
| bauzas | this is not in use now :) | 15:58 |
| bauzas | I provided it, because I wanted the method to be as generic as possible | 15:58 |
| scroiset | it's for future use cases ;) | 15:59 |
| DinaBelova | bauzas, ok, so may you remove it now? we'll keep in mind such possibility if needed? | 15:59 |
| bauzas | ok :) | 15:59 |
| scroiset | +1 | 15:59 |
| DinaBelova | I just think this change is needed with stuff having need in it | 15:59 |
| DinaBelova | scroiset, as for https://review.openstack.org/#/c/64705/5..6/climate/db/sqlalchemy/api.py - I think we may need some help to find out who's right | 16:01 |
| DinaBelova | bauzas, help us :D | 16:01 |
| DinaBelova | i need to go afk now | 16:01 |
| DinaBelova | will be here in an hour | 16:01 |
| *** DinaBelova is now known as DinaBelova_ | 16:02 | |
| openstackgerrit | Nikolay Starodubtsev proposed a change to stackforge/climate: Implement keystone trust support https://review.openstack.org/48002 | 16:06 |
| openstackgerrit | Nikolay Starodubtsev proposed a change to stackforge/climate: Add utils to work with openstack components https://review.openstack.org/52296 | 16:06 |
| openstackgerrit | Nikolay Starodubtsev proposed a change to stackforge/climate: Implement basic plugin for VM management https://review.openstack.org/49142 | 16:06 |
| Nikolay_St | bauzas: changes which we did in utils was help from Yuri Taraday - previous version was trash and didn't work | 16:09 |
| *** Nikolay_St has quit IRC | 16:09 | |
| bauzas | ok | 16:10 |
| *** chandankumar_ has quit IRC | 16:10 | |
| openstackgerrit | Sylvain Bauza proposed a change to stackforge/climate: Filter DB queries per project_id https://review.openstack.org/59109 | 16:21 |
| *** DinaBelova_ is now known as DinaBelova | 16:33 | |
| openstackgerrit | Swann Croiset proposed a change to stackforge/climate: Physical host reservation plugin (lease update) https://review.openstack.org/67121 | 16:38 |
| *** YorikSar has joined #openstack-climate | 16:44 | |
| *** bauzas has quit IRC | 16:45 | |
| *** DinaBelova is now known as DinaBelova_ | 16:58 | |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 17:22 | |
| *** DinaBelova_ is now known as DinaBelova | 17:45 | |
| openstackgerrit | A change was merged to stackforge/climate: Physical host reservation (manager and base plugin) https://review.openstack.org/64706 | 18:11 |
| *** DinaBelova is now known as DinaBelova_ | 20:08 | |
| *** bauzas has joined #openstack-climate | 20:08 | |
| openstackgerrit | Jenkins proposed a change to stackforge/climate: Updated from global requirements https://review.openstack.org/68254 | 20:30 |
| openstackgerrit | A change was merged to stackforge/climate: Fix malformed plugins table https://review.openstack.org/68061 | 21:43 |
| *** SergeyLukjanov is now known as SergeyLukjanov_a | 22:50 | |
| *** SergeyLukjanov_a is now known as SergeyLukjanov_ | 22:51 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!