| *** openstack has joined #openstack-climate | 00:02 | |
| *** chandankumar_ has joined #openstack-climate | 02:29 | |
| *** chandankumar_ has quit IRC | 02:31 | |
| *** frankbutt has joined #openstack-climate | 04:20 | |
| *** frankbutt has left #openstack-climate | 04:20 | |
| *** Nikolay_St has joined #openstack-climate | 07:25 | |
| *** f_rossigneux has quit IRC | 07:36 | |
| *** f_rossigneux has joined #openstack-climate | 07:37 | |
| *** DinaBelova_ is now known as DinaBelova | 08:53 | |
| DinaBelova | scroiset, f_rossigneux we still have two unmerged changes important for 0.1 | 08:55 |
|---|---|---|
| DinaBelova | https://review.openstack.org/#/c/49142/ | 08:55 |
| DinaBelova | and https://review.openstack.org/#/c/63097/ | 08:55 |
| DinaBelova | I will really appreciate your review - because I suppose Sylvain will WFH today and I do not know if he will take a look on it | 08:56 |
| DinaBelova | these changes are separating us from 0.1 | 08:57 |
| scroiset | DinaBelova: I'll review these asap | 09:00 |
| DinaBelova | scroiset, thank you | 09:01 |
| DinaBelova | scroiset, 'cause after all changes will be merged | 09:02 |
| DinaBelova | I insist on at least one day code freeze | 09:02 |
| DinaBelova | with full testing | 09:02 |
| DinaBelova | for VM and PH use cases | 09:03 |
| DinaBelova | this means we'll have release hopefully on Thursday | 09:03 |
| scroiset | yep, sounds good | 09:04 |
| DinaBelova | f_rossigneux, also I'm quite worried about these stats: http://russellbryant.net/openstack-stats/climate-reviewers-60.txt | 09:05 |
| scroiset | ... I saw | 09:05 |
| DinaBelova | as you see last 60 days you have no reviews at all | 09:05 |
| DinaBelova | f_rossigneux, I want to remind you that being core team member means working on Climate not only writing code | 09:06 |
| DinaBelova | but also reviewin it | 09:06 |
| DinaBelova | scroiset and Nikolay_St - you at least are doing that, although I prefer better stats, but still | 09:06 |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 09:08 | |
| scroiset | DinaBelova: not at full time on climate you know, I'll try to be more present if my boss wish it ;) | 09:16 |
| DinaBelova | scroiset :D | 09:17 |
| DinaBelova | I know that quite good | 09:17 |
| DinaBelova | that's why I'm ok with your and Nick stats | 09:17 |
| DinaBelova | I just want f_rossigneux also to spend some timeon it | 09:17 |
| DinaBelova | otherwise I see no other choice to exclude f_rossigneux from core team - he does incredible job, but I believe, that core team member should work on reviewing too | 09:18 |
| f_rossigneux | I am not sure it is relevant that I am in the review team. I have not a lot of time to do code reviewing. I can contribute, ok, but my primary job is not code reviewing. During the next months, I plan to work on scheduling improvements, standby modes, billing, and I want also to write a paper on Kwapi, and contribute to a chapter of a white book on Cloud Computing. So as you can see, I can't spend a lot of time on code review | 09:28 |
| f_rossigneux | ing if I try to achieve my goals. | 09:28 |
| DinaBelova | f_rossigneux, ok, understood | 09:29 |
| DinaBelova | so you will have no objections if you'll be removed from core team because of lack of time for reviewing? | 09:30 |
| f_rossigneux | It's ok for me. | 09:30 |
| DinaBelova | ok | 09:32 |
| openstackgerrit | Dina Belova proposed a change to stackforge/climate: Fix testing env variables and testing directory https://review.openstack.org/69574 | 10:36 |
| *** DinaBelova is now known as DinaBelova_ | 10:58 | |
| *** DinaBelova_ is now known as DinaBelova | 11:18 | |
| *** SergeyLukjanov is now known as SergeyLukjanov_a | 11:19 | |
| *** SergeyLukjanov_a is now known as SergeyLukjanov | 11:19 | |
| scroiset | one review done.. some concerns about tests. see my comments inline. I'll (try) test the nova extension now | 11:29 |
| DinaBelova | scroiset, I see them | 11:29 |
| DinaBelova | I wanted to ask you about https://review.openstack.org/#/c/49142/48/climate/utils/openstack/nova.py | 11:29 |
| DinaBelova | I mean your comments about 'bypass_url to set management_url auth_token to set .. auth_token' | 11:29 |
| DinaBelova | Are you sure that functionality is in novalient 2.15.0? | 11:30 |
| DinaBelova | not in master? | 11:30 |
| scroiset | I just checked the master .. indeed | 11:30 |
| DinaBelova | 'cause I'm pretty sure that there is no auth_token in master | 11:30 |
| DinaBelova | that was the main problem here | 11:30 |
| DinaBelova | and it was solved this way - like heat guys do that | 11:31 |
| DinaBelova | sorry, I meant '' no auth_token in 2.15.0"" | 11:31 |
| DinaBelova | as for other your comments - quite agree with you | 11:32 |
| scroiset | why are we adherent to 2.15.0 .. don't remember :) | 11:33 |
| scroiset | .. this is the last release I guess | 11:33 |
| DinaBelova | cause that's global req now | 11:33 |
| DinaBelova | and that's last release | 11:33 |
| DinaBelova | we won't pass gate without same reqs as in global ones | 11:33 |
| scroiset | ok, so feel free to ignore this part of my comments .. and let's fix as soon as it's released with our need | 11:34 |
| DinaBelova | scroiset, agreed | 11:34 |
| DinaBelova | Nikolay_St. will you fix other comments? | 11:34 |
| scroiset | DinaBelova: openstack is so fast evolving. We are really near the trenches with climate :D | 11:38 |
| DinaBelova | :D | 11:38 |
| DinaBelova | yep :) | 11:38 |
| DinaBelova | also we are reason of new keystoneclient release | 11:39 |
| DinaBelova | and I hope soon for novaclient :D | 11:39 |
| openstackgerrit | Dina Belova proposed a change to stackforge/climate: Port to oslo.messaging https://review.openstack.org/57880 | 12:47 |
| DinaBelova | scroiset, please take a look on https://review.openstack.org/#/c/69574/ - I found smth not really nice in our testing env variables :) | 12:49 |
| *** bauzas has joined #openstack-climate | 12:57 | |
| openstackgerrit | A change was merged to stackforge/climate: Fix testing env variables and testing directory https://review.openstack.org/69574 | 13:11 |
| *** chandankumar has joined #openstack-climate | 13:16 | |
| bauzas | hi all | 13:20 |
| DinaBelova | bauzas, hello | 13:23 |
| bauzas | DinaBelova: would it be possible to review https://review.openstack.org/#/c/68927/ | 13:23 |
| bauzas | I'm currently deploying the latest patch from virtual instances | 13:24 |
| bauzas | in order to test it | 13:24 |
| bauzas | even if there are -1 on it | 13:24 |
| DinaBelova | bauzas, great | 13:24 |
| bauzas | making sure we won't forget any more obvious things | 13:24 |
| DinaBelova | -1 is mostly cosmetic one, so we really may test major things | 13:24 |
| DinaBelova | bauzas, thank you | 13:25 |
| bauzas | indded | 13:25 |
| DinaBelova | bauzas, I'm fighting with oslo.messaging after all hosts related things have been merged | 13:25 |
| DinaBelova | it's not simple :D | 13:25 |
| bauzas | argh | 13:25 |
| bauzas | why ? | 13:26 |
| DinaBelova | I'm testing PR use case directly with oslo.messaging | 13:26 |
| bauzas | any needed help , | 13:26 |
| bauzas | what's the problem ? | 13:26 |
| DinaBelova | it seems that hack with taking methods from host plugin via managrs getattr | 13:26 |
| DinaBelova | is not really consumed by oslo.messaging | 13:27 |
| bauzas | oh I see | 13:27 |
| DinaBelova | I'm trying to locate problem now | 13:27 |
| bauzas | indeed, I can help you | 13:27 |
| bauzas | the previous openstack.common thing was doing an explicit getattr() call | 13:27 |
| bauzas | so, that's why I chose to implement __getattr___ | 13:28 |
| DinaBelova | yep, I'm investigating how that's going on now | 13:28 |
| DinaBelova | and I believe it's somehow getattr now too | 13:28 |
| bauzas | I was thinking there was a dispatcher | 13:28 |
| DinaBelova | oh, it seems that now it is | 13:28 |
| bauzas | lemme find the call itself with the previous code | 13:28 |
| bauzas | maybe you could find the piece by analoguing | 13:29 |
| DinaBelova | http://paste.openstack.org/show/T0nvixkhxovpOO71qAyk/ | 13:29 |
| DinaBelova | ok. tnx | 13:29 |
| DinaBelova | I believe this problem is some kind of mixture of getattr/oslo.messaging/my wrappers | 13:30 |
| bauzas | got it | 13:30 |
| bauzas | https://github.com/stackforge/climate/blob/master/climate/openstack/common/rpc/dispatcher.py#L172 | 13:31 |
| bauzas | the call was quite simple | 13:31 |
| bauzas | so we have to find out how the call is done with the new oslo.messaging stuff | 13:32 |
| bauzas | maybe dhellman could help | 13:33 |
| DinaBelova | bauzas also I was thinking there cannot be taken method from physical host plugin | 13:33 |
| DinaBelova | although I was not right | 13:33 |
| DinaBelova | it's taken correctly | 13:33 |
| DinaBelova | so problem is not there for sure | 13:33 |
| bauzas | what pdb is saying ? | 13:33 |
| bauzas | when you got thru the manager service ? | 13:34 |
| bauzas | are you sure the __getattr__ method is called ? | 13:34 |
| DinaBelova | http://paste.openstack.org/show/sCtvRsFVOcgbfNo0nULI/ | 13:34 |
| DinaBelova | that's pdb in my methods wrappers | 13:35 |
| DinaBelova | server side | 13:35 |
| DinaBelova | <bound method PhysicalHostPlugin.list_computehosts of <climate.plugins.oshosts.host_plugin.PhysicalHostPlugin object at 0x33fb190>> | 13:35 |
| DinaBelova | I suppose that means I have this method here | 13:35 |
| bauzas | correct | 13:35 |
| bauzas | looking at your traceback | 13:36 |
| *** chandankumar has quit IRC | 13:36 | |
| bauzas | so there is still a dispatch method doing an explicit getattr() | 13:36 |
| DinaBelova | that might be problem of https://github.com/stackforge/climate/blob/master/climate/utils/service.py#L46 | 13:36 |
| DinaBelova | I suppose this decorator has been envolved in trace | 13:37 |
| bauzas | the context ! | 13:38 |
| bauzas | that's the main difference ! | 13:38 |
| bauzas | compare both calls : | 13:38 |
| DinaBelova | yep, here it is | 13:38 |
| bauzas | http://paste.openstack.org/show/T0nvixkhxovpOO71qAyk/ | 13:38 |
| bauzas | https://github.com/stackforge/climate/blob/master/climate/openstack/common/rpc/dispatcher.py#L172 | 13:38 |
| DinaBelova | that's strange | 13:39 |
| DinaBelova | moment | 13:39 |
| scroiset | hi bauzas ! | 13:40 |
| bauzas | scroiset: :) | 13:40 |
| bauzas | scroiset: 4 days without coding was too long for me ;) | 13:41 |
| scroiset | hehe | 13:41 |
| DinaBelova | bauzas, scroiset just one question | 13:43 |
| DinaBelova | https://github.com/stackforge/climate/blob/master/climate/plugins/oshosts/host_plugin.py#L236 | 13:43 |
| DinaBelova | how do you use that decorator for sure? | 13:43 |
| DinaBelova | I truly believe this decorator might be removed without any harm | 13:44 |
| DinaBelova | it's no more used for lease_create, etc. things | 13:44 |
| bauzas | well, the previous implem was waiting for a context :) | 13:44 |
| bauzas | oh, understood your mistake :D | 13:45 |
| bauzas | because I reviewed long time ago the patch for oslo.messaging | 13:45 |
| bauzas | yes, we no longer need to use export_context | 13:45 |
| DinaBelova | ok, I'll provide this change | 13:46 |
| DinaBelova | removing export_context | 13:46 |
| bauzas | but as you removed them from the manager code itself without merging it from the physical side... :) | 13:46 |
| bauzas | here is why it failed | 13:46 |
| bauzas | because now this code is nonsense | 13:46 |
| DinaBelova | yep | 13:46 |
| bauzas | sorry to have missed that | 13:46 |
| bauzas | it was in my mind, without recalling it | 13:46 |
| bauzas | so, it should work now | 13:47 |
| DinaBelova | nah, everything is nice | 13:47 |
| DinaBelova | I was just thinking am I crazy or not | 13:47 |
| DinaBelova | if I see that mistake | 13:47 |
| DinaBelova | :D | 13:47 |
| openstackgerrit | Dina Belova proposed a change to stackforge/climate: Port to oslo.messaging https://review.openstack.org/57880 | 14:00 |
| DinaBelova | ^_^ | 14:00 |
| *** chandankumar has joined #openstack-climate | 14:03 | |
| *** chandankumar has quit IRC | 14:09 | |
| bauzas | ^_^ | 14:17 |
| *** chandankumar has joined #openstack-climate | 14:22 | |
| *** DinaBelova is now known as DinaBelova_ | 14:26 | |
| *** chandankumar has quit IRC | 14:35 | |
| *** DinaBelova_ is now known as DinaBelova | 14:37 | |
| bauzas | DinaBelova: dammit, can't unshelve my instance | 14:55 |
| DinaBelova | bauzas, what's hapanning? | 14:55 |
| bauzas | although it does work within Climate as I can see the call | 14:55 |
| bauzas | DinaBelova: dunno, have to deep further | 14:55 |
| DinaBelova | 0_0 | 14:55 |
| bauzas | that's purely nova | 14:56 |
| bauzas | I saw the instance status as "unshelving" | 14:56 |
| DinaBelova | so Nova is not unshelving, although Climate sends this request to it? | 14:56 |
| bauzas | so that's enough for me | 14:56 |
| DinaBelova | really interesting | 14:56 |
| bauzas | Nova was unshelving, but it seems it failed suddently | 14:56 |
| bauzas | my whole lab is running on my PC | 14:56 |
| bauzas | it raised up to 13.00 load avg. | 14:57 |
| DinaBelova | may you find some traces in nova-compute or nova-api logs? | 14:57 |
| DinaBelova | It really may have not enough resources or smth | 14:57 |
| bauzas | unfortunately, I had no looked at the traces and screen didn't kept the most interesting ones | 14:57 |
| bauzas | indeed | 14:57 |
| bauzas | probably | 14:57 |
| bauzas | something went wrong during the unshelving, but can't say wha | 14:58 |
| bauzas | I was about testing the lease ending | 14:58 |
| bauzas | did you tested out ? | 14:58 |
| DinaBelova | yep | 14:58 |
| bauzas | ok | 14:59 |
| DinaBelova | stop | 14:59 |
| *** chandankumar has joined #openstack-climate | 14:59 | |
| DinaBelova | lease was ending? | 14:59 |
| DinaBelova | or starting? | 14:59 |
| bauzas | no no | 14:59 |
| DinaBelova | unshelving should be on starting | 14:59 |
| bauzas | I was planning to end it | 14:59 |
| DinaBelova | oh | 14:59 |
| DinaBelova | ok | 14:59 |
| bauzas | yep | 14:59 |
| bauzas | the thing is : | 14:59 |
| bauzas | I tested the start | 14:59 |
| bauzas | and saw that Climate works | 14:59 |
| bauzas | but, as Nova hasn't properly created the instance, I can't test the end of the lease | 15:00 |
| bauzas | that's it | 15:00 |
| DinaBelova | I got your point | 15:00 |
| bauzas | albeit it's a good thing for testing Climate reliability about VMs :) | 15:00 |
| DinaBelova | there might be small hack here | 15:01 |
| DinaBelova | you may boot simple Vm | 15:01 |
| bauzas | of course, I can manage it | 15:01 |
| bauzas | yep | 15:01 |
| DinaBelova | and then hack DB record | 15:01 |
| DinaBelova | for reservation | 15:01 |
| bauzas | that was my plan :) | 15:01 |
| DinaBelova | ;) | 15:01 |
| bauzas | or, I can even go thru a lease create | 15:01 |
| DinaBelova | everybody loves dirty hacks :) | 15:01 |
| bauzas | Nova will just say 'eh dude, your VM is already unshelved, nah ?' | 15:02 |
| bauzas | both will work | 15:02 |
| DinaBelova | :) | 15:02 |
| *** chandankumar has quit IRC | 15:06 | |
| SergeyLukjanov | hey folks | 15:26 |
| SergeyLukjanov | how is your 0.1 preparations? | 15:26 |
| DinaBelova | SergeyLukjanov, Nick is fixing scroiset's comments now | 15:32 |
| DinaBelova | while bauzas is testing virtual use case | 15:32 |
| DinaBelova | cause scroiset's comments were mostly cosmetic and should not influence on Climate working | 15:33 |
| SergeyLukjanov | cool | 15:38 |
| SergeyLukjanov | looks like you'll be able to release this week | 15:38 |
| DinaBelova | SergeyLukjanov :D | 15:38 |
| DinaBelova | hope so | 15:39 |
| DinaBelova | I'm thinking about Thursday :D if we'll have everything merged + 1-2 days on full testing | 15:39 |
| DinaBelova | we have not much functionality now, so one testing day might be enough | 15:40 |
| *** SergeyLukjanov is now known as SergeyLukjanov_ | 16:09 | |
| *** DinaBelova is now known as DinaBelova_ | 16:14 | |
| *** chandankumar has joined #openstack-climate | 16:45 | |
| *** DinaBelova_ is now known as DinaBelova | 17:00 | |
| *** chandankumar has quit IRC | 17:09 | |
| *** chandankumar has joined #openstack-climate | 17:15 | |
| *** chandankumar has quit IRC | 17:34 | |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 17:36 | |
| *** DinaBelova is now known as DinaBelova_ | 18:05 | |
| *** DinaBelova_ is now known as DinaBelova | 18:33 | |
| *** DinaBelova is now known as DinaBelova_ | 20:47 | |
| *** SergeyLukjanov is now known as SergeyLukjanov_ | 21:59 | |
| *** openstack has joined #openstack-climate | 23:03 | |
| *** bauzas has quit IRC | 23:19 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!