| *** Nikolay_St has joined #openstack-climate | 04:57 | |
| *** YorikSar has quit IRC | 07:24 | |
| *** YorikSar has joined #openstack-climate | 08:04 | |
| *** bauzas has joined #openstack-climate | 08:07 | |
| bauzas | DinaBelova: you there ? | 09:49 |
|---|---|---|
| bauzas | DinaBelova: YorikSar: I was writing the unittests for Pecan and I thought about something related to conductors | 09:52 |
| bauzas | DinaBelova: YorikSar: as I need to mockpatch all the rpc calls, it should be definitely easier if we would be using conductors instead of the manager for placing calls to the DB | 09:53 |
| bauzas | DinaBelova: YorikSar: for CRUD lease/host I mean | 09:53 |
| bauzas | DinaBelova: YorikSar: and as conductors have a local mode (not RPC) we could be having real functional tests without needing Rabbitmq | 09:54 |
| bauzas | DinaBelova: YorikSar: and that would ease a lot the writing for unittests | 09:54 |
| YorikSar | bauzas: Hi | 09:56 |
| YorikSar | bauzas: I don't think that introducing whole conductor just for testing is a good way. | 09:57 |
| bauzas | YorikSar: of course, I'm just saying that's another pro for it | 09:58 |
| YorikSar | bauzas: If you need some shortcut for testing, you can just mock call() and cast() methods... | 09:58 |
| YorikSar | bauzas: Oh, look, there's a fake driver for oslo.messaging. You can use that for testing. | 09:59 |
| bauzas | for sure | 09:59 |
| bauzas | oh | 09:59 |
| bauzas | ok, let me think about it | 09:59 |
| bauzas | because that's quite ugly to monkeypatch | 09:59 |
| YorikSar | bauzas: I think, it'd be great if you investigate how it's going to look to use it for testing. | 10:00 |
| *** saju_m has joined #openstack-climate | 10:05 | |
| bauzas | YorikSar: the main conceptual issue I'm currently dealing with is that Pecan provides a way to perform *functional* tests | 10:06 |
| bauzas | end-to-end I mean | 10:06 |
| YorikSar | bauzas: How is that an issue? Sounds like a feature to me :) | 10:07 |
| bauzas | YorikSar: so, at the moment, I dealt with patching remote objects instead | 10:07 |
| bauzas | YorikSar: well, anyway, I'll provide a patchset for it, feel free to review it and comment :) | 10:08 |
| YorikSar | bauzas: Ok :) | 10:08 |
| YorikSar | bauzas: btw, I didn't have a chance to look at your new patchset fro Pecan migration. | 10:11 |
| YorikSar | bauzas: I'll try to find some time today. | 10:11 |
| *** saju_m has quit IRC | 10:18 | |
| *** saju_m has joined #openstack-climate | 10:31 | |
| bauzas | YorikSar: no pb | 10:35 |
| bauzas | YorikSar: I took most of your comments | 10:35 |
| *** saju_m has quit IRC | 10:54 | |
| *** Nikolay_St has quit IRC | 10:58 | |
| bauzas | YorikSar: still there ? | 11:08 |
| bauzas | DinaBelova: you too ? | 11:08 |
| YorikSar | bauzas: yep | 11:09 |
| bauzas | YorikSar: so I tested out the fake driver for oslo.messaging | 11:10 |
| bauzas | YorikSar: quite cool | 11:10 |
| bauzas | YorikSar: but that requires to load a Manager | 11:10 |
| YorikSar | bauzas: Just like conductor would require. | 11:10 |
| bauzas | YorikSar: so, I think I'll make use of mock objects per need | 11:10 |
| bauzas | YorikSar: indeed | 11:11 |
| bauzas | YorikSar: at the difference this is not a separate thread | 11:11 |
| bauzas | YorikSar: even a process | 11:11 |
| bauzas | YorikSar: anyway, thanks for providing me pointer around it, will still make use of mock object for direct calls | 11:12 |
| bauzas | YorikSar: as Tempest testsuite is going to be implemented soon | 11:12 |
| DinaBelova | щ. | 11:17 |
| DinaBelova | o/ | 11:17 |
| openstackgerrit | Dina Belova proposed a change to stackforge/climate: Fix REST API docs https://review.openstack.org/76493 | 11:30 |
| openstackgerrit | Dina Belova proposed a change to stackforge/climate: Fix work with new keystoneclient master https://review.openstack.org/78965 | 11:35 |
| *** cmart has joined #openstack-climate | 12:05 | |
| *** pafuent has joined #openstack-climate | 14:05 | |
| *** pcargnel has joined #openstack-climate | 14:25 | |
| pcargnel | Dina: About https://review.openstack.org/#/c/79452/, your proposal is to add a max number of retries to the current proposal or to replace the timeout with retries? | 14:27 |
| DinaBelova | I was about also adding number of retries | 14:28 |
| DinaBelova | like wait timeout -> try 1 -> try 2 -> try 3 ... -> try n | 14:28 |
| DinaBelova | or that process will be endless :( | 14:28 |
| DinaBelova | if there is smth with keystone | 14:29 |
| DinaBelova | I'm ok with your proposal, but please add max number of retries | 14:29 |
| pcargnel | Clear, but the timeout function will cancel the execution after 5 seconds right? Am I missing something? | 14:32 |
| DinaBelova | oh. | 14:33 |
| DinaBelova | sorry | 14:33 |
| DinaBelova | it looks like I was stupid :) | 14:33 |
| DinaBelova | you're right :) | 14:34 |
| pcargnel | :) | 14:34 |
| DinaBelova | so please just remove tab and it's ok | 14:34 |
| pcargnel | Great, I will. Thanks for the feedback! | 14:35 |
| DinaBelova | the only moment - maybe, it's better to set 10 secs for timeout | 14:37 |
| DinaBelova | I guess 5 is more than needed, but to have some buffer | 14:37 |
| DinaBelova | of time in case of some difficulties with keystone | 14:38 |
| pcargnel | Great. I will fix that one too. | 14:38 |
| openstackgerrit | Pablo Fernando Cargnelutti proposed a change to stackforge/climate: Wait for keystone Service to start https://review.openstack.org/79452 | 14:56 |
| DinaBelova | pcargnel, you here? | 15:12 |
| DinaBelova | I just understood | 15:12 |
| DinaBelova | that your change won't be needed if there will be lazy nova client usage in physical host plugin | 15:13 |
| DinaBelova | so it seems that https://review.openstack.org/#/c/76830/ will fix this devstack error too | 15:13 |
| DinaBelova | may you check if rejoin is working with https://review.openstack.org/#/c/76830/ without any devstack changes? | 15:14 |
| *** casanch1 has joined #openstack-climate | 15:18 | |
| bauzas | DinaBelova: the NovaClient is not lazy | 15:38 |
| DinaBelova | not novaclient | 15:38 |
| bauzas | DinaBelova: or the review should use the LazyProxy here | 15:38 |
| DinaBelova | Swann wrote self.nova that is property | 15:38 |
| DinaBelova | so it will go to keystone only when there will be first request | 15:39 |
| DinaBelova | not while __init__ | 15:39 |
| DinaBelova | as it is now | 15:39 |
| DinaBelova | so I believe Swann's change will fix this moment too | 15:39 |
| pcargnel | I'm checking rejoin with the changed that you suggested | 15:40 |
| DinaBelova | pcargnel, thanks | 15:40 |
| DinaBelova | if it'll work, please add Closes-Bug: #1282534 to Swann's commit and abandon your one | 15:41 |
| pcargnel | No problem. Ok. | 15:41 |
| DinaBelova | I'm sorry I did not get this idea before - you spent your time on it :( | 15:42 |
| bauzas | DinaBelova: indeed you're right | 15:47 |
| bauzas | DinaBelova: sorry, I just jumped from the Gantt meeting :D | 15:47 |
| DinaBelova | :) | 15:48 |
| DinaBelova | only you and n0ano? :) | 15:49 |
| bauzas | nah, more people there | 15:49 |
| bauzas | DinaBelova: someone had the great idea to propose Gantt for GSoC | 15:50 |
| bauzas | DinaBelova: that's not the most famous idea I know of | 15:50 |
| DinaBelova | well, as I remember there were some ideas about it in ML too | 15:50 |
| DinaBelova | some of these letters were really fres | 15:50 |
| DinaBelova | fresh* | 15:50 |
| bauzas | DinaBelova: yey, but the project itself is not a good opportunity for students starting in May | 15:51 |
| DinaBelova | :D | 15:53 |
| DinaBelova | that's also true)) | 15:53 |
| openstackgerrit | Jenkins proposed a change to stackforge/climate: Updated from global requirements https://review.openstack.org/79649 | 15:56 |
| pcargnel | I'm getting an AttributeError during the stack. The same that in the devstack gate job: http://logs.openstack.org/30/76830/3/check/gate-climate-devstack-dsvm/804c35c/logs/screen-climate-m.txt.gz | 16:00 |
| pcargnel | Shouldn't that job be in red? :) | 16:00 |
| casanch1 | DinaBelova today it is the TC meeting? | 16:18 |
| bauzas | casanch1: yup | 16:34 |
| bauzas | casanch1: I don't think your presence is needed btw., but you can attend anyway | 16:34 |
| openstackgerrit | Swann Croiset proposed a change to stackforge/climate: Use nova client mixin in all plugins modules https://review.openstack.org/76830 | 16:41 |
| DinaBelova | pcargnel, job now is only running, not checking | 16:51 |
| DinaBelova | we'll do that next | 16:51 |
| DinaBelova | pcargnel, as for error, Swann should fix it - now his change seems not working :( | 16:52 |
| DinaBelova | pcargnel, scroiset has uploaded new patch set, we'll look on it | 16:53 |
| openstackgerrit | Sylvain Bauza proposed a change to stackforge/climate: Change API v1 path to explicit module https://review.openstack.org/78135 | 17:09 |
| openstackgerrit | Sylvain Bauza proposed a change to stackforge/climate: Add extensions for API v2 controllers https://review.openstack.org/78309 | 17:09 |
| openstackgerrit | Sylvain Bauza proposed a change to stackforge/climate: Port to Pecan/WSME for API v2 https://review.openstack.org/71011 | 17:09 |
| bauzas | say hello to the first unittests for Pecan :) | 17:10 |
| DinaBelova | :) | 17:18 |
| DinaBelova | nice :) | 17:18 |
| openstackgerrit | A change was merged to stackforge/climate: Updated from global requirements https://review.openstack.org/79649 | 17:20 |
| openstackgerrit | Jenkins proposed a change to stackforge/climate: Updated from global requirements https://review.openstack.org/79700 | 17:37 |
| *** bauzas has quit IRC | 17:38 | |
| *** bauzas has joined #openstack-climate | 18:14 | |
| pcargnel | Dina, I also checked and I'm still having the same issue. | 18:25 |
| *** bauzas has quit IRC | 18:48 | |
| DinaBelova | Yes, that's because there is need to fix smth else to Swann's change | 19:06 |
| DinaBelova | I hope it'll be done tomorrow | 19:06 |
| DinaBelova | I | 19:06 |
| DinaBelova | have left comments to his change, I think he'll look on them) | 19:07 |
| pcargnel | Great, I will check it tomorrow. | 19:07 |
| *** gursis has joined #openstack-climate | 19:16 | |
| *** gursis has quit IRC | 19:24 | |
| *** muchitel has joined #openstack-climate | 19:31 | |
| *** bauzas has joined #openstack-climate | 19:36 | |
| *** muchitel has quit IRC | 19:42 | |
| *** michaelgo has joined #openstack-climate | 19:45 | |
| *** michaelgo has quit IRC | 19:46 | |
| *** pcargnel has left #openstack-climate | 20:02 | |
| *** cmart has quit IRC | 20:53 | |
| *** pafuent has left #openstack-climate | 21:01 | |
| *** YorikSar has quit IRC | 21:28 | |
| *** f_rossigneux has quit IRC | 21:28 | |
| *** scroiset has quit IRC | 21:28 | |
| *** bauzas has quit IRC | 21:28 | |
| *** casanch1 has quit IRC | 21:28 | |
| *** chandan_kumar has quit IRC | 21:28 | |
| *** openstackgerrit has quit IRC | 21:28 | |
| *** SergeyLukjanov has quit IRC | 21:28 | |
| *** DinaBelova has quit IRC | 21:28 | |
| *** scroiset has joined #openstack-climate | 21:41 | |
| *** YorikSar_ has joined #openstack-climate | 21:41 | |
| *** bauzas has joined #openstack-climate | 21:41 | |
| *** chandan_kumar has joined #openstack-climate | 21:41 | |
| *** openstackgerrit has joined #openstack-climate | 21:41 | |
| *** SergeyLukjanov has joined #openstack-climate | 21:41 | |
| *** DinaBelova has joined #openstack-climate | 21:41 | |
| *** f_rossigneux has joined #openstack-climate | 21:47 | |
| *** openstackstatus has joined #openstack-climate | 22:43 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!