*** chandan_kumar has joined #openstack-climate | 04:32 | |
*** chandan_kumar has quit IRC | 08:50 | |
*** chandan_kumar has joined #openstack-climate | 09:09 | |
*** chandan_kumar has quit IRC | 10:43 | |
*** chandan_kumar has joined #openstack-climate | 10:51 | |
*** casanch1 has joined #openstack-climate | 12:59 | |
*** cmart has joined #openstack-climate | 13:19 | |
*** cmart has quit IRC | 13:28 | |
*** cmart has joined #openstack-climate | 14:06 | |
openstackgerrit | Christian Martinez proposed a change to stackforge/climate: Add scenario testing support https://review.openstack.org/87352 | 14:11 |
---|---|---|
*** chandan_kumar has quit IRC | 14:14 | |
*** pafuent has joined #openstack-climate | 14:15 | |
openstackgerrit | Pablo Andres Fuente proposed a change to stackforge/climate: Added use of trusts to Physical Host plugin https://review.openstack.org/84158 | 14:22 |
openstackgerrit | Pablo Andres Fuente proposed a change to stackforge/climate: Removed DefaultReservationController from devstack https://review.openstack.org/86653 | 14:23 |
cmart | Hello core reviewers... Could you please take a look at : https://review.openstack.org/#/c/87949/. I'll really thank you for that.. | 14:24 |
DinaBelova | already done))) | 14:25 |
DinaBelova | Nikolay_1t ^^ | 14:25 |
DinaBelova | pafuent, I guess I'll add you to the core team this week)) Otherwise our review process looks awful))) | 14:25 |
pafuent | DinaBelova: :-D | 14:26 |
DinaBelova | :D | 14:26 |
cmart | :) | 14:26 |
cmart | Pablo, could you please check my comments on https://review.openstack.org/#/c/87684/?? | 14:27 |
cmart | :D | 14:27 |
pafuent | DinaBelova: BTW, I'm in debt with you. I owe to you the tempest blueprints. | 14:28 |
pafuent | cmart: Ok, checking | 14:29 |
*** cmart_ has joined #openstack-climate | 14:30 | |
DinaBelova | pafuent, sorry did not got you :? | 14:31 |
*** cmart has quit IRC | 14:31 | |
pafuent | DinaBelova: Some meetings ago you ask to me if I could draft some BP summarizing the areas that Tempest should cover | 14:32 |
DinaBelova | oh, yeeeees | 14:32 |
pafuent | DinaBelova: Only one thing. Should be one BP with multiples TODO or multiple BP? | 14:33 |
DinaBelova | I guess one bp with multiple changes within | 14:34 |
pafuent | DinaBelova: Ok | 14:34 |
openstackgerrit | A change was merged to stackforge/climate: Removed DefaultReservationController from devstack https://review.openstack.org/86653 | 14:35 |
*** chandan_kumar has joined #openstack-climate | 14:35 | |
cmart_ | DinaBelova, Nikolay_1t, scroiset_, are you there? | 14:45 |
DinaBelova | I am)) | 14:46 |
cmart_ | Could you please tell us your thoughts around the comments on https://review.openstack.org/#/c/87684/? | 14:46 |
cmart_ | me and pafuent were discussing about it, and we need a third opinion around that :) | 14:47 |
DinaBelova | cmart_, well, I guess double checking is ok here) | 14:47 |
DinaBelova | for me it's not the bad way, as argparse may also change some moment | 14:47 |
DinaBelova | that's why I don't really agree here with pafuent | 14:48 |
*** cmart_reloaded has joined #openstack-climate | 14:48 | |
pafuent | For me, could be confusing for someone that don't know that argparse is doing that check | 14:48 |
cmart_reloaded | sorry, I got disconnected.. | 14:48 |
DinaBelova | cmart_reloaded, cmart and cmart_ | 14:49 |
DinaBelova | :D:D:D | 14:49 |
DinaBelova | pafuent, well, here I'm ok with both the variants | 14:49 |
*** cmart1 has joined #openstack-climate | 14:50 | |
DinaBelova | cmart_reloaded, let's do as pafluent wants to) | 14:50 |
DinaBelova | heh | 14:50 |
DinaBelova | cmart1? | 14:50 |
cmart1 | yea | 14:50 |
DinaBelova | there are 4 of you here)) | 14:50 |
cmart1 | :S | 14:50 |
DinaBelova | ^^ let's do as pafluent wants to) | 14:50 |
cmart1 | yes.. I felt lonely | 14:50 |
cmart1 | :D | 14:50 |
DinaBelova | pafuent* | 14:50 |
DinaBelova | sorry for the typos) | 14:50 |
cmart1 | sorry for the multiple users.. | 14:50 |
cmart1 | :D | 14:50 |
*** cmart_ has quit IRC | 14:51 | |
pafuent | So if we have UT for that code, and a bug is filled against that piece of code, a new contributor (or a lazy one) could fix the code, check against the tests and do not test the CLI, and think that he/she fixed the bug. | 14:51 |
DinaBelova | ok, agreed | 14:51 |
pafuent | I'm clear? | 14:51 |
DinaBelova | yes | 14:51 |
DinaBelova | you made me change my mind) | 14:51 |
DinaBelova | gut) | 14:51 |
pafuent | :-D | 14:51 |
cmart1 | OK.. Will change that expression with a OR. | 14:51 |
cmart1 | thanks Dina | 14:51 |
DinaBelova | ok | 14:51 |
DinaBelova | ;) | 14:51 |
pafuent | DinaBelova: Could you take a look at https://review.openstack.org/#/c/84158/ ? | 14:53 |
*** cmart_reloaded has quit IRC | 14:53 | |
DinaBelova | yes, will comment it today if will find some moments | 14:53 |
pafuent | DinaBelova: Thanks | 14:53 |
DinaBelova | wel, will comment anyway :D | 14:53 |
DinaBelova | As I remember you discussed these moments with Sylvain, am I right? | 14:54 |
DinaBelova | I mean the right way of trusts usage? | 14:54 |
pafuent | DinaBelova: Yes | 14:54 |
DinaBelova | yes, I'm just checking my mind) | 14:55 |
DinaBelova | I'm a little crazy last days) | 14:55 |
openstackgerrit | Christian Martinez proposed a change to stackforge/python-climateclient: Add new option to allow lease reductions https://review.openstack.org/87684 | 14:57 |
cmart1 | Done | 14:57 |
pafuent | cmart1: ;-) | 14:58 |
cmart1 | DinaBelova, are you still there? | 15:14 |
DinaBelova | yep) | 15:14 |
cmart1 | cool! I put some comments on the https://blueprints.launchpad.net/climate/+spec/before-end-notification-crud whiteboard | 15:15 |
cmart1 | related to the format of the new parameter to be added to the update command of the climateclient | 15:15 |
cmart1 | It'll be great if you could tell us your opinion around that | 15:16 |
DinaBelova | reading it | 15:16 |
cmart1 | my idea is to treat the param as an elapsed time, like the prolong-for parameter.. but I need to add some restrictions to that, because you won´t be able to change that value to, for instance, ten seconds.. | 15:17 |
cmart1 | it won´t make any sense to do that.. | 15:18 |
cmart1 | on the other hand, treat it as fixed date it easier for all of us, but we need to make sure that is the appropriate approach | 15:18 |
openstackgerrit | Cristian A Sanchez proposed a change to stackforge/climate: Sends notifications at lease events https://review.openstack.org/75189 | 15:18 |
DinaBelova | cmart1, sorry, I'm a little crazy to the end of a day - so you're suggesting to implement crud's for the before end events with info like "notify 5 hours before lease end", without the exact date | 15:19 |
DinaBelova | am I right? | 15:19 |
DinaBelova | I'm just trying to understand) | 15:19 |
cmart1 | I got together with casanch1 and we find out that we need to add a new parameter to the climateclient (just for the lease-update command) | 15:20 |
DinaBelova | personally I think that python client should pass the exact datetime, as the CLI should provide smth like the prolong-for/reduce-by - so if'll be "climate lease-update --before-end 5h" it'll be cool | 15:21 |
DinaBelova | smth like this | 15:21 |
cmart1 | since all the other params related to lease extension-reduction (which are prolong-for and reduce-by) are using elapsed date (like "1 day,), I think that it is the best for this new param | 15:21 |
cmart1 | right | 15:21 |
cmart1 | but the thing here is that the before end param is used "to send a notification x hours before the lease expires" | 15:22 |
casanch1 | DinaBelova I agree | 15:22 |
casanch1 | that's what we thought with cmart1 | 15:22 |
cmart1 | so for instance, sending an update with this "look": climate lease-update before-end "10s" lease_name.. it won´t make sense | 15:23 |
DinaBelova | cmart1, well, probably we might use only hours now, but later implement also mins/hours/days - that look ok sor me | 15:24 |
DinaBelova | for* | 15:24 |
cmart1 | OK.. I was thinking on putting some min values around that.. and adding more info on the help command | 15:24 |
cmart1 | I'll add my code and then you can tell me what do you think, is that OK? | 15:25 |
DinaBelova | cmart1 - also we'll need to use exact datetime (not timedelta) in the climate code | 15:26 |
pafuent | To check If I got all the idea: The API will receive this parameter as a fixed date, some validations will be made on API and the CLI will provide a nicer way to set this parameter. | 15:26 |
cmart1 | pafuent: yes | 15:26 |
DinaBelova | pafuent, +++++ | 15:26 |
cmart1 | DinaBelova, yes! | 15:26 |
DinaBelova | that's why I'm saying about modifying the notification code | 15:27 |
DinaBelova | to accept fixed datetime as a param | 15:27 |
DinaBelova | not the delta | 15:27 |
cmart1 | yes! That's part of our working items (I think :)) | 15:27 |
DinaBelova | ok, cool | 15:27 |
DinaBelova | thanks) | 15:27 |
*** chandan_kumar has quit IRC | 15:29 | |
casanch1 | cmart1, DinaBelova, pafuent: we're all in the same page :) | 16:55 |
*** chandan_kumar has joined #openstack-climate | 17:21 | |
*** cmart1 has quit IRC | 18:20 | |
*** chandan_kumar has quit IRC | 18:55 | |
*** chandan_kumar has joined #openstack-climate | 18:56 | |
*** pafuent has quit IRC | 19:33 | |
*** chandan_kumar has quit IRC | 19:34 | |
*** pafuent has joined #openstack-climate | 19:50 | |
*** pafuent has quit IRC | 20:09 | |
openstackgerrit | Pablo Andres Fuente proposed a change to stackforge/climate: API returns project/user/trust ids without dashes https://review.openstack.org/89412 | 20:20 |
*** pafuent has joined #openstack-climate | 20:22 | |
openstackgerrit | Pablo Andres Fuente proposed a change to stackforge/climate: Added V2 API auth configuration to devstack https://review.openstack.org/89418 | 20:58 |
*** pafuent has left #openstack-climate | 21:12 | |
*** casanch1_ has joined #openstack-climate | 21:28 | |
*** casanch1 has quit IRC | 21:30 | |
*** casanch1 has joined #openstack-climate | 21:30 | |
*** casanch1_ has quit IRC | 21:32 | |
*** casanch1 has quit IRC | 21:35 | |
*** openstackstatus has quit IRC | 21:35 | |
*** openstackstatus has joined #openstack-climate | 21:36 | |
*** openstackgerrit has quit IRC | 23:50 | |
*** openstackgerrit has joined #openstack-climate | 23:50 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!