| *** tomek_adamczews1 has quit IRC | 00:11 | |
| *** spandhe has joined #openstack-climate | 00:54 | |
| spandhe | Hello! | 01:36 |
|---|---|---|
| spandhe | does climate need to be installed on the api host itself? Does it have any such dependencies? | 01:36 |
| spandhe | can someone help? Trying to setup climate | 01:38 |
| *** spandhe has quit IRC | 02:18 | |
| *** spandhe has joined #openstack-climate | 03:43 | |
| *** chandan_kumar has joined #openstack-climate | 04:20 | |
| *** chandan_kumar is now known as chandankumar | 04:26 | |
| DinaBelova | spandhe, climate-api should be running on the api host, and climate-manager where you'd love to | 04:44 |
| *** tomek_adamczewsk has joined #openstack-climate | 05:57 | |
| openstackgerrit | Jay Lau proposed a change to stackforge/climate: Do not change nova scheduler filters after installed climate https://review.openstack.org/92304 | 06:06 |
| openstackgerrit | Jay Lau proposed a change to stackforge/climate: Do not change nova scheduler filters after installed climate https://review.openstack.org/92304 | 06:08 |
| *** bauzas has joined #openstack-climate | 06:29 | |
| *** spandhe has quit IRC | 06:30 | |
| *** bauzas has quit IRC | 06:31 | |
| *** bauzas has joined #openstack-climate | 07:09 | |
| *** tomek_adamczewsk has quit IRC | 07:50 | |
| *** tomek_adamczewsk has joined #openstack-climate | 08:14 | |
| openstackgerrit | Jay Lau proposed a change to stackforge/climate-nova: Some code clean up in climate_filter.py https://review.openstack.org/92336 | 10:07 |
| *** tomek_adamczewsk has quit IRC | 11:01 | |
| *** tomek_adamczewsk has joined #openstack-climate | 11:06 | |
| *** tomek_adamczewsk has quit IRC | 11:25 | |
| *** cmart has joined #openstack-climate | 12:36 | |
| cmart | Hello people | 12:39 |
| cmart | anyone there? | 12:56 |
| openstackgerrit | Christian Martinez proposed a change to stackforge/climate: Update V2 documentation https://review.openstack.org/92177 | 13:02 |
| cmart | DinaBelova, bauzas? | 13:05 |
| bauzas | DinaBelova is GMT-8 currently | 13:09 |
| bauzas | so that means it's around 4am there :) | 13:09 |
| bauzas | 5am sorry :) | 13:09 |
| cmart | OMG I didn´t know! | 13:11 |
| cmart | bauzas: thanks for the clarification | 13:11 |
| cmart | guess I'll wait a couple of hours then | 13:12 |
| cmart | Would you able to check my review, bauzas? | 13:13 |
| bauzas | I should be | 13:18 |
| bauzas | can I ask you why you're not using WSME autodoc ? | 13:19 |
| bauzas | cmart: because I'm tempted to give a -1 to it :( | 13:20 |
| cmart | probably because I'm kind of lost on how the docs are built.. I found the doc folder, a rest_v2.api doc that was empty and I thought that that was the path to follow | 13:21 |
| bauzas | cmart: oh ok :) | 13:21 |
| bauzas | cmart: then trust WSME | 13:21 |
| bauzas | cmart: hold on | 13:21 |
| cmart | hahah | 13:21 |
| bauzas | cmart: giving you some links | 13:21 |
| cmart | OK | 13:21 |
| cmart | cool | 13:21 |
| bauzas | http://wsme.readthedocs.org/en/latest/document.html | 13:22 |
| bauzas | cmart: do you know how to build docs N? | 13:22 |
| bauzas | I'll put a -2 to the patchset for saying it's not the good way | 13:22 |
| cmart | no problem.. | 13:23 |
| bauzas | don't worry, it's not meaning I don't want the patch | 13:23 |
| bauzas | cmart: if you want to build docs, then run tox -edocs | 13:23 |
| cmart | regarding the question, I don't know how to do it.. I read something about a maven plugin | 13:23 |
| bauzas | it will create a build subdir | 13:23 |
| bauzas | nah | 13:23 |
| cmart | at what level? | 13:23 |
| bauzas | forget about it | 13:23 |
| bauzas | cmart: like you perform unittests | 13:23 |
| cmart | sorry, I went to openstack-manuals and I found that. | 13:24 |
| cmart | OK | 13:24 |
| bauzas | at the climate root level | 13:24 |
| bauzas | openstack-manuals are different | 13:24 |
| bauzas | so, run tox -edocs where tox.ini is placed | 13:24 |
| bauzas | it will generate some docs | 13:24 |
| bauzas | in the docs/build subdir | 13:25 |
| bauzas | HTML and also manpages | 13:25 |
| bauzas | so you can look at them | 13:25 |
| cmart | greate | 13:25 |
| cmart | and what about the wsme stuff you gave me? | 13:25 |
| cmart | Does the tox e-docs uses that to create docs? | 13:25 |
| bauzas | forget about the setup | 13:26 |
| bauzas | just run tox -edocs :) | 13:26 |
| bauzas | you don't have to modify the rst files | 13:27 |
| bauzas | as it's autogenerated | 13:27 |
| bauzas | thanks to the WSME types I mentioned (leases and hosts) | 13:27 |
| cmart | sweet! | 13:27 |
| bauzas | hence the -2 | 13:27 |
| cmart | I have no problems with -1 and -2.. they help me to do better stuff and learn :) | 13:28 |
| cmart | and about -1's.. https://review.openstack.org/#/c/91455/.. it's the v2 client stuff | 13:28 |
| bauzas | will take a look too | 13:29 |
| bauzas | I spent some time for setuping my new workspace | 13:29 |
| bauzas | now it's nearly done | 13:29 |
| cmart | I have two big concerns about it. 1) is the stuff being discussed on the ML related to the url and the "discovery" thing that you mentioned. 2) about client commands management | 13:29 |
| cmart | yeah.. and what about the new place? Is it bigger? haha | 13:29 |
| cmart | Is it better? | 13:30 |
| bauzas | cmart: so, about the second question, far easier to answer | 13:31 |
| bauzas | cmart: I'm now working from home | 13:31 |
| bauzas | cmart: so, yes, I love that place :p | 13:31 |
| bauzas | cmart: regarding the v2 client thing | 13:32 |
| bauzas | cmart: hell yeah... | 13:32 |
| bauzas | cmart: can't get the idea | 13:33 |
| cmart | as you can see, I duplicated the dict for the v2 commands.. and it works. But it has a "smell" that I don't like.. | 13:34 |
| cmart | and I was thinking in doing it differently.. Like, having a shell module inside the different clients.. and then filling the commandmanager with that commands.. | 13:35 |
| cmart | but to do that, I need to change a lot of stuff (the sub_command method, the authenticate user and the client setup, etc) | 13:35 |
| cmart | I checked other openstack clients.. the one's using cliff and argparse (neutron and openstack) don´t have this issue | 13:36 |
| cmart | neutron has a huuge dict with commands (but I'm not sure how they're handling different api versions) | 13:37 |
| *** chandankumar is now known as chandankumar|afk | 13:37 | |
| cmart | and openstack.. well, it's huge and it has custom tiny clients with versions being handle in a different way.. | 13:38 |
| bauzas | cmart: you missed the most important thing | 13:41 |
| bauzas | cmart: I mean, we should change the endpoint url for Climate | 13:42 |
| bauzas | in Keystone | 13:42 |
| cmart | the endpoint? yes! | 13:42 |
| cmart | that was my first concern hehe | 13:43 |
| bauzas | cmart: so that the client would be able to look up at / to know which versions are supported | 13:43 |
| bauzas | cmart: and so know the urls | 13:43 |
| cmart | so, keystone will retrieve a url with No version at the end | 13:44 |
| bauzas | exactly | 13:44 |
| cmart | I got that part (in a different patch, of course) | 13:45 |
| cmart | and about the discovery process within the client, I need to modify my client.py in order to append the version to the climate_url | 13:45 |
| bauzas | https://github.com/openstack/ironic/blob/master/ironic/api/controllers/root.py | 13:45 |
| cmart | what is that? | 13:46 |
| bauzas | that's an example of implementation for version discovery | 13:46 |
| bauzas | I don't mean we have to copy them | 13:46 |
| bauzas | but that's an idea how to do it | 13:47 |
| cmart | Man I need to read wsme RIGHT NOW | 13:48 |
| cmart | but I got the idea | 13:48 |
| cmart | every time a get is called, this root appends the right version to the url | 13:49 |
| cmart | this should be put inside the climate module, right? | 13:56 |
| bauzas | indeed | 13:59 |
| *** tomek_adamczewsk has joined #openstack-climate | 14:01 | |
| cmart | OK..Will do that and then I would switch to the client and make the changes you requested.. One last thing: I ran tox -edocs and pages were generated, but I have nothing to commit (no changes on my local copy). What am I doing wrong? | 14:02 |
| bauzas | cmart: are the docs correctly including what you wanted to add ? | 14:03 |
| bauzas | cmart: I mean, are you finding in the HTML docs the proper fields you wanted to add ? | 14:04 |
| cmart | I'm finding the fields in the Data samples, but nothing else | 14:04 |
| cmart | I should add more stuff to each one of the API's | 14:05 |
| bauzas | cmart: I can't get what's missing ? | 14:07 |
| bauzas | cmart: if before_end_notification is the doc, that's fine | 14:09 |
| bauzas | cmart: lemme check | 14:09 |
| cmart | OK | 14:13 |
| *** tomek_adamczewsk has quit IRC | 14:29 | |
| *** tomek_adamczewsk has joined #openstack-climate | 14:31 | |
| bauzas | cmart: double-checked and no modifications are necessary | 14:36 |
| bauzas | cmart: we accept a Lease type as body | 14:37 |
| bauzas | cmart: and before_end_notification is part of this Lease object | 14:37 |
| bauzas | cmart: so that doesn't require a change | 14:37 |
| cmart | so what should I do with the doc? Leave it as it is and abandon the review? | 14:55 |
| *** cmart has quit IRC | 15:17 | |
| *** tomek_adamczewsk has quit IRC | 15:53 | |
| *** pafuent has joined #openstack-climate | 16:00 | |
| *** pafuent has left #openstack-climate | 16:14 | |
| *** spandhe has joined #openstack-climate | 16:18 | |
| *** pafuent has joined #openstack-climate | 16:27 | |
| *** casanch1 has joined #openstack-climate | 16:48 | |
| *** cmart has joined #openstack-climate | 16:49 | |
| cmart | DinaBelova, are you there? | 16:49 |
| cmart | I guess bauzas is already gone :S | 16:50 |
| *** spandhe has quit IRC | 16:56 | |
| *** spandhe has joined #openstack-climate | 17:19 | |
| *** chandankumar|afk has quit IRC | 17:24 | |
| DinaBelova | cmart, I'm here | 17:57 |
| *** chandan_kumar has joined #openstack-climate | 17:58 | |
| *** casanch1 has quit IRC | 18:01 | |
| cmart | Hello Dina! | 18:01 |
| cmart | have some news regarding v2 client that I want to discuss with you.. | 18:02 |
| cmart | first of all.. I talked to sylvain about the topic discussed on the ML | 18:02 |
| cmart | He suggested that we should do something like this: https://github.com/openstack/ironic/blob/master/ironic/api/controllers/root.py | 18:03 |
| cmart | the idea is to append the version to the url right before redirecting to the appropriate api version app | 18:04 |
| cmart | a good place to put this is the api.py file, inside climate/cmd | 18:06 |
| cmart | and it will affect both api version apps | 18:07 |
| *** casanch1 has joined #openstack-climate | 18:09 | |
| cmart | Is that OK for you? | 18:12 |
| *** chandan_kumar has quit IRC | 18:22 | |
| *** tomek_adamczewsk has joined #openstack-climate | 18:39 | |
| cmart | DinaBelova? | 18:41 |
| *** casanch1 has quit IRC | 18:52 | |
| DinaBelova | cmart,sorry, had a lunch :D | 19:01 |
| DinaBelova | cmart, well, personally I don't like the idea of v1 changing... | 19:02 |
| DinaBelova | but: | 19:02 |
| DinaBelova | I completely agree with the fact that we need good archtecture here | 19:02 |
| DinaBelova | sooo | 19:02 |
| DinaBelova | I would say ok here | 19:02 |
| cmart | cool | 19:02 |
| DinaBelova | as we'll have lot's renaming chnages anyway | 19:03 |
| DinaBelova | that are risks themselves | 19:03 |
| DinaBelova | one more is only one more | 19:03 |
| DinaBelova | cmart, it's so-o cool to be around your timezone :D | 19:03 |
| DinaBelova | quite comfortable | 19:04 |
| cmart | haha | 19:04 |
| cmart | Where are you right now? | 19:04 |
| cmart | Atlanta? | 19:04 |
| DinaBelova | CA | 19:04 |
| DinaBelova | :) | 19:04 |
| DinaBelova | Sunnyvale | 19:04 |
| openstackgerrit | A change was merged to stackforge/climate-nova: Some code clean up in climate_filter.py https://review.openstack.org/92336 | 19:04 |
| DinaBelova | heh, right now - Mountain View | 19:04 |
| DinaBelova | :) | 19:04 |
| cmart | great! | 19:04 |
| cmart | what time is it? 1 pm? | 19:05 |
| DinaBelova | 12:00 | 19:05 |
| DinaBelova | dunno if that pm or am | 19:05 |
| DinaBelova | I'm confused with it | 19:05 |
| DinaBelova | I mean 12's - day and night | 19:05 |
| cmart | no worries | 19:05 |
| DinaBelova | what's the right btw? | 19:06 |
| cmart | I really don't know... We use 12 for mid-day and 24 for midnight so.. | 19:06 |
| cmart | and that's it :D | 19:07 |
| DinaBelova | :D | 19:07 |
| DinaBelova | so you're confused too here ::D | 19:07 |
| cmart | yes I am.. that's why I just keep calling people.. no matter what time zone are they. | 19:07 |
| cmart | for instance, pafuent and casanch are in Portland right now.. I think that it's the same timezone that the one that you have | 19:08 |
| cmart | and I keep calling them as if they were right next to me :D | 19:08 |
| cmart | OK, So..I will work on that changes and let you know. | 19:09 |
| cmart | btw let me ask you about docs generation... https://review.openstack.org/#/c/92177/ | 19:10 |
| cmart | Sylvain told me to use the WSME autodoc with tox -edocs to update documentation | 19:10 |
| cmart | but the thing is that after running that "tox -edocs" command, I'm not getting any diffs with my code.. | 19:11 |
| cmart | and I'm not sure if I had to add smth or not :| | 19:11 |
| *** bauzas has quit IRC | 19:15 | |
| cmart | DinaBelova? | 19:27 |
| DinaBelova | cmart, sorry, I've read your messages))) | 19:27 |
| DinaBelova | just did not know what to say)) | 19:28 |
| DinaBelova | that's common issue)) | 19:28 |
| DinaBelova | as for the docs | 19:28 |
| DinaBelova | I'm not quite specialized with the wsme docs.... | 19:28 |
| DinaBelova | Sylvain is better here... | 19:28 |
| DinaBelova | possibly we may wait him and try to ping him in next 4-5 hours | 19:29 |
| cmart | Ok | 19:30 |
| *** pafuent has quit IRC | 19:30 | |
| cmart | well.. I have work to do. Thanks for all the help! | 19:30 |
| cmart | ttyl! bye | 19:30 |
| *** casanch1 has joined #openstack-climate | 19:31 | |
| *** pafuent has joined #openstack-climate | 19:32 | |
| *** pafuent has quit IRC | 19:34 | |
| *** casanch1 has quit IRC | 19:57 | |
| *** pafuent has joined #openstack-climate | 19:59 | |
| *** casanch1 has joined #openstack-climate | 20:04 | |
| pafuent | cmart_ | 20:16 |
| pafuent | cmart: tox -edocs | 20:17 |
| pafuent | cmart: firefox doc/build/html/index.html | 20:17 |
| pafuent | cmart: That's it | 20:17 |
| *** cmart has quit IRC | 20:17 | |
| *** cmart has joined #openstack-climate | 20:22 | |
| *** tomek_adamczewsk has quit IRC | 20:23 | |
| *** pafuent has left #openstack-climate | 20:25 | |
| *** pafuent has joined #openstack-climate | 20:26 | |
| pafuent | cmart: tox -edocs | 20:26 |
| pafuent | cmart: firefox doc/build/html/index.html | 20:26 |
| pafuent | cmart: That's it | 20:26 |
| cmart | but I see no changes on it! | 20:30 |
| cmart | guess that wsme already created the docs and there was no need to do that again | 20:30 |
| DinaBelova | cmart, I guess to have changes you need to change the methods docstrings | 20:34 |
| DinaBelova | possibly you may add some info there, if it's needed | 20:34 |
| cmart | Do you mean like adding api examples or smth like that? | 20:36 |
| cmart | ("inside the docstrings") | 20:36 |
| cmart | and also, the changes are reflected at doc/build/html folder level.. and that folder is not versioned.. So my question is how these are reflected in the current doc? | 20:41 |
| cmart | If I go to https://wiki.openstack.org/wiki/Climate/REST_API, I won't see the wsme autogenerated doc.. So how can I validate that the doc is correct? | 20:44 |
| *** casanch1 has quit IRC | 21:00 | |
| cmart | please, if you have any comments, let me know at christian.martinez@intel.com | 21:02 |
| cmart | thanks! | 21:02 |
| cmart | bye! | 21:02 |
| *** cmart has quit IRC | 21:03 | |
| *** casanch1 has joined #openstack-climate | 21:06 | |
| DinaBelova | cmart - wiki is not autogenerated... To see Sphinx docs you need to generate them - we simply have no place for docs publishing before the renaming | 21:08 |
| *** casanch1 has quit IRC | 21:10 | |
| *** pafuent has quit IRC | 22:51 | |
| *** pafuent has joined #openstack-climate | 22:55 | |
| *** pafuent has quit IRC | 23:03 | |
| *** spandhe has quit IRC | 23:10 | |
| *** spandhe has joined #openstack-climate | 23:12 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!